- 04 Nov, 2020 40 commits
-
-
Emircan Uysaler authored
This CL merges acquire fences for primary plane and overlays so that the updates happen at the same time. We could see artifacts when they were out of sync, as the underlay strategy expects a perfect fit under transparent layer. This CL makes sure that the updates happen in sync. Bug: 1144320, 1127984 Change-Id: I4b6bc776e0f3c2c8b0d6c4811245cc2cbcc3b9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514465Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824202}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I49569382a033fc8cc4f3e37a1b7a5d46c22ca501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518802Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824201}
-
Leonard Grey authored
Bug: 1014639 Change-Id: I6f06f2fb7cce2588130c2e2e7be323c778a683cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518748Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824200}
-
Erik Språng authored
Bug: chromium:934391 Change-Id: I63c35a4954e3405217db5fd7820fb187242a8bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518863 Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#824199}
-
Roberto Carrillo authored
TBR=nodir,bsheedy,vadimsh,gbeaty Bug: 1145735 Change-Id: Id7921fbacb0fedfd3500fd86953173fa63eb80b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518699Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#824198}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/419b7d7bd164..ad54c71632cc 2020-11-04 capn@google.com Fix Vulkan benchmarks build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6daec4ca1bb9ed9e96a990cbb08210ef871923cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520035Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824197}
-
Alexander Surkov authored
dumptest helper * tree formatters should be kept generic, because they are not scoped to testing only, and thus should implement no test logic; * event recorders implicitly relies on tree formatters test expectations code, which requires event recorders always used in conjunction to tree formatters; * there is no need to have a separate interface for test expectations, since there's only small amount of callers which all depend on dumptest helper, and thus all logic can be implemented inside dumptest helper; * simpler code, less error prone Bug: 1133330 Change-Id: I21de46bb01a2c9b3dce42aa1229a568e6bf94e0a AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502729Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#824196}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/6MHYJ8TDtszEqfw Bug: 889763 Change-Id: I7cca271a77160b2746809ee8d295e258452989f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517223 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824195}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* && autoninja Change-Id: I3c3438545ebd4209da697aa36fe6cf8ede6448a6 webui: closure_compile Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511255 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#824194}
-
Lily Chen authored
Change-Id: I7780c3040d2ac3e4d67c394fe34abeadc1e9612b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518918Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#824193}
-
Emircan Uysaler authored
This CL fixes the error from the previous CL where we always registered videos with an image pipe. Bug: 1127984 Change-Id: I54a90068a96145c354a6ec2f874e415b8824e422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518136Reviewed-by:
-
Ken Rockot authored
The js_type_check for some WebUI test mojom was inadvertently broken to no longer perform most of the useful type checks. This fixes that. Bug: 1004256 Change-Id: Ic8e9d4bdc098daa84c591a72f9c82e53b9e7d87f Tbr: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517486Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#824191}
-
Sergey Ulanov authored
VideoCaptureDeviceFactoryAndroid was enumerating list of supported formats for each device every time when enumerating devices. This was problematic on some devices where opening a camera breaks existing stream for that camera. This CL adds cache of supported formats in VideoCaptureDeviceFactoryAndroid. This allows to workaround the bug by enumerating formats only once for each device. Also updated VideoCaptureFactory.java to make it possible to get unique device IDs, not just indices. Bug: 1138608 Change-Id: Ib397b6cbe1f3e343fbb1e2187e91859576b6acc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494030 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824190}
-
Roberto Carrillo authored
TBR=nodir,bsheedy,vadimsh,gbeaty Bug: 1145735 Change-Id: Ia6793aa3c3198ab0b425ec9048c15490f353c32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519879Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#824189}
-
Chan Li authored
https://chromium-review.googlesource.com/c/infra/infra/+/2516252 added a new adapter for such test suites, so resultsink should be able to support them. The test suites are: - content_shell_crash_test - flatbuffers_unittests - resource_sizes_cronet_sample_apk Bug: 1137507 Change-Id: Ib194a54ae7e171ce7efe02080f9fb9a6a5eeb551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519036Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824188}
-
Karan Bhatia authored
This reverts commit 89891098. Reason for revert: The original test failures were caused due to crbug.com/gn/215 which caused spurious failures in incremental rebuilds. The corresponding GN roll has now been reverted. Original change's description: > Revert "JsonSchemaCompiler: Raise error on parse failures of optional properties." > > This reverts commit eec7bff8. > > Reason for revert: > After this change, JsonSchemaCompilerErrorTest.* are failing on > several linux bots: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95122 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/92709 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21165 > > Original change's description: > > JsonSchemaCompiler: Raise error on parse failures of optional properties. > > > > Currently when an optional property fails to parse and error generation > > is enabled for the schema, the auto-generated Populate function > > continues parsing the type but still populates error. This CL changes > > the code to ensure that we raise an error in these cases. > > > > We also don't raise an error on unrecognized keys any longer since we > > shouldn't be raising an error while returning a parse success: Most > > consumers currently don't distinguish between the two cases and this can > > lead to the returned error being a concatenation of unrelated errors, > > which is not ideal. > > > > We now enforce the constraint that Populate only returns an error iff > > there is a parse failure. We DCHECK the same in the auto-generated > > FromValue function. > > > > This also brings the code more in-line with what we do for > > auto-generated manifest parsing. > > > > Currently only 3 schemas use error generation: > > - declarative_net_request.idl > > - extensions_manifest_types.json > > - manifest_types.json > > > > The latter two may be affected by the change. In particular, parsing > > manifest types declared by them may lead to a hard error when an > > optional property can't be parsed now. > > > > BUG=1113513 > > > > Change-Id: I63966389e25f7591b4425815d32d9da59d35c3fb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500425 > > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823545} > > TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org > > Change-Id: I3b26905381996192b377f79abcde757efaf08f31 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113513 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519330 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823902} TBR=rdevlin.cronin@chromium.org,nhiroki@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1113513 Change-Id: I57d4725126af7c019518cd2bff000403a8b749b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519173Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824187}
-
Rouslan Solomakhin authored
Before this patch, payment credential storage and retrieval did not cancel database operations when secure payment confirmation was being torn down, so the database operation callbacks could use secure payment confirmation code path after free. This patch cancels the payment credential storage and retrieval operations during the tear down. After this patch, there is no use-after-free errors when a database operation is in flight during secure payment confirmation tear down. Bug: 1136078 Change-Id: I2a02089f4ab5c3c8ae5ebed91304b11e1c1eaf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518924Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824186}
-
Erik Chen authored
This CL does not currently change any configuration. Lacros is still disabled by default on stable channel. Bug: 1144323 Change-Id: I99354aa334931c8688d3eb46ef9e6bca1431efb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518753 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#824185}
-
Adrian Taylor authored
Change-Id: Ie9294ddfc5eb4902ff8903bfec130da00b381268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510353Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#824184}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I0b9015531b45af5ca08cd660b8715e2cb97bf2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519582Reviewed-by:
-
Taylor Bergquist authored
The NTB is instead laid out just right of the tabstrip by TabStripRegionView. Behavior is unchanged, except for: - The NTB will never hide (e.g. during drag sessions) because it's now positioned reasonably during the cases where it was previously hidden. - The NTB is positioned slightly further to the right. It was previously overlapping the rightmost tab a bit to be better aligned relative to the trailing separator. That of course doesn't make sense when the tabstrip is scrollable, but still could before that state is reached, or if the tabstrip is scrolled all the way to the end. - A few details of the NTB's movement during animations are different, e.g. when pinning the rightmost tab. Under the hood, the NTB is no longer explicitly animated; that is happening implicitly as the tabstrip's bounds change during animation. Also rewrites BrowserNonClientFrameViewTabbedTest.HitTestTabstrip because it was a) testing very different things per platform and b) was very unclear about what it was expecting and why. Bug: 1093972 Change-Id: I3cf086a8f9b4219c5ce46b13ed28c9f8aa52e8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490554 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824182}
-
Adam Ettenberger authored
This is a reland of 3cf58053 Revert CL : https://chromium-review.googlesource.com/c/chromium/src/+/2388361 Reason for revert: There are 3 new performance regressions related to this change : [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1123547 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1123235 [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1123254 Very likely caused AccessibilityIpcErrorBrowserTest.ResetBrowserAccessibilityManager consistently fail on android x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2007 * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1102 It has been verified that this test * passed with earlier revision: https://chromium-swarm.appspot.com/task?id=4e5ebf09d330cd10 * failed with this revision: https://chromium-swarm.appspot.com/task?id=4e5eb98aba040310 I believe the performance regressions were caused by enqueuing many blink text-changed events. This has been fixed by migrating most of the blink events to only marking the node dirty and using AXEventGenerator fire text or name changed events. Parts of the original change have been split into separate CLs : - https://chromium-review.googlesource.com/c/chromium/src/+/2391766 - https://chromium-review.googlesource.com/c/chromium/src/+/2393067 Original change's description: > Fix Role::kButton name invalidation when descendant text is modified > > This CL addresses a bug where Role::kButton, and possibly other roles > that derive their name from descendant contents, were not firing > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > ax_object_cache_impl.cc : > - When firing a text changed event, also fire a text changed event for > the first ancestor that derives its name from descendant contents. > This ensures the nodes are invalidated, send appropriate text changed > events, and the changes are serialized to the browser process AXTree. > > browser_accessibility_manager_win.cc : > - FireUiaTextContainerEvent made it possible to fire text events more > than once for a given text provider so it has been removed. > - Instead, populate a set |text_changed_events_| which contains the > text providers via |GetUiaTextPatternProvider| and fire the UIA text > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > - |text_selection_changed_events_| could also potentially end up with > the same double-event problem, so it uses GetUiaTextPatternProvider > now as well. > - Removing usage of std::unordered_set based on the guidance in > base/containers/README.md. In general these sets shouldn't grow large > enough to benefit from being unordered. > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > Bug: 1105262 > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796464} Tbr: wez@chromium.org,haraken@chromium.org Bug: 1105262 Change-Id: Icf2b909f62f3b58b7398bbdcb27e02b1bf4f6d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391762 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#824181}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc186f0ead79..d75314bf680f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042023,chromium:1078229,chromium:1134178,chromium:1142577,chromium:1142775,chromium:1142990,chromium:1143787,chromium:948282 Tbr: xhwang@google.com,sahel@google.com Change-Id: Id27faa4b69afbc0959ca48981d5d840adfd1f3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520036Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824180}
-
Simeon Anfinrud authored
Classes that derive from this can choose to store these pointers in private members, initialized at construction. Merge-With: eureka-internal/480348 Bug: Internal b/138199589 Test: Build internal chromecast binaries and tests Change-Id: I84723d6d298c9453d43c92ffd9f05b136d774b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518715 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#824179}
-
Joel Hockey authored
Bug: 1144138 Change-Id: I57414924c9b09d100af6b6fa2b1f713310104209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504447 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#824178}
-
David Black authored
This code assumes that switching from LTR to RTL will not occur while holding space tray icon exists. Screenshot: http://shortn/_yJnkajLPTg Bug: 1142572 Change-Id: Ib71a89ce4458db16bd7e2050d267f6473c5893a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519856Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#824177}
-
Joel Hockey authored
Since COPY_PASTE and DRAG_DROP handling of callbacks has been unified, there is no need to differentiate between them. Bug: 1144138 Change-Id: I6e55f12ddc0ce625c7cc164b40049bd33b8c65f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514939 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3744b2a36638..f12d05d125a8 2020-11-04 scroggo@google.com Implement SkPathBuilder(SkPathFillType) 2020-11-04 egdaniel@google.com Allow creating SkSurfaceCharacterizations directly for vk secondary CB context. 2020-11-04 senorblanco@chromium.org Dawn: update to RenderPassEncoder::SetIndexBufferWithFormat(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1144921 Tbr: bsalomon@google.com Change-Id: If54354b83fa37c507636ba34bd4ab97e6ae20747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518925Reviewed-by:
-
yilkal authored
This cl ensures that all edu accounts added as secondary accounts on a supervised user device will record their corresponding TermsOfService version number. Upon policy update for the TermsOfService, this cl checks which account has an outdated agreement and invalidates the token for the account. The change from the local flow to the server flow will not result in accounts being invalidated. Bug: 1134682 Change-Id: Ib19f26f11d760d05f78d21abd7fbad9481578d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459947Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824174}
-
Owen Min authored
This reverts commit 206cb06f. Reason for revert: causing crash on canary: crbug.com/1145676 Original change's description: > Add real-time extension request throttler. > > When previous real time extension request is generated less than 1 minute > or haven't got response from the server, all new requests will be > batched and wait. > > In case of any error, the throttler will stop working until the next > successfully upload. In case of policy change, the throllter will be > deleted or created. > > The throttle creation is also behind the feature flag. > > Bug: 1137964 > Change-Id: I6b3e7158163959211abc13a77ae07058c8ef99dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505445 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823549} TBR=pastarmovj@chromium.org,zmin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1137964, 1145676, 1145576 Change-Id: I3a214d178d1e784fd9c69938662f4497daff75e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519201Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824173}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5bdfcd8f3397..deff57f9b2c8 2020-11-04 sokcevic@google.com Add unit tests for guessing main as upstream If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143724 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I41eb418c964c6279eac31e89b4c929cf356be221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519589Reviewed-by:
-
dpapad authored
Bug: 1144866 Change-Id: I9607f191e309b2ce5f57f475157c17df778445f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512902 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#824171}
-
Eugene But authored
Add metric which record number of tabs after clean shutdown and after the crash. If users have more tabs in metrics recorded after the crash than there is a correlation between number of tabs and crashiness. These metrics will help us understand if reducing memory footprint from multiple tabs may have positive impact on stability. Bug: 1140990 Change-Id: I07026ac9671e72d9367faf01b5fa71d8d990bdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516240 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824170}
-
Sahel Sharify authored
debugger-inline-values-frames.js: flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9kZXZ0b29scy9zb3VyY2VzL2RlYnVnZ2VyLXVpL2RlYnVnZ2VyLWlubGluZS12YWx1ZXMtZnJhbWVzLmpzDA sample failure: https://test-results.appspot.com/data/layout_results/linux-trusty-rel/17662/blink_web_tests/layout-test-results/results.html Sample failure continue-to-location-markers-in-top-level-function.js flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9kZXZ0b29scy9zb3VyY2VzL2RlYnVnZ2VyLXVpL2RlYnVnZ2VyLWlubGluZS12YWx1ZXMtZnJhbWVzLmpzDA sample failure: https://test-results.appspot.com/data/layout_results/Linux_Tests/95147/blink_web_tests/layout-test-results/results.html TBR=paulirish@chromium.org Bug: 1046784, 1144273 Change-Id: If688f8666c072aad3bf6f02aa3bae44945832793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519996Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#824169}
-
Karan Bhatia authored
This reverts commit 2c7db28c. Reason for revert: The test failures were caused due to crbug.com/gn/215 which caused spurious failures in incremental rebuilds. The corresponding GN roll has now been reverted. Original change's description: > Disable JSONSchemaCompiler tests > > The tests started to fail on > https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests when > https://crbug.com/1113513#c16 was landed. > The revert was supposed to fix other failures. > > Tbr: karandeepb@chromium.org > Bug: 1113513 > Change-Id: Ia800eba3f90cf3be44bd800c999d7a694f819573 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517567 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823954} TBR=karandeepb@chromium.org,dullweber@chromium.org Change-Id: I30e936c84c9dcae8e2702eed89e320ad7f4ff5a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518308Reviewed-by:
-
Michael Bai authored
This reverts commit dad827a2. Reason for revert: Change the test, previous test method caused DCHECK failure in L, M, N. The new way won't remove the view from view tree instead notify the window invisible to let the renderer think the frame is in background. Verified in N device with debug build, the issue was fixed. Original change's description: > Revert "ContentCapture: re-stream onscreen content when the frame show again" > > This reverts commit dbe0ea06. > > Reason for revert: New test fails on the following bots: > https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester > https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester > https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20N%20%28dbg%29 > > Original change's description: > > ContentCapture: re-stream onscreen content when the frame show again > > > > Previously ContentCaptureConsumer had no way to know the the frame > > shows again because the visible content didn't change. > > > > This patch resets the task session when the frame was hidden, so > > ContentCapture task will stream on-screen content because they > > aren't streamed from the task point of view when the frame was > > shown. > > > > Adds the test to coverage this scenario. > > > > Bug: 1137463 > > Change-Id: I0065ce080101d2149622b0f9f6a3aa196c18d717 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511030 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Michael Bai <michaelbai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823251} > > TBR=michaelbai@chromium.org,wangxianzhu@chromium.org > > Change-Id: I219bd94c5dfc36b073590d6e604ce951aef3c966 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1137463 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518401 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823660} TBR=michaelbai@chromium.org,nyquist@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1137463 Change-Id: Ib7be9bf21a5aadcf88b79f4334e5298ee9d41275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518752Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#824167}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie30eca62a20126b99006f0163e21f09ec764a70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519994Reviewed-by:
-
Jared Saul authored
Fixed: 1144787 Change-Id: I5ed58126470efc65ef8681cd7d30ce2bb1f98eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515105 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#824165}
-
Ken Rockot authored
Several WebUI pages have recently been migrated to mojo JS modules. In the process, full closure type checking was inadvertently disabled due to incorrect use of js_type_check closure_flags. This re-enables full type checking for the affected pages and fixes any existing flaws revealed as a result Bug: 1004256 Change-Id: If11808a64501606a784495baeb2543cee33daf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518089 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824164}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in uievents/mouse/layout_change_should_fire_mouseover.html. Bug: 1145677 Change-Id: If90ec00d39b773df06570aeebb0a98dbcdd1c463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518599Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#824163}
-
