- 07 Mar, 2019 40 commits
-
-
Yuri Wiitala authored
Fixes a "choppy audio" issue on platforms with certain audio timing parameters/scenarios. Investigation on crbug.com/934770 led to the realization that three related problems needed to be addressed: 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH directions, not just one direction; and on both the input and output flows. This accounts for the case where a device-switch in audio::OutputController results in a sudden drastic shift in the delay timestamps. 2. Add automatically-increasing capture delay logic to audio::LoopbackStream to ensure the reads from all nodes' delay buffer will never result in underrun. 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) addressing a subtle source of error in task scheduling delay math due to integer truncation; b) exposing timestamps to worker callbacks that allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| that behaves just like a real AudioOutputStream. This "lessens the blow" of a device-switch to SnooperNode. Bug: 934770 Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638427}
-
Takuto Ikuta authored
I will deprecate deps in proto_library for improved build throughput. And we can use proto_deps here instead. Bug: 938011 Change-Id: I406ef84c220536058e3f9e18ccd9ce3e4cb2e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504602 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638426}
-
Jinsuk Kim authored
This CL consolidates various ways to create Tab instances into a single one using TabBuilder. Saves us from passing unannotated params |null| to the constructor, so makes the intention clearer. Bug: 925242 Change-Id: I7440eb501a5ef7a6f456ee60e1c1000932af85b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485611 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#638425}
-
Xiaocheng Hu authored
This VisiblePosition-typed variable should have been cleared in crrev.com/1501035 but was left over. This CL clears it. Bug: 657237 Change-Id: Idec9cb0e6a4709bece76e6ed36da325d7ab7fba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507134Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638424}
-
Mei Liang authored
This CL adds accessibility strings for tab group feature IPHs and updates tab groups related strings description according to the spec. Bug: 938522 Change-Id: I7efec5e3eeedb76135975ceb30dc3077d70a9439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504162 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638423}
-
wutao authored
This patch adds unit tests for emebedded Assistant UI to test the basic UI visibility and app list states. Bug: 924624 Test: AppListView*Test:*EmbeddedAssistantUI* Change-Id: I588ffb174d5f4e6ec2a1e0c80d139648740a01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501514 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#638422}
-
Dan Beam authored
As far as I can tell, this CSS doesn't work. Removing it instead of attempting to update it for dark mode. R=dpapad@chromium.org BUG=926658 Change-Id: I34213a54828c2becc3b59cfcdd60f8de72bdad2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506389Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638421}
-
Eugene But authored
The test was calling gtm_dictionaryWithHttpArgumentsString method to verify that method exists. Chrome does not call this method, so there is no need to test method existence. Bug: 933827 Change-Id: I86200d3d8bbb9096f12277b7e951422b07672d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500628 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638420}
-
Kayce Basques authored
Bug: 939147 Change-Id: Ic3a208e37a863b695da91af04d0485efe738d118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506305Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Auto-Submit: Kayce Basques <kayce@google.com> Cr-Commit-Position: refs/heads/master@{#638419}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I57c94f248bf2db118e94903f6861c81289b07f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507013Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638418}
-
Stefan Zager authored
The root cause for the failure is most likely a change in when the flags controlling frame throttling are updated. That changed when the IntersectionObserver steps were moved to run in a post-lifecycle step. It's possible that a frame was marked as throttled at the time that UpdateAllLifecyclePhases ran, so it was skipped for update; but the throttled flag was flipped to unthrottled before the code path where the crash occurs, so that the call to ShouldThrottleRendering() does not reflect the state of throttling when the lifecycle ran. BUG=938651 R=schenney@chromium.org Change-Id: Ifb7e50d40f096e333e45e5e8610ef7ab7671bee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506757 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#638417}
-
Wei-Yin Chen (陳威尹) authored
Enable triggering of IPH_TabGroupsQuicklyComparePages when tab groups feature is enabled. Bug: 930970 Change-Id: I9182bb3ebe40c00d9dd03f7eb234bde4f1d800c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497638 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
dpapad authored
This file is only referenced by a test HTML file, which in turn is not referenced anywhere. Deleting both. Bug: None Change-Id: I2f872560da6aec7c7b98bdeb57501a9f2cd2a021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507236 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638415}
-
Justin Cohen authored
This reverts commit b89cc617. Bug: 936211, 926235 Change-Id: Ia62f48168f41302582a607b2695cb1b379529945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506880 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638414}
-
Matthew Dempsky authored
The V8 JIT requires the ability to re-map heap pages as executable, but Fuchsia only allows this with pages allocated with MAP_JIT. Bug: 927411 Change-Id: I589981de14e0a8646ed3e245d237f10b92b26118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504507Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Matthew Dempsky <mdempsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638413}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6c1dc894e745547c7a083b7219cab3c63cd33085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638412}
-
shrekshao authored
Bug: chromium:930993 Change-Id: I4cda4f4dfd7802cbce46b81048e3676d7469a861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496098Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#638411}
-
Jinsuk Kim authored
This CL makes TabFullscreenHandler Tab's UserData so that Tab doesn't have to manage |mFullscreenHandler|. Bug: 924242 Change-Id: I5a3ea1fc15a8e5d09ab0b1a5ac048feaa2471a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496272Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#638410}
-
Rouslan Solomakhin authored
Before this patch, a background tab could show the payment sheet. This patch aborts payment if the web contents of the currently active tab are not the same as the web contents that invoked the PaymentRequest API. After this patch, Chrome rejects the PaymentRequest.show() with "AbortError: Request cancelled" if it was called from a tab that is not currently shown to the user. Bug: 939162 Change-Id: Ia4e3eba7b882b5361185536e5b2b96edc80f5a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507125Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638409}
-
John Lee authored
Bug: 938945 Change-Id: I6fb499405dcf511545cd5c71f93cb7d569b18cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506386Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#638408}
-
Etienne Pierre-doray authored
This CL distributes waking-up workers to avoid having 1 thread waking-up many workers. This implies: - Cap num_workers_to_wakeup to 2 in EnsureEnoughWorkersLockRequired. - Call EnsureEnoughWorkersLockRequired from GetWork(), so it can wakeup more workers (which will, in turn wakeup other workers). This is ground work for supporting TaskSource with concurrency > 1 and shouldn't have a big impact currently since it's rare for EnsureEnoughWorkersLockRequired() to wakeup many workers. RepeatedWillBlockDoesNotCreateTooManyWorkers had to be adapted; The test didn't take into account the idle thread, and it seems there was no code path maintaining the idle thread in this situation. This CL changes this and an idle thread is now created, which the test need to take into account. TBR=fdoray@chromium.org Change-Id: If2479b703ff6d85a0f11e73908ff1e09ed249c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474462 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#638407}
-
Luciano Pacheco authored
Downloads special case from shouldShowMenuItemsForEntry so it doesn't hide copy, zip-selection and paste-into-folder, change special case for destructing commands cut, delete and rename. This affects directory tree and file list context menus. Change EntryListItem to use non-root context menu to display #new-folder command for MyFiles, but continue to use root context menu for removable (USB/SDCard). This only affects diretory tree context menus. Bug: 925516, 932772 Change-Id: I00c17c5f5144b0be96055fc107857b055d07732d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498733 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#638406}
-
Andrew Xu authored
drmModeConnectorPtr and drmModeCrtc are destructed by "free". So their memory should be allocated by "malloc" instead of "new". Bug: 937638 Change-Id: I34737a692963735a8e88c8e1a0012ad6b09666fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501996 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#638405}
-
Evan Stade authored
Bug: 939160 Change-Id: Ib7dd41dc550ffa712720cc633aa7585e4f4d6d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506451Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
-
CJ DiMeglio authored
Previously with screenreaders we were seeing duplication of information, due to a container being selectable/aria-readable. The initial solution was to make this container unselectable, but this caused the menu to be unusable. This new solution instead makes the containter aria-hidden, and sets the information previously obtained from its children on the parent label. Bug: 919446 Change-Id: I6b5a057b24ccc43c9f7deebe7805ee8f2a6a3821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1401454Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#638403}
-
Evan Stade authored
by shutting down SystemClockClient as appropriate. Bug: 939160 Change-Id: I145b2b96e602b412340e56858172a66e9dd8dca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507216Reviewed-by:
-
Jun Mukai authored
Bug: 936603 Test: manually Change-Id: I2b83069342dc094c097a5d26b6a63cd9ac5364ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506662 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638401}
-
Simon La Macchia authored
Problem: The Protected media content Site Setting does not support Bluetooth keyboard navigation. The three radio buttons are treated as one clickable target, making the individual radio buttons unselectable. Solution: Make radio buttons selectable and clickable to support navigation with a Bluetooth keyboard. This behavior matches existsing Chrome settings support for Bluetooth keyboard navigation. This change does not affect navigate by touch and will work the same as before. R=twellington@chromium.org Bug: 936143 Change-Id: Ib14c4515d5a70fa0cb8344727b367e2c9260c36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490016Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Simon La Macchia <smacchia@amazon.com> Cr-Commit-Position: refs/heads/master@{#638400}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2c25b14c34c1..2995dc2a67c7 git log 2c25b14c34c1..2995dc2a67c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 chrisforbes@google.com Wire up depth and stencil attachments to pipeline 2019-03-06 bclayton@google.com Split regres test lists into full and CI lists. 2019-03-06 bclayton@google.com SpirvShader: Implement OpSelect 2019-03-06 bclayton@google.com SpirvShader: Add relational ops for ordered and unordered floats 2019-03-06 headlessclayton@gmail.com Plumb PipelineLayouts down to SpirvRoutine Created with: gclient setdep -r src/third_party/swiftshader@2995dc2a67c7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118619338,chromium:b/127664487,chromium:b/126873455,chromium:b/127282157,chromium:b/126330097 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib56a0bdeae8091e34222176c6e6b5ee0189829b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506575Reviewed-by:
-
Siddhartha S authored
This CL is split from: https://chromium-review.googlesource.com/c/chromium/src/+/1491032 This does not move the webview whitelists into services/tracing. The argument filter is set by chrome delegate in each process. But, tracing service runs as a sandboxed process, where the filter is not set. In Perfetto backend json convertor filters arguments for all events in the service process. So, move the filter to services/ and ensure it is always used. In short term, webview will continue using the filter as it is till we agree on how to properly serialize the filter for Perfetto bcakend. BUG=925148 TBR=avi@chromium.org Change-Id: Ifaa491cbaf215f718a534063d39cbd771261cb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506659Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#638398}
-
Burton authored
Removals -------- 1. Removed NCSCCS HPKP code as it is deprecated. 2. Removed the sirburton.com domain as it is deprecated. 3. Removed the 0.me.uk domain as it is deprecated. 4. Removed the themathematician.uk domain as it is deprecated. 5. Removed the ncsccs.com domain as it is deprecated. Changes ------- 1. Moved the calculates.org domain to manual section. 2. Moved the codebreaking.org domain to manual section. 3. Moved the typewritten.net domain next to my other domains. Addition -------- 1. Added the comment above these domains in the HSTS list: - Burton domains (contact: burton at typewritten.net). - In case you need contact me in regard to the domains. 2. Added the name "Burton <burton@typewritten.net>" - I don't include firstname anymore. Burton R=nharper@chromium.org Change-Id: Iba0784cf582b4e800c1c48e238a580d5ebb0a3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506392 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#638397}
-
Ian Swett authored
R=rch@chromium.org Change-Id: Ic8cbf358f796827f4570a8cb285a5438060ab953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506000 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
-
Ryan Hamilton authored
which records the reason a QUIC packet could not be processed, logged for each dropped packet. (And adds the associated enums.xml entry) The histogram was added in https://chromium-review.googlesource.com/c/chromium/src/+/1498774/2/net/third_party/quic/core/quic_framer.cc#444 Change-Id: I0ba6bf960b9f6260edab4cf517c1f4038b0874f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506102 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#638395}
-
Amit Hilbuch authored
This adds the histograms that are used to measure usage of simulcast. Histograms are added for: 1. Counting the number of send encodings in calls to AddTransceiver. 2. Counting the number of times that simulcast was disabled because remote party did not negotiate it back. 3. Counting how simulcast was indicated in calls to ApplyLocalDescription and ApplyRemoteDescription. Specifically counting no simulcast, legacy simulcast and spec-compliant. Bug: webrtc:10372 Change-Id: I95ef97bde88b36f0ce9c057363811417a5e1c9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497325Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Seth Hampson <shampson@chromium.org> Reviewed-by:
-
Josh Nohle authored
This reverts commit 657a8c53. Reason for revert: ASAN errors; container overflow Original change's description: > Use existing kUserKeyPair keys during key creation, if possible. > > In CyptAuth v2 Enrollment, the user key pair--also known as > CryptAuthKeyBundle::Name::kUserKeyPair or "PublicKey"--has special > standing in order to 1) accommodate any existing key from v1 Enrollment > and 2) enforce that the key is not rotated. Only one user key pair > should exist in its key bundle, and it should be an active, P-256 key > with handle "device_key". > > It is possible that CryptAuth could request the creation of a new user > key pair even if the client sends information about an existing key in > the SyncKeysRequest. If this happens, the client should re-use the > existing user key pair key material when creating a new key. At the end > of the enrollment flow, the existing key will be replaced with this new > key that has the same public/private keys, but possibly with a new key > directive. > > It might seem more efficient to simply ignore the key-creation request, > but the method outlined above natually fits into the enrollment flow, > the key directive will be updated, and the client will be able to > provide CryptAuth with an EnrollKeys request, which it might be > expected. > > Bug: 899080 > Change-Id: I3a4a63aa902090698ecb619bc7af78ff1e790c23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504121 > Commit-Queue: Josh Nohle <nohle@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638327} TBR=khorimoto@chromium.org,nohle@chromium.org Change-Id: Ida02d62899eecc6a391e05b34bf576ff12e9541f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507279 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#638393}
-
mrefaat authored
tab.browserState used to get the ReadingListModel, So instead use webState to get ChromeBrowserState which can be used to get ReadingListModel Bug: 902044 Change-Id: I66d84993e9d74f301b872e53c2b09dd75a106463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504496 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3ec692344cb..4ad364d5cbb9 git log c3ec692344cb..4ad364d5cbb9 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 vapier@chromium.org cbuildbot: run ctest out of crostestutils Created with: gclient setdep -r src/third_party/chromite@4ad364d5cbb9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I52f53a5cabd3b57eb79e5ba4a3932908ec2034fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507133Reviewed-by:
-
Josh Nohle authored
This reverts commit c439e081. Reason for revert: <INSERT REASONING HERE> Original change's description: > Use key bundle name instead of key handle for HKDF "info" parameter > > In the CryptAuth v2 Enrollment flow, a key derivation function (HKDF) is > needed for symmetric key generation and symmetric key proof computation. > The v2 Enrollment protocol specifies that the "info" input parameter to > HKDF should be the key bundle name, e.g. "PublicKey" or "authzen"; > however, we were previously using the key handle. > > We verified this through manual testing. > > Bug: 899080 > Change-Id: I31e6d5d4aba819f17b960744bd70f80c07ea9867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504310 > Commit-Queue: Josh Nohle <nohle@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638378} TBR=khorimoto@chromium.org,nohle@chromium.org Change-Id: Ic53495e0755ed26a6ec121bac81dad7ee92ed341 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507278Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Now that PendingBookmarkAppManager doesn't access ExtensionRegistry and ExtensionPrefs directly for installations, we can avoid faking some cases in tests. PendingBookmarkAppManager still uses ExtensionRegistry for uninstallations so we still need to fake some calls to it. Once we abstract uninstallation, we can remove all usage of ExtensionRegistry from tests. Bug: 916381 Change-Id: Ied92df67f8cb6ab7d07ffa5ea64b487e5d50d6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502258 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638389}
-
Vlad Tsyrklevich authored
On some libcs posix_memalign is defined with warn_unused_result. Check its return value and handle it appropriately in this test. Change-Id: Iaa7151fe101b0dfc04192229a9a8751e1f92507f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507037 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638388}
-
