- 27 Jan, 2019 35 commits
-
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 925652 Change-Id: I336d7d916dd8bd9a355bfa0ef0f720111b78d221 Reviewed-on: https://chromium-review.googlesource.com/c/1438361 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#626399}
-
Olivier Li authored
Bug: 661143 This experiment will be re-attempted now that crbug.com/680698 was fixed. Change-Id: Iade1ebe52fa755c6494ca69f4bd9fbb961896859 Reviewed-on: https://chromium-review.googlesource.com/c/1434077 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#626398}
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-request/pull/721 Tests: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRetryTest.java Manual tests: wpt/payment-request/payment-response/retry-method-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html Bug: 861704 Change-Id: Ibeae527b950c32e31ca19a631da3a88dc9e33429 Reviewed-on: https://chromium-review.googlesource.com/c/1415050 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#626397}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=smcgruer@chromium.org Bug: 925652 Change-Id: Ibd9e6d542f0b76ce4c868600c655a41c106262b6 Reviewed-on: https://chromium-review.googlesource.com/c/1438268 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#626396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac2ed7df2033..8c65c2868c5d Created with: gclient setdep -r src-internal@8c65c2868c5d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1e2956aefcc5fc0228009af6fdf7dd130ac8dc68 Reviewed-on: https://chromium-review.googlesource.com/c/1438477Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626395}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1332e178. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie711638bc092d87bc057e85f08e9e4cf07532caf Reviewed-on: https://chromium-review.googlesource.com/c/1437932Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626394}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=guidou@chromium.org Bug: 925652 Change-Id: I01ea2b6aea86958b966cf75c5ae93abee02d928a Reviewed-on: https://chromium-review.googlesource.com/c/1438392 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#626393}
-
Pavel Shmakov authored
Currently, if the user is able to navigate or gets redirected to another trusted origin within a TWA, the only way to ensure that the other origin gets verified is by calling CustomTabsSession#verifyRelationship on the client side. Besides being a bit awkward api, that would delay launching Chrome, and consequently, showing splash screen, so this needs to change. This CL is about receiving a list of additional origins and verifying them as they are visited. Companion CL in custom tabs: https://chromium-review.googlesource.com/c/custom-tabs-client/+/1422138 Bug: 856544 Change-Id: I3561b3ac3c11a7bf18a8ca23785ad4692bb693f1 Reviewed-on: https://chromium-review.googlesource.com/c/1422159Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#626392}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5d462f614c5..ac2ed7df2033 Created with: gclient setdep -r src-internal@ac2ed7df2033 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaf9d9126a1beb03e8d65c911d99ef4695e2d0dd6 Reviewed-on: https://chromium-review.googlesource.com/c/1438119Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 045a6cd0. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5cc7fd22eb004b0dfa7ed32d88e7bb1891fda842 Reviewed-on: https://chromium-review.googlesource.com/c/1438058Reviewed-by:
-
BUG=762641 TBR=michaelpg@google.com Change-Id: Idc14032a6ede478de8a2dd5dfaa1963f16d820a9 Reviewed-on: https://chromium-review.googlesource.com/c/1438036Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626389}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bc0507ffff1..b5d462f614c5 Created with: gclient setdep -r src-internal@b5d462f614c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iab05838a0d3781ce6af28e8f19f56f2ca4949605 Reviewed-on: https://chromium-review.googlesource.com/c/1438476Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 925652 Change-Id: I69bce93044e76e565d8224e772feac12af85db88 Reviewed-on: https://chromium-review.googlesource.com/c/1438293 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626387}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/55bd70de653a..accf90556a95 git log 55bd70de653a..accf90556a95 --date=short --no-merges --format='%ad %ae %s' 2019-01-27 manojgupta@chromium.org Revert "chromeos_config: Move kevin64-chrome-pfq to kevin64-chromium-pfq." Created with: gclient setdep -r src/third_party/chromite@accf90556a95 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4321f8f46076900fff0f09225f4b612b6016545f Reviewed-on: https://chromium-review.googlesource.com/c/1437549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626386}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=meacer@chromium.org Bug: 925652 Change-Id: I69b3596033c224e332b5d2a119c6fe660ccdf070 Reviewed-on: https://chromium-review.googlesource.com/c/1438403 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/acee6cbedb0e..4bc0507ffff1 Created with: gclient setdep -r src-internal@4bc0507ffff1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib9515ef12c0e73f4736b0701c05d0b39fe680759 Reviewed-on: https://chromium-review.googlesource.com/c/1437548Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib8e77127c0d75c2f5ef49c16d6aa4abfbe71d4ad Reviewed-on: https://chromium-review.googlesource.com/c/1438475Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 925652 Change-Id: Ibd2d17e843c4dcc0adc8461886348458dc44bc22 Reviewed-on: https://chromium-review.googlesource.com/c/1438333 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626382}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57dc0df8. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie353c5b18f01ec417e7a4d66102c8700b77e2b9d Reviewed-on: https://chromium-review.googlesource.com/c/1438057Reviewed-by:
-
Zhongyi Shi authored
When the original connection failes with WRITE_ERROR before handshake is confirmed, kick off a new connection on the alternate network if that's available. Note this will require the alternate network happen to be available when the write error is triggered. Otherwise, this will be a no-op. Bug: 790547 Change-Id: Ib6fb6c6fdb3848b5c94b880b0d6777b9f4bcb3f6 Reviewed-on: https://chromium-review.googlesource.com/c/1422745Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#626380}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id0742876e07e169fc1782fe85a4ff17f07767de3 Reviewed-on: https://chromium-review.googlesource.com/c/1437550Reviewed-by:
-
Justin Cohen authored
Seeing the following two tests regularly failing on first run, occasionally failing on retry, and always failing on the internal iOS12 beta bots. SaveCardInfobarEGTest/testUserData_LocalSave_UserDeclines SaveCardInfobarEGTest/testUMA_Upstream_UserDeclines Bug: 925670 TBR: mahmadi@ Change-Id: Id39d897859565f1e89699690eae893f99ea348ef Reviewed-on: https://chromium-review.googlesource.com/c/1438459Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626378}
-
edchin authored
The goal of this CL is to fix side swiping so that the infobar doesn't magically disappear when side swiping. Previously, the infobar was being hidden when the user side swipes the omnibox to change the tab. While it is necessary to hide the infobar and other accessory UI when swiping to navigate, it is not necessary for swipe to change tabs. The reason it is not necessary is that the whole UI is covered by the side swipe horizontal carousel cards (which use a snapshot of the tab). On the other hand, side swipe to navigate does not place a snapshot above the tab, so the tab is sliding behind a stationary infobar. This CL removes unnecessary code that hides accessory views when side swiping the omnibox. Bug: 925246 Change-Id: I767566d0b4ac7e8371b1ce69368855d005433d64 Reviewed-on: https://chromium-review.googlesource.com/c/1435721Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626377}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=rch@chromium.org Bug: 925652 Change-Id: I91a7e8eb670531ea1b85051a9917276ea9602f58 Reviewed-on: https://chromium-review.googlesource.com/c/1438295 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
edchin authored
web_state.h is an ObjC header and must be #imported per the style guide. This fixes usages in /components/autofill/ios. This CL was uploaded by git cl split. R=mahmadi@chromium.org Change-Id: Ib91c8e41074c8e8a24ac59f4b8f37d69c1efeac9 Reviewed-on: https://chromium-review.googlesource.com/c/1433600Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626375}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/33625e18d47e..55bd70de653a git log 33625e18d47e..55bd70de653a --date=short --no-merges --format='%ad %ae %s' 2019-01-27 manojgupta@google.com chromeos_config: Move kevin64-chrome-pfq to kevin64-chromium-pfq. Created with: gclient setdep -r src/third_party/chromite@55bd70de653a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5ce8d4217751752964e2e173adfa25a454fe5fff Reviewed-on: https://chromium-review.googlesource.com/c/1438298Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I4a1afcfb095ed6e61183c9b22dad0bb1ca10d331 Reviewed-on: https://chromium-review.googlesource.com/c/1438454Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#626373}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=michaelpg@chromium.org Bug: 925652 Change-Id: I4c82811ae5b6bb31e2fef4930eb910e93ccb72e0 Reviewed-on: https://chromium-review.googlesource.com/c/1438359 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626372}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 925652 Change-Id: I5982d852f25d78b08a7f8fedab089002def3145b Reviewed-on: https://chromium-review.googlesource.com/c/1438383 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626371}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 925652 Change-Id: If020cff4421068fdc3a25299eb0288cc8c4860ab Reviewed-on: https://chromium-review.googlesource.com/c/1438315 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#626370}
-
Justin Cohen authored
The following tests have been consistently failing on first run, and flakily failing on the second run. Disabling for the time being while investigating. ContentSuggestionsTestCase/testAdditionalItemsKept ContentSuggestionsTestCase/testLearnMore ContentSuggestionsTestCase/testOpenPageAndGoBackWithMoreContent NTPHomeTestCase/testFavicons NTPHomeTestCase/testCollectionShortcuts Bug: 925657 TBR: kkhorimoto@, gambard@ Change-Id: I085fbb35dd3191f175422e3988e7e6dc3b72742e Reviewed-on: https://chromium-review.googlesource.com/c/1437839Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33363aa07cff..acee6cbedb0e Created with: gclient setdep -r src-internal@acee6cbedb0e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id9c86e40735ffbdb0121d04481f29102d9ef9a7f Reviewed-on: https://chromium-review.googlesource.com/c/1437864Reviewed-by:
-
Vlad Tsyrklevich authored
Currently, the crash analyzer determines if a crash is related to GWP-ASan by checking to see if the exception address was in the GWP-ASan region. This can lead to some messy logic, such as requiring a double free to intentionally access the invalid allocation to crash which can be racy. Currently if two threads race a double free Thread 1 marks an allocation freed but not yet inaccessible and Thread 2 can fail to crash on accessing the page. Instead, update the allocator to store the double free address if a double free occurs and trap and have the crash handler to use that address as the source of the crash. Bug: 925447 Change-Id: Ia34a10c53d3d4a78c5bf82db671e3d0bb87ea4b9 Reviewed-on: https://chromium-review.googlesource.com/c/1435984 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#626367}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9518a57428ae..5ec7f0c4a113 $ git log 9518a5742..5ec7f0c4a --date=short --no-merges --format='%ad %ae %s' 2019-01-24 acozzette Fixed "make dist" 2019-01-22 absl-team Googletest export 2019-01-22 absl-team Googletest export 2019-01-07 chrisjohnsonmail fix: Add Arduino setup()/loop() functions back 2019-01-03 chrisjohnsonmail misc: Reapply Arduino functions 2019-01-03 chrisjohnsonmail misc: Revert formatting changes. 2019-01-03 chrisjohnsonmail chore: Add Windows cmake files to .gitignore 2019-01-03 chrisjohnsonmail chore: Alphabetize exclude directories. 2019-01-03 chrisjohnsonmail fix: Correct *_main.cc paths 2019-01-03 chrisjohnsonmail fix: Remove Arduino entry points Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chrome.try:win_chrome_official Change-Id: I79d929e33c5be9db27932970d8ef4db4bab1be96 Reviewed-on: https://chromium-review.googlesource.com/c/1437918 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626366}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e485df98. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6d176ca2469b1cebfd9bca8fba6787180dd72587 Reviewed-on: https://chromium-review.googlesource.com/c/1438033Reviewed-by:
-
- 26 Jan, 2019 5 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97dedda6a492..33363aa07cff Created with: gclient setdep -r src-internal@33363aa07cff The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iabbde1b30b469a887a10b952c9c893b250a774c5 Reviewed-on: https://chromium-review.googlesource.com/c/1437862Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id19a5213ae6043ea40572a7faf5fe47a51c00834 Reviewed-on: https://chromium-review.googlesource.com/c/1437860Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89faf0651c17..97dedda6a492 Created with: gclient setdep -r src-internal@97dedda6a492 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I96c3c9cbe9e61b30935e2438f882bc48fba8a14f Reviewed-on: https://chromium-review.googlesource.com/c/1437859Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eb2767b2eb24..bdb1123726a2 git log eb2767b2eb24..bdb1123726a2 --date=short --no-merges --format='%ad %ae %s' 2019-01-26 iannucci@chromium.org [osx_sdk] Fix properties when setting a single value. Created with: gclient setdep -r src/third_party/depot_tools@bdb1123726a2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9cfc48d69e13535583e4a18a79ff35ef2b3d18de Reviewed-on: https://chromium-review.googlesource.com/c/1437858Reviewed-by:
-
Thomas Tangl authored
This is a follow up to crrev.com/c/1422000. Missing includes and dependencies are added. TBR=dpapad@chromium.org Bug: 919745 Change-Id: Ie88b4a286fbb59b4ed47887ddc6d8a594da50bfe Reviewed-on: https://chromium-review.googlesource.com/c/1437208Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#626360}
-
