- 27 Nov, 2019 3 commits
-
-
Wez authored
Migrate all FIDL library target dependencies from their short names to fully-qualified ones, e.g fuchsia.mem was: //third_party/fuchsia-sdk/sdk:mem and is now //third_party/fuchsia-sdk/sdk:fuchsia-mem TBR=sky,dcheng,dalecurtis,agl,sergeyu,tsepez,yucliu Bug: fuchsia:42135 Change-Id: I3e4632fef22887f9f68ddd2b9d3e34dbb9bc7eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937578Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719425}
-
Oystein Eftevaag authored
The PickleWriter version is not needed outside of tests now, and generates conflicts when the TraceLog is first enabled by ETW (or etrace), which means 1) Initially, tracing client code which creates TracedValues, will get a PickleWriter. 2) After tracing is started normally, the tracing service client library installs the hooks into //base which causes ProtoWriters to be created instead. 3) Trace events which try to merge TracedValues, might then get into the unsupported scenario of trying to add a PickleWriter (created before pt 2) as a child of a ProtoWriter (created after pt 2). As part of this, changed a couple of callsites in cc/ which uses TracedValues purely for ToString() debugging and need to be able to generate JSON still. Change-Id: I0dbd145450fc34584d2034638931c424500863d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888271Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719424}
-
Daniel Murphy authored
This change is the first one in a series to start removing blob-specific code from the IndexedDBBackingStore class into its own file. This will eventually hold the blob storage integration separately with its own tests, etc. Work planning doc: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?pli=1#heading=h.ilyrswbua4hv Bug: 1024966 Change-Id: I3a468f79720344437973b175b098ad60389079fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918199Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#719423}
-
- 26 Nov, 2019 37 commits
-
-
Dan Harrington authored
Moves the source code. Updates imports. Feed tests remain under third_party for now, as they do not yet run or meet the style guide. ActionTypeConverter was renamed ActionTypesConverter to avoid being flagged as a TypeConverter which requires security review. Bug: 1024945 Change-Id: I34a2e9057d43e6542d35438b321aeb66cf1fa55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928303 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719422}
-
Matthew Denton authored
To support glibc 2.30, allow clock_nanosleep in the baseline BPF policy, with the same clock_id restrictions as clock_gettime and other clock_* syscalls. Bug: 1025739 Change-Id: Ic53a782fef01049bc61c535b50735a4a7d4c23c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935715 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719421}
-
Yun Liu authored
Original configs seem causing some suite failed, e.g.: weblayer_instrumentation_test_apk Bug: 1027689 Change-Id: I8b08c87fd22081906ce0333a5cbdaf62a08fba7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937567 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719420}
-
Malay Keshav authored
This patch changes the float precision from 'mediump' to 'highp'. This is needed for android. Bug: 1009322 Test: Manually tested various websites that were reported on the bug Change-Id: I87b57d57c43093b590741393dfef3c75c151c1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913708 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#719419}
-
Sarthak Shah authored
This CL will enable Chromium on Windows to have a touch fling inertia that behaves more like Edge and other native applications. This CL is third phase in the series of CL's for new fling animation curve. Phase 1: https://crrev.com/c/chromium/src/+/1884752 Phase 2: https://crrev.com/c/chromium/src/+/1884758 Note that this implementation does not tune the curve depending on the scroller’s size for non-root scrollers, something that may be desired. User feedback will be used to determine the importance of bringing that behavior to Chromium. Bug: 647137 Change-Id: Ie893a5b8309ffb0c68c2f638651433402cd4f316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906299 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719418}
-
Sergey Ulanov authored
Previously FilteredServiceDirectory was taking service names as char* and then retaining that pointer to use it later. This didn't work correctly when AddService() was called with name that's not stored in a static buffer. Updated it to take StringPiece and then copy it to std::string internally. Change-Id: I382e3929eabb9806f4a74664ed355da886dcc61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935723Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719417}
-
siyua authored
Adding a separate file for some the util functions in credit_card.h. These functions will be shared with the newly added CreditCardCloudTokenData file in CL crrev.com/c/1897317. Split this refactoring into a single CL as suggested. TBR=rouslan@chromium.org,edchin@chromium.org for a simple name change. Bug: 1020740 Change-Id: I4a046eb1294e8ee07b96ca07584e4e5c1f6598aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928011 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#719416}
-
Johannes Henkel authored
Looks like it's not used. Also fix typo (protocl) and simplify dispatcher_ field. Change-Id: I7e61571eecb56f3a89c0636b7ea44e8afcc9187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937769Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719415}
-
Owen Min authored
Bug: 1028778 Tbr: lazyboy@chromium.org Change-Id: I992baf4cac7f05577ab3fea86b0d78aa3670f67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937777Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719414}
-
Ben Wagner authored
Support for variable fonts on macOS earlier than 10.12 was incomplete. CGFonts supported variations fairly well by themselves, but hid the tag name of the axes. CTFonts only supported named variations of system fonts (which meant only Skia). It is possible to create a CTFont from a CGFont, but this can into various bugs (because the CTFont didn't really know about the variations in the CGFont). Beginning in 10.12 it is possible to create a CTFont from data and set a variation on it directly, allowing for much simpler code, a path forward for better and faster API, and a possible reduction in font data leaking. The only real observable affect of this change will be that the Skia system font on macOS 10.11 will stop varying. Blink will still use FreeType to render variable webfonts on macOS 10.10 and 10.11. Change-Id: I7c188f4245af1b36c6e258a17935710a1ac02076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937778 Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#719413}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/9b73e21c0df8..b8549ed88953 $ git log 9b73e21c0..b8549ed88 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 angiebird Make GetCodingFrameNum const function 2019-11-22 angiebird Add missing includes to simple_encode.h 2019-11-21 angiebird Correct typo in simple_encode.h 2019-11-21 angiebird Cosmetic change of GetBitrateInKbps 2019-11-25 johannkoenig fix __has_attribute in visual studio 2019-11-20 vitalybuka Disable -ftrivial-auto-var-init= for hot code 2019-11-15 vitalybuka Disable -ftrivial-auto-var-init= for hot code 2019-11-20 angiebird Change vp9_get_encoder_config. 2019-11-20 angiebird Add trailing underscore to members of SimpleEncode 2019-11-20 angiebird Rename impl by EncodeImpl (...) 2019-10-25 angiebird Make [min/max]_gf_interval static under rate_ctrl 2019-10-24 angiebird Add rate_ctrl flag 2019-10-29 johannkoenig always use lf for shell scripts 2019-10-29 johannkoenig remove .gitattributes 2019-10-29 johannkoenig remove .gitattributes filters 2019-10-29 johannkoenig support visual studio 2019 (vs16) 2019-10-29 johannkoenig remove old visual studio remnants 2019-10-23 angiebird Add get_arf_layers() 2019-10-23 angiebird Use RANGE in get_gop_coding_frame_num 2019-10-23 angiebird Add get_gf_interval_active_range() Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Bug: 1020220 Change-Id: I1549581f59fef928bf02fca77bcd542eb77475aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937135Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#719412}
-
Noel Gordon authored
CL:1924341 limited the horizontal scroll of the directorytree to 0, to resolve issue 1025581, and needs a test of this behavior. Test: create a nested set of test folders, and use keyboard arrow-left (provided by expandSelectedFolderInTree, note) to navigate to the last of those folders. Post navigation, verify the navigation, and that the directory tree is not horizontally scrolled. This new test passes with CL:1924341, and fails before that CL (good). The CL used requestAnimationFrame (rAF) to limit the scroll. Add async test rAF helper and call it to ensure the scroll rAF is done, and that expandSelectedFolderInTree events have been processed. Test: browser_tests --gtest_filter="*TreeKeyboardHorizontalScroll*" Bug: 1025581 Change-Id: Iff79b963559d282841f1d2045aadcee7e5840cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936579Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719411}
-
Andrei Polushin authored
Currently base::ReplaceChars() accepts std::string for the 3rd parameter, and immediately converts it to base::StringPiece. To avoid string copies on the caller side, it should accept base::StringPiece instead. This change became possible after r504430. BUG=760330 TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceChars Change-Id: I9a3a4cc02cfbfb8c8a258dc077612dd5146b9592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930799 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719410}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f1fce1f..f1c7d33e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia075ef59363e2e993415199109e0953772976764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719409}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44d7ec06830e..7a9a092708f1 git log 44d7ec06830e..7a9a092708f1 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 mellem@webrtc.org Delete media transport integration. 2019-11-26 saza@webrtc.org Fix fuzzer-found bug in fuzzer Created with: gclient setdep -r src/third_party/webrtc@7a9a092708f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028614 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f34bbebe369ce18678cd82740ec7bd8ef8b8abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719408}
-
Reilly Grant authored
Bug: 1007632 Change-Id: Ic571ca1cb670e8387ff64b3e6f84aee3f6679a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931152 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#719407}
-
Nico Weber authored
Except on Fuchsia (https://crbug.com/1028723) and macOS (testing/libfuzzer/fuzzers/mach/mach_message_converter.cc) for now. Bug: 999871 Change-Id: Iad97504432c293c880698cb28d0efb6c3611bbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937650 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719406}
-
Caleb Rouleau authored
The .json files are generated by using the following command: src/tools/perf$ ./generate_perf_sharding update --builders android-pixel2_weblayer-perf Bug: 965158, 1026327 Change-Id: I45eee6660b225e298def222135b1ad41af435ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935752 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719405}
-
Pavel Feldman authored
Change-Id: I81afd25f1124dd18da8e406bb46156ffccfbd616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937864 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719404}
-
Piotr Bialecki authored
This CL adds cancel() method to hit test sources. Details can be found here: https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md#unsubscribing-from-hit-test Change-Id: Ia988497ebb26b4c5b76f71de323398593b883b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937140 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#719403}
-
Danyao Wang authored
This patch splits the SkipToGPay experiment into two phases that can be tested separately per request from early partners: 1) kSkipToGPayIfNoCard: enables skip-to-GPay if and only if user doesn't have a usable autofill instrument. 2) kSkipToGPay: enables skip-to-GPay regardless of availability of autofill instruments in the user's profile. Part (1) required an extra lookup from the PersonalDataManager before dispatching payment app creation. Manual profiling on a Nexus 5 showed that this added 0.3-19ms extra main thread processing, with average around 3ms for profiles that contain at least one credit card. This is a relatively small performance penalty. Bug: 877284 Change-Id: If465bb1fe0c1f79979cc3743af5474662bd6dd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936107Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#719402}
-
Andrey Kosyakov authored
This reverts commit ec3649f6. Reason for revert: attempt to re-land the original change while maintaining protocol copy where devtools-frontend expects to find it. TBR=dgozman@chromium.org,tapted@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org Original change's description: > Revert "Move browser_protocol.pdl to third_party/blink/public/devtools_protocol" > > This reverts commit 3e9d66eb. > > Reason for revert: Widespread bot failures for Step "isolate tests" > > error like: > > isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/devtools_type_check.isolate: partitioning deps: lstat /b/s/w/ir/cache/builder/src/third_party/blink/renderer/core/inspector/browser_protocol.pdl: no such file or directory > > Bug: 1028446 > > Original change's description: > > Move browser_protocol.pdl to third_party/blink/public/devtools_protocol > > > > Bug: 1018108 > > > > This still retains a copy of protocol.json for compatibility with > > devtools front_end. > > Also, remove a presubmit for front-end compilation upon a change to PDL > > since the front-end is in another repository now. > > > > Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538 > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718903} > > TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org > > Change-Id: I39435e4be7dde62ffd48d1f72a0ecbbac9165ae1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1018108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935479 > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718977} Change-Id: Iae5bdbd809cea60fe566b1ebf160836982c4cfcd Bug: 1028446, 1018108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937860 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719401}
-
Alex Cooper authored
During local development it's possible for these tests to fail due to reaching the timout limits for polling that the error state has been reached. This bumps up the timeout to ensure that the tests can pass in local development environments as well as the waterfall. Bug: 1028777 Change-Id: Iaf6d93295cfe044046ef989710f0894ee8e6b850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938031 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719400}
-
Sean Gilhuly authored
GPU compositing is never specifically blacklisted in software_rendering_list.json, only when all are disabled, so remove it, and add GPU_FEATURE_TYPE_GL. Use this as a proxy for GPU compositing for now. This will need to be fixed to support the case where GL is blacklisted, but Vulkan is still enabled. Bug: 1005383 Change-Id: I0330021cfa59c6c4cf2719785f7931e53ec50f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917753 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719399}
-
manuk authored
Currently, we opened suggestions in a background tab when holding the super (Linux) or command (Mac) keys and pressing enter. The code implies pressing the window key and pressing enter should behave likewise on Windows; but this didn't work because key presses aren't propagated when the window key is held down. With this CL, holding alt+shift and pressing enter behaves similarly. This 1) brings feature parity to Windows, and 2) is symmetric to alt+enter which opens the suggestion in a new foreground tab. Bug: 898277 Change-Id: Ia6423435e9a3c9de81746ceda266803cad18704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937687 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719398}
-
Wenbin Zhang authored
From Pinpoint, end user can launch a job by selecting a benchmark together with a story or a story tag. Though, there's no way to run all stories of a benchmark. The reason behind this is that Pinpoint does not have enough devices so it wants to limit the duration of each job. However, some benchmarks are small and it won't be a big load even running all of their stories. Per Blink team's request, this CL adds "all" tag to two of its benchmarks: blink_perf.layout blink_perf.paint Bug: 1023451 Change-Id: I8754a40a283564677562bb0594dea07a8ba25d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929757 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#719397}
-
Yuki Shiino authored
Adds new APIs to web_idl.FunctionLike: overload_group overload_index Accordingly, set_overload_group is added with guards against abuse. In order to avoid circular imports, OverloadGroup is moved into function_like.py with only change in OverloadGroup.__init__. Bug: 839389 Change-Id: I8cf6b8550596d939eda1acc162959012e1d26b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936691Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719396}
-
Devlin Cronin authored
All implementations of ExtensionHostDelegate::GetExtensionHostQueue() returned a singleton instance of an ExtensionHostQueue. Instead of this piping, introduce ExtensionHostQueue::GetInstance(), which does the same thing without needing to be implemented by the embedder. TBR=atwilson@chromium.org (trivial background_contents.cc change) Bug: 1028334 Change-Id: I339267c2a8193c27bd782b63a8f8cc5e15957be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935489 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719395}
-
Peng Huang authored
This CL makes SkiaOutputDeviceBufferQueue work with Vulkan. It creates GLSurfaceEGLSurfaceControl for SkiaOutputDeviceBufferQueue. So SkiaOutputDeviceBufferQueue and SkiaOutputSurfaceImplOnGPU can use this GLSurface to present the SharedImage (AHardwareBuffer) as an overlay. TODO: * Refactor GL unrelated code out of GLSurfaceEGLSurfaceControl, so we can used them for both GL and vulkan. * Remove GL dependencies from SkiaOutputDeviceBufferQueue Bug: 1012401 Change-Id: Ic58e82d9f3cde86ac1601dc4f330a4309bff6178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931376Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719394}
-
Owen Min authored
Disable the test on Mac and ChromeOS Bug: 1028765 Tbr: kolos@chromium.org Change-Id: Ic5a0f3ae6e20fea7dc507ce2d890a374eee53cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937776Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719393}
-
Caleb Rouleau authored
https://chromium-review.googlesource.com/c/catapult/+/1896356 changed the default so that now you need to pass in --run-abridged-story-set or else the full story set will run. Bug: 965158 Change-Id: I4453359f2bea160200c47befd118894d239a4634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935787 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719392}
-
Clark DuVall authored
This was causing problems with the QA testing, since many sites open new tabs for signin pages, etc. Bug: 1028695 Change-Id: I14a3f1ca644e5a0dfd0efad9ef3070de093804bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937865Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719391}
-
Natalie Chouinard authored
Fix some of the more trivial presubmit warnings and errors in the preferences package. This will reduce the number of failures we'll need to bypass in the upcoming package renaming. Bug: 1027271 Change-Id: I5bda8192c91158d281f214a4d91e907f058a24d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935716Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#719390}
-
Natalie Chouinard authored
The "Added Symbols named -ForTest" check is no longer disabled. Change-Id: I3b42550f138de7146627591b5dc4b48d2406e2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937861 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#719389}
-
Olga Gerchikov authored
Implemented common mechanism for targeting animation events initiated by animations and worklet animations. Changes made: - AnimationHost::SetAnimationEvents consults animation timeline to find a target animation. - Moved animation events routing logic from cc:ElementAnimations to cc:Animation. - Directly route to the target keyframe model using keyframe id and model id instead of using element id and group id to identify the target keyframe model. Bug: 1013727 Change-Id: I28613b0e708258e6433a45e828710caa3e73e280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872486 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719388}
-
Benjamin Beaudry authored
This is a reland of 507f4ee8 It seems like CL:1935027 caused the failures and the revert. Once this change relands with a fix (CL:1935212), I'll reland this one. Original change's description: > Do not return InlineTextBox nodes from UIA GetEnclosingElement > > In AXPlatformNodeTextRangeProviderWin, nodes with role kInlineTextBox > should never be exposed to UIA. This CL introduces a simple fix. > > In GetEnclosingElement(), if the enclosing node is an inline text box, > we simply return its parent. I also updated a unit test for this case. > > Bug: 928948 > Change-Id: I31a31566461c3091bed36ebad626c4f51afc55a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931753 > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#718920} Bug: 928948 Change-Id: I6dbac3eae0a17d29f13c3d6b75532018729782de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937134Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#719387}
-
Piotr Bialecki authored
Change-Id: Ifea3556a96b99f27a13c6ba0b3785d4ddefe28a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937351 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#719386}
-