Commits · 5012d3ea1d61bc163ed1135644b3931a5282a519 · eriksson monteiro / tangled

17 Jun, 2020 40 commits

[Web Payment] Make PaymentAppProvider use WebContents* · 5012d3ea

Nick Burris authored Jun 17, 2020

This patch makes PaymentAppProvider methods take a WebContents* instead
of BrowserContext*. This is a first step toward making WebContents own
PaymentAppProviderImpl rather than it being a singleton.

The payment_handler_windows_ map is changed to a single
payment_handler_window_, but note this is just to remove the
BrowserContext* key dependency, we still enforce one payment request
per browser via PaymentRequestDisplayManager.

PaymentAppProviderImpl's RespondWithCallback and callback repository
still depend on BrowserContext*, since the callback may outlive the
WebContents. This will be cleaned up in step (3) of the bug, where the
callbacks will be owned by PaymentAppProviderImpl instead of a singleton
repository.

Bug: 1075687
Change-Id: Ib4460b82f9938e973f067f45669a6031f7f0da3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240064Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779343}

5012d3ea

Include-what-you-use related to logging.h (google_apis) · 362f5ee0

Hans Wennborg authored Jun 17, 2020

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I232b5159e7816b2f2bb640ede69bed7fac7a75da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248630
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779342}

362f5ee0

IndexedDB: Use url::Origin::host() in IndexedDBQuotaClient. · 07a0ecf8

Victor Costan authored Jun 17, 2020

The original code converts the Origin to GURL, then uses

net::GetHostOrSpecFromURL(). This is likely the result of mechanical
conversions replacing GURLs representing origins with url::Origin.

Change-Id: I1fb5e38987b569c88a69bed41450957a33db3f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249387Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779341}

07a0ecf8

Add VS Code remote dev link for Chromebooks · 3ba9120d

Peter Wen authored Jun 17, 2020

Since Googlers may not be able to use ssh in crostini, add a link for an
alternate way to set up VS Code remote development on chromebooks.

Tbr: minor doc change
Bug: None
Change-Id: Ie59e888dca4f7d86522584b012af671f8b544b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246859Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779340}

3ba9120d

[Extensions UI] Don't show the (x) button in settings overridden dialogs · 51bdbc67

Devlin Cronin authored Jun 17, 2020

The latest UX style indicates we shouldn't show a (x) button in modal
dialogs. Update the extension settings overridden dialogs to match.

Note that the dialog can still be dismissed without a decision by
- hitting the escape key (which triggers the "closed" callback)
- closing the parent widget

Bug: 1079364
Change-Id: I4dea1c41656f76e5951267cfd3c2459ad9e148e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247352Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779339}

51bdbc67

Remove DirectoryCryptographer · fed7e6a3

Maksim Moskvitin authored Jun 17, 2020

This CL removes DirectoryCryptographer and its last usages.

Bug: 1083924
Change-Id: I800c9aee00c1f35e81fc177bf835ea76916bd760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228553
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779338}

fed7e6a3

Revert "[WPT Import] Make importer use vpython rather than python" · c3debeea

Robert Ma authored Jun 17, 2020

This reverts commit c75217d6.

Reason for revert: https://crbug.com/1095643
Broke run_web_tests.py for Windows developers

Change-Id: Id7422be7bed874a65cf35da952978f42f0cb76c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248725Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779337}

c3debeea

[Passwords] Init PasswordSaveUpdate*View members in the header · a48db565

Mohamed Amir Yosef authored Jun 17, 2020

Bug: 1044038
Change-Id: I48ac13f6ffc6f44f990c5dfd7f3248ab3b614d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248629Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779336}

a48db565

Include-what-you-use related to logging.h (dbus) · 16460913

Hans Wennborg authored Jun 17, 2020

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Icf68406e5513792097ba9b7ed6da2e7e8b75b080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248576
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779335}

16460913

Document min_os_version · 60ac0eca

Jonathan Backer authored Jun 17, 2020

Change-Id: Ie4b2ecd7e64a19d17fb84790b844fc96751621a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246545
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779334}

60ac0eca

Use EXPECT_DCHECK_DEATH in gtest_links_unittest · d187540d

Sven Zheng authored Jun 17, 2020

Change-Id: I0b6e93ae809189b749d10b35365a52bf40297c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247349
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779333}

d187540d

Include-what-you-use related to logging.h (headless) · 3d897740

Hans Wennborg authored Jun 17, 2020

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I0ed5a3c7a64e4fcc3a68a2ec0522d639f1fa4474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249801
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779332}

3d897740

Include-what-you-use related to logging.h (ppapi) · 2e85796c

Hans Wennborg authored Jun 17, 2020

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Icaa271ea7e32c0494a7b3f578696e397e7cd0a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249675
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779331}

2e85796c

Include-what-you-use related to logging.h (ios) · 22bfb42e

Hans Wennborg authored Jun 17, 2020

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Id378f4f3ceaabbfeabb83a02779708f5707c4fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248762
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779330}

22bfb42e

[Android] Fix DFM logging issues after previously failed attempts. · 827b67ad

Fred Mello authored Jun 17, 2020

This change will make sure that the availability logger ignores
previously failed attempts.

Bug: 1095136
Change-Id: I129bd9b2357fd831fe9a82749cdde2b85390ef85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248866Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779329}

827b67ad

[tools/perf] Fix proxy power metric · 6a8ef68b

Mikhail Khokhlov authored Jun 17, 2020

Sched slices with utid = 0 correspond to the time when CPU is idle,
so they don't contribute to the total power consumption.

Bug: b/155073796
Change-Id: I072b2e9bb8984161518634633d9b4a7bf411eceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247893Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#779328}

6a8ef68b

RubyNG: Move ruby-related functions to ng_ruby_utils.{cc,h} · e5fb002b

Kent Tamura authored Jun 17, 2020

Moves the following functions:
 - NGInlineLayoutAlgorithm::ComputeAnnotationOverflow()
 - LastLineTextLogicalBottom() in ng_block_layout_algorithm.cc
 - FirstLineTextLogicalTop()  in ng_block_layout_algorithm.cc

This CL has no behavior changes.

Bug: 1069817
Change-Id: Ie59211a2644f81a4e43bcde5f7010f8765b2955a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249431
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779327}

e5fb002b

Fix clang build if ATK_230, ATK_232 aren't defined · 82c7f7d7

Kristian Kirs authored Jun 17, 2020

In this case compiler warns about function declared never referenced.

Change-Id: If8f7458c930890182c74e776dd31bb168956a693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246167
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779326}

82c7f7d7

Roll src/third_party/libunwindstack/ 046920fc4..11659d420 (3 commits) · dba9a2b8

Mike Wittman authored Jun 17, 2020

https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/046920fc491a..11659d420a71

$ git log 046920fc4..11659d420 --date=short --no-merges --format='%ad %ae %s'
2020-06-15 wittman Make new upstream version build with Chrome
2020-06-15 wittman Update to upstream a7b4c5d25aeb
2020-06-16 wittman Streamline update process

Created with:
  roll-dep src/third_party/libunwindstack

Also includes updates to Chrome's native_unwinder_android.cc to account
for libunwindstack interface changes:
  - split of Step() function into StepIfSignalHandler() and Step()
  - use CreateLocalProcessMemory() to create memory subclass for the
    current process

Bug: 1004855
Change-Id: I54590d7c7ef3670fde42cc03ec1697c0f605d40b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248759Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779325}

dba9a2b8

Revert "Roll WPT internal tools to 3016dfa710e2114595431f6506f1c7d5729c2484" · 4422d7ce

Stephen McGruer authored Jun 17, 2020

This reverts commit f1e5e2aa.

Reason for revert: Broke WPT importer: crbug.com/1095643

TBR=robertma@chromium.org

Change-Id: Ice2e5f837095b2ea09c48bef7f6565d145d0d32c

Bug: 1095643
Change-Id: Ice2e5f837095b2ea09c48bef7f6565d145d0d32c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248061
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779324}

4422d7ce

Remove DownloadShelf::CloseReason. · 11b6f25d

Peter Kasting authored Jun 17, 2020

No DoClose() implementation actually reads this argument.

Bug: none
Change-Id: Iee84eb6f912351eb80f7655b26aabc586d3fef67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248464
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779323}

11b6f25d

Reland "CDP: make a11y info optional" · 6e2a807e

Alex Rudenko authored Jun 17, 2020

This is a reland of aa42f61e

Original change's description:
> CDP: make a11y info optional
>
> This CL adds an attribute to the highlight config object to control
> whether a11y info should be shown. The test expectations have been
> updated accordingly. There is an accompanying CL in DevTools which makes
> use of the new attribute[1].
>
> [1] https://crrev.com/c/2238230
>
> Bug: 1092841
> Change-Id: Ic4a888ecf134b852fd67430b924da3812f244dac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238828
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778791}

Bug: 1092841
TBR: caseq@chromium.org
Change-Id: I9b14d446efe6355af0e8a8f43dcf1f866783a216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248680Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779322}

6e2a807e

oobe: Check if WizardController is initialized for testing methods · 5fbf47ec

Roman Sorokin authored Jun 17, 2020

This CL fixes regression introduces in CL:2230472. Before *ForTesting
methods checked if WC is created. After the offending CL WC is always
created. So in this CL the methods also check if the WC is initialized

Bug: 1094552
Change-Id: I603de486c6da5e62a406c7f6ecd407dafabf7762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247734
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779321}

5fbf47ec

Use ui::GetMenuSourceTypeForEvent() consistently. · b51f3c6e

Peter Kasting authored Jun 17, 2020

As far as I can tell from examining the affected locations, any possible
behavior changes are either oversights or can't really happen.

Bug: none
Change-Id: I7bf4095d15c022a6a35f672871d123b96c96c604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248350
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779320}

b51f3c6e

[b4p/Settings] Remove exceptions from 'passwords on this device' page · 66faa2f0

Victor Hugo Vianna Silva authored Jun 17, 2020

This CL is essentially a revert of cc694e8d, the reason being that UX
has decided not to have exceptions on this page anymore. The only two
differences regarding the original commit are: hasDeviceOnlyPasswords_
and hasDeviceAndAccountPasswords_ are still replaced with a shared use
of isNonEmpty_(); and the file documentation is updated to remove any
mention to exceptions.

Bug: 1049141
Change-Id: Ic95bf0042d6f4214ec40dd9dd0fedc492de56421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248683
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779319}

66faa2f0

Roll DevTools Frontend from 8dcbdb8aebf4 to cac292283bfa (3 revisions) · 980a9c7d

chromium-autoroll authored Jun 17, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8dcbdb8aebf4..cac292283bfa

2020-06-17 aerotwist@chromium.org Removes First Meaningful Paint
2020-06-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-06-17 mathias@chromium.org Encode Python indentation style in .editorconfig

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1096008
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib81836eac5978a58cb7faf5a0a8bfbab15cbd2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249708Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779318}

980a9c7d

Fix PasswordBubbleInteractiveUiTest with EnablePasswordsAccountStorage · f6de52dc

Marc Treib authored Jun 17, 2020

PasswordBubbleInteractiveUiTest.BasicOpenAndClose contains some
static_casts of the open passwords bubble
(from PasswordBubbleViewBase to PasswordSaveUpdateView). However, if
the feature EnablePasswordsAccountStorage is enabled, then instead of
PasswordSaveUpdateView, PasswordSaveUpdateWithAccountStoreView is used -
despite the similar name, an unrelated class, so the static_cast
produced undefined results.

This CL changes the static_cast to cast to the right thing, depending
on the state of EnablePasswordsAccountStorage.

Bug: 1093310
Change-Id: I555286ac9d6e428f2d565f458d2c9efb363a483b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248566Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779317}

f6de52dc

[Sync] Remove an obsolete histogram · fc889aa2

Jan Krcal authored Jun 17, 2020

This CL removes an expired histogram in the Sync Directory code that
is not used any more and will be deleted later in 2020.

Bug: 1089542
Change-Id: I07a9c4f18d7676944ade32200a1a795c4271484c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248571
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779316}

fc889aa2

Add final strings for 'passwords on this device' page · 6c259b78

Victor Hugo Vianna Silva authored Jun 17, 2020

Bug: 1062344
Change-Id: I6b025432d75c74bfd71fb0ce54f71a29c84cd8bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247830
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779315}

6c259b78

Roll Chrome Win64 PGO profile from... · e4ffd6b6

chromium-autoroll authored Jun 17, 2020

Roll Chrome Win64 PGO profile from chrome-win64-master-1592384236-59c052c5d04aee966d200af8272c6f3b6edf1818.profdata to chrome-win64-master-1592394610-918984ddb97fe9042cd9fa15afdd7d2534645615.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ibdde2caec205ab8e74682233f123d2e1fb3e92ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249707Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779314}

e4ffd6b6

Include-what-you-use related to logging.h (base) · afeb3908

Hans Wennborg authored Jun 17, 2020

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs to include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

TBR=ajgo

Bug: 1031540
Change-Id: Ie89d33873b42f9cd5eaab867b1f986afb9c3ac44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247833
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779313}

afeb3908

[wasm] Add missing use counters for post MVP features · ce70c079

Thibaud Michaud authored Jun 17, 2020

R=jochen@chromium.org
CC=clemensb@chromium.org

Bug: v8:10549
Change-Id: I6c2c5e1cd419ed7b217934a99d0032ce8667786e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247880Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779312}

ce70c079

Make GetVariationsVector (by key set) a private impl method · ab720e47

Roger McFarlane authored Jun 17, 2020

This CL renames/moved the GetVariationsVector method taking a set of
collection key ids to be a private GetVariationsVectorImpl method and
adjusts the call sites, tests and definition order to match.

Bug: 1073600
Change-Id: Ia921ae158e82159a695037090a53e74d1ddf8fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243991
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779311}

ab720e47

PasswordManagerClientHelper: don't prompt to move in incognito · 31eb61b8

Marc Treib authored Jun 17, 2020

This CL adds a check in PasswordManagerClientHelper so that it doesn't
call PromptUserToMovePasswordToAccount() in incognito mode.
Note that this does not actually change the overall behavior: The move
prompt was already suppressed in incognito, but in a somewhat
convoluted (and potentially fragile) way (see bug).

Bug: 1094918, 1093310
Change-Id: Iccfaaae7095d585c5ea39d3bf409c75c288ab723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247828
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779310}

31eb61b8

[COOP] Add the access reporting flag. · 5f87dca8

arthursonzogni authored Jun 17, 2020

Adds the cross-origin-opener-policy-access-reporting flag.

- The cross-origin-opener-policy-reporting flag was about reporting
  browsing context switches [1].
- The cross-origin-opener-policy-access-reporting is about reporting
  access in between two windows blocked by COOP [2]

We have two flags because:
1) [1] is simpler to implement than [2], we might have to ship them in
   different releases.
2) The feature is complex, the flag could be used as a kill-switch. We
   want to be able to disable only this part while preserving the other
   if needed.

[1]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md#reporting-browsing-context-switches
[2]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md#report-blocked-accesses-to-other-windows

Bug: 1090273
Change-Id: Id9bada094fac34a30a2ed9da9c71baf1e51207a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247832Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779309}

5f87dca8

Roll src-internal from 7d12eb78c7c0 to 20aa34ea8ddc (1 revision) · 2335dd50

chromium-internal-autoroll authored Jun 17, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d12eb78c7c0..20aa34ea8ddc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC ioanap@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1082908
Tbr: ioanap@google.com
Change-Id: I3888dd7b4ad297e49b11f4f11f426a1944e5acdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249703Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779308}

2335dd50

Notificafions: don't register notification click in all browsers · 6af117e0

Cezary Kulakowski authored Jun 17, 2020

With current implementation of notifications on mac clicking on
notification created by any active chromium browser will be
registered in all the browsers. Additionally clicking in notification's
button Settings will open settings page in all browsers. This commit
adds new field to the notification: creator's pid which is checked
with the pid of current process when the information about notification
being clicked is send to the browser process from the NSUserNotificationCenter.
If there is no match we do not process the notification. It doesn't solve
the problem with the focus (all browsers gets it and the last one which got
it will have it) but at least click on the notification is only registered
in the proper browser. It also fixes the problem with button Settings.

Bug: 1086899
Change-Id: Ia484c03c076f841ba3695b029ebced3c1191e6ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218827
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779307}

6af117e0

Roll WebRTC from a46fce2194df to ae1892d4e4ce (1 revision) · 4c765ca9

chromium-autoroll authored Jun 17, 2020

https://webrtc.googlesource.com/src.git/+log/a46fce2194df..ae1892d4e4ce

2020-06-17 terelius@webrtc.org Add simulation of robust throughput estimator to the event log analyzer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I221acd963c4b1519e4e9197a4afc3ef21a9f4dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249706Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779306}

4c765ca9

Roll Skia from 4c47d0ddea16 to f5cd604cb9d0 (1 revision) · cc497ab5

chromium-autoroll authored Jun 17, 2020

https://skia.googlesource.com/skia.git/+log/4c47d0ddea16..f5cd604cb9d0

2020-06-17 bsalomon@google.com GrMagnifierEffect uses child for src

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: djsollen@google.com
Change-Id: I3e797c833ccd99b85ab50c5cce58882e46cb3aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249705Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779305}

cc497ab5

[Signin][Android] Destroy account picker bottomsheet in observer · b4076165

Alice Wang authored Jun 17, 2020

This CL destroys the account picker bottomsheet by registering a
BottomSheetObserver object in BottomSheetController.

Bug: 1063362
Change-Id: Ibfcc6e27fc8c5438589d49f4e753b76321d5604c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241653
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779304}

b4076165