- 05 Aug, 2020 40 commits
-
-
Eric Seckler authored
This is a reland of 027aa92e Relanding but disabling test on CrOS devices (some of our CrOS devices seem to have asymmetric CPUs that aren't covered by the test). Original change's description: > base: Add API to restrict thread affinity to little cores on Android > > Adds functions that facilitate setting the CPU affinity of a given > thread or process to all little cores on the system. > > We intend to use this API to run a power experiment. > > Bug: 1111789 > Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794998} TBR: dcheng@chromium.org Bug: 1111789 Change-Id: I59315ec0e9a1727986278a04fa5bde409143dfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339416Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#795126}
-
Ken Rockot authored
Storage service will no longer maintain support for unsandboxed out-of-process operation. This change eliminates the separate sandboxed service test suites and renames the others to drop the "unsandboxed" qualifier. Bug: 1052045 Change-Id: Ide0da8e819d52c989f84233f76ed9823423d65e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339716 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#795125}
-
Xianzhu Wang authored
crrev.com/794218 caused memory regression because of more frequent allocation of LayoutBoxRareData for the previous layout overflow rect which probably has different rareness characteristics from the other rare fields. Move the previous layout and visual overflow rects from LayoutBoxRareData into BoxOverflowModel to reduce chance of allocation of LayoutBoxRareData. This also enables us to simplify the previous overflow rect saving logic. Bug: 1112535 Change-Id: I1bc416b4065f6b47e6da0bcc05f2ec039bc04f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335647 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795124}
-
David Bertoni authored
Add tests for chrome.tabs.reload and chrome.tabs.update. This CL also cleans up the expected/actual order for chrome.test.assertEq in another test. Bug: 1093066 Change-Id: I614e82180e1ca08953515cbb1899ab00832f2fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322743Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795123}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/d6a5a2271e6e..8f1c25394047 2020-08-05 dpranke@google.com DEPS: remove use_relative_hooks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107325 Tbr: jophba@chromium.org Change-Id: Ic1008d083cd61e18042f553d44434bfffa824a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795122}
-
Eric Seckler authored
The Agent's GetCategories() can now be called on any sequence/thread, so needs to be thread-safe. Bug: 1111914 Test: N/A Change-Id: I2cba9d7306fea61ce76d97e46b3db1632666bd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332625 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795121}
-
Richard Townsend authored
Some Windows machines are DCHECKing in the HTML document parser. The intent of this check is to try and diagnose situations where the parser is still scheduled to perform asynchronous work on a stopped or detached document. Previously, this check was done all on one line, this CL separates it into two so that the crash report will show which of these two things is happening from the line number. Bug: 1112544, 901056 Change-Id: Ifd5877dbb3cfaaed9e43769f09af6e0adb61d76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339210Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#795120}
-
Marijn Kruisselbrink authored
Follow up for fix in https://crrev.com/c/2333036 Bug: 1112122 Change-Id: I4d98da63e7da3aabbb89971344ae10ddf425e5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339602 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#795119}
-
Brian Ho authored
The original CL was reverted [1] because it broke a few tests running on SkiaRenderer Vk (namely Pixel_Video_Context_Loss_MP4). This was because we only ensure the GL context is current in the ImplOnGpu::InitializeForGL path, but SharedImageFactory always creates a GL backing factory which in turn invokes a few GL API calls in its constructor. This CL fixes the issue by always making the GL context current regardless of Skia backend. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1111312 Bug: 1111312, 1046788, 971257, 1098435 Change-Id: Ifa5d91dc6d96d2ecc4144be95221cd188095f0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333991 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795118}
-
Mike Wittman authored
dladdr doesn't know about the Chrome module when it has been loaded by the crazy linker. Provide an alternate mechanism for finding the module in that case. Bug: 1004855 Change-Id: I3f6ac2cbd8df454fec38da17bbbab21d739a76f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327952 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#795117}
-
Keren Zhu authored
This CL is part of the effort to make Views default constructible, allowing UI to be built in a declarative fashion. Bug: 1108460 Change-Id: I28650681fa1fa7254ce3199c69a9b39bb49ec01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337973 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#795116}
-
arthursonzogni authored
The NavigationRequest holds a bunch of "document" related objects to be moved into the RenderFrameHostImpl once it has committed a new document. They must be moved if and only if a new document commits. In particular, nothing must be happen when receiving DidCommitNavigation for: - same-document navigation. - bfcache-restore navigation. There are several arguments that were overridden/reset mistakenly when committing a BackForwardCache restore navigation: - coep_reporter - coop_reporter - virtual_browsing_context_group - active_sandbox_flag - client_security_state Resetting these attributes mistakenly causes bugs, like not being able to send COOP reports. This fixes one test and adds 2 regression tests. Bug: chromium:1102285,chromium:1109648 Change-Id: I2ce5ebb1655b02e2b7f92a401fea33508abce178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320508 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#795115}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d84b21c3f04c..6dacd170b8de 2020-08-05 dproy@chromium.org trace-viewer: Add polyfill to systrace viewer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: oysteine@google.com Change-Id: Ica73c36ed38ff6dfd0b34a7788aaee0d5f56f1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339438Reviewed-by:
-
Aaron Colwell authored
Increasing the max size of the crashkey value and shortening the field names used in the crashkey value so that more information can be stored in it. The current values were accidentally made too small and initial crash reports contain incomplete information as a result. Bug: 1099998 Change-Id: I66c29113764b098e2fd100451d613fd1ea195860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339715 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Devtool Warning. Before - when enforcing full delegation, those sw-apps that are skipped for partial delegation are skipped silently. After - under the same situation, the apps are skipped with a warning message in devtool console. * Show Rejection. Before - when enforcing full delegation, if all sw-apps are skipped, no error would be given to the developer. After - under the same condition, the developer would receive an error in the form of a show() promise rejection. Note that if there has already been an error, do not override the error. * Test Addition. Add a test for the multiple-app scenario. * Test Fix. Bug: 1100656, 1103695 Change-Id: Ic6c8a1e222069a0eadbbcad7de2d358489dec8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316799 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795112}
-
Yuke Liao authored
This CL uses xvfb to run interactive_ui_tests on Linux and Lacros. Bug: 1104318 Change-Id: I8d1c245a8d266bef383e26d8e82418ab118559d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339598 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#795111}
-
Scott Violet authored
There are still some TODOS (most notably incognito is not supported), but this can largely be used outside of that. Embedder usage is as follows: . embedders interested in favicons call Tab::CreateFaviconFetcher() supplying a delegate. At this time embedders don't get the ability to specify a size (I wouldn't be surprised if we need this later). The actual size requested depends upon the platform. . The delegate is notified any time the favicon of the current navigation changes (not including when a new navigation starts). . The current favicon can be requested from the FaviconFetcher returned from CreateFaviconFetcher. Implementation wise the following pieces are used: . FaviconServiceImpl: implementation of favicon::CoreFaviconService that is used on the main thread to interact with WebLayerFaviconBackend. . WebLayerFaviconBackend: owns the database. All methods largely delegate to the database (same database used in chrome). . FaviconTabHelper: responsible for creating favicon::ContentFaviconDriver as necessary. ContentFaviconDriver is ultimately responsible for getting the favicon for the current navigation. ContentFaviconDriver is only created when necessary (meaning CreateFaviconFetcher() was called) as it actively downloads favicons. . FaviconFetcherImpl: created via Tab::CreateFaviconFetcher(), uses FaviconTabHelper to handle notifying delegate and maintaining favicon. BUG=1076463 TEST=covered by weblayer_browsertests Change-Id: I74bce59a6a46c38000b37b028a2d3e7797680e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337275 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#795110}
-
Guillaume Jenkins authored
Hooks up the basic CBCM infrastructure to Bling initialization. CBCM is disabled by default and requires the "--enable-chrome-browser-cloud-management" command-line switch to be enabled. This basic skeleton does not yet implement any of the CBCM functionality, even when the command-line switch is set. It only creates the iOS classes needed for CBCM to function (except the reporting delegates, which will be added later) and hooks up their lifecycle. This also adds a simple EG test that launches Chrome with and without the command-line switch and makes sure the browser can still be used to navigate, which should catch any initialization issues in both the enabled and disabled code paths. Bug: 1066495 Change-Id: Ic939f45cd20878981a8d407576e79252ec778ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331915 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795109}
-
Piotr Pawliczek authored
This patch adds additional logs to device log when a new USB printer is detected. BUG=chromium:1023648 TEST=tested on atlas Change-Id: I0aace9ca088378cea038a9b11138bdcf2b1d1e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339417 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#795108}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596628771-e32af535197a262fe54680b0a1a803a0983bdd0a.profdata to chrome-win32-master-1596635955-2b1d31dacdbaf52cf854414e21cd977f1d32db43.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I10b5110df8f5736125b114da54cdabd647cee298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339600Reviewed-by:
-
Yue Li authored
Check if the quick answers view is not dismissed when creating new ones to prevent multiple views showing. This is also a short term workaround of the view stuck issue. Bug: b/162596353 Test: Manual Test Change-Id: I5bc418547077622d637687796196c6de4aa3842e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335755Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#795106}
-
Haiyang Pan authored
There are not sufficient Pixel 2 devices to support CQ, due the maintenance work. Bug: 1111436 No-Try: true Change-Id: I6f72b5f5e734dd9ddbf7241ed0491382ae277e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339918Reviewed-by:
-
Kevin McNee authored
Bug: None Change-Id: I3f3cf99557701aae897b9a5cbdfd8bd3f093bcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339898 Auto-Submit: Kevin McNee <mcnee@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795104}
-
Kevin Marshall authored
Consolidates the forked OnLoadScriptInjectors into one single shared implementation. The shared implementation is a necessary prerequisite step for developing platform-agnostic bindings browsertests. * Deletes Fuchsia and Cast specific OnLoadScriptInjectors. * Moves most browser process logic into a new class "OnLoadScriptInjectorHost", to further harmonize the platforms. * Migrate Mojo interface from ScopedSharedBufferHandle to ReadOnlySharedMemoryRegion. Merge-With: eureka-internal/432742 Bug: 1113289 Bug: 1060846 Bug: 1103058 Test: cast_shell_browsertests and web_engine_browsertests both pass. Change-Id: If9fd2c54de08d9bc225771b01cdb32152a95fde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286193 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795103}
-
Kai Ninomiya authored
This flakes enough times in a row that RetryOnFailure is not enough. Could be because the flake rate is high, or because some system state causes it to fail consistently across a few retries. No-Try: true TBR: kbr@chromium.org Bug: 1112101, angleproject:4922 Change-Id: I1e5612644349ac28e782ef25ede61a2eac255631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338857Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#795102}
-
Joao Victor Almeida authored
Mousewheel (and touchscreen) hardware implementation of the scroll behavior can differ from different manufacturers. Some implement large scroll interactions as a series of small scrolls in a short interval of time. In these scenarios, clamping by a minimal scroll delta creates a very fast and jumpy scroll experience (as those small deltas are clamped by 16px). This was a first motivation to remove the lower-bound of percent-based deltas for mousewheels. But since the lower-bound is perceivable only in extreme cases (scrollers smaller than 100px), for simplicity, we remove the lower-bound for all use cases. In this CL, the minimum of 16px is removed from ScrollUtils::ResolveScrollPercentageToPixels. Bug: 1107662 Change-Id: If0572db744f83829884072f50e63d2ad03c2a545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336510 Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795101}
-
Peter Kasting authored
This also fixes some bugs: * Non-normal modes still used the file name + status label heights for the preferred label height, instead of an appropriate other 2-line label. * There was no padding between labels and dropdown button. * Various RTL positions and widths could be computed wrong. Bug: none Change-Id: Ie330c5daf4ed553a382db4bd8ca4d759972599d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333370Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795100}
-
Yuke Liao authored
This CL runs linux-lacros-compile-rel on CQ by default, required resources have been provisioned in: https://chrome-internal-review.googlesource.com/c/infradata/config/+/3197325 Bug: 1110382 Change-Id: Ic0914361ff7d74270aeeed3ad1a034b9b11a254c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335503 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#795099}
-
Etienne Bergeron authored
This CL is explicitly defining the closure called to ensure the NO_SANITIZE attributes is applied to the right function. see: https://bugs.chromium.org/p/chromium/issues/detail?id=1110792#c9 It seems there are code that detect CFI issues even if the attribute is specified. bug: 1110792, 1091259 Change-Id: I2261b138f84d7e05ffe9873d768e162d09b7fc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336871Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795098}
-
Lambros Lambrou authored
The host currently supports a control message to request ICE restart, which re-negotiates SDP offer/answer exchange. This CL adds a new control message to only do the SDP exchange without restarting ICE, since that is not necessary to reconfigure SDP parameters (for example, to switch to a different codec). Bug: 706220 Change-Id: I35f21d3eb701f91c56b05f7b97cd2d2d8540c2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336870 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795097}
-
Andrey Kosyakov authored
DOMSnapshot.captureSnapshot should be used instead. Change-Id: I32b9539e06b4f2d20bee6c34b7ba64a289c84ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335483Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795096}
-
Brian Sheedy authored
Fixes the earlier Gold issues by rolling the version of goldctl we use and re-enables Gold functionality in affected tests. Bug: 1112946 Change-Id: Ie9680d8f43883abe4392de55366ff37dfc3bf1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337398Reviewed-by:
-
Milica Selakovic authored
Bug: 1110942a Change-Id: If829d88ecc353ba86d20f1197f94365313f5e778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332608 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#795094}
-
Chris Harrelson authored
This one fixes fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html. It also modifies the test to actually verify that the video is composited. Bug: 1112884,1108972 Change-Id: Ia4357a540a3b8ac530331810824591af2210a5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337544 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Devlin authored
This reverts commit 9b84489c. Reason for revert: breaks windows compile Looks like we missed a callsite here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/google/google_update_policy_fetcher_win.cc;l=37;drc=0103fe2cf95d7e8fc1a46633d30f56131228906c [46403/48688] CXX obj/chrome/browser/browser/google_update_policy_fetcher_win.obj FAILED: ../../chrome/browser/google/google_update_policy_fetcher_win.cc /Foobj/chrome/browser/browser/google_update_policy_fetcher_win.obj /Fd"obj/chrome/browser/browser_cc.pdb" ../../chrome/browser/google/google_update_policy_fetcher_win.cc(37,13): error: no matching member function for call to 'Set' policies->Set(policy_name, policy::POLICY_LEVEL_MANDATORY, ~~~~~~~~~~^~~ ../..\components/policy/core/common/policy_map.h(146,8): note: candidate function not viable: no known conversion from 'typename remove_reference<unique_ptr<Value, default_delete<Value>> &>::type' (aka 'std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value>>') to 'base::Optional<base::Value>' for 5th argument void Set(const std::string& policy, ^ ../..\components/policy/core/common/policy_map.h(153,8): note: candidate function not viable: requires 2 arguments, but 6 were provided void Set(const std::string& policy, Entry entry); ^ 1 error generated. Original change's description: > Remove the old version of PolicyMap::Set > > 1. Removed the old version of PolicyMap::Set, > which passes value as unique_ptr. > 2. Changed all the remaining refs use the new > version which passes value parameter as base::Value > instead of unique_ptr. > > Bug: 1092469 > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795078} TBR=avi@chromium.org,eugenebut@chromium.org,emaxx@chromium.org,ayaelattar@chromium.org Change-Id: I03456080e9878bcc82eda2eddfe6474b8b13fed2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339389Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795092}
-
Stephen Martinis authored
We're looking at testing non-default field trial configurations on our bots to cover cases which happen in production which might not have existing test coverage. Bug: 1014727 Change-Id: Ib25bd35468010026acfc481f95bc7724083bd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238779 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#795091}
-
Devlin Cronin authored
Flaky on Mac. TBR=rogerta@chromium.org Bug: 1112111 Change-Id: Id90a9c6333874bb18ec1300537b8df583b21e132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339499 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Since PRImpl#onlySingleAppCanProvideAllRequiredInformation() is UI logic, it's being moved to PaymentUIsManager. * Replace the "requestXXX" calls in the method. Bug: 1102522 Change-Id: I6eabb53ca43e353b1a64d49fc305b13253287b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332370 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Josip Sokcevic authored
Bug: 1098562 Change-Id: I10e83b99a480d2d96b911e26b09e8db5d34a082e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333301 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795088}
-
Sreeja Kamishetty authored
This CL disables failing test "RenderFrameHostManagerTest.BeginNavigationIgnoredWhenInPendingDeletion" with BackForwardCache and adds a new test "RenderFrameHostManagerTestWithBackForwardCache.BeginNavigationIgnoredWhenInBackForwardCache" to consider the case when BackForwardCache is enabled. Bug: 1102630 Change-Id: I9999e443f96302f01c09c0a4def37cab7a536930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310310Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
