GitLab

This CL removes unused constructor code and fixes crash when
sharesheet is launched from non-files app.

Bug: 1132697
Change-Id: Ib61cf18393eaec5eae9b9f6ea7d16b2bfe6153fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434069Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811498}

directory is hidden unless show hidden files is checked.

Bug: 1119701
Change-Id: I35a5ce9ce867570d29e549c04f456519a08e0365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432444
Commit-Queue: Giovanni Panaro <tsrwebgl@gmail.com>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811497}

* Convert PressedCallback into a class to allow it to be constructed
  from the various different callbacks and listeners.  This reduces the
  number of overloads needed in APIs (though, sadly, not by as much as
  I'd hoped, since the ButtonListener constructor is two-arg and thus
  cannot be implicitly run in all the existing locations).
* Convert various APIs to take a PressedCallback primarily, with a
  temporary ButtonListener* overload.

Bug: 772945
Change-Id: Idde520cce7edd8f37a7a83ec0317bb453b9666e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433586
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811496}

After
https://chromium-review.googlesource.com/c/chromium/src/+/2424854

we slightly changed some of the enum key literals e.g. activedecsendantchanged
to activeDescendantChanged.

This undercovered an issue where methods like

chrome.automation.AutomationNode.prototype.addEventListener

appear to receive no validation. Callers can do
|node.addEventListener(undefined)| and reach the native bindings.

This change is a quick fix to make it so we don't crash.

R=dmazzoni@chromium.org

AX-Relnotes: n/a
Fixed: 1132662
Change-Id: Idf4effeb29a6974df6d2d0a933f157c3aed705ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433997
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811495}

Record user action when an emoji is suggested to get timestamp.
This is to figure out if some users get emoji suggested in a short
timespan.

Bug: b/168692236
Change-Id: I5ceb7c3c1846b9cae5a3c44a0ccc0bf62b7cb756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434186
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811494}

Change-Id: I72116e0417261f70826303cfc7d239ecb86b0dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427079Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811493}

Verification is expensive because of the need for sync IPCs and
unnecessary unless resources are shared across processes. This was
inadvertently added for cases where the resource is used within the same
process, for instance a canvas to canvas draw.

R=sunnyps@chromium.org

Bug: 1131916
Change-Id: I54dcf298f185928faaa5a9caa9198b3815b6fa8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432859
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811492}

This renames UpdateAncestorOverflowLayer() to
AncestorScrollContainerLayer.

BUG=1087667
TEST=purely rename.

Change-Id: I039b08c9378d74e015cbe334aed595ecc06ffd31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432079Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811491}

This reverts commit 26aa33d2.

Reason for revert: trybots are failing

https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/685012

[4694/19597] CXX obj/ash/ash/silence_phone_quick_action_controller.o
FAILED: obj/ash/ash/silence_phone_quick_action_controller.o
../../build/toolchain/clang_code_coverage_wrapper.py --target-os=chromeos --files-to-instrument=../....(too long)
../../ash/system/phonehub/silence_phone_quick_action_controller.cc:35:20: error: no member named 'SetDoNotDisturbState' in 'chromeos::phonehub::DoNotDisturbController'
dnd_controller_->SetDoNotDisturbState(!is_now_enabled);
~~~~~~~~~~~~~~~  ^
1 error generated.

In renaming SetDoNotDisturbState you missed the call in ash/ash/silence_phone_quick_action_controller

Original change's description:
> Reland "[CrOS PhoneHub] Add setter functions to various manager classes"
>
> This is a reland of 6a3c229f
>
> Original change's description:
> > [CrOS PhoneHub] Add setter functions to various manager classes
> >
> > The added setters are going to be used by a future Cl that implements
> > the PhoneStatusProcessor class.
> >
> > Bug: 1106937
> > Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346
> > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#810084}
>
> Bug: 1106937
> Change-Id: I02ac4d496d9493c7b52de7d6bb36eb61517caa16
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429290
> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811479}

TBR=khorimoto@chromium.org,jimmyxgong@chromium.org

Change-Id: I4d5edab201fa06caa630678a9b18d4d85f235e0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1106937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437016Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811490}

Bug: 1030199
Test: None
Change-Id: I2aba6e2b92e5db749d4faa389d01bfbeab1dbad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428515Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811489}

CL:2261179 added a definition of this API, but there was no
implementation for it.
This CL adds it.

Bug: 1127721
Test: browser_test AccessibilityFeaturesApiTest
Change-Id: I131406370e6e81599286bb02b5dd3e0dd6761aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407937
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811488}

Fix potential crash found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Iba1093736fa49775ad0c3605bc78e0a65cb890d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431487Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811487}

Focused state:
- Blue ring drawn outside of view.

Selected state:
- Blue ring drawn at border of view.
- Semi-transparent blue overlay drawn over view.

This CL also updates size of the pin icon.

Bug: 1131267
Change-Id: Ia3e45e0c42cbe99e40893ab5efc2e085eb91f2af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434766
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811486}

There are a couple reasons for this change:
1. Avoid copying a struct larger than a pointer.
2. If the pointer in the struct gets replaced by CheckedPtr with
   a non-trivial constructor, the compiler will complain.

See go/miracleptr for more details on the experimental CheckedPtr project.

Bug: 1080832
Change-Id: I5d0718a351af253bd3917bef87d417f9f0d71b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435033
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811485}

Roll Chrome Win32 PGO profile from chrome-win32-master-1601098956-d2e0aa4048f1f94bf1822bc14b11121ebd74fc3b.profdata to chrome-win32-master-1601294375-ec6f4fd0c2345f1003140fa4e4e991347147fa6d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Iba5a5de5a45f756dbe315fc8ff3a5f186b4a0e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435632Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811484}

This is a reland of f2f4de88.
The original version of this change caused crashes when running the
capture unit tests on Win7 (due to the MF DXGI Device Manager not being
supported on Win7).

The capture unit tests have been updated to skip MF D3D11 tests on Win7
 or earlier.

Original CL description:

[Win Camera Capture] Use D3D11 with Media Foundation Video Capture

This CL updates the VideoCaptureDeviceFactoryWin/VideoCaptureDeviceMFWin
implementations to use D3D11 with the MF device source and capture
engine. The VideoCaptureDeviceFactoryWin creates and manages an
IMFDXGIDeviceManager and associated D3D11 device instance. It provides
the IMFDXGIDeviceManager to the MF device source and also plumbs it to
the VideoCaptureDeviceMFWin implementation. The VideoCaptureDeviceMFWin
implementation subsequently provides the IMFDXGIDeviceManager to the MF
capture engine on initialization.

Providing a MF DXGI device manager to the MF device source and capture
engine is required for zero-copy capture (it allows the Windows frame
server service and MF capture engine to keep captured video frames in
GPU memory and expose MF samples backed by D3D11 textures).

Bug: 1120900
Change-Id: I41f1ef14e7040c84fa63e0ad2618330d73e7cdc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434469Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#811483}

This adds support for validating the device name that a user enters.
Validation happens as the user types and also when they try to save the
name. If an invalid name is detected, an error message will appear and
the "Done" button will be disabled.

Screenshots:
  https://screenshot.googleplex.com/3gnC6aQVyj4YmkX.png
  https://screenshot.googleplex.com/5arMAbok2MgfioU.png
  https://screenshot.googleplex.com/BEbCJ9LteRAYFpv.png

Bug: b:161297140
Change-Id: I3290eb92222cd796a1dede3ce603da5cc44940bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424675
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#811482}

Send a request to the plugin upon detecting a 'paint-thumbnail' event.
Set the thumbnail's image data upon receiving a response.

Bug: 652400
Change-Id: I3e8faa5a1cc15fbd274c9e641078d6aa8de7ec8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412968
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811481}

Video decoding was being accelerated on Linux even though the newly
added "enable-accelerated-video-decode" flag was not specified. The
chrome://gpu page was misleadingly showing this feature as disabled:

  > Video Decode: Software only. Hardware acceleration disabled

This change adds a check for --enable-accelerated-video-decode when
considering if video decoding should be activated. (Only on Linux.)

Extra context: https://crbug.com/1097029#c18 (and also comment 20).

Bug: 1066176, 1097029
Change-Id: I534115f5f6ceed0ee3511fcf5c2d0f1dd04b9b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431434Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811480}

This is a reland of 6a3c229f

Original change's description:
> [CrOS PhoneHub] Add setter functions to various manager classes
>
> The added setters are going to be used by a future Cl that implements
> the PhoneStatusProcessor class.
>
> Bug: 1106937
> Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346
> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810084}

Bug: 1106937
Change-Id: I02ac4d496d9493c7b52de7d6bb36eb61517caa16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429290
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811479}

- Create a base class for quick actions controller.
- Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states.
- Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL.

BUG=1106937,1126208

Change-Id: I3eb511e1843cd4cb6b80316a706a2dcbc61a8e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419552
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811478}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009280800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/VGNbHOZcwQ-4eGRBpvMYde9m0v8pkT_TboRdiMdOPC4C

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/166042882,b/166043485,b/169488265
Tbr: help-app@grotations.appspotmail.com
Change-Id: I31c2c791e8166c029f9b7f6b4e9e16c0d0f0aafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435492Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811477}

There are a couple reasons for this change:
1. Avoid copying 2-pointer struct.
2. If any of the pointers in the struct gets replaced by CheckedPtr with
   a non-trivial constructor, the compiler will complain.

See go/miracleptr for more details on the experimental CheckedPtr project.

Bug: 1080832
Change-Id: Ic2c6c1cc37601a8a22cb0bb2177547ea614fbcea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434021
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811476}

TBR=rsleevi@chromium.org

Change-Id: Iaa7a5aa9633f87b0f3538a7362091ed6e4ff72b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435723Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811475}

Change-Id: Ide40db02dcd3f16caf3da24b1283f3dd99348680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428271Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Tal Pressman <talp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811474}

TBR=govind@chromium.org

Change-Id: I074bcae49156e45b0d7795aedb502de95e03ca16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435756Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811473}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a49d4b5de90..1099c11d5d12

2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-09-28 chanli@chromium.org [depot_tools] Roll led to latest
2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I47d85337c4cee4a363a6e547d9feca0924704ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436890Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811472}

This reverts commit 5fd12ebf.

Reason for revert: No obvious change for crbug.com/1121730.

Original change's description:
> Revert "Enable transformed rasterization for most layers"
>
> This reverts commit b179b125.
>
> Reason for revert: for debugging crbug.com/1121730
>
> Original change's description:
> > Enable transformed rasterization for most layers
> > 
> > Background: transformed rasterization is used to render sharp text in a
> > composited layer with fractional transform. It snaps the composited
> > transform of the layer to whole pixels, then applies the fraction
> > during rasterization.
> > 
> > Previously we disallowed transformed rasterization in blink for directly
> > composited layers (excluding backface-visibility:hidden and trivial 3d
> > transforms such as translateZ(0)), especially for will-change:transform
> > because change of fractional transform would cause re-rasterization
> > which would defeat the purpose of will-change:transform.
> > 
> > Now for a layer that was not eligible for transformed rasterization,
> > calculate the initial raster translation which achieves sharp text
> > rendering with the initial transform. When the transform of the layer
> > changes, keep its original raster translation to avoid invalidation
> > of tilings, to ensure animation performance. The rendered result will
> > be blurry during animation but the initial rendering result is sharp.
> > 
> > Remove blink-side transformed rasterization conditions and let cc
> > decide it based on screen and draw transforms of the layers.
> > 
> > Bug: 1111195
> > Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Reviewed-by: vmpstr <vmpstr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#798268}
>
> TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1111195, 1121730
> Change-Id: Ibab42e963cab263cab062377ffa2aad38291c5a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427125
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810026}

TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1111195
Bug: 1121730
Change-Id: Ie61adb5086d7424346ec3ca006555e31e936be43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435803Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811471}

This is a reland of 7cf7dadf

Fixes: https://chromium-review.googlesource.com/c/chromium/src/+/2432754/2..3

device_junit_tests is also the name of a junit_binary, and cannot be
used as the target name. Not sure why CQ didn't catch this last time,
confirmed locally that was the problem.

Original change's description:
> Modularize DeviceConditions to chrome/browser/device
>
> This is a step to unblock some classes that depend on it (list below)
> and allow modularized code to reuse it.
>
> 11 inbound dependency(ies) into .c.b.DeviceConditions:
>     [chrome_java]
>         <- .c.b.background_sync.BackgroundSyncBackgroundTask
>         <- .c.b.background_sync.PeriodicBackgroundSyncChromeWakeUpTask
>         <- .c.b.download.DownloadInfoBarController
>         <- .c.b.explore_sites.ExploreSitesBackgroundTask
>         <- .c.b.offlinepages.BackgroundSchedulerBridge
>         <- .c.b.offlinepages.BackgroundSchedulerProcessor
>         <- .c.b.offlinepages.OfflineBackgroundTask
>         <- .c.b.offlinepages.prefetch.OfflineNotificationBackgroundTask
>         <- .c.b.offlinepages.prefetch.PrefetchBackgroundTask
>         <- .c.b.services.gcm.ChromeGcmListenerService
>         <- .c.b.sharing.click_to_call.ClickToCallMessageHandler
>
> This also breaks about 0.4% of the existing package cycles.
>
> Change-Id: I8ff8b665af2269161811ff76a4087b7e38d38172
> Bug: 1132380
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429587
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810702}

Bug: 1132380, 1132399
Change-Id: I3a41f3cb154ed261aed671debeb393b82b1411fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432754
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811470}

Use explicit expectations because wildcards make maintenance of the
expectations files more difficult in the long run.

Bug: 1095679, 1130440
Change-Id: I0ba4a2b8800e521202baa0e6c9ce498798b65061
Tbr: enga@chromium.org
Tbr: ynovikov@chromium.org
Tbr: bsheedy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436752Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811469}

This reverts commit 40a4a6b6.

Reason for revert: crbug.com/1132734

Original change's description:
> [Instant Start] Supports stack tab switcher.
>
> In this CL, we remove the check of stack tab switcher in
> TabUiFeatureUtilities#supportInstantStart(). Thus instant start can be
> enabled in MVP++. These changes can be verified by:
> - StartSurfaceTest#testShow_SingleAsHomepage_V2__Instant*.
>
> The following changes are made to support stack tab switcher in instant
> start:
> 1) Defer the creation of TabList in StackLayoutBase. It allows the
>    StackLayoutBase/StartSurfaceStackLayout to be created pre-native.
> 2) Add pending observer list in TabModelFilterProvider. Any observer
>    which is added before the TabModelFilterProvider is initialized, will
>    be cached and notified when the initialization is completed.
> 3) StartSurfaceLayout and StackLayoutBase will create its SceneLayer if
>    hasn't yet before calling updateSceneLayer().
>
> Bug: 1116449, 1076449
> Change-Id: I42a730045d4b9799d4bb08dc7d7dc947956f42ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356167
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810924}

TBR=hanxi@chromium.org,twellington@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1116449
Bug: 1076449
Change-Id: Ib4ab05dfe04288d28bbfbd01ef2a0f01493795c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437010Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811468}

Video playback fails with the Metal-based command decoder, because
it binds IOSurfaces as TEXTURE_2D, not TEXTURE_RECTANGLE. Plumb
through a flag to specify if TEXTURE_RECTANGLE support is present.

Bug: 1108909
Change-Id: Ib7bccefea54985f052267f51f6b91ce955e30f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436311Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811467}

Modifies name for consistency with other relevant configs.

Change-Id: I48677a0283fcd92e2147ab0492f2982d75c59ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432134Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811466}

Change:
* onWebContentsForRequestAvailable() was called two times when
bottomSheetController.requestShowContent() failed in
PaymentHandlerCoordinator. One is in PaymentHandlerCoordinator; one is
in ServiceTabLauncher. Now, onWebContentsForRequestAvailable()
guaranteed to be called only once - in ServiceTabLauncher only.

Bug: 1132972

Change-Id: Iba288b1287e034a35ff83994f5f675b5df463527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435739Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811465}

Bug: 1106523
Change-Id: I36cbf3d0de3c5e4a229874f2d505016772fb6d44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432384Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811464}

- Add close button functionality
- Update ESim flow ui to use iron pages

screenshot: https://screenshot.googleplex.com/A7ZxANAamWYTxs3.png

Bug: 1093185
Change-Id: I755d40eefa068398a6a3c1cab6428f8f5aed7ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424830
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811463}

Previous changes have left cut points where the change in QR key structure
was split off. This change contains the remainder of those changes. It
doesn't quite make CableDiscoveryData V1-only, but it's a lot closer.

BUG=1002262

Change-Id: Id57aec7f09d574720ed57a49e1482eb6890e3947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430324
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811462}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/printing
This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Change-Id: I2e8c8fbca3a293b1ac93a7a82f9a821e05bc9554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435194
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811461}

There's a note in media_switches.cc indicating that this feature is okay
to be removed.

Bug: 1126640
Change-Id: Ie4c87b13fb573327038753ea30a59708df3bc691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427213Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#811460}

Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit#

Bug: 1007635
Change-Id: I1910c2ad1c47d00f069d6c70dbc7dc6e1ef2eedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434929
Auto-Submit: Andrew Shulaev <ddrone@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#811459}