- 22 Jul, 2020 40 commits
-
-
Maksim Ivanov authored
Fix the problem with the DCHECK in TestBackgroundPageFirstLoadObserver::OnBackgroundHostCreated() being hit in case when the extension's background page host gets destroyed and recreated. The DCHECK was fired because the class didn't expect to observe more than one host at the same time. The underlying issue was that the class didn't stop observing the deleted host, leading to the DCHECK hit and a potential use-after-free (in tests). Bug: 1090941 Test: stress-test the "CertificateProviderApiTest.LazyBackgroundPage" browser test after applying crrev.com/c/2312817 Change-Id: I91cf8f3bb0126a04b63e3a73d3f39259c621f330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312799Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791054}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9faf0cdcd0c6..ffb31229fce4 2020-07-22 m.maiya@samsung.com Capture/Replay: Enable capturing slingshot scenes 2020-07-22 jmadill@chromium.org Fix trace tests auto-generation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I618689ae0512ec0267c255bd97c515a99efc431e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791053}
-
Yi Xu authored
This is the last cl in the theory. I moved all perf_tests/canvas that contains frame changes to rendering benchmark. TBR=fserb@chromium.org Bug: 1077148 Change-Id: I52a9e98d9e70dfdb4fa4337dc9174dad38d42ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290703Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#791052}
-
Avi Drissman authored
- Update the base::mac::IsOS*() functions. Introduce a parallel set of IsOS#() functions to match the IsOS10_#() functions. Update all tests to match, and update callers where appropriate. - Turn on the CFAllocator OOM killer for Big Sur, as the internals of CFAllocator have not changed. BUG=45650, 1101439 TEST=base_unittests Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791051}
-
Josh Nohle authored
Add a contact manager implementation class, where the overridden methods are currently marked as NOTIMPLEMENTED(). We also include a fake implementation and factory for use in unit tests. The full implementation will happen in a follow-up CL. For now, these classes unblock consumers of the contact manager. Bug: b/154863722 Change-Id: I1fe9813fe0578f72aa50f13d402995ed4a46b6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308948Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791050}
-
Maksim Moskvitin authored
SecureBox provides a set of simple interfaces for performing encryptions and decryptions, by using a public key owned by the recipient and/or a secret shared by the sender and the recipient. Bug: 1101813 Change-Id: I9ced4c91a8d31b0b395096ad6045b5075df899f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279971 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deded62426ed..c3e7ab19bbf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kelvinjiang@google.com,wjmaclean@google.com Change-Id: Ib0c1b168a336f1ccb94b20b758a5fa0bf7e0cbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791048}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026b1e2be09a..f9803e14b0fb 2020-07-22 fmayer@google.com Merge "Fix non-Unix build for local_symbolizer" 2020-07-22 aninditaghosh@google.com Move vendor specific functionality to seperate file 2020-07-22 treehugger-gerrit@google.com Merge "Refactor heapprofd end to end test." 2020-07-22 treehugger-gerrit@google.com Merge "Add thermal events" 2020-07-22 lalitm@google.com Merge "ui: update cpu frequency track to also use proper counter quantization" 2020-07-22 lalitm@google.com Merge "ui: fix counter track quantization" 2020-07-22 lalitm@google.com Merge "tp: label pid 0 thread as "swapper" without cpu suffix" 2020-07-22 treehugger-gerrit@google.com Merge "ui: fix computation of resolution" 2020-07-22 fmayer@google.com Fix compile error for non-Linux trace processor. 2020-07-22 treehugger-gerrit@google.com Merge "Add a version file for Chromium protos autoroller" 2020-07-21 aninditaghosh@google.com Load trace_processor binary if the path to it is defined 2020-07-21 aninditaghosh@google.com Merge "metric() returns proto message instead of bytes" 2020-07-21 oksamyt@google.com Merge "Add host_app_package_name to ChromeProcessDescriptor" 2020-07-21 fmayer@google.com Allow to index symbol files by build ID. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:161235574 Tbr: perfetto-bugs@google.com Change-Id: I1493ccd14ad4e3663398f3f2776f363c83258787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314796Reviewed-by:
-
Maksim Ivanov authored
Provide test coverage for the scenario when the Ash PIN dialog, appearing during a challenge-response login (a.k.a. smart card based login), is canceled by the user. Bug: 1033936 Change-Id: Iba1bebb12b3883a496bec360539b33a109e83ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310493 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791046}
-
Ken Buchanan authored
This adds a startup metric on Mac, Windows and ChromeOS to report whether the current system has a platform authenticator available. Understanding prevalance of platform authenticators is useful for planning WebAuthn-related features, especially around payment flows. Bug: 1104229 Change-Id: I4f0d141c8eb0cf390a3aafe50c83f081715d4aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293070Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791045}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8bd3bcf43431..9061d5d154bc 2020-07-22 rharrison@chromium.org Remove deprecated use_relative_hooks reference If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia11dffe45e2b976aac2e10cd055ef2ffa804ba7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315116Reviewed-by:
-
Gabriel Charette authored
And remove the PreventMessagePumpHangs experiment. It was initially planned to be used for more than this experiment but has since reached its expiry date without this version showing side-effects on metrics (as intended). I'll add it back if/when doing further MessagePump experiments. R=chromium-metrics-reviews@google.com, fdoray@chromium.org Bug: 1074019 Change-Id: I5b19e80380202133afa3f494268a27e6ffd06c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312839 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791043}
-
Will Harris authored
Also, move win7-rel from master-only to chromium so it will continue to run on the branches. BUG=None Change-Id: I46ee1c2095cccd9ba23332d8a94dc354f3ed3354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315181Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791042}
-
Alan Cutter authored
This CL removes the system theme check for web apps in ShouldUseTheme(). This logic now lives in BrowserFrame::GetThemeProvider() as of: https://chromium-review.googlesource.com/c/chromium/src/+/2239912 Bug: 1087693 Change-Id: Icd006bccab2fe08112990f8c856ecf4c75fef0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309993 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791041}
-
Karandeep Bhatia authored
Instead of merely bypassing the CSP in the isolated world, enforce the isolated world CSP. Also, plumb the correct DOMWrapperWorld for ResourceLoaderOptions in PreloadHelper::PreloadIfNeeded. BUG=1099975 Change-Id: I00ca5376c21692a547d2665533e4237e8609a843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276649 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#791040}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4e1fb30c836..caa2f149fb8b 2020-07-22 nodir@chromium.org Roll dirmd to 6c4507c0 2020-07-22 guterman@google.com Add explicit "python" to script for Windows compatibility If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106176,chromium:923016 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Id61e673a2891dceee3b9aac19fd5eb60e7217504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314800Reviewed-by:
-
Brandon Wylie authored
Bug: 1041576 Change-Id: I0b326b558e4578765ac1c20ee43402d758335a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314020Reviewed-by:
-
Nico Weber authored
Bug: 989095 Change-Id: I238f929bcf655a2be953bbb4d65a560d1452937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310189 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL fixes two problems with WebView/SkiaRenderer/GL with vulkan hwui: * Missing allocator, chrome introduced one to use single instance with Skia. * Wrong fboid for query alpha capabilities. Bug: 984955 Change-Id: Ib8e9fb57bcf9b11557aac5a412abb91556819038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314419Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#791036}
-
Kelvin Jiang authored
This subtest is currently flaking and I am disabling it (for now). Bug: 1108534 Change-Id: I7bf50d77a841a87f13b5e1a579d59ed6217dd737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314787Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791035}
-
Henrique Nakashima authored
Modularize the interface and its dependencies: - AsyncTabParams - AsyncTabCreationParams Change-Id: I5b785cae99907b43dc4188f1aa09c240ae3b47ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305116 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#791034}
-
Katie D authored
Disables LookalikeUrlNavigationThrottleBrowserTest.Idn_SiteEngagement_Match which flakes on all platforms. TBR=jdeblasio@chromium.org Bug: 1106402 Change-Id: I4c31fbbaa67f9e6cac7b4faa1a17f1ddc3d774cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311073Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791033}
-
Panos Astithas authored
This was part of a Cronet-related experiment a long time ago and nobody is actively monitoring these metrics as far as the Chrome Networking team can tell. Bug: 1088987 Change-Id: I74428e52c85c03008ffd6a58a1eada902bca4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311698Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Panos Astithas <pastithas@google.com> Cr-Commit-Position: refs/heads/master@{#791032}
-
Ilya Sherman authored
R=asvitkine Fixed: 1107465 Change-Id: I1465acf2973c177b4224a8a301fa4faf0801b8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311657Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791031}
-
Karandeep Bhatia authored
Delete code related to the github file system since it's not been used for years. Also delete some other obsolete code. BUG=820606, 1105728 Change-Id: Ia4b4e851ddd3b5ca640ca892bf27e3e934c96369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311897 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791030}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic125b7ff0853a12f174052f1a8d12f4710792367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314718Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I28de537fde53d0a6f1b9dfc7cfb8c89fea716b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314117Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#791028}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I93e7adba3a3df519d42b3ef351820984394b05de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313460Reviewed-by:
-
Nico Weber authored
Bug: 1098899 Change-Id: I9423e63db7f55fe4c18271a26ff60cee6b802bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314676 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Yuwei Huang authored
This CL makes HeartbeatSender send request via Protobuf over HTTP. This is OK to be checked in now since unlike FTL, our backend is ready to accept Protobuf/HTTP requests. Bug: 1103416 Change-Id: Iefdbcb59602436e01dbf4475cab3f6db67004e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311121 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#791025}
-
zhaoyangli authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/119c1b0adbc0..a1c3b1271dcd $ git log 119c1b0ad..a1c3b1271 --date=short --no-merges --format='%ad %ae %s' 2020-07-16 tirodkar Remove UIWebView loading in GREYAutomationSetup. 2020-07-16 tirodkar Fix comment breakages in the OSS Xcode project. 2020-07-15 chanheepark Remove deeplink error as EarlGrey minimum target os is iOS 11. 2020-07-15 chanheepark Add new error code for deeplink action error. 2020-07-14 chanheepark Look for textField in case the URL field is the first responder. 2020-07-14 tirodkar Remove the UIHierarchy legend 2020-07-14 albertbow Make kGREYIntializationErrorDomain use new error format. 2020-07-13 tirodkar Guard duplicate TextField id's for iOS 14. 2020-07-13 tirodkar Ensure that replaceText calls the valueChanged control event. 2020-07-10 chanheepark Return frame for top level windows when converting to screen coordinate. 2020-07-09 tirodkar Add the keyboard dismissal error code for the new formatter. Created with: roll-dep src/ios/third_party/earl_grey2/src Change-Id: I64ec59c89d11c617d0f04fdc180e8df1a9db7966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304725Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791024}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ie88ba35be8ee0d8c78cf685a270a3cedee0c872e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314023 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#791023}
-
Peng Huang authored
Concurrent read access from both GL and Vulkan is not allowed. Get rid of the concurrent read problem by releasing the texture from GL temporarily, when a Vulkan read is requested. And resume GL read access, when the Vulkan read access is over. Current chrome GL and Vulkan concurrent read pattern is - Blink holds and caches read access for a backing shared image for a WebGL or 2D canvas. SkiaOutputSurfaceImplOnGpu only requests read access just before playing back DDL and releases the read access after playing back DDL and before SwapBuffers. The GPU will not schedule other tasks between playing back DDL and SwapBuffers. So it should be safe to temporarily pause GL read access. Bug: 1104231 Change-Id: I729eeebd5196bc5387ac148133b5926358bb4b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311330Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791022}
-
Josh Nohle authored
Add a certificate manager implementation class, where the overridden methods are currently marked as NOTIMPLEMENTED(). We also include a fake implementation and factory for use in unit tests. The full implementation will happen in a follow-up CL. For now, these classes unblock consumers of the certificate manager. Bug: b/154863644 Change-Id: Ib81bd4e09b7fed0d98e7e18792de78664ff9d20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311078Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf25ef52..9d73e198 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c8abe5a5a73a0d6c194e542937b88eb265c3772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314376Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791020}
-
Maxime Charland authored
Having a custom accessibilityIdentifier for the cell set through the TableViewItem enables easier egtests and better accessibility without having to set the ID in cellForRowAtIndexPath. A use case for this is RecentTabs, which will use the same TableViewIllustratedItem for all the empty states, with different ItemTypes. Without this modification to TVIllustratedItem, RecentTabs would have to manually set the a11yID of the cell for every itemType. Bug: 1098328 Change-Id: I341692643556a42984c843594a9be8d24b139762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313297 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791019}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a469e5b085a5..ed914d124174 2020-07-22 brgoddar@microsoft.com Grid: Update grid telemetry to fire on devtools launch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106888 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I462988ff27faa999a7cbee4a10133814ec9a9673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314717Reviewed-by:
-
W. James MacLean authored
Disables another test for all platforms. TBR=brucedawson@chromium.org Bug: 1084931 Change-Id: Id84a3030a4ffa49784c39eb5dfd01c8b92058d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313980Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#791017}
-
Travis Skare authored
Fixes crash when using a keyboard shortcut to close the active tab with the bubble open. Note with recent changes, the icon intentionally stays visible after bubble close, so this call is no longer needed anyway. Bug: 1107857 Change-Id: Ic254f28522e3b405591d068d2395aa4f4f281f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314696Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#791016}
-
Jimmy Gong authored
- Previously print jobs that are ongoing or printed within 24 hours displayed the printed time in a 12hr format. - Not all language locales are in the 12hr format, so the fix is to remove that parameter and use the numeric locale format. Before: https://screenshot.googleplex.com/B3Y9JiAp6ET After: https://screenshot.googleplex.com/srMiTVBJT6G Bug: 1106231 Change-Id: I4103e954b5b3b26b6eacc9b188366ee022e5e10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311616Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#791015}
-
