- 23 Jul, 2020 6 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d73e198..22d918bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I358b5adc3ffa7187a152e84e45871b87387c3213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315316Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791086}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf2eeb0ca5a4f90d01e205e1c2c5391371e4e325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791085}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9ced4f3da51..184f6013466b 2020-07-22 mtklein@google.com JIT load64_{lo,hi} 2020-07-22 bsalomon@google.com Fix Chrome pixel tests after separating Mip from MinMag filtering. 2020-07-22 tdenniston@google.com Show mirror drawn with SkStroke (toy stroker) 2020-07-22 tdenniston@google.com Add path recorder class (toy stroker) 2020-07-22 westont@google.com [infra] Move iPhone11 jobs to iOS-13.6. 2020-07-22 kjlubick@google.com [canvaskit] Publish 0.17.2 2020-07-22 mtklein@google.com JIT store64 2020-07-22 egdaniel@google.com Reland "Add GrContext api to update compressed backend textures." 2020-07-22 westont@google.com [infra] Add ios-dev-image-13.6 asset. 2020-07-22 westont@google.com [infra] Add ios-dev-image-13.5 asset 2020-07-22 bsalomon@google.com Separate MIP filtering from min/mag filtering. 2020-07-22 adlai@google.com Migrate SkImage::flush methods to GrDirectContext 2020-07-22 bsalomon@google.com A few more suggest override clang 12 warning tests 2020-07-22 nifong@google.com Bump version of mskp files for skpbench If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1099255 Tbr: robertphillips@google.com Change-Id: I8092a10203720a0db5009a738cf1f2881d5f6600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314131Reviewed-by:
-
Jason Lin authored
The return value is also changed from a boolean to a clearer enum. The renaming is to reduce confusion: * CanClose() is called only when we do want to close the window. This is the only call path: Widget::CloseWithReason() -> NonClientView::CanClose() -> ClientView::CanClose() * ClientView::CanClose() is only overridden by BrowserView and WebDialogView, and both of them are actually doing closing logic instead of acting like a harmless predicate. For example, WebDialogView::CanClose() dispatchs an unload event for the web contents, which leads to the web contents being closed. The follow up CL 2278793 refactors WebDialogView::CanClose() (now OnWindowCloseRequested()) so that WebDialogDelegate::OnDialogCloseRequested() is called and has a chance to stop the web contents being closed. This will allow us to remove the hacky closing logic in Crostini{Installer,Ungrader}Dialog. Bug: 970196 Change-Id: I98ade7a88975a4a43e7b453cb1356c0b398a0f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247838 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#791083}
-
Xianzhu Wang authored
Add FragmentData::VisualRectIn2DTranslationRoot() for LayoutShiftTracker. It's currently based on FragmentData::VisualRect() and OffsetTo2DTranslationRoot(). When we remove VisualRect(), we'll remove FragmentData::visual_rect_ and offset_to_2d_translation_root_, and store visual_rect_in_2d_translation_root_ only. We don't need any more change to LayoutShiftTracker when we remove Fragment::VisualRect(). Bug: 1107724 Change-Id: I8f6f7bfe8677180a2062fb7f67f73ff7ca6ce1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311676Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791082}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ed914d124174..cc02814e07b3 2020-07-22 isherman@chromium.org Add a utility for parsing the X-Client-Data header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103854 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaff3aa6b476fc037b4a00967042dccf0c337bcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314725Reviewed-by:
-
- 22 Jul, 2020 34 commits
-
-
Miguel Casas authored
Remove use of blacklist in VaapiWrapper as per guidelines in https://tools.ietf.org/id/draft-knodel-terminology-00.html#rfc.section.1.2 Change-Id: Iffee2570d8ed6c0340ea6624b774b5cb892e18f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314994 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#791080}
-
Qiaofei Ye authored
... and WGI, add WGI class skeleton. This CL is part of the feature to make Windows.Gaming.Input (WGI) turned on by default on Chromium. WGI will provide game controller support on Windows 10 desktop, WCOS, and Xbox. The WGI also provides support for gamepad-specific Plug & Play APIs, even on WCOS devices. This feature can work on both Windows Desktop (win32 apps) and Windows 10X. This change Added the skeleton of class WGIDataFetcherWin. In the future, we will have separate data fetchers for separate APIs (XInput & WGI). In the following CL, we will perform the renaming of gamepad_platform_data_fetcher to XInputDataFetcherWin. Since this feature is under a experiment controlled rollout, the change is put behind a feature flag "kEnableWindowsGamingInputDataFetcher", and is turned off by default. Bug: 1098876 Change-Id: I1780e98c912d3472bebe91934f1c375db24312cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293615 Commit-Queue: Qiaofei Ye <qiaye@microsoft.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#791079}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a45603bd6801..6a8a74986c35 2020-07-22 amaiorano@google.com Fix ReactorDebugInfo off by one line issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2eb81ffa449cbe42c2c0feb32e2571d7e69b4e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314722Reviewed-by:
-
Salvador Guerrero authored
The following tests have been disabled TabGridDialogTest#testSwipeToDismiss_Dialog TabGridDialogTest#testUndoClosureInDialog_TabStrip TabGridDialogTest#testRenderDialog_5Tabs_InitialScroll_NightModeDisabled TabGridDialogTest#testBackPressCloseDialog TabGridDialogTest#testTabGridDialogAnimation TabGridDialogTest#testDialogToolbarMenuShareGroup TabGridDialogTest#testRenderDialog_5Tabs_InitialScroll_NightModeEnabled TabGridDialogTest#testRenderDialog_3Tabs_Portrait_NightModeDisabled TabGridDialogTest#testClickScrimCloseDialog TabGridDialogTest#testRenderDialog_3Tabs_Landscape_NightModeEnabled TabGridDialogTest#testSelectionEditorUngroup TabGridDialogTest#testDisableTabGroupsContinuation TabGridDialogTest#testUndoClosureInDialog_GTS TabGridDialogTest#testRenderDialog_3Tabs_Landscape_NightModeDisabled TabGridDialogTest#testRenderDialog_3Tabs_Portrait_NightModeEnabled TabGridDialogTest#testDialogInitialShowFromStrip TabGridDialogTest#testTabGroupNaming TBR=yusufo@chromium.org Bug: 1108547 Change-Id: I8edcbc15398dbd71573f9e1310b089038c42f979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314664Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#791077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/caa2f149fb8b..dc3f2b55c360 2020-07-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I43580553204c3c799a690734a86fcbae0b0ab32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314814Reviewed-by:
-
Wei Li authored
Link's title should be optional at the construction time. It may be set separately. Bug: 1108460 Change-Id: Id4ee8a5030d6c6dd0d4ea7e900512214e3faef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314037 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791075}
-
Ghazale Hosseinabadi authored
This CL adds PopupRepeatedOpening test, which verifies that sessionStorage does not persist between repeated opening and closing of a popup. Bug: 42599 Change-Id: I837dd93bb12225619707127304802cff3e2d407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297687Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791074}
-
Victor Vasiliev authored
This has been previously blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=1046390. Change-Id: I1c0d68dc56d109be6189df0cfb8fc04230949a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302721 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791073}
-
Meredith Lane authored
This reverts commit 780e443e. Reason for revert: Suspected Culprit for tree closure: https://ci.chromium.org/p/chromium/builders/ci/mac-arm64/2964? Original change's description: > Update core items for macOS Big Sur. > > - Update the base::mac::IsOS*() functions. Introduce a parallel set > of IsOS#() functions to match the IsOS10_#() functions. Update all > tests to match, and update callers where appropriate. > - Turn on the CFAllocator OOM killer for Big Sur, as the > internals of CFAllocator have not changed. > > BUG=45650, 1101439 > TEST=base_unittests > > Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791051} TBR=avi@chromium.org,mark@chromium.org,kelvinjiang@chromium.org Change-Id: I86460b6921c2b141d69d44351c6c2702e85dff67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 45650 Bug: 1101439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315357Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#791072}
-
Austin Eng authored
The WebGPU API provides facilities to create mapped GPUBuffers backed by shared memory. This makes it very easy for JavaScript to make large transfer buffer allocations which fail allocation and instantly lose the context. This CL adds an option to CommandBuffer::CreateTransferBuffer and MappedMemoryManager::Alloc to not lose the context on OOM but instead fail gracefully. Bug: dawn:450 Change-Id: I7311dd2ab685a150574056fbe9df5fa1724e4b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310831Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#791071}
-
zhaoyangli authored
Simulators created within test runner should be removed. However this was lost when migrating to xcodebuild_runner. Bug: 1108012 Change-Id: Ib59f1c4a580acad28fb3829238f6601a460af3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310673Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791070}
-
Scott Violet authored
This function is only used in chrome, and should be moved there. BUG=1076463 TEST=covered by tests Change-Id: I5916d68e5761635839e6ce1db680d45116ea0331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311520Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791069}
-
Devlin Cronin authored
Add support for a "match_data_urls" field in content scripts specified in an extension's manifest. This CL adds the parsing logic and related unittests, behind a base::Feature. Future CLs will add support for the actual injection of scripts into these data URLs, as well as expanding the support to include dynamic script injections. Bug: 55084 Change-Id: I288c66dfb901e9cb77d09562cf943a223adcb8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292697Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791068}
-
Ilya Sherman authored
This header contains serialized and base64-encoded protocol buffers. This utility simply base64-decodes the serialized data, and then parses the proto via compiled JSPB parsing. R=mathias@chromium.org, yangguo@chromium.org Bug: 1103854 Change-Id: I233683468fdb189f206c819f650c07eae34525d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301121 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#791067}
-
Nick Harper authored
Change-Id: I3f5bd166da9b104128ade1891e427e8953083c83 Bug: 855690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314556Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791066}
-
Ahmed Mehfooz authored
Ux specs are attached in the bug. Bug: 1106054 Change-Id: Ie8982f5b07a6330e16d76da19b3e36f48fc9731a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300633 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791065}
-
Ian Struiksma authored
Bring up win1909 to tests before rolling out to larger machine pool. Bug: 990885 Change-Id: Id3900e8f04a386bd2e6fe81dee4799bc747cdfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311124 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#791064}
-
Tommy Li authored
We've always returned the current page's URL as a verbatim default match for ZeroSuggest (with the exception of on the NTP). However, we don't need this anymore on Desktop. This CL preserves the most-visited mode's behavior, but removes the verbatim match from all remotely fetched (from the suggest server) ZeroSuggest results on Desktop. We leave Android and iOS alone. Android needs the verbatim match for the Search Ready Omnibox edit widget. iOS we're leaving alone because there's no strong reason to change it. Bug: 1095843, 1106096 Change-Id: Iac6c1ee401a93cda05df7cc96d5e176e3d36f3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308944 Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#791063} -
Ahmed Mehfooz authored
UX required a few tweaks to the battery icon and badges. Bug: 1106382 Change-Id: Ic29f812d0254b01223e6709750ac74792b6ce8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304724Reviewed-by:
-
Eric Lawrence authored
Most CSP directives are ignored for PDF responses, but the frame-ancestors directive should remain supported. Test that CSP can be used to prevent embedding of a PDF file. Also test that a CSP can allow embedding even if an X-Frame-Options: DENY directive is present. Bug: 1107535 Change-Id: I3fbe5fca5e591bb670e0ad79babde191c83be0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313999 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791061}
-
Dana Fried authored
This is a local fix to the larger problem of scaled bitmaps rendered in ImageViews at non-integral DIP scaling factors (125%, 133%, 175%, etc.) It solves the specific bug, but does not solve the larger problem of the ways we scale bitmaps and Views canvases being sometimes different. More info is available on the issue cited. I am looking for feedback - if this is an acceptable fix for right now or if we should drive towards a more comprehensive approach. Probably both. Bug: 1094566 Change-Id: I024e216542cee057cd4198a5a65344ffa0cd999d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306751Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#791060}
-
Edward Lesmes authored
Bug: 1108541 Change-Id: Id56dce83803e6389c8112be9bf7b1b057c78e58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314132Reviewed-by:
-
Edward Lesmes authored
gn check was failing because a header listed in sources (src/src/loader/xr_generated_loader.h) didn't have the right name (it should be .hpp, not .h). Bug: 1108481 Change-Id: I7f0df8a8efcd1d8e0b82591fb63f9062713dc20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314163Reviewed-by:
-
Pavel Feldman authored
Before this change, postData was annotated as text, but was used as binary string in the code. This change annotates it as binary, which means that it'll be base64-encoded in the JSON wire. This is a breaking change to the experimental Fetch.continueRequest method, but since implementation was never correct, we believe that fixing, documenting and testing it is the right way to go. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1107728 Change-Id: Ic8022035875ff3d66e75d1d0266cbf9488f10673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315239Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Auto-Submit: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791057}
-
Jeffrey Cohen authored
screenshot: https://hsv.googleplex.com/5667084082085888 Bug: 1106145 Change-Id: I51655f571ba9e4c61da5807a7c208b9c163de788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307648 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#791056}
-
Maksim Ivanov authored
Make the TestCertificateProviderExtension's test extension have a fixed extension ID (by putting its public key into the manifest.json file), and update the class to expose this ID as a constant. This is a preparation step for getting rid of the TestCertificateProviderExtensionLoginScreenMixin (in favor of ExtensionForceInstallMixin). Bug: 1090941 Change-Id: Ic27ed9f0161631b6415a07d3a8e73b8329ec34eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312817 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791055}
-
Maksim Ivanov authored
Fix the problem with the DCHECK in TestBackgroundPageFirstLoadObserver::OnBackgroundHostCreated() being hit in case when the extension's background page host gets destroyed and recreated. The DCHECK was fired because the class didn't expect to observe more than one host at the same time. The underlying issue was that the class didn't stop observing the deleted host, leading to the DCHECK hit and a potential use-after-free (in tests). Bug: 1090941 Test: stress-test the "CertificateProviderApiTest.LazyBackgroundPage" browser test after applying crrev.com/c/2312817 Change-Id: I91cf8f3bb0126a04b63e3a73d3f39259c621f330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312799Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791054}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9faf0cdcd0c6..ffb31229fce4 2020-07-22 m.maiya@samsung.com Capture/Replay: Enable capturing slingshot scenes 2020-07-22 jmadill@chromium.org Fix trace tests auto-generation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I618689ae0512ec0267c255bd97c515a99efc431e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314720Reviewed-by:
-
Yi Xu authored
This is the last cl in the theory. I moved all perf_tests/canvas that contains frame changes to rendering benchmark. TBR=fserb@chromium.org Bug: 1077148 Change-Id: I52a9e98d9e70dfdb4fa4337dc9174dad38d42ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290703Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#791052}
-
Avi Drissman authored
- Update the base::mac::IsOS*() functions. Introduce a parallel set of IsOS#() functions to match the IsOS10_#() functions. Update all tests to match, and update callers where appropriate. - Turn on the CFAllocator OOM killer for Big Sur, as the internals of CFAllocator have not changed. BUG=45650, 1101439 TEST=base_unittests Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791051}
-
Josh Nohle authored
Add a contact manager implementation class, where the overridden methods are currently marked as NOTIMPLEMENTED(). We also include a fake implementation and factory for use in unit tests. The full implementation will happen in a follow-up CL. For now, these classes unblock consumers of the contact manager. Bug: b/154863722 Change-Id: I1fe9813fe0578f72aa50f13d402995ed4a46b6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308948Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791050}
-
Maksim Moskvitin authored
SecureBox provides a set of simple interfaces for performing encryptions and decryptions, by using a public key owned by the recipient and/or a secret shared by the sender and the recipient. Bug: 1101813 Change-Id: I9ced4c91a8d31b0b395096ad6045b5075df899f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279971 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deded62426ed..c3e7ab19bbf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kelvinjiang@google.com,wjmaclean@google.com Change-Id: Ib0c1b168a336f1ccb94b20b758a5fa0bf7e0cbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791048}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026b1e2be09a..f9803e14b0fb 2020-07-22 fmayer@google.com Merge "Fix non-Unix build for local_symbolizer" 2020-07-22 aninditaghosh@google.com Move vendor specific functionality to seperate file 2020-07-22 treehugger-gerrit@google.com Merge "Refactor heapprofd end to end test." 2020-07-22 treehugger-gerrit@google.com Merge "Add thermal events" 2020-07-22 lalitm@google.com Merge "ui: update cpu frequency track to also use proper counter quantization" 2020-07-22 lalitm@google.com Merge "ui: fix counter track quantization" 2020-07-22 lalitm@google.com Merge "tp: label pid 0 thread as "swapper" without cpu suffix" 2020-07-22 treehugger-gerrit@google.com Merge "ui: fix computation of resolution" 2020-07-22 fmayer@google.com Fix compile error for non-Linux trace processor. 2020-07-22 treehugger-gerrit@google.com Merge "Add a version file for Chromium protos autoroller" 2020-07-21 aninditaghosh@google.com Load trace_processor binary if the path to it is defined 2020-07-21 aninditaghosh@google.com Merge "metric() returns proto message instead of bytes" 2020-07-21 oksamyt@google.com Merge "Add host_app_package_name to ChromeProcessDescriptor" 2020-07-21 fmayer@google.com Allow to index symbol files by build ID. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:161235574 Tbr: perfetto-bugs@google.com Change-Id: I1493ccd14ad4e3663398f3f2776f363c83258787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314796Reviewed-by:
-
