- 17 Apr, 2020 40 commits
-
-
Christian Dullweber authored
Add render test to ensure PageInfo is displayed correctly in various states. Bug: 1040091 Change-Id: Ic6334f662ec966e573bfbda5043f38815b83fe59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061754Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760073}
-
Clark DuVall authored
Factored out chrome-specific logic into a delegate, and the protocol handler logic was completely moved to the delegate. The interesting changes are in tab_specific_content_settings*, most of the other changes are adding the content_settings:: namespace. Bug: 1070825 Change-Id: I912e385b10dbb98aa7ab9da1ee138264dab3ec96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151841 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760072}
-
Antonio Gomes authored
Drive-by: some \t are renamed at 4-spaces. BUG=767015, 1063749 R=rego@igalia.com Change-Id: I369fc1fb602c4b87f33d8fe14b517743e82aec02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154460 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#760071}
-
Tina Wang authored
- Add policy handler - Edit policy_test_cases.json to enable unit test Bug: 1066474 Change-Id: Ide9dfceb4c30456113536165066911200c96e627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130632 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#760070}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/307b31ea2a17..6da120098f37 git log 307b31ea2a17..6da120098f37 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 treehugger-gerrit@google.com Merge "Extract basic counters from thread time in state" Created with: gclient setdep -r src/third_party/perfetto@6da120098f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I39321e3f92d27df216fc657e32626c326557808a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760069}
-
Robbie Gibson authored
Text Zoom does not work on iPad because the Javascript property used to change the content size doesn't work on iPad in iOS 13. Bug: 1061119 Change-Id: Icc46da8c2a6990388b72312eaa4d4fd5807bd29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152812 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760068}
-
Guillaume Jenkins authored
- Adds the basic handler for the SavingBrowserHistoryDisabled policy on iOS. - Adds simple unit test for the policy via the boolean test helper. - Adds an EG test for the policy that also tests at the feature level to ensure the end behavior is as expected. - As part of this, small refactors were done to ChromeEarlGrey helpers and to the history EG tests. Bug: 1066488 Change-Id: Ibd466e2689b1aaaffab1b576d2fc92811dc6b9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140712 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760067}
-
Samuel Huang authored
This CL adds tests for the remaining methods in FileUtils: * extractAsset(). * queryBitmapFromContentProvider(). Bug: 1066730 Change-Id: I194c62a83ea9a9d656e04947b304401cb2062281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154383 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#760066}
-
Gauthier Ambard authored
A todo that was left from previous CL. Bug: 1025225 Change-Id: I0f0bfbfbeeef992db102a6b2326eac353a0bf4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144075 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#760065}
-
Colin Blundell authored
This CL dedupes the identical matchResolveInfoExceptWildCardHost() methods of //chrome and //weblayer's ExternalNavigationDelegate impls into ExternalNavigationHandler. This deduping is a preq for removing a bunch of methods from the ExternalNavigationDelegate interface. Bug: 1071390 Change-Id: I0a7d126f08a50397b1e042a3a347cccbf6a7984a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154190Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25ce8725224..ea66320c09bd git log d25ce8725224..ea66320c09bd --date=short --first-parent --format='%ad %ae %s' 2020-04-17 bclayton@google.com SpirvShader: Fix ASSERT firing in debugger Created with: gclient setdep -r src/third_party/swiftshader@ea66320c09bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I690284df3bd006ce0ddabe78fbf94bbba78eacd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154559Reviewed-by:
-
Sasha McIntosh authored
Manually tested by deploying to a CrOS device, rotating and casting the screen. Verified via log statements that occlusion culling is performed. Test: DisplayTest.DrawOcclusionWithMultipleRenderPass Bug: 1022544 Change-Id: I389a658699e4e68c5269151ab7be3d6f0e341341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139433Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#760062}
-
Dave Tapuska authored
This allows us to replace this with a mojo definition in a later CL. TBR=avi@chromium.org Change-Id: I62b500dc091e197bb887feb2ae3dc35d7469784f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153069 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#760061}
-
Victor Hugo Vianna Silva authored
TBR=sky@chromium.org TBR=rouslan@chromium.org Bug: 1057577 Change-Id: Iccb6ae9ad543a63b0764fdb0703e3137bc808f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153070 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760060}
-
Pavol Marko authored
This does a few things: * Bump policies that were documented to be supported starting with M-82 to M-83 or M-84 (depending on the policy author's feedback). * Update docs of policies that were saying they would be removed in M-82 but are still there. * Some version examples mentioned M-82, changed that to M-83 too. Policies that were marked as supported until M-81 were not modified, because that's technically still correct. BYPASS_POLICY_COMPATIBILITY_CHECK=M-82 is skipped so the changes are safe Bug: 1071651, 1016253 Change-Id: I8901c0dd0c2a5cd164d67c3da8d1847cd5ab648a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153028Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a846fe623f6..633ae40e7435 Created with: gclient setdep -r src-internal@633ae40e7435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049042 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I85eac9d0733379c2b7c1ff3a6cf0578eeae71d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154556Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760058}
-
Gauthier Ambard authored
This CL restrict the user agent restoration to iOS 13 and further as iOS 12 has an issue getting the right User Agent. Bug: 1070593 Change-Id: Ie4570efcb9931ccb8662511b16a1298570f0a297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154189Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760057}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1261b5caa386..da6cda839dac git log 1261b5caa386..da6cda839dac --date=short --first-parent --format='%ad %ae %s' 2020-04-17 elrello@microsoft.com Improve outbound-rtp statistics for simulcast Created with: gclient setdep -r src/third_party/webrtc@da6cda839dac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6d2ce79aa75cf4d319d71dfb92d6e2aee7aca52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154558Reviewed-by:
-
Nohemi Fernandez authored
The new sign-in architecture modifies the case of several button title labels in the sign-in UI. This causes EarlGrey test failures when we try to use the new architecture exclusively. Move all tests that currently use raw test to use accessibility IDs. Bug: 971989 Change-Id: Ic8b38bef5de13786330c606328d21b5720e0931d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146903 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760055}
-
Avi Drissman authored
There were two different watchers for WebContents destruction in two different test helper files, in addition to lots of tests rolling their own. Consolidate all of them. Bug: none Change-Id: I9b5723758aa997467689cce8767a3def9e8c13e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153747 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#760054}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0173ae54a67a..02153f0ed2c9 git log 0173ae54a67a..02153f0ed2c9 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@02153f0ed2c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5469526d9469011b1945397bc503f46a7db94fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154555Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/748197e6959a..1bf127479c6d git log 748197e6959a..1bf127479c6d --date=short --first-parent --format='%ad %ae %s' 2020-04-17 kjlubick@google.com Reland "Revert "GrDisplacementEffect uses GrTextureEffect."" Created with: gclient setdep -r src/third_party/skia@1bf127479c6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ie0e316f2b3ad1cd7ec503de25ace735ff8a24b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154554Reviewed-by:
-
Olivier Robin authored
Attribute is needed for some debug functions in Xcode (e.g. simulated MetricKit payload). Change-Id: I6ee8456a7dd4bc1ecc9e3ebc4e31526b2c5ad506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144039Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760051}
-
Eric Robinson authored
This histogram provides useful information when verification of the IndexedRuleset fails. Spikes in this can indicate a problem with the ruleset, and while the actual cause of the failure is less important now that the checksum method has been working for some time, overall information about failures is still needed. Bug: 1036874 Change-Id: Ia87dfcf8fff628b5f698d37334cb1c72361d438a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153315Reviewed-by:
-
Michael Lippautz authored
The methods in the macro are put on every GarbageCollectedMixin which is expensive in terms of binary size. The HoH getter can be replaced with GetTraceDescriptor(). Change-Id: I0daaf3fc51a95f71baf7f6c7bed387e94963601f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139758 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#760049}
-
Antonio Gomes authored
Note: This test fails in Firefox (and EdgeHTML) but this is expected as both haven't implemented the change on the spec yet. This is the Firefox bug about [1]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1481876 BUG=767015, 1063749 R=rego@igalia.com Change-Id: I42392e66f6fabb3550907ad3309907f48e5fe18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153268 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Swapnil authored
installed extensions Some failures occur due to NOT_PERORMING_NEW_INSTALL error. The reason for this is a deprecated extension which should not be used, thus it is a misconfiguration from admin. Some failures occur due to REPLACED_BY_ARC_APP error. If a device doesn't support ARC++, the app will be installed, otherwise the ARC++ app will be used and this one will fail as expected. This error is considered a misconfiguration only if ARC++ is enabled for the profile. Bug: 1067605, 1067606 Change-Id: I8001c70c5b13a3aa1c06c4c3ab4549dfe1e04eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144027 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#760047}
-
Gabriel Charette authored
DLL loading on background thread causing priority inversions that jank the main thread, see https://crbug.com/973868#c31 for a snapshot of a jank caused by this one. Bug: 973868 Change-Id: Id4879953754fb6bef09ef95fe998befce508e047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152904Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#760046}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a12377e7..3b8fda4b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I77766c4aebeec3de4e7446369f663d1bd8be8df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154456Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760045}
-
Anqing Zhao authored
Make sure the following functions are covered. - ArcKioskAppManager::GetAppByAccountId - ArcKioskAppManager::UpdateNameAndIcon Change-Id: I5232d68c690682a94045b25a3a6e83e0595cc249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144083 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#760044}
-
Mohamed Amir Yosef authored
This is a follow up to crrev.com/c/2141099 The test is still flaky because of its dependency on a singleton class. crrev.com/c/2141099 cleared the state after running each test to make sure not other tests are affected. This CL clears the states before running each test to make sure it's not affected by other tests outside chrome/browser/ssl/tls_deprecation_config_unittest.cc TBR= cthomp Bug: 2141099 Change-Id: I1bf04ee46023b43796767ca7cf92c1bda0b69cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153437 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#760043}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0aa745498c75..307b31ea2a17 git log 0aa745498c75..307b31ea2a17 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 treehugger-gerrit@google.com Merge "Merged proto: Add TracingServiceState to merged protos" 2020-04-17 fmayer@google.com Improve symbolization docs. 2020-04-17 treehugger-gerrit@google.com Merge "IPC: Add Sync() method to synchronize Producer and Service" Created with: gclient setdep -r src/third_party/perfetto@307b31ea2a17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:154237981 Change-Id: Iffb65e9784181e4d42311b9bac94631b67732277 Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152792Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#760042}
-
Henrique Ferreiro authored
Migrate this test out of web_tests/fast/css-grid-layout/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: Icdb180274b6d82ae02dc25461efa1b5819670195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151512 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Andrey Zaytsev authored
For more details: go/safety-check-mobile-design. Existing unit tests cover all of the affected code. Bug: 1070620, 1015841 Change-Id: Ie59e53d5f1f5466f5cf5cbd9c5422e2d88dc77f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146904 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760040}
-
Victor Hugo Vianna Silva authored
Unit testing the new AccountStorageAuthHelper requires mocking 2 of the methods of SigninViewController. This CL makes such methods virtual and adds the basic unit test setup. Future CLs will: 1) Refactor AccountStorageAuthHelper so that it can be injected a signin_view_controller_getter callback. The controller itself cannot be directly injected since its attached to a browser, while the helper is per tab. 2) Add the actual tests. Bug: 1070944 Change-Id: I48fe5031e24ee6488be293d7f96f44c4716ae6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153047 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#760039}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //google_apis. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=kinaba@chromium.org Bug: 714018 Change-Id: Id6fb28ec93f35e37036c2277d0ec56f92cc7503f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132191Reviewed-by:Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#760038}
-
Sebastien Lalancette authored
Allows usage of this ViewController when we don't have a named image. Bug: 1064990 Change-Id: I53191d86f83fb552042f3f30c2de4bd954b30d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152896Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#760037}
-
George Burgess IV authored
r758850 was a refactor of some code. Looks like it removed these functions from the `logging` namespace, but left the macros unchanged, causing clang-tidy errors. Bug: 1070788, 1070795 Change-Id: I15b209574674426e2a5fbbc37dc5fb4dc8f3559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154380 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#760036}
-
Majid Valipour authored
The test was moved but not its chrome specific automation script. Moved the script to correct folder and updated expectation file. Minor: Also rename the test to match the convention. FIXED: 912613 Change-Id: I44ddc7d5693df18f00400f79e63a95aeb626f03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150397Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#760035}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29cf2b0cbb75..1261b5caa386 git log 29cf2b0cbb75..1261b5caa386 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 hbos@webrtc.org [Adaptation] Move EffectiveDegradationPreference to RA-Processor. 2020-04-17 mbonadei@webrtc.org Remove WebRTC-LibvpxVp{8,9}TrustedRateController. 2020-04-17 hbos@webrtc.org [Adaptation] Delete Processor Proof-of-Concept. Created with: gclient setdep -r src/third_party/webrtc@1261b5caa386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8a47c59b7a424f7d9d123b9a415cc790c98fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154553Reviewed-by:
-
