- 28 Nov, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9cce7d1..241ab903 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie9a867ada4b13243a569a4b93a7db4eced30a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941373Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719956}
-
Mohamed Amir Yosef authored
This class encapsulates the logic for updating/saving for Butter for Passwords efforts. Change-Id: I03ac490ad272576f4613df172a333b2c97a01919 Bug: 1012203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876409Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#719955}
-
Raphael Kubo da Costa authored
Small simplification that should not have any user-visible effects. Change-Id: I93764d578de2e6e84c013f5e8a44392d0938835b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941887 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719954}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/editing as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: I84e4f60aac33de14ae43671a6dd77fa161a8b29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940004Reviewed-by:
-
Gyuyoung Kim authored
This CL converts SpellCheckPanelHostPtr|Request to the new Mojo types. Major changes are as below, - Convert mojom::SpellCheckPanelHostPtr to mojo::Remote<mojom::SpellCheckPanelHost> - Convert mojo::SpellCheckPanelHostRequest to mojo::PendingReceiver<mojom::SpellCheckPanelHost> - Convert mojo::BindingSet to mojo::ReceiverSet Bug: 955171 Change-Id: I2e8934227b97a685cb02c9c1a7a00b2ed0b3c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935967Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#719952}
-
Raphael Kubo da Costa authored
The former was introduced in C++14 and is slightly more concise than the latter. This has no user-visible changes. Change-Id: Iaabfb3cd52f7d577ab2d26ec6b162dc25292536b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940184 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f875b2946bb..6cbbaee824c4 git log 2f875b2946bb..6cbbaee824c4 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 treehugger-gerrit@google.com Merge "Create views and table only if they do not exist" Created with: gclient setdep -r src/third_party/perfetto@6cbbaee824c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idd3bb1f37bfbe3e83fb4bc6f8740f3c5134dc19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719950}
-
David Roger authored
This CL reverses part of the change introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1826678 The reason is that we don't want the pill to stay open while the password bubble is displayed, as the user may mistakenly believe that their password is uploaded to their google account. TBR=pbos Fixed: 1027112 Change-Id: I77bbcb8793369579e96597bb6e72be89e852227b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940238 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#719949}
-
Antonio Gomes authored
... by webrtc::StatsReport::Value::Type directly. Enums are 1:1 mapped. BUG=787254 Switch RTCLegacyStats away from WebString The CL also changes RTCLegacyStatsMemberIterator similarly. BUG=787254 R=guidou@chormium.org Change-Id: Iba87df118c032f71ae363f0c44e25de010308dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940430 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719948}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/068f95675eec..b2e8e6e030c9 Created with: gclient setdep -r src-internal@b2e8e6e030c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Iba818bf377222f5766ab234966de34d4b4b7d5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7bb0115cecb6..7fd3ad466b4d git log 7bb0115cecb6..7fd3ad466b4d --date=short --first-parent --format='%ad %ae %s' 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src f31f26f73930..b334829a91d6 (4 commits) 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 6f6e3371c92a..979b531e9fff (1 commits) 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 663dcefa22ea..d6e903bdc9ef (4 commits) Created with: gclient setdep -r src/third_party/angle@7fd3ad466b4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: cwallez@google.com Change-Id: I133a8773a6fd35691dbf393699695440ca7eec6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941575Reviewed-by:
-
Peter Kasting authored
* Use tints to compute frame colors in more cases * Pull dark mode computation out to a temp to make it easy to reuse later * Separate "shouldn't theme" and "should theme but can't" frame cases Bug: none Change-Id: I093e0e88c99fc061a04be69e15203ee3f16d2fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941169 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#719945}
-
Per Åhgren authored
This CL -Updates the multi-channel processing activation flags to match the the intended use in WebRTC. -Makes sure that the APM in the audio processor complies to properly run capture-side multi-channel processing. Note: This CL can only land once the WebRTC CL https://webrtc-review.googlesource.com/c/src/+/160707 has been landed and imported into Chromium. Bug: webrtc:10859 Change-Id: Ied2b185d36e43187d90b5d608243702ec929ec1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937030 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#719944}
-
Oleg Davydov authored
After https://crrev.com/c/1937958 was landed, on some build configurations ImageProcessor became large enough for chromium style checked to forbid inline destructor. This commit moves destructor to image_processor.cc file, after that this is no more issue for style checker. Change-Id: I36efb3601fc9305ef61af1705618e6156528489a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941313 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719943}
-
George Zhang authored
The main purpose of the java heap profiler is to obtain a heap dump in the form of an hprof file and then parse the hprof file. Currently, there exists a parser that does one pass and keeps track of all the different instances and fields associated with them such as object_id, name, etc. With this CL, we pass over all the instances we just stored. The purpose if that is that we are able to connect references between two different instances. Bug: 1012072 Change-Id: I03180731ab5ce347383f64d1103d5dd750326a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907281 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#719942}
-
Fredrik Söderquist authored
Tbr: schenney@chromium.org Bug: 583097, 633012, 674797, 1029104 Change-Id: I4bc7c650f3d7737d5e974c1049d0fc6b52055223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939804Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#719941}
-
sczs authored
- Creates Mobile.Messages.Confirm.Accept.Time histogram. - Records the new created Histogram for Restore Infobars and Block popups. Bug: 1028951 Change-Id: Ifc33e345b9a78989a1584776e8e141ad14a7be16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939976 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719940}
-
Roman Sorokin authored
We need to save the flag in the local state because TokenHandleUtil::CheckToken might fail on the login screen due to lack of network connectivity. Bug: 998410, b/143986150 Change-Id: Iff38194d8fc714fcf486424c721f919992ae79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938949Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719939}
-
Oriol Brufau authored
- Remove GridTrackSizingAlgorithmStrategy::GetCachedGridTrackSize in favor of GridTrack::CachedTrackSize. - Remove comment that no longer applies. - Remove the flex_factor parameter of NormalizedFlexFraction, since it can be obtained from the track. - Let GridTrackSizingAlgorithm::RawGridTrackSize return by reference for the same reasons as in r715665. The changes have no effect in practice. Change-Id: Ife54b87c85508a4e1be3a19775408fe06f74200b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940107Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#719938}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef9ae256. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I8df6fff69df7187a2d8162221d79391ad67b4bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941371Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719937}
-
Yifan Luo authored
Adjust the wpt tests for application cache according to https://chromium-review.googlesource.com/c/chromium/src/+/1926478/20/third_party/blink/web_tests/external/wpt/fetch/metadata/appcache.tentative.https.sub.html#24. Bug: 1024198 Change-Id: I8bf6d94fbd12e5dd5ef65aea8a317a4694057c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938908Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#719936}
-
Morten Stenshorne authored
Fieldset elements require legacy layout, which also disables NG block fragmentation. The test uses fieldset elements, while the ref doesn't. There's a subtle rendering difference between the engines here. Not sure if it's a bug or not, but we'll get to that once LayoutNGFieldset has shipped. TBR=futhark@chromium.org Bug: 1028595 Change-Id: Ia63a2382719f02f8c24b485933a9fa1b56ee671e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941310Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#719935}
-
Miyoung Shin authored
This CL cleans up the binder registry in DedicatedWorkerHost class since WebUsbService mojom interface has been bound via BrowserInterfaceBroker by https://crrev.com/c/1768839, and nothing registers a mojo interface to the binder registry. Bug: 936482 Change-Id: I3c533da40e4c5d7bf03a36ff16185c2cb7a6062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941652 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719934}
-
Noel Gordon authored
Change the QuickView metadata box custom element clear() method to use Polymer this.setProperties() which can set multiple element properties with one function call. Create a local reset Object, containing the properties to change, then call this.setProperties(reset) to apply those changes. Per lucmult@ CL:1937949, it is 25-33% faster, compared to setting each property value, one after the other as in the code before this CL. Bug: 1029211 Change-Id: Ia00f334a5f2394546ce0395fd654c0017f5354a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941531Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719933}
-
Antonio Gomes authored
The CL also changes RTCLegacyStatsMemberIterator similarly. BUG=787254 R=guidou@chormium.org Change-Id: I2ce4dca3316560398e271d0dd2964a7533db3924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940128 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4c0786bd310..d2610646af11 git log c4c0786bd310..d2610646af11 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 yangguo@chromium.org Roll protocol changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@d2610646af11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d0cef1be94220862b188156b8fba5b1428370f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941619Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbbafc60ae10..068f95675eec Created with: gclient setdep -r src-internal@068f95675eec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Idfe3fc0dd345a5a24f1f047c85d092758083cfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941618Reviewed-by:
-
Antonio Gomes authored
Note that this file contains two pure virtual base classes reimplemented in renderer/modules/peerconnection. However, given that the types are still referenced in other renderer/platform APIs/headers, it is not possible to simply remove them at this step. TODO added. Note2 that both classes got renamed, with the "Web" prefix removed. BUG=787254, 919392 R=guidou@chormium.org, haraken@chromium.org Change-Id: Ic24b6ec15d04b9cf4618c384204440311ba96502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939742Reviewed-by:
-
Luciano Pacheco authored
Change command default handler for copy/paste/cut/delete to only set |canExecute| when focusing the element where the default handler was forced. This fixes the infinite recursion on <cr-input> and its clear button, because the handler is forced in the <cr-input> and but the focus event was triggered in its children <cr-button> (clear button). These commands should be noop in buttons, these are forced for inputs to be able to copy/paste/etc the text in the input. Our error counter doesn't capture this error, so our integration test can't detect it. Test: Manually checked. Bug: 1029213 Fixed: 1029213 Change-Id: I4a9f9d0e05dee8eb18a06359f770498011db0487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939999 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Hans Wennborg authored
This is a reland of 0ff2da3a Original change's description: > Disable -Wdeprecated-copy with tip-of-tree Clang > > while we figure out how to handle this new warning. > > TBR=rnk > > Bug: 1028110 > Change-Id: I88be5c763bd0f2fcb40ebecc20990f96853d70c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932804 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718651} TBR=rnk Bug: 1028110 Change-Id: Iaac6251551d0ae5089da8eb465c57111b48bba9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940181 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719927}
-
Mihai Sardarescu authored
This CL makes id a private field of the CoreAccountId structure to ensure as clients of this API are not supposed to use it directly. It also adds comments explaining clearly that the result returned by CoreAccountId::ToString() cannot be used as a persistent key until the migration of CoreAccountId from email to Gaia id is not completed on ChromeOS. Note that this CL allowed to identify risks for the migration that are all tracked as dependencies of bug http://crbug.com/id=1028182. TBR= blundell@chromium.org, khorimoto@chromium.org Bug: 1028182 Change-Id: I57c95a29e9cf24c26c935c229bf6a41e2fbc50b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932445Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f31f26f73930..b334829a91d6 git log f31f26f73930..b334829a91d6 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 alanbaker@google.com Validate nested constructs (#3068) 2019-11-27 afdx@google.com spirv-fuzz: Improve debugging facilities (#3074) 2019-11-27 stevenperron@google.com Handle unreachable block when computing register pressure (#3070) 2019-11-27 greg@lunarg.com Improve RegisterSizePasses (#3059) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b334829a91d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Icdd00288d9b8aae1525df0f2089e6ea7ad99913c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941281Reviewed-by:
-
Mikhail Khokhlov authored
We'll need the Perfetto trace processor tool for proto trace conversion and eventually for running TBMv3 metrics. So far it doesn't build on Android, so adding the dependency on desktop platforms only. Bug: 1028612 Change-Id: Id3c3231516ee200f30db60a8f14edda136a257a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939789Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#719924}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc3ec57ddf27..7bb0115cecb6 git log fc3ec57ddf27..7bb0115cecb6 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 8c954d5a413d..61050599ec0f (6 commits) Created with: gclient setdep -r src/third_party/angle@7bb0115cecb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: I17c7b5f5b10c4f3a09cb439c95009923368ea981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941617Reviewed-by:
-
Fabian Sommer authored
Add property to pin_keyboard to disable input. Bug: 1027988 Change-Id: Ib715335fc0e9d8c54f440c48361851549b8a0464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936496Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@google.com> Cr-Commit-Position: refs/heads/master@{#719922}
-
Theodore Olsauskas-Warren authored
This is being done in concert with the elevation of the privacy card from the advanced section to the basic section. Certain settings access points were previously duplicated in the people and privacy sections, but will now be in one or the other and the people section renamed to You and Google to better reflect the settings options there. Safe browsing settings are being moved from sync and google services subpage to privacy and security card. Allow chromium sign in is being moved from privacy card to sync and google services subpage. Every change except the rename of the people section is behind the privacySettingsRedesignEnabled finch flag. Bug: 1014143 Change-Id: Id257a770e9d62d21b7174adaf42f6ae6c72b32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936253 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719921}
-
Peter Marshall authored
Awaiting onceAttachedToTarget() directly after the evaluate() call which creates the new worker is not safe. The event could be fired after the `await evaluate()` is finished but before the AttachedToTarget handler is registered. Listening for the attached event before triggering the creation of the worker is the only safe way to do this. Change-Id: I2e9374d42da5a98b18f3c643b9259818620bb2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940245 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719920}
-
Morten Stenshorne authored
We had this almost right, but failed when there was a break with low appeal inside a child. Bug: 829028 Change-Id: I67c0d07db85b8de6d9ac3f685263fb1d3b490760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940273Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#719919}
-
Carlos Caballero authored
Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: I8bded85ad30d311a6bab530b48251224f1d71b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939411Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#719918}
-
Kenichi Ishibashi authored
Looks like this is a redundant callback because both OnStarted() and OnHttpInfoRead() are called at the same time. Merge OnHttpInfoRead() into OnStarted() to remove an API surface. Bug: N/A Change-Id: I0387d4117b59fa1bfb6b2cb9a440f0e67ae20def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940006 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719917}
-
