GitLab

UX feedback to add back the label.
However, the functionality seems obscure so adding metrics to gauge
usage.

View: http://screen/6VCZQPfziWwa4kk

Note: Restart now and Restart later in enum has never been used, it was
added due to earlier designs.

Bug: 1113439, 1133061
Change-Id: Ia33cb71b3bd22133faaecec60f80cb302b16f349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437581
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811940}

Roll ChromeOS Orderfiles from 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I081997ef57d966f33509dccb0a7340c358b37246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439703Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811939}

Undo-Close-All is only valid when the tab grid is empty.
This CL disables the undo action when a tab is added.

Bug: 1112759
Change-Id: I41e407068a227fc87b53be12db8f35329cff52a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438233
Commit-Queue: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811938}

Bug: 989569
Change-Id: Iccfbc60f2e3d2c7026c5e310ab94dd2076ea3713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438473
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811937}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We rewrite below tests
fast/scroll-behavior/main-frame-interrupted-scroll.html,
fast/scroll-behavior/overflow-interrupted-scroll.html and
fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
because we cannot guarantee that the scroll arrives before the animation
completes.

TBR=bokan@chromium.org

Bug: 1047176
Change-Id: I59bb34a98326892380d748a2a4691ea4664cad26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438652Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811936}

The empty implementation will be used when the read later feature is
disabled. So we won't hit the actual backend.

TBR=dtrainor@chromium.org

Bug: 1128074
Change-Id: I5c2bed4b2136d758a6c504eabf6a77547650f69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438484
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811935}

This reverts commit c14fae86.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 811926 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2MxNGZhZTg2Y2M0MzIyMDcyN2Q2NzNmYjJjMDRiNDJhZTI4YTI3NTQM

Sample Failed Build: https://ci.chromium.org/b/8867766288975154688

Sample Failed Step: compile

Original change's description:
> [fuchsia][a11y] Refactors convert node ID logic.
> 
> This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID.
> 
> It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID.
> 
> R=yangsharon
> 
> TEST: web_engine_unittests
> Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Sharon Yang <yangsharon@chromium.org>
> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com>
> Cr-Commit-Position: refs/heads/master@{#811926}


Change-Id: Ide2c5fe9720fffc79de88a7b462906a4edc93d2c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439702
Cr-Commit-Position: refs/heads/master@{#811934}

This is a reland of 6a3c229f

Original change's description:
> [CrOS PhoneHub] Add setter functions to various manager classes
>
> The added setters are going to be used by a future Cl that implements
> the PhoneStatusProcessor class.
>
> Bug: 1106937
> Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346
> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810084}

Bug: 1106937
Change-Id: I0278e9221eac360ac6f6000fa1400bf83d0d6437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439014Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811933}

Feedback provided in a different CL (2375597: dpwas: Add
window-controls-overlay as a new display mode |
https://chromium-review.googlesource.com/c/chromium/src/+/2375597)
and in https://github.com/w3c/manifest/pull/932 is that we need a
way to say new display modes are allowed in display_override but
not display.

The plan is to introduce a new enum EnhancedDisplayMode, and
display_override should be:
  sequence<DisplayModeType or EnhancedDisplayModeType>.

To support that, this CL deprecates the existing display_override field,
and renames it. Renaming here should be fine, as long as we don't use
JSON serialization. Once the new field has landed, we will remove
this field, and mark it reserved so that future users don't reuse
the field.

Explainer: https://github.com/WICG/display-override/blob/master/explainer.md
Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing
I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion
Manifest w3c PR: https://github.com/w3c/manifest/pull/932

Bug: 1092667
Change-Id: Ifbc0160a88263d4994d138f99921371ceea2bcb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436417
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811932}

Add virtual tests for default dark mode behavior for images. This will
help check and correct default behavior for images.

Bug: 1116914
Change-Id: Ifcd6db9df15b5616511fdc50125f277071341976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434023Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Cr-Commit-Position: refs/heads/master@{#811931}

This change adds new application classes for Chrome/Monochrome which can
be used with isolated splits to load the logic from the real application
classes from the chrome split in the browser process. In child
processes, only the necessary initialization will be done, and the
chrome split will never be loaded.

Application methods which have logic in ChromeApplication or
MonochromeApplication have been moved an inner implementation class,
which will then be called from the SplitCompatApplication superclass.

Fonts were moved to the base module because they were conflicting with
resources from the elements aar.

Unfortunately, there is an Android bug with how services are loaded from
isolated splits (b/169196314). I'll fix this in a follow up.

Bug: 1126301
Change-Id: Icafe93a8c6fb560315c3022839544faaa0327fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425404
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811930}

Currently, when running the unit test
WorkerMainScriptLoaderTest.ResponseWithFailureThenOnComplete locally,
the result reports all tests passed:

[1/1] WorkerMainScriptLoaderTest.ResponseWithFailureThenOnComplete (12 ms)
SUCCESS: all tests passed.

but actually, there is an error reported:

Actual function call count doesn't match
EXPECT_CALL(*mock_observer, DidReceiveResponse(_, _, _, _, _))
Expected: to be called once
Actual: never called - unsatisfied and active

The root cause is that we must execute a forced GC in order to finalize
objects depending on the mock object before the test finished, and
the test begins to fail consistently after executing a GC in the dtor.
Meanwhile, we should call ResourceLoadObserver's DidReceiveResponsei()
method before stopping loading the main script by WorkerMainScriptLoader.

The WorkerMainScriptLoader class is designed to load the main script
for workers, which is pre-requested in browser process and passed to
renderer process through WorkerMainScriptLoadParams, and when the http
status code indicates a failure, we should notify the
|resource_load_observer_| by invoking its DidReceiveResponse() method,
thus the devtools could be aware of this response.

This patch implements that behavior to make the test runs successfully.

Change-Id: I03f062276abad2253b35ebfa4ed8b4f58eddab4f
Bug: 1132634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433631
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811929}

Also opts aliases into symbol sorting.

Bug: None
Change-Id: I62b01b7a59156b7599769666f854209e9cd63ae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438872
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811928}

 1. Adds a 'type_detail_fields' into the request json which makes the
    response as small as possible.

 2. Removes the FileTasksNotifier pointer from the provider, which we
    don't need anymore.

Bug: 1034842
Change-Id: I8c663c10543e1547aa3379cf6acce173e653a71e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438089Reviewed-by: Rachel Wong <wrong@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811927}

This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID.

It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID.

R=yangsharon

TEST: web_engine_unittests
Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Commit-Queue: Lucas Radaelli <lucasradaelli@google.com>
Cr-Commit-Position: refs/heads/master@{#811926}

Add this metric to help us understand usage and plan
improvements.

Bug: 1099338
Change-Id: I77ce043b2e54031b8c35d8ba302be8b7b254edcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424508
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811925}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=lakpamarthy@chromium.org

Change-Id: I03396595652afda6036ac5cb0a2187eb25e4228a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439428Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811924}

Beta builders build on default and run tests on beta version. SDK
builder build and run on beta version.

Bug: 1132967
Change-Id: Iee320ec6154986dd7811d5193b0febc39b4b5713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436864Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811923}

Most of the new issues are related to BackupRefPtr, but some
unrelated ones surfaced recently too. While at it, format the
CheckedPtr2/MTECheckedPtr better.

See this section for more details:
https://docs.google.com/document/d/1cnpd5Rwesq7DCZiD8FIJfPGHvQN3-Gul6xib_4hwfBg/edit?ts=5ed2d317#heading=h.jeb8au4vq4yf

Bug: 1069567
Change-Id: Ic49feaff08450ed4ac9ca93b03ef9d5b71245f28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437832Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811922}

This is a pure refactor, no functional change.

TBR=dmazzoni@chromium.org

AX-Relnotes: n/a.
Bug: None
Change-Id: If8d4eb247f61e0abe1df9e32879d3641974bab1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438481Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#811921}

Update password was calling the save password delegate method.
Accidentally introduced in:
https://chromium-review.googlesource.com/c/chromium/src/+/2315252

Change-Id: I5779831c37aa24f383940abbfb534e1b618ec9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439018
Auto-Submit: John Wu <jzw@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811920}

This patch changes |NGInlineNode::SetTextWithOffset()| not to reuse last
glyph in run to handle kergning, e.g. "AV".

When inserting character "V" after "A", before this patch, we have glyph
run for "A" and "V" without adjusting spaces between space "A" and "V"
because we reuse shaping result of "A" then concatenating shape result
of "V". After this patch, we does shaping "AV" once.

Bug: 1129710
Change-Id: I2ecf2ce04945dba18ed9622a9f6745ea4060ce87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423802
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811919}

Introduce the fake host resolver class, used by unit tests, to avoid
duplication across multiple routines.

BUG=chromium:956783
TEST=none

Change-Id: I4a5e9b6f07de4b55a07e54cd46c8e879c3df080e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434555Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811918}

Bug: 1128995
Change-Id: I9bc59f6b4a4af4df0850175826050e2e84381ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432385Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811917}

As an ongoing effort to polish the virtual desks renaming textfield,
this CL adds 8dip horizontal padding and sets the height to 24dip.

Tests: manual
Bug: 1127498
Change-Id: I3fb939b355eae56710e6fbb1bfc35f464792584b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434912
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811916}

We recently migrated to the NGOffsetMapping class to convert from DOM offsets, which might have uncompressed white-space, to text offsets
which are used in the accessibility tree.
However, the assumption was that NGOffsetMapping supports returning text offsets for
all block flow elements, which is untrue. Only block flow elements that are at inline or inline-block level are supported.
Unfortunately, allowing block-level elements through to the NGOffsetMapping class could cause a serious crash in Blink.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org, yosin@chromium.org

Change-Id: I311be3cbc01abd8d1819c405bf7c63aaa62785d5
Bug: 1124963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436748
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811915}

Bug: none
Change-Id: If156da0fe3fb65e99ad00984cf65c0b962a6bbf8
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438732
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811914}

This CL updates descriptions on two Language Settings strings based on
feedback from translators.

Bug: 1133470
Change-Id: I91c27b06104fea6b3bb57a3033aec3cc1136450b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438311
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Auto-Submit: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811913}

Add tests for base::TimeDelta parameters of zero, min, max, and
negative. Fix errors in constructor DCHECK's uncovered by the tests.

Add a gmock InSequence declaration to ExpectBindAndRespondToQuery, which
included two expectations that happened to be in the wrong order. This
makes it usable from inside another InSequence block, and also enforces
the correct order in tests that don't already use InSequence.

R=chrisha

Bug: 1080672
Change-Id: I39ece84cbbeaf23466fd1678bd761f62f54f7d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422903
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811912}

The PasswordProtectionService and
PasswordProtectionNavigationThrottle both
own a scoped_refptr to PasswordProtectionRequest.
When both the Service and Throttle class are
created, two scoped_refptrs are created for
the same PasswordProtectionRequest. When
the request is finished, the Service class
erases the scoped_reptrs, but the Throttle
class still contains a reference to the
scoped_refptr, which causes a page hang.
Thus, the Throttle class also needs to
release the scoped_refptr when navigation
is resumed or canceled.

A follow up is to refactor the PasswordProtectionRequest
and not have it RefCounted.

Bug: 1110427
Change-Id: Idf66b0451036099d0a417a42b6a37f5a5b10cf13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406599
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811911}

This adds code to enable media router features, although the
implementation is still missing.

Notably,
- a feature flag is added to enable/disable MediaRouter code
- Media-related java, new and old, is moved into weblayer_private.media

Bug: 1057100
Change-Id: Ied1cfd60e19890166568fc3facbd012285c9fabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427289Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811910}

Bug: 1123769
Change-Id: I9cc14ddb946dcd50b34854374b581f5c4b28ed30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429981Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811909}

When rendering HTML, specify charset. Without this, we get some
strange looking characters in the render. This should not fix all cases,
but hopefully fixes the majority.

Bug: 1128615
Change-Id: Ie81e2278c29c6f056bc5b4a1af886f5f9c089a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437706
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811908}

Reduce the scope of |kBuiltInHost| so it is created on first use. Also
fix a bunch of nits in the file.

Bug: 537099
Change-Id: I5834a415fb26cd1b4cd071fbdb938453b1757d8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430767Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811907}

Also, fix typo in a method name.

Bug: None
Change-Id: I53912102768cc98dcad18377859d2bb8664ddb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437539
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Reviewed-by: My Nguyen <myy@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811906}

This CL adjusts layout to match the spec, adds ink drop to action
buttons, and adds a drop down icon next to title label.

Bug: 1133026
Change-Id: I46a8af315c98b43e2b557908dfebf810c1666ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436419Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811905}

* Add Finch to control snooze duration experiment.
* Add UMA to track 4 events, all with the count of previous snoozes.
  1) Tab Group IPH trigger.
  2) Tab Group IPH dismiss by dismiss button.
  3) Tab Group IPH dismiss by right-click on tab.
  4) Tab Group IPH snooze.

Bug: 1121399
Change-Id: Ib5aa2ed0c92d5bf8cfe2f1744d596ac2d03e6a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425230
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811904}

Test: none
Change-Id: If8a7d3c203a36f342440f4046c5c1fc789c4e9b2
Fixed: 1088590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438873Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811903}

This reverts commit 6c5fa707.

Reason for revert: VTConfigUtil.FormatDescriptionBT709 and FormatDescriptionInvalid are failing on mac
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/58972

Original change's description:
> Add media::GetFormatDescriptionColorSpace
>
> This function is nearly identical to media::GetImageBufferColorSpace,
> but instead operates on a CMFormatDescriptionRef.
>
> Add DCHECKs that the behavior of the two functions be the same, that is,
> the kCVImageBuffer-prefixed and  kCMFormatDescription-prefixed
> constants be equal.
>
> Use base::mac::CFCast instead of reinterpret_casts.
>
> The next patch in this sequence will move these two functions over
> to media/base/mac, because it will be accessed in capture.
>
> Bug: 959962
> Change-Id: I8a4d8468abc866a13cb6181cbd49d9ee04288124
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436513
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811829}

TBR=dalecurtis@chromium.org,ccameron@chromium.org

Change-Id: Iaa57cf20273eb0bcdace23a1ee9e588da15ea733
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 959962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438551Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811902}

This CL adds a new parameter to all AffiliationFetcherDelegate virtual methods - a pointer to AffiliationFetcher.
This change is required to later handle multiple pending fetchers logic in AffiliationServiceImpl to process each result per specific fetcher.

Bug: 1117045
Change-Id: I26ad49ba7bca605c2117ce8a88ce017de2dda276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433927
Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811901}