- 29 Jul, 2020 40 commits
-
-
Edward Lesmes authored
Change-Id: I56259bca22bf1726ef06c9002426ab080b219a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316690Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#792904}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96d6c6f04dcb..a40e7b77fbb1 2020-07-29 brianosman@google.com Add Skia.natvis to platform_tools/debugging 2020-07-29 senorblanco@chromium.org Fix MSVC build. 2020-07-29 reed@google.com Can't share encoded data if we have any modifiers 2020-07-29 mtklein@google.com don't let shaders know the destination is unpremul 2020-07-29 csmartdalton@google.com Make tessellation join type values negative 2020-07-29 mtklein@google.com skvm sprite blitter 2020-07-29 rmistry@google.com Use storage.ErrObjectNotExist in Canary-G3 2020-07-29 bungeman@google.com SkUNREACHABLE should fail, not be UB. 2020-07-29 robertphillips@google.com Re-org image-cacherator-from-* GMs 2020-07-29 johnstiles@google.com Add LLDB debugging extensions for SkAutoTArray. 2020-07-29 johnstiles@google.com Add LLDB debugging extensions for SkTArray and SkString. 2020-07-29 nifong@google.com A puppeteer test that runs karma-like tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I562311e76a90a753e2d6da48cd9223513c921b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792903}
-
Mustafa Emre Acer authored
Bug: 1077426 Change-Id: I4fe56e3b9c21a734628a5d82c6d53ca4a466b901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327634Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792902}
-
Nick Burris authored
PaymentAppProviderImpl was recently changed[1] to use WebContents* instead of BrowserContext*, in preparation for making the object owned by WebContents. However, the service worker logic still needs to use a BrowserContext* to register callbacks in case it outlives the WebContents, which is possible in the current state where it's a singleton. This patch makes it so all service worker logic uses a BrowserContext*. Bug: 1110207 Change-Id: Iee16d9cdfc81e2f186226e11be379890d6d66eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324041Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#792901}
-
James Vecore authored
This is a reland of https://crrev.com/c/2317166 which fixes an issue with the post CQ builder: linux-blink-cors-rel. Fixed by adding 'network::features::kOutOfBlinkCors' to the enabled list in featureList. This also fixes an issue in the WATCHLISTS. Revert is here: https://crrev.com/c/2325433 Original message: > [Nearby] Add NearbyShareSettings mojo for use in settings and webui > |NearbyShareSettings| provides a strongly typed wrapper over the raw > user prefs and allows clients to observe individual changes. This class > also implements a mojo interface to allow multiple WebUIs to access > settings (OSSettingsUI, NearbyShareDialog, and eventually SettingsUI). > > This CL achieves sharing of mojos and the components that depend on them > outside of chrome://resources by having the shared resources hosted in > chrome://nearby and re-registering them in chrome://os-settings. This > gets around having to include explicit references to the mojo generated > resources in //content which required a DEPS exception that was not > acceptable to //content/OWNERS. > > Many other options were considered to solve this shared resource > problem. Please see the dicussion thread for more context: > http://g/chrome-webui/Q8WGiGO7h-E > > Change-Id: I831044176ed71b15fb7df0be8f1c393e574254f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317166 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Josh Nohle <nohle@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792503} Change-Id: I433a4a6292525d50eb7df12d20a8abe81d2949db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327010Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#792900}
-
Francois Beaufort authored
This CL makes sure sendReport(), sendFeatureReport() and receiveFeatureReport() will throw an error if an invalid reportId is provided by simply using EnforceRange. Spec: https://github.com/WICG/webhid/pull/25 Bug: 890096 Change-Id: I4d6eee9a7460cfe1d707d87702f58c9fe43d39d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317788 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#792899}
-
Maksim Ivanov authored
Delete the TestCertificateProviderExtensionLoginScreenMixin mixin class and migrate the existing tests to ExtensionForceInstallMixin. The motivation is unifying the implementation in tests that need to force-install extensions: the new ExtensionForceInstallMixin is a more universal and flexible tool. The old TestCertificateProviderExtensionLoginScreenMixin was very-narrow focused on simulating a specific use case. Bug: 1090941 Change-Id: I3965abe807d0d41250a3b138383e5a6dfe460876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316359 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#792898}
-
Dmitry Shachnev authored
To fix warnings/errors from binutils 2.35 branch about relocation in read-only section `.text', when building Chromium as a shared library (as in Qt WebEngine). See the following binutils bugs: - https://sourceware.org/bugzilla/show_bug.cgi?id=20824 - https://sourceware.org/bugzilla/show_bug.cgi?id=22909 And this Debian bug: https://bugs.debian.org/965328. TBR=ssilkin Change-Id: Ie3342eb433d30eb1073b7553687d23acaa38625b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309438 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#792897}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I3078305bd106abc310bdb8eb4af855cbb09f0dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324176 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#792896}
-
David Black authored
This is being done to provide ash::ClipboardHistory the ability to access and restore ClipboardData directly from ClipboardNonBacked without having to otherwise read/write the clipboard buffer. Manually reading/writing the buffer would likely be prone to missing some aspects of ClipboardData if changes were to get out of sync. Bug: 1104352 Change-Id: I80c800f1ebde26ad3bb8196bc0f438394bed2067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316802 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792895}
-
Matt Menke authored
Because they're for startup logging, they have to open files while blocking the UI thread. In chrome/, we instantiate the NetworkService before we start blocking file I/O on the UI thread, so things work fine, but in content_shell, NetworkService is only created after I/O blocking is configured, so opening the files DCHECKs. This CL adds a ScopedAllowBlocking around opening these files to resolve the issue. Fixed: 1048822 Change-Id: I264a54e7dfb6da0040c74f6fcf1fb5aba51ae18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324169 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#792894}
-
Scott Violet authored
No actual code change, just updates the docs. BUG=1076463 TEST=none Change-Id: Ic02eb8adc562fb6eace70500c7c2fb00fb6ed8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326690 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792893}
-
Matt Jones authored
All users of the old widget have been converted to use the ScrimCoordinator component. This patch removes the old widget and any lingering references. Bug: 1062099 Change-Id: Ib7673611e02bae32258ab1d945f22adf52dfe3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312916Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#792892}
-
Olivia Flynn authored
This CL adds: - A CDP method to act as an entry point for new a tool that shows the source order of child elements within a given node - A CDP object to hold information about how to draw the outlines - An inspector tool to draw outlines of the nodes Screenshot: https://imgur.com/a/LIKYJEJ This CL is part of creating a Source Order Viewer, which was identified as a customer ask on The Web We Want The Web We Want submission: https://webwewant.fyi/wants/64 Explainer: https://docs.google.com/document/d/1t33UTIpW46MGor70W8mdBJVRio8eo3p76w3FH8MjV7A/edit?usp=sharing Back-end CL to label child elements w/ source order: https://chromium-review.googlesource.com/c/chromium/src/+/2250883 Front-end CLs: Drawing labels: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2250404 UI: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2251080/9 Bug: 1094406 Change-Id: I226f1ae5a2a2263d592e66c56a8a56d3f1fd1ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250504 Commit-Queue: Olivia Flynn <t-olfly@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792891}
-
Xiaohui Chen authored
Token refresh unitest has a delay that's too long. It causes many screen refreshes and makes the unittest run very slow. R=wutao@chromium.org Bug: None Change-Id: Ic93fdc6a97a4125dff42be077d99ca197cc94b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327273Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792890}
-
Tao Bai authored
Directly use the result of FormFieldData.IsVisible(), since it is hard to detect if a field visible to the end user or not, the result could be false positive, but once it is set to INVISIBLE, it isn't visible to the user. Bug: 1110041 Change-Id: Ie745ababf98ce0e195c7cd603fa16665656d5918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324996Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#792889}
-
Kevin Babbitt authored
Open up early-adopter testing to look for site compatibility issues. Bug: 1081945 Change-Id: I677f1008436b6b738f519d7f50cab995320b4f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293575Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792888}
-
Philipp Hancke authored
use LOG(ERROR) instead of DLOG(ERROR) in the log message for hitting the maximum number of audio input/output streams. BUG=chromium:1110171 Change-Id: Ic49ba74ffc7d43d00460aadce211cc6e806d0e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325610Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#792887}
-
Brandon Wylie authored
Bug: 1111001 Change-Id: I7b5278e7ec80feca1ba71700cab9e25c07c1e2da TBR=andypaicu@chromium.org Change-Id: I7b5278e7ec80feca1ba71700cab9e25c07c1e2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327139Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792886}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieef7e6fa8ad4b0eb5713cf6bb5e0dbe5fb2eabf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792885}
-
Mehran Mahmoudi authored
This attempts to decrease the inconsistensies between the paint preview and the live page by delaying the removing of paint preview until both onPageLoadFinished AND didFirstVisuallNonEmptyPaint happen. Bug: 1111006 Change-Id: I66c46cc9454608a92b6b6f09c2beba60668b431f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327278 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#792884}
-
Steven Bingler authored
Mark both of OwnedState's member variables as final. Bug: 1085168 Change-Id: I04f5fb4468161e3839d211037ea22a3877021638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327614 Commit-Queue: Steven Bingler <bingler@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#792883}
-
Joshua Pawlicki authored
Bug: 1053773 Change-Id: I466d21f7e384a1c68d178bddb9b87f7e87e1575a Fixed: 1053773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323583Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#792882}
-
Alex Hawker authored
Adds a new chrome://flags entry to enable the offline Bento experience feature. Bug: 1110112 Change-Id: I73cec4264465711f0e98c0b8c8b5d54013e83257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321342Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alex Hawker <ahawker@google.com> Cr-Commit-Position: refs/heads/master@{#792881}
-
Peter Boström authored
This reverts commit b4631b6c. Reason for revert: Still flaky on Mac10.13 Tests (dbg). https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19508 Original change's description: > Re-enable CrSettingsPasswordsSectionV3Test in debug builds > > Bug: 1090931 > Change-Id: If41e533eefce52db80a40e1ab7fdcfe75ae906e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317873 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Victor Vianna <victorvianna@google.com> > Cr-Commit-Position: refs/heads/master@{#792701} TBR=treib@chromium.org,victorvianna@google.com Change-Id: If31b5a7cd4cdf6a7da3d71e3677daa53086ad57a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327819Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792880}
-
Anders Hartvoll Ruud authored
As far as I can tell, this check for HasAuthorBackground has never worked. The function StyleResolver::HasAuthorBackground belongs to the old code path in the StyleResolver, and in that code path, we'd only cache the UA style if we had some 'appearance' other than 'none'. And since we only try to perform the adjustment when we have no appearance, the function will always return false. Since this code was introduced [1], we've introduced the EffectiveAppearance field [2], but as far as I can tell we can only go from non-none to none if the element is nullptr, in which case we'll also not attempt the adjustment. Note also that since M83 (CSSCascade ship), StyleResolver:: HasAuthorBackground has *always* returned false regardless of circumstance. (It was believed to be unused, but I missed this call site). Hence, we can just remove the check. [1] https://crrev.com/9d6f3016641f26e4e330da6baf70fa2133f62721 [2] https://crrev.com/23a4dcc92d21834769f61c0125edbcf4b1af15dc Change-Id: I973978e08398ef5906845884b5e133923f6bfb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321309Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#792879}
-
Frank Liberato authored
If GpuResources fails to init, and if a call to PushNewTexture is queued before the error makes it to the wrapper, then it can get a nullptr in `gl_image_` or `stream_`. This CL adds a check, and posts another error if so. Bug: 1110812 Change-Id: I13723aad1386f7352d175508f6c31aa1c88615c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326872 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792878}
-
Avi Drissman authored
The previous version of this change, 21e6c4e1, set the CFBundleName to the app_product, but that gives it the name "Google Chrome Canary" rather than just "Chrome Canary". Adjust the bundling script. Bug: 1109411 Change-Id: I7a1986cfa41a34b19b6a95d2c011f55aaba315ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327130Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792877}
-
Yuchen Liu authored
Bug: internal b/161738703 Test: Build, gn check Change-Id: I11dcb51566db41d27facbbb7f491eed19f7b7ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327141 Auto-Submit: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#792876}
-
Gayane Petrosyan authored
Add basic Link to text feature without link generation request. This CL also adds a new version of Sharing hub with a message. Success case: https://screenshot.googleplex.com/2KiLEciz0uS.png Failure case: https://screenshot.googleplex.com/jQgcyd6kpjg.png Bug: 1102382 Change-Id: I3508169170d657c0538bb6b450e7e33a93191fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309003 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#792875}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Icecf8ad743a7431ae5cb3ec2cf1c8e88262b8eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324894 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#792874}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I166df0a487263bc706e6b811d19416b3526322d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792873}
-
Nate Chapin authored
WebView has a special mode where the initial empty document of the main frame can be reused. This is accomplished by giving the initial empty document's security origin universal access. This causes us to reuse the WindowAgent created for the initial empty document, but if we conduct a security check against that agent, we trigger a SECURITY_CHECK in binding_security.cc. We therefore need to ensure that we do not reuse the WindowAgent in this special WebView-only case. Bug: 1006684, 1096140 Change-Id: I00fb74e46a417e36dcc963df5dc2fa2c60932a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321707Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#792872}
-
Haiyang Pan authored
Bug: 1108306, 997376 Ignore-CQ-Freeze: Disable tests in emulator builder Change-Id: Ife854678e91c3857fb058074c929a8870ff11ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321557Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#792871}
-
Dale Curtis authored
Previously we always allocate the full size for YUV decodes, even if they are going to use a temporary full size intermediate before being scaled into their final destination. After this change we'll size the destination pixmap at the scaled size instead of the full decode size. R=khushalsagar Bug: None Test: No asan failures :) Change-Id: I3b7625ed275f1e0b19e0a0e1fc3745a39eb13fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324211 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#792870}
-
ckitagawa authored
This CL adds multi-frame tests for - Scrolling - Scaling - Link clicks Bug: 1106035 Change-Id: I09eb3e008701204ac55b2cd60fb97a206d88cb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324489 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792869}
-
Maksim Sadym authored
follow-up after CL 2317956 Bug: 1090802 Change-Id: I9ddbce522dc3860e429228510d89f7456fdc6f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327670 Commit-Queue: Maksim Sadym <sadym@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792868}
-
Bo Liu authored
For Android WebView, the DumpWithoutCrash for URLLoaderFactory.CreateLoaderAndStart deserialization failure is the #1 crash signature on stable. Add a crash key to to determine which deserialization check is causing the failures in webview. Note in general, deserialization failures are generally not caused by deserialization of "raw" types, but come from "additional" checks. So attempt to set a crash key string only for these "additional" checks. Also for now only add crash key in services component. If this data suggests additional disambiguation is needed in other components, then can add them later. Bug: 1028189 Change-Id: I6a5026b39790538a7d3c693ead6a96f48252802c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324488Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792867}
-
Collin Baker authored
This will also be enabled for 84+ via Finch. Bug: 1069634 Change-Id: Ie4f897ee19a521076cfbb4aab1c4e66f510e3ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327371Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#792866}
-
Dale Curtis authored
Adds bit_depth to the ToSkYUVColorSpace() function so that we can use the new bit-depth appropriate BT.2020 Skia color spaces. R=ccameron, pkasting Bug: 1108626 Test: New unittests. Change-Id: I29924719655ce0d80b8d71e5adda891ed9b30050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321307 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#792865}
-