- 21 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c681b47a0955..e060aaf770ca git log c681b47a0955..e060aaf770ca --date=short --first-parent --format='%ad %ae %s' 2020-02-21 btolsch@chromium.org Add URL parsing support 2020-02-20 miu@chromium.org Improved FakeClock::Advance() for simulating task execution. Created with: gclient setdep -r src/third_party/openscreen/src@e060aaf770ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I76b4f5fc4e06a6e1128d877c4561f4781ecde468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743428}
-
Charlene Yan authored
Bug: 1040657 Change-Id: I50c63cb1f94da36ff24c882f76125b65165d0888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063734Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743427}
-
David Munro authored
Test: None Bug: None Change-Id: I47c1f70860ed364fdfecb403a29c3d8a1ab8b4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067757Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#743426}
-
Takashi Sakamoto authored
This reverts commit de6ebaa2. Reason for revert: causes compile failure on linux-chromeos-chrome Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3372 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8887878986181186864/+/steps/compile/0/stdout?format=raw --- [34344/60074] CXX obj/chromeos/services/assistant/lib/assistant_manager_service_impl.o FAILED: obj/chromeos/services/assistant/lib/assistant_manager_service_impl.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../chromeos/services/assistant/assistant_manager_service_impl.cc:101:16: error: unused variable 'kScreenContextQuery' [-Werror,-Wunused-const-variable] constexpr char kScreenContextQuery[] = "screen context"; ^ 1 error generated. --- Original change's description: > assistant: Remove IsScreenContextQueryEnabled > > Remove unused code. > > Bug: b/145218971 > Test: manual > Change-Id: I54e08fc38e967517212b2f41fabe6bb872d17cf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067938 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743408} TBR=xiaohuic@chromium.org,wutao@chromium.org Change-Id: I565b31eb10ecaf53d9adae452320de420b7f00db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/145218971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067761Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#743425}
-
Klaus Weidner authored
Move this declaration from the "overrides RenderFrameHostDelegate" section to the "overrides RenderWidgetHostDelegate" section to match the actual inheritance. Should be a no-op. Change-Id: Id0a7b70b8000b0b393cb89aae062afa74a6a17a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067566Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#743424}
-
bttk authored
Bug: 1046181 Change-Id: I0c269a5991701027702fd5011586d66de6192273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017912 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#743423}
-
Klaus Weidner authored
Add a special case to allow entering fullscreen mode when a DOM Overlay is being set up for WebXR immersive-ar mode, without consuming user activation. The initial WebXR session request had required user activation, but this may have triggered a permission/consent prompt, and if the user took more than 5s to answer that, the activation state will have expired at the time it's checked. (Fixes regression from https://crrev.com/c/1903675 which added a browser-side user activation check for Fullscreen API.) Bug: 1054557 Change-Id: Iaea843c34c948764ee5d08effdadf18d7b28d982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067539Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#743422}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I0192db636f7349f0d0fa90607909df467d9399ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068117Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743421}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I9b583888cea7708a69eb35ac89c2dca2938f74b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066405Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743420}
-
Kenneth Russell authored
Instead of only checking whether the containing frame is same-origin with respect to the top-level document during transferControlToOffscreen, check in the OffscreenCanvas constructor, both for the main thread as well as dedicated workers. Dedicated workers are same-origin per specification, so always grant access to the discrete GPU in this scenario. Add new pixel tests that verify WebGL-rendered OffscreenCanvas into an ImageBitmapRenderingContext (i.e., where the OffscreenCanvas was not originally tied to a canvas element). On dual-GPU macOS devices, also verify the active state of the low-power and high-performance GPUs. Simplify some of the tests most recently written for low/high-power GPU switching. Bug: 1048892 Change-Id: I85addc2b53a58997499e444b357d433d7082e262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043076 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#743419}
-
Kent Tamura authored
Resolves two TODO()s. This CL has no behavior changes. Change-Id: Ibee5cc16246703940b3312fcbea05a9b2a529e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066420Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743418}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a305558..c7aa5ac7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0b5933032dfa5ade86518307c07db9ec8297fc4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067977Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743417}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I138fff767f7fa644ecec09aa1183d554bff43b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743416}
-
Eric Willigers authored
WebAppPictureInPictureWindowControllerBrowserTest no longer uses extensions methods to create web apps. Bug: 1053876 Change-Id: I2dec113cd7fa00c45643839b66017619b0a1156e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062123 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#743415}
-
jessing authored
This is a reland of d4838474 Previously in chromeos/components/sample_system_web_app_ui/BUILD.gn, the build rule js_library("app") was causing build failures due to a missing app.js file. This cl fixes the file path for the js files. Original change's description: > [system-web-apps] Add chrome-untrusted iframe to sample system web app > > An example of how to embed a chrome-untrusted iframe into a system web > app. > > To do so, we need to add abstract methods in WebUI despite WebUIImpl > being the only class to actually implement it. This is so the > WebUIController can add requestable schemes so the WebUI can request > the chrome-untrusted resource. > > Bug: 1048951 > Change-Id: Ia3152e21412845cf421df74bb00a16e0a8f264b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037186 > Commit-Queue: Jessica Huang <jessing@google.com> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Jessica Huang <jessing@google.com> > Cr-Commit-Position: refs/heads/master@{#742999} TBR=kinuko@chromium.org Bug: 1048951 Change-Id: I38307ef0966813426e99e97ecf54403c54124917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066404Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#743414}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4a3fef3b6875..518e466ec497 git log 4a3fef3b6875..518e466ec497 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 fancl@chromium.org Fix matching for sheriff-config 2020-02-20 bsheedy@chromium.org Update minidump_stackwalk Created with: gclient setdep -r src/third_party/catapult@518e466ec497 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040502,chromium:1052720 Tbr: crouleau@google.com Change-Id: I042ac2367209a30b69bb13c83582dd8159429cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743413}
-
Nico Weber authored
This requires changing wayland/fuzzer/wayland_templater.py a bit. -Wmisleading-indentation used to fire on harness.cc (see try jobs on https://chromium-review.googlesource.com/c/chromium/src/+/2063736/1), because harness.cc.tmpl is indentede according to jinja directive level, not indented according to generated output code level. That makes the .tmpl files readable, but the generated code looks weird. As a fix, pipe the jinja output through clang-format before writing it to disk, so that the output looks readable too (to both compilers and humans). This is the approach we use in other code generators in Chromium as well. While here, also change the script to only write its output if the contents change. This allows ninja to not run the compile step for the generated cc files if the file contents don't change (due to a no-op change to the generator, or due to a whitespace-only change to the .tmpl file that clang-format now normalizes away). The wayland_templater.py change is meant to be behavior-preserving. Bug: 031169 Change-Id: I045070be3c1649e8752b6e09bb6655b1f3f60fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066108Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743412}
-
Xinghui Lu authored
It is not needed to cancel the check if the request is never sent. Also introduce a helper function to send the check to the database_manager. This helper function will be reused in another refactoring CL. Bug: 1050859 Change-Id: I64f1d721f77c60c93d0829dd0c0bf8c791b4f053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067462Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743411}
-
Joey Arhar authored
In http://crrev.com/c/1922699 I made anchor clicks cancel all form submissions on a page in order to make this test pass: external/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html The test basically says that anchor navigations should take precedence over form submissions when the form submission is initiated by the onclick handler of the anchor element. However, when the anchor has href="#", form submissions should actually go through, and this has introduced a bug on websites which rely on this behavior. This logic I added to cancel form submissions would not be necessary if we made anchor clicks navigate asynchronously like the spec says to do, so I made a bug to do so and remove this logic: http://crbug.com/1053679 Bug: 1053312 Change-Id: I27bf193cf0d544222cddad932728a1d0f61ba62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063265Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743410}
-
Hitoshi Yoshida authored
Drops a use case of Dictionary in IDL. Following the spec, this CL replaces Dictionary type with an IDL dictionary JsonWebKey used in importKey(). Bug: 385376, 839389, 1047081 Change-Id: I531f3088301d330cb15dcba5de9fad2cd6f997f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065193Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#743409}
-
wutao authored
Remove unused code. Bug: b/145218971 Test: manual Change-Id: I54e08fc38e967517212b2f41fabe6bb872d17cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067938 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743408}
-
Sorin Jianu authored
The build break is due to a missing dependency on //chrome/updater:version_header. TBR: ganesh@chromium.org Bug: 1054682 Change-Id: I36bb38ef63965e4e39ec7901bdb3e326592d8a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067951Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743407}
-
Makoto Shimazu authored
Previously we use them to prevent from evaluating a script until the byte-for-byte comparison is completed. However, now comparison is done in the browser process and we don't use them. This CL removes an unused callback pause_after_download_callback_ in ServiceWorkerVersion and a message ResumeAfterDownload on EmbeddedWorkerInstanceClient. Bug: 999907 Change-Id: I3505bd95c13685096cfabef3208cfa304046f324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060446Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743406}
-
Hajime Hoshi authored
This CL adds two new UKMs * HistoryNavigation/BackForwardCache.IsServedFromBackForwardCache * HistoryNavigation/BackForwardCache.NotRestoredReasons Both are similar to the existing UMAs, and records the same things as UKMs. IsServedFromBackForwardCache records whether the page was restored from the cache. NotRestoredReasons records the reasons why the page was not restored from the cache. NotRestoredReasons are represented as a bitmask. Bug: 1033410 Change-Id: I4513d235d344ff94bad56358c26693a20e8bad05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961830Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743405}
-
John Chen authored
Change-Id: I563cea0cb482ac581814407500b0784361db089b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067742 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743404}
-
Robbie McElrath authored
crrev.com/c/2039812 Added the Variations.DownloadJobFetchTime metric, which was written via TimesHistogramSample. That class only supports durations up to 10 seconds, which isn't sufficient for that metric. This CL replaces that histogram with Variations.DownloadJobFetchTime2 (you have to create a new metric when changing a histogram's bucket distribution) that can store durations up to 20 minutes, which is twice the time Android allows for jobs to execute. Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedLoaderTest#*' Bug: 1047536 Change-Id: I9a1f97982f13d075d32ad96f853ac33088da125b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067546Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#743403}
-
Michael Thiessen authored
After some trial and error, I think the best strategy for migrating our java code to GURL is to convert all of the leaf nodes (typically jni boundaries) to GURL, providing a deprecated interface for existing usage, then convert the rest. Bug: 783819 Change-Id: I8c00386e70008a588e0d5e249e3c398112c94e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044759Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#743402}
-
Eleni Dimitriadis authored
Added a new ChipRanker type, which will house a new Dolphin model. This model will rank apps alongside both local and drive files, which will allow us to compare the different types of items. These ranks will be used to adjust the scores of the files to be in line with the app scores, while still preserving the original ordering of both groups. This ensures the files will display appropriately in the suggestion chips, but that their ranking elsewhere will be unaffected. Bug: 1034842 Change-Id: I618e2694b74c6c5917eef66a900ef822f5422b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989742Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Eleni Dimitriadis <edimitriadis@google.com> Cr-Commit-Position: refs/heads/master@{#743401}
-
Thomas Guilbert authored
Currently, video frame metadata is reported back up from the compositor to the blink layer as soon as a new frame is presented. Since video-rAF callbacks have their execution delayed until the next rendering steps, by the time the callbacks are run, there is a chance for a newer frame to have been presented. This means that the metadata we have would be referring to the frame that is now being displayed on screen, instead of current frame. This CL removes the pushing of the metadata, and instead pulls it at the last moment, right before the callbacks are run. This means we are more likely to get metadata that is relevant for the upcoming v-sync, instead of the one that just happened. However, we might miss more frames, as measured by non consecutive "presented frames". Bug: 1049761 Change-Id: I544d190a477f79c9d917a65b781ae68cd099dc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042143 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#743400}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/166875eb84cc..ce4918f18f73 git log 166875eb84cc..ce4918f18f73 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 jmadill@chromium.org Vulkan: Sanitize Images & Buffers with non-zero values. 2020-02-20 spang@chromium.org Generate entrypoints for Fuchsia external objects extensions 2020-02-20 jmadill@chromium.org Vulkan: Add command stream diagnostics when graph is disabled. 2020-02-20 tobine@google.com Vulkan:Add FramebufferVk cache 2020-02-20 jmadill@chromium.org Vulkan: Enable FenceNV extension without graph. 2020-02-20 spang@chromium.org Add external object extensions for Fuchsia to GL API 2020-02-20 jmadill@chromium.org Vulkan: Make mapped memory available with graph disabled. Created with: gclient setdep -r src/third_party/angle@ce4918f18f73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7fbc16d657933d16eb876d190132ff58d7d909a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067587Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743399}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I01af9fec6cdce911b2111bdebcb6a8ac1269d272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066460Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#743398}
-
Matthew Mourgos authored
Bug: 976949 Change-Id: I076b56bdad13f12b664d41586b143bb238e15c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067720Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743397}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Device pointer page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I193b33a5bbaf251b4e2cb0d6a8ea67c9a7906c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065251 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743396}
-
Filip Gorski authored
Bug: 1031595 Change-Id: If0f9c8625de099c730cbf2fc909efdec1b21245b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065415 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#743395}
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of moving OS specific strings from settings_strings.grdp to os_settings_strings.grdp, specifically parental control page strings. Bug: 967883 Change-Id: Ie9ba498cf7980b8ed202b9784cd94038613d739c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065142 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743394}
-
nancy authored
Refactor the current app pause dialog view, to add a base class app dialog, to keep consistency for the app pause dialog and the app block dialog. The app uninstall dialog might be changed to inherit from app dialog as well, when the decision has been made for https://bugs.chromium.org/p/chromium/issues/detail?id=1010303 BUG=1035136 Change-Id: I2e5a17f75bce8f343d15ffa1b7e7b542ea433b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060433Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743393}
-
Mehran Mahmoudi authored
This implements the logic for the paint preview capture experiment. The experiment is behind a chrome flag that is disabled by default. Experiment doc: http://go/fdt-sample-experiment Bug: 1039810 Change-Id: I0b9db1ebe06d5b10da482ca1105c88d33afd1bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044064Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743392}
-
Kazuki Takise authored
This CL reverts https://crrev.com/c/1529500. The reason why we hid the auto-hide shelf at the time is that we didn't apply the collision detection logic to the PIP initial bounds and the auto-hide shelf could overlap with PIP. Now that we apply collision detection to the initial bounds, we can now revert this CL. Currently there are a few issues with PIP if the auto-hide shelf gets hidden when there's a single PIP window. - When you trigger PIP via minimize, the original window gets minimized first and the auto-hide shelf becomes shown, but soon after PIP shows up and the shelf becomes hidden again, which looks a bit weird. - When PIP gets shown, the auto-hide shelf is still visible and then it gets hidden, but the PIP window doesn't move to the bottom as at this point the gravity is "to the right". BUG=b:149889866 TEST=Manually confirmed the PIP interacts well with the auto-hide TEST=shelf. Change-Id: I643487b53b23931bdabd816a30c6337741d15fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065256Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#743391}
-
John Z Wu authored
CWVSyncController needs a way to unobserve signin::IdentityManager before its associated CWVWebViewConfiguration destroys its WebViewBrowserState. This avoids a DCHECK in the IdentityManager's observer list. Change-Id: I1a0d15bc4bc57a3cf1dd7fbc5a38bdb0adefad0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067472Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#743390}
-
John Budorick authored
crrev.com/c/2032038 revealed that android_browsertests are opening the NTP on initialization rather than about:blank. This caused issues w/ the switch from the old NTP to start surface, which doesn't have an associated WebContents. This CL instead always opens the initial tab in android_browsertests on about:blank, which should ensure that an actual Tab (and WebContents) are created regardless of whether we're using the NTP or start surface. Change-Id: I5a87e3093a5f78ea76179fe605b859df9dc3b193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065331 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743389}
-