- 04 Oct, 2016 40 commits
-
-
mef authored
BUG=650710 Review-Url: https://codereview.chromium.org/2389113003 Cr-Commit-Position: refs/heads/master@{#422918}
-
wangxianzhu authored
Previously we used containingBlock() as the default flipped blocks container in LayoutBox::topLeftLocation(). This was incorrect for table rows and table cells whose locations and topLeftLocations should be relative to the containing section. This fixes layout tests about table row/cells in vertical writing mode for slimmingPaintInvalidation. BUG=652392 Review-Url: https://codereview.chromium.org/2392503003 Cr-Commit-Position: refs/heads/master@{#422917}
-
panicker authored
BUG=635596 Review-Url: https://codereview.chromium.org/2390863002 Cr-Commit-Position: refs/heads/master@{#422916}
-
chongz authored
Key point of the implementation: * We want to apply 2 commands but only push 1 undo entry. Solution: 1. Introduce empty wrapper command |DragAndDropCommand| and apply first 2. Apply |DeleteSelectionCommand| for |deleteByDrag| 3. Apply |ReplaceSelectionCommand| for |insertFromDrop| The wrapper command in 1. won't create undo entry by itself, but will act as a catcher and combine the following 2 commands into a single undo entry. --- After CL behavior * Event order: (See [1]) 1. 'drop' 2. 'beforeinput' InputType=|deleteByDrag| 3. (DOM update for deletion) 4. 'input' InputType=|deleteByDrag| 5. 'beforeinput' InputType=|insertFromDrop| 6. (DOM update for insertion) 7. 'input' InputType=|insertFromDrop| 8. 'dragend' * Canceling 'beforeinput' will only prevent DOM update for current 'beforeinput', and won't affect remaining events. e.g. Cancelling 'deleteByDrag' won't affect 'insertFromDrop' * |dataTransfer| field: 1. NULL for |deleteByDrag| 2. Readonly |dataTransfer| for |insertFromDrop| * Undo entry: 1. Creates a single undo entry for Drag&Drop, if no JS-triggered DOM mutation happened in between 2. Otherwise creates 2 separate undo entries For more detailed behavior please refer to LayoutTest. [1] Event order for |deleteByDrag| and |insertFromDrop|: https://github.com/w3c/input-events/issues/24#issuecomment-249153755 Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ BUG=652393 Review-Url: https://codereview.chromium.org/2374743002 Cr-Commit-Position: refs/heads/master@{#422915}
-
enne authored
There's a race between page resize and devtools emulation disabling which can change the root layer transform scale. If a commit occurs after the page resize but before the scale, then layers end up picking the wrong scale, and if they have will-change on them then they will not change again after the root layer transform scale. This scale isn't really part of the page or under the author's control, and so will-change should be ignored when devtools changes the scale and content should always be rerastered and the ideal scale. This patch implements that behavior by plumbing a flag all the way from the devtools scale change to LayerTreeHost which then then resets the raster scale on all the picture layers after commit. BUG=630979 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2390923002 Cr-Commit-Position: refs/heads/master@{#422914}
-
junov authored
Follow-up to post-vommit comment in: https://codereview.chromium.org/2388293002/ TBR=senorblanco@chromium.org BUG=652126 Review-Url: https://codereview.chromium.org/2393493003 Cr-Commit-Position: refs/heads/master@{#422913}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/04593858..18233f57 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2397493002 Cr-Commit-Position: refs/heads/master@{#422912}
-
michaelpg authored
Whitelists the metricsPrivate.getIsCrashReportingEnabled() extension API function separately from the rest of the metricsPrivate API. This should prompt developers to get an OWNERS review for new usages of getIsCrashReportingEnabled(). It's implemented as a feature whitelist instead of a permission whitelist so that existing uses will continue to work. To that end, also whitelists all extensions that are already whitelisted for the metricsPrivate permission as a starting point. BUG=374199,647397 Review-Url: https://codereview.chromium.org/2387793002 Cr-Commit-Position: refs/heads/master@{#422911}
-
wnwen authored
For Android JellyBean and older, there was a bug in MappedByteBufferAdapter that caused ByteBuffer#rewind() to not be propagated to the underlying buffer, causing buffer underflow when the same buffer was read completely again to save the state. Fix is to manually read the buffer rather than rely on rewind/remaining. BUG=635744 Review-Url: https://codereview.chromium.org/2395493002 Cr-Commit-Position: refs/heads/master@{#422910}
-
isheriff authored
Fix a data race introduced by https://codereview.chromium.org/2378663006 BUG= Review-Url: https://codereview.chromium.org/2391093002 Cr-Commit-Position: refs/heads/master@{#422909}
-
tfarina authored
It's not something we want permanently set via about:flags. We'll enable it for debugging via net-internals. BUG=344544 TEST=passing --disable-async-dns to chrome does nothing anymore R=thestig@chromium.org,mmenke@chromium.org Review-Url: https://codereview.chromium.org/2388783003 Cr-Commit-Position: refs/heads/master@{#422908}
-
bsep authored
The border is drawn with a 1 DIP inset, so the overflow scroll indicators and item highlights also need to be inset by 1 DIP. BUG=635996 Review-Url: https://codereview.chromium.org/2387503002 Cr-Commit-Position: refs/heads/master@{#422907}
-
fdoray authored
This allows NativeMessageProcessHost to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Review-Url: https://codereview.chromium.org/2384163003 Cr-Commit-Position: refs/heads/master@{#422906}
-
kwiberg authored
Otherwise, argument-dependent lookup will (given that the proper set of headers are included at the same time) identify WebRTC's rtc::MakeCheckOpString as an alternative to logging::MakeCheckOpString if one of the function arguments are from the rtc:: namespace, making the call ambiguous. This was the reason why https://codereview.webrtc.org/2384693002 had to be reverted. Review-Url: https://codereview.chromium.org/2384263004 Cr-Commit-Position: refs/heads/master@{#422905}
-
dschuyler authored
This CL changes the direction of the back arrow in rtl languages. In ltr we go forward to the right and back to the left. That is reversed in rtl and this CL makes the icon match the language flow. BUG=586579 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2389123003 Cr-Commit-Position: refs/heads/master@{#422904}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9d498f565765..da2a4758cdc2 $ git log 9d498f565..da2a4758c --date=short --no-merges --format='%ad %ae %s' 2016-10-04 achuith Fix a bug in credentials parsing, add tests. 2016-10-04 petrcermak [tracing] Change breakdown view dimension upon pressing left/right arrows 2016-10-04 dproy Add a method to access renderer with largest pid BUG=651249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2391073002 Cr-Commit-Position: refs/heads/master@{#422903}
-
mgersh authored
Originally written by xunjieli in https://codereview.chromium.org/2360813003/. Review-Url: https://codereview.chromium.org/2393543003 Cr-Commit-Position: refs/heads/master@{#422902}
-
lukasza authored
Instead of storing borrowed pointer to TestRunner, WebFrameTestClient and WebViewTestClient can both obtain the same pointer via another (also borrowed) pointer they already have - one to WebViewTestProxyBase. Less fields to worry about (e.g. wrt lifetime management) is good. In the long-term we also should remove |delegate_| field from WebFrameTestClient (responsible for UaF in https://crbug.com/606594). BUG=595089 Review-Url: https://codereview.chromium.org/2386683002 Cr-Commit-Position: refs/heads/master@{#422901}
-
rockot authored
Straightforward conversion, no surprises. Also changes some (re-)initialization details of RPHI. Namely: * The mojom::RouteProvider and mojom::Renderer associated interface proxies are acquired immediately upon Channel creation, before pausing the Channel. This avoids an issue where one of these interface requests could be lazily acquired during Channel pause, blocking a subsequent message on that interface which should be sent immediately while the Channel is unpaused. See https://goo.gl/ot0S32 for some explanation of this behavior. * Any cached associated interface proxies are reset in ProcessDied() rather than Init(), per nasko@'s suggestion. This clarifies that they are per-process state. BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2383853003 Cr-Commit-Position: refs/heads/master@{#422900}
-
mcasas authored
This CL adds the said settings to the idl (capabilities and settings) and wires them through image_capture.mojom to its implementations in Fake and Linux/CrOs video capture device. BUG=650676 TEST= manually using [1] and a Logitech C920, result equivalent to e.g. guvcview. [1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture --use-fake-ui-for-media-stream https://rawgit.com/Miguelao/demos/master/imagecapture.html Review-Url: https://codereview.chromium.org/2387303002 Cr-Commit-Position: refs/heads/master@{#422899}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/779582280747..3fdf52cf389d $ git log 779582280..3fdf52cf3 --date=short --no-merges --format='%ad %ae %s' 2016-10-04 caryclark fix fuzz with null check 2016-10-04 mtklein Make all SkRasterPipeline stages stock stages in SkOpts. 2016-10-04 liyuqian Resubmit issue 2221103002 to fix the iOS build by declaring the flag in SkCommonFlags.h 2016-10-04 csmartdalton Move GPU fences into sk_gpu_test 2016-10-04 stephana Revert of Analytic AntiAlias for Convex Shapes (patchset #14 id:260001 of https://codereview.chromium.org/2221103002/ ) CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=stephana@google.com Review-Url: https://codereview.chromium.org/2390363002 Cr-Commit-Position: refs/heads/master@{#422898}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/14d67d35010e35c51029e9a6d1ff41f78d61c32a Add new chromium perf fyi bot chromium recipe builder (martiniss@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=639530 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2391103002 Cr-Commit-Position: refs/heads/master@{#422897}
-
dbeam authored
Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer how a user can change their default browser. R=dschuyler@chromium.org BUG=651720 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2382243003 Cr-Commit-Position: refs/heads/master@{#422896}
-
sebmarchand authored
BUG= Review-Url: https://codereview.chromium.org/2392553002 Cr-Commit-Position: refs/heads/master@{#422895}
-
ymalik authored
When a nested scroller is at its scroll bounds InputHandlerProxy gets another set of synthetic GestureScrollBegin/Update/End to scroll the parent scroller. Before this CL, deltaUnits was not copied in GestureScrollBegin but was copied in GestureScrollUpdate. As a result, InputHandlerProxy would expect an instant scroll after GestureScrollBegin, but perform a smooth scroll in GestureScrollUpdate. BUG=647205 Review-Url: https://codereview.chromium.org/2391643002 Cr-Commit-Position: refs/heads/master@{#422894}
-
estade authored
Set default width based on contents rather than hardcoding a value (which happened to be too small once we adjusted outer padding for the dialog). BUG=614317 Review-Url: https://codereview.chromium.org/2344703002 Cr-Commit-Position: refs/heads/master@{#422893}
-
jzern authored
https://chromium.googlesource.com/webm/libvpx.git/+log/691ef20272d3..50b9c467da77 $ git log 691ef2027..50b9c467d --date=short --no-merges --format='%ad %ae %s' 2016-10-01 jzern vpx_convolve8_neon,load/store*: correct param type 2016-10-01 martin Remove a stray END declaration in loopfilter_4_neon.asm 2016-09-29 jzern *idct*_neon.c: add missing rtcd include 2016-09-30 jzern idct,msa/neon: exclude idct files from hbd build 2016-09-30 linfengz Refactor vpx lpf NEON files (step 2/2) 2016-09-30 linfengz Refactor vpx lpf NEON files (step 1/2) 2016-09-29 jzern *rtcd_defs.pl: remove empty specialize calls 2016-09-29 jzern vp8,frame_buffers: remove unused use_frame_threads 2016-09-28 linfengz Unify loopfilter function names 2016-09-29 linfengz Refine vpx_convolve_copy_neon() and vpx_convolve_avg_neon() 2016-09-28 deepa.kg Fix an issue in vp9_first_pass for non-mulitple of 16 resolutions 2016-09-29 johannkoenig vp8: remove mmx functions 2016-09-29 johannkoenig Rename _xmm functions to _sse2 2016-09-29 johannkoenig Remove vp8_clear_system_state 2016-09-29 marpan vp9: On change_config() only call update_frame_size if needed. 2016-09-26 marpan vp9 real-time mode: Change loopfilter speed feature at speed 8. 2016-09-29 linfengz Refine vpx convolve8 NEON intrinsics optimization 2016-09-29 johannkoenig vpx_dsp: clean up rtcd 2016-09-29 johannkoenig vp8: clean up rtcd 2016-09-28 jzern vp9_detokenize,decode_coefs: fix signed int overflow (...) R=johannkoenig@google.com BUG= Review-Url: https://codereview.chromium.org/2397473002 Cr-Commit-Position: refs/heads/master@{#422892}
-
ianwen authored
In some locales we will set Sogou as default search engine. This CL adds a dialog to notify the users of such change. BUG=638062 Review-Url: https://codereview.chromium.org/2380133002 Cr-Commit-Position: refs/heads/master@{#422891}
-
robliao authored
This allows for the Browser Task Scheduler to setup and redirect after SetupFieldTrials to get variations data but before SetupMetrics, which posts tasks to the blocking pool. This harmonizes iOS with https://codereview.chromium.org/2342993002/ BUG=636518 Review-Url: https://codereview.chromium.org/2376123004 Cr-Commit-Position: refs/heads/master@{#422890}
-
cjgrant authored
BUG=41413 Review-Url: https://codereview.chromium.org/2392023002 Cr-Commit-Position: refs/heads/master@{#422889}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2385003002 Cr-Commit-Position: refs/heads/master@{#422888}
-
dmazzoni authored
When sending a message from the BrowserAccessibilityManagerAndroid to the render process to perform some accessibility action on a node, we need to send it to the right frame by calling the delegate function on the node's BrowserAccessibilityManager. We were incorrectly calling it on the current BrowserAccessibilityManager, which is only the same for elements in the root frame. BUG=562757 Review-Url: https://codereview.chromium.org/2395533002 Cr-Commit-Position: refs/heads/master@{#422887}
-
rnephew authored
The stories go to their respective sites and open a series of images and close them. Pinterest will also 'pin' every other image it clicks on. BUG=646392 Review-Url: https://codereview.chromium.org/2383883002 Cr-Commit-Position: refs/heads/master@{#422886}
-
bruthig authored
Removed Ash.AppList.TimeBetweenTaskSwitches and Ash.Tab.TimeBetweenSwitchToExistingTabUserActions histograms. These histograms are triggered in the chrome process but are actually recorded in ash (which is in a different process). This is problematic for the mus+ash refactoring and since there are no clear decisions being made from these metrics they are being removed. BUG=616581 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2390793002 Cr-Commit-Position: refs/heads/master@{#422885}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2395473002 Cr-Commit-Position: refs/heads/master@{#422884}
-
jam authored
This regressed in r420175 because a different code path is taken that doesn't go through browser_navigator.cc's CreateTargetContents. BUG=650349 Review-Url: https://codereview.chromium.org/2388803003 Cr-Commit-Position: refs/heads/master@{#422883}
-
mahmadi authored
BUG=630118 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2389043003 Cr-Commit-Position: refs/heads/master@{#422882}
-
lushnikov authored
The crrev.com/2384783003 introduced a regression where tabbedEditorContainer starts opening file for every created persistence binding. This patch fixes the issue. BUG=none R=pfeldman, dgozman Review-Url: https://codereview.chromium.org/2390333002 Cr-Commit-Position: refs/heads/master@{#422881}
-
dsinclair authored
This Cl adds the test case for the case sensitivity of getEntriesByType and getEntriesByName. BUG=chromium:651507 Review-Url: https://codereview.chromium.org/2393633002 Cr-Commit-Position: refs/heads/master@{#422880}
-
dpapad authored
BUG=651513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2393463002 Cr-Commit-Position: refs/heads/master@{#422879}
-