- 07 Dec, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607285417-319fac9cd61d6e3a5b6b6bda38f6eeeb3d5cb0d0.profdata to chrome-win64-master-1607309475-be47e6675d78a40c2743c701a82c248ac3d955c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0dffa347c95babfc5b3db6dd944f151264a035f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834137}
-
Nidhi Jaju authored
Based on https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/19136/overview, there is an error when downcasting the reader in readable_stream_generic_reader.cc:131. This CL just removes the cast as it is unnecessary. Bug: 614302 Change-Id: Icf426cb630e209ee04556477da1c7620084b1a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576064Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#834136}
-
Joel Hockey authored
Bug: 953310 Change-Id: I3bbe48e5aad77b1ba702a713a26f444bed491e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574116 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#834135}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d67df01dcf3a..aa443a8cce7c 2020-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bae138de13ac to 7c84426d2abe (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I30ba6e072a71f02e9427e5a7354a4517086a4cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575733Reviewed-by:
-
Alexey Baskakov authored
This reverts commit 2d41c395. Reason for revert: Failed tests on Wim7 builder https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/111291/overview Original change's description: > Reland "[FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle." > > This is a reland of 00437792 > > The main difference is to make sure iterating over a directory doesn't > return files we don't want to expose either (and not CHECK failing if > such files are found when iterating). > > Original change's description: > > [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle. > > > > This isn't directly using net::IsSafePortablePathComponent since what > > is safe for the File System Access API is not the same as what is safe > > for Downloads. As such currently this duplicates a lot of the > > implementation of this method, but in a followup we should attempt to > > unify these two implementations as much as possible. > > > > Bug: 1150810, 1154757 > > Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383 > > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: Victor Costan <pwnall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833042} > > Bug: 1150810 > Bug: 1154757 > Change-Id: I3341b9824a1ac4cbd6f100355960ad55b01f0753 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575370 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834118} TBR=mek@chromium.org,pwnall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I4cf610510109c47f62c59921fbe95a78b098a1a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150810 Bug: 1154757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576223Reviewed-by:
-
Asami Doi authored
This CL adds a new state `WARN_NOT_OFFLINE_CAPABLE` and show a warning message to developer console to tell new criteria for offline detection will be enforced after M93. Bug: 965802 Change-Id: Iced93f8194ba1dea43b2bd5de419b053dec2f323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567057 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#834132}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e602c60a2b59..55e9ddf21994 2020-12-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I053f914ad39ab3fb4f2c5f4f8bd6ade1bd34f89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575732Reviewed-by:
-
Nidhi Jaju authored
Following a recent addition to the Streams spec in https://github.com/whatwg/streams/pull/1095, this CL adds reader type assertions to the beginning of several ReadableStream abstract operations that are only called with one particular type of reader. This includes: - ReadableStreamFulfillReadIntoRequest - ReadableStreamFulfillReadRequest - ReadableStreamGetNumReadIntoRequests - ReadableStreamGetNumReadRequests Bug: 614302 Change-Id: I1da9105f0ba6c7e494945befb6859fc3242f67df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576661Reviewed-by:
-
Nidhi Jaju authored
This CL adds a new WPT for the case that a ReadableStream with a byte source is constructed with a start algorithm that throws an error, which was not previously tested. Bug: 614302 Change-Id: Ib3d10fbff7aefe5422d02badfab4d47434463711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574042 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
-
Hirokazu Honda authored
Video::Decode() decodes compressed videos and fills decoded frames to the buffer. Originally, the plane size of filled frames is computed by VideoFrame::PlaneSize().GetArea(). However, this aligns resolutions by two and thus the computed plane size is not the succinct area. For instance, when a resolution is 641x361, PlaneSize().GetArea() returns 232404=642x362 for the first plane, but the test demands a plane size is 231401=641x361. This CL fixes the mismatch. This enables video_encode_accelerator_tests to run odd resolution videos. Bug: b:174318867 Test: video_encode_accelerator_tests crowd-641x361.vp9.webm --codec=vp9 on atlas Change-Id: I5d2d9fa31ae838abd501e60e19509d667f70821c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563186 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#834128}
-
Tal Pressman authored
Change-Id: If603d2878bc1cd0ee9b333f5b653361adcac33e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575781Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#834127}
-
Hirokazu Honda authored
This adds NV12Dmabuf cropping test case, where the visible rectangle of fed VideoFrames to an encoder doesn't start with (0, 0). Bug: b:174318867, b:172210338 Test: video_encode_accelerator_tests --gtest_also_run_disabled_tests on atlas Change-Id: I1361011344a685484bb7098e0f3507dc8014b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563391 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hayato Ito authored
The WebBundle subresource loading POC CL is https://crrev.com/c/2503068. This CL is a part of the POC, focusing only on updating URLRequest and other related types so we can land this CL separately. The design doc: https://docs.google.com/document/d/1_AqUBS4Gr45MPPtXGTUl7Q0DMIEw2zUeWO0zo6Sj0z4/edit#heading=h.5g0nmaz8ctg This CL itself is no-op; no one is using the added fields. Follow-up CLs will use the added fields. Bug: 1082020 Change-Id: I0475aa37d935997bb9487a1705100c4fc6cc0fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560526Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#834125}
-
Eric Willigers authored
We now match wildcards like */* and image/* against specific content types like image/png Bug: 1153537 Change-Id: Ic0f5dc64ed92b71cd57c31b550f1330dc4acad96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569195 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#834124}
-
Alexey Baskakov authored
This reverts commit 0b7367ff. Reason for revert: A culprit CL which might break NTP tests here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26482/overview Original change's description: > [ntp][modules] Add shopping module fieldtrial_testing_config.json > > Bug: 1110075 > Change-Id: I735506c3e0efff1f92582498400bea0a914cf215 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566374 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833561} TBR=mahmadi@chromium.org,tiborg@chromium.org,caitlinfischer@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110075 Change-Id: I865c3885224e08eaf1abbd0a0afab690fe5f1449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576065Reviewed-by:
-
Leo Zhang authored
These codes are not used. BUG=b/162559903 TEST=build local chrome Change-Id: Ie0cb1f8c634ab3dbcc2f8873e2f2337ec6168738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573898Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#834122}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/48576261660b..d4a2ec641899 2020-12-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I928d11147d8396b9817e62e19498ac1156eb762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576421Reviewed-by:
-
Kent Tamura authored
The flag will change the following behaviors: - Remove the workaround for <summary> display:list-item - Add a deprecation message for ::-webkit-details-marker - HTMLDetailsElement adds the default style for a shadow <summary>. - HTMLSummaryElement doesn't add a shadow element for ::-webkit-details-marker. - LayoutTheme adds additional style for "details > summary:first-of-type". Also, this CL removes the following code: - kSummaryElementWithDisplayBlockAuthorRule counter - kCSSSelectorPseudoWebKitDetailsMarker counter This CL has no user-visible behavior changes yet. Bug: 590014 Change-Id: I71dad46c84ba79a866696d53a10d4b292cd100ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576660 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#834120}
-
Kent Tamura authored
This CL merged details-add-summary-*.html into a single reference test. This CL has no behavior changes. Change-Id: Id12480c924d00bd29c8a1f1794b6d5f02dd02eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574642 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This is a reland of 00437792 The main difference is to make sure iterating over a directory doesn't return files we don't want to expose either (and not CHECK failing if such files are found when iterating). Original change's description: > [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle. > > This isn't directly using net::IsSafePortablePathComponent since what > is safe for the File System Access API is not the same as what is safe > for Downloads. As such currently this duplicates a lot of the > implementation of this method, but in a followup we should attempt to > unify these two implementations as much as possible. > > Bug: 1150810, 1154757 > Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833042} Bug: 1150810 Bug: 1154757 Change-Id: I3341b9824a1ac4cbd6f100355960ad55b01f0753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575370 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834118}
-
Harvey Yang authored
As we may retry up to 50 times of the initialization in AccelerometerFileReader, this commit shows only the first log of empty directory of /dev/cros-ec-accel and missing Accelerometer trigger. BUG=none TEST=run on octopus Change-Id: Idac9846b1c022ca4658f73b218f68900f4f633d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569501Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834117}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I42751fa035d3af6e4689ac889fd9151d38ea5908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574605Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834116}
-
adafang@google.com authored
Added a space to the end of a string so when concatenated the words are not directly joined. Change-Id: Ia8d80398ad97fd1c45323faaf3e6b66c29020f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576720Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Ada Fang <adafang@google.com> Cr-Commit-Position: refs/heads/master@{#834115}
-
Eric Willigers authored
We generate a POST request from the share intent. Spec: https://w3c.github.io/web-share-target/level-2/ On Chrome OS, only one file type may be shared at a time. Note that sharing title/text/url is not yet supported. Bug: 1125880 Change-Id: I4aa2a0b887bbb208bf33fdef849b970d72bf1e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560080 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#834114}
-
Rakina Zata Amni authored
VerifyThatBrowserAndRendererCalculatedDidCommitParamsMatch currently has DumpWithoutCrashing, which doesn't always fail tests if browser & renderer-calculated DidCommitParams don't match. This CL adds DCHECKS so that tests will fail in that case, and update unit tests to adhere to this (and remove parts we don't need anymore) Bug: 1155414, 1154753, 1131832 Change-Id: I7163bdd691db298c472462c27e6cdd2897a06c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570751Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#834113}
-
Nidhi Jaju authored
This CL adds a new WPT for the case that a ReadableStream with a byte source, and hence a ReadableByteStreamController is constructed, with autoAllocateChunkSize: 0. This should throw a Type Error because autoAllocateChunkSize cannot be 0, and should rather be positive. Bug: 614302 Change-Id: Iea15e4730f4965d52ff5c68367ba6212d5eca089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569490 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
-
John Palmer authored
Will replace right-click-> Emoji for Physical keyboard users with new emoji picker. BUG=1152237 Change-Id: Ife087bba8d4c52d38cc543cf77a93e6e47221301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546342 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834111}
-
Jiewei Qian authored
ChromeLauncherController may be created with a nullptr profile. In this case, the profile is resolved to the current active profile. SettingsWindowManager should wait for profile resolution before checking if the profile uses legacy settings window. Change-Id: Ia8c16f35387a6f328f611a8810e54118ac1a2b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567845Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#834110}
-
Keishi Hattori authored
When Navigate() calls ShowSingletonTabOverwritingNTP(), the std::move(*params) is executed before params->browser is passed as an argument. This becomes a problem when we use BackupRefPtr for NavigateParams::browser. Because BackupRefPtr will clear when moved so ShowSingletonTabOverwritingNTP will receive a nullptr. Bug: 1080832 Change-Id: Id26f41e128b9c79d2506ac82e3655d1fdb58f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567279Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834109}
-
Keishi Hattori authored
When BackupRefPtr is used for WebUIImpl::web_contents_, the destruction order of the fields causes a null dereference. This is because BackupRefPtr is cleared in the destructor. The destructor of WebUIMessageHandler subclasses are accessing the WebContentsImpl through WebUIImpl::web_contents_. Bug: 1080832 Change-Id: I24570aad42dbd09febd94ef6d25be31c9817c091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564979Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit 5ab6138e. Reason for revert: Due by http://crbug.com/1154761 Original change's description: > Utilize EphemeralRange::IsCollapsed() in ComputeAdjustedSelection() > > This patch makes |ComputeAdjustedSelection()| to utilize |IsCollapsed()| > of |EphemeralRange|[1] to simplify source code for improving code health. > > Note: This patch doesn't change behavior. > > [1] http://crrev.com/c/2550834: [editing] Ranges with equivalent positions > should be collapsed > > Change-Id: Iab464fafb0f02f90d346bc1cbc0a2734d6744138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567146 > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832722} # Not skipping CQ checks because original CL landed > 1 day ago. TBR=yosin@chromium.org Change-Id: Ifa4fe1a3e27ef78858123b0027cab2f59a1cca48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576063 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834107}
-
Alexey Baskakov authored
This reverts commit f8a44173. Reason for revert: Breaks browser tests here https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/6369/overview Original change's description: > Adding more navigation-like fields to search prefetch requests > > This CL adds a few fields to the search prefetch resource request to > make it more similar to a navigation request. Additionally, this adds > capability for URLLoader throttles to defer (in this case cancel) or > change headers on the prefetch request allowing things like variation > headers to be added more similarly to how navigation requests have them > added. > > Client hints CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2551671 > > Bug: 1138648 > Change-Id: Ia868aa624b2f9f573a54432eb0fa62834eacd2f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552723 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833987} TBR=kinuko@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1138648 Change-Id: I7077c0f73dbc60ddd5541caed7c1a91adf04b208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574640Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#834106}
-
Yuly Novikov authored
With Ubuntu 18.04.5. Also focus Linux FYI Release (Intel UHD 630) on this version. And try re-enabling tab_capture_end2end_tests on this OS version. TBR=bsheedy Bug: 1153159 Change-Id: I255bb6b221278253213c8a4504e387360250661b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575348Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#834105}
-
Alan Cutter authored
This CL adds a DesktopPWAsElideExtensionsMenu flag to Chrome. This is in preparation for moving the Extensions "puzzle piece" icon out of web app window title bars and replace it with an entry in the app menu. Bug: 1155421 Change-Id: Idc780e77334591e1099e00dda51e20ceed488f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573842 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#834104}
-
Changwan Ryu authored
Bug: 1094366 Change-Id: I6774cc67767b7decc3aa04cf32a81190a9e3f288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392745Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834103}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607274992-2974a9a4282254902cff6a65cece32eb62bb49c4.profdata to chrome-linux-master-1607296838-726b11db44d1999a156b631ebee4ad43068bfed6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie5d52a7165d7d19a76fbd0ee1a3b0db51b403966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576578Reviewed-by:
-
Rakina Zata Amni authored
The RFH accessed in a DCHECK might be null if the navigation never reached the ReadyToCommitNavigation state. This CL updates the check added in https://chromium-review.googlesource.com/c/chromium/src/+/2569637 to be clearer. Bug: 1133115 Change-Id: I9e4fcc6f239a6e69e855f7abd56b74a3b2cad0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574118Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#834101}
-
Alexey Baskakov authored
This reverts commit 9771027b. Reason for revert: Breaks ash_unittests on ASAN bots (use after free) https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39004/overview Original change's description: > desks: Fix crash when touchpad swipe with external monitors. > > The crash was because a new screenshot is requested when the current > screenshot is about to get scrolled out of bounds. It was using a fixed > number threshold, meaning displays that are not the same size could > get out of sync easily, leading to a CHECK failure. > > This CL addresses that by requesting screenshot on all displays if even > one of them needs one. Another approach would be change the spacing and > threshold to be based on the display width instead of fixed number, but > that could be prone to roundoff error which may cause a similar issue. > > Also noticed visible desk metric was double counting when there are > multiple displays. Added a TODO for that one as it is lower priority. > > Bug: 1154868 > Test: manual, added regression test > Change-Id: I48f5ef62d3284b710f44a2808f75c95686bc9b3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570551 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833993} TBR=afakhry@chromium.org,sammiequon@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1154868 Change-Id: I23cf043d8bc4ae5c9ed8531429b9ffcee43224e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575778Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607274992-5f60b37d32a0de70e3a3f8971d87b0de74f1a94e.profdata to chrome-mac-master-1607296838-983fc71424be447753e5e41dabd44a4fead37886.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1cbac97a3ae2431397dab042982355edaf3bc728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576757Reviewed-by:
-
Jie Jiang authored
The new added metric shows the time diff for detecting an L2 connectivity issue between the two link monitors. CrOS patch to emit the metric: https://crrev.com/c/2439961 BUG=b:162194516 TEST=See the TEST line in CrOS patch Change-Id: I9b1cb421f2d0c0accd3e151d006cad254d4289a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462753 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#834098}
-
