- 29 Jan, 2018 40 commits
-
-
Christopher Cameron authored
On Mac, the browser's ui::Compositor is always the same size as the renderer's ui::Compositor. In non-viz and non-surface-sync mode, this is done by resizing the ui::Compositor to match the renderer frame size at SubmitCompositorFrame. This isn't suitable anymore, since SubmitCompositorFrame is going away. Change this so that the ui::Compositor is resized to match the surface size, at OnFirstSurfaceActivation. Add a method to DelegatedFrameHostClient to plumb this signal through to the BrowserCompositorViewMac. Also rename WasResized to OnNSViewWasResized, to be more clear. This mechanism works with and without surface synchronization enabled. Bug: 805774 Change-Id: I7a85b2e4eba8c962ef1c67446b38425637fdeb62 Reviewed-on: https://chromium-review.googlesource.com/887966 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532351}
-
Nico Weber authored
R=alancutter@chromium.org Change-Id: Ic7b6bda1eb48346cb0f2f5f285f458023d8eb798 Reviewed-on: https://chromium-review.googlesource.com/889764Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#532350}
-
Tetsui Ohkubo authored
MessageListView::SetRepositionTargetForTest just calls SetRepositionTarget internally. We can simply replace all references to SetRepositionTargetForTest by SetRepositionTarget. TEST=ash_unittests BUG=none Change-Id: I3294e2cce6d995585baed3a0ce29dd068e656b20 Reviewed-on: https://chromium-review.googlesource.com/882629 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#532349}
-
Philip Jägenstedt authored
This is a no-op change that makes it easier to later remove them. The copyright license is required to pass presubmit. Bug: 690582 Change-Id: I8f4074102dff3ef87b35d239f06ce2c93246d88d Reviewed-on: https://chromium-review.googlesource.com/693861Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#532348}
-
Takayoshi Kochi authored
This reverts commit 9784fa2f. Reason for revert: crbug.com/806216, potential cause for CSS perf regression (and 3/5-5/5 were already reverted due to crbug.com/805383 and have not relanded). Original change's description: > Remove dead code after multiple shadow removal [2/5] > > Remove > - ElementShadow::YoungestShadowRoot() > - ElementShadow::OldestShadowRoot() > > TBR=mlamouri@chromium.org for media_controls > > Bug: 795221 > Change-Id: I391b737acf04b45978ab1474725314442c979a06 > Reviewed-on: https://chromium-review.googlesource.com/828344 > Commit-Queue: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531452} TBR=kochi@chromium.org,hayato@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 795221, 806216 Change-Id: I123f9da565b8b43cbb808d613c35171321b76c49 Reviewed-on: https://chromium-review.googlesource.com/890842 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532347}
-
Yuzu Saijo authored
This CL moves www.infomoney.br into resource_loading_list because it loads resources continuously, which leads to flakiness. Change-Id: Ib6c974ef3569965aef777f72afe268aa6fc00c73 Reviewed-on: https://chromium-review.googlesource.com/890692Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#532346}
-
Megumi Hattori authored
This CL enable the reply button on the right of the textfield in the inline reply. So, the message in the textfield can be submitted not only by pressing enter key but also clicking the reply button. TEST=message_center_unittests Bug=803759 Change-Id: I6e7518d0fabd329d52d589b2024357869aca2fa2 Reviewed-on: https://chromium-review.googlesource.com/885693 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#532345}
-
Makoto Shimazu authored
This reverts commit b6486594. Reason for revert: speculative revert for fixing browser_tests failure on Win (32) Tests bot. ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked started to fail continuously after the CL. I'm not fully confident of the relationship between the failure and this change, but trying to revert to see if it helps. Original change's description: > Use SCANOUT_* usage in GpuMemoryBufferVideoFramePool > > Currently GpuMemoryBufferVideoFramePool allocates buffers with > GPU_READ_CPU_READ_WRITE usage. This means these buffers won't be used for > scanout (no fb added on CrOS). > > This CL simply changes the usage used when allocating buffers to > SCANOUT_CPU_READ_WRITE, in this way this buffers will be created for > scanout, if possible. > > Note that SCANOUT implies GPU_READ, meaning that in case the allocation > of the buffer for scanout will fail, the buffers will be allocated > exactly as they'd be if GPU_READ_CPU_READ_WRITE were used instead. > > Bug: b/71837407 > Change-Id: I3a03daf721f1cc04038a4f6f91985b5affe2a276 > Reviewed-on: https://chromium-review.googlesource.com/884401 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532286} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org,ddavenport@chromium.org Change-Id: I13c479543ac53694f6f413c83aa15481e9c80c53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/71837407 Reviewed-on: https://chromium-review.googlesource.com/890978Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532344}
-
nikhil authored
Fixing names of password_manager kEnableHtmlBasedUsernameDetector feature as per the naming convention. Bug: 785953 Change-Id: I8818a2e2335d9a651d02ab9925bd7e4987a661a3 Reviewed-on: https://chromium-review.googlesource.com/878101 Commit-Queue: NIKHIL SAHNI <nikhil.sahni@samsung.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532343}
-
Ricky Liang authored
BUG=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib3c36ecb62f932b0aa03752732b02f745014e6ea Reviewed-on: https://chromium-review.googlesource.com/890881Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532342}
-
tanvir.rizvi authored
InsertOrderList command creates a numbered ordered list for the selection. We try to restore the original selection by storing the index of the original start and end positions. There are cases where after list command is applied the index changes, causing wrong selection shown. This CL tries to fix those cases by introducing a TextIteratorBehavior, which suppresses the extra new line added for a <p> tag. Bug: 345935 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8019f6176f859f4d2c19030e08e1836b1f05a27d Reviewed-on: https://chromium-review.googlesource.com/850252 Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532341}
-
Makoto Shimazu authored
This reverts commit c70ba0e8. Reason for revert: The original CL caused failures of AnimationPlayerTest.SwitchToLayer on Linux CFI bot. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AnimationPlayerTest.SwitchToLayer&testType=cc_unittests Original change's description: > Group effects support in cc::AnimationPlayer > > The current cc/animations logic assumes a single animation has a single > keyframe effect and can only affect a single layer. To enable animations > with multiple keyframe effects, cc::AnimationPlayer need to support > multiple AnimationTickers each corresponding to one keyframe effect. > > Currently there is a 1:1 relationship between AnimationPlayer and > AnimationTicker. This patch is to extend it to 1:n. Here is a summary of > changes: > - Introduce a sub-class of AnimationPlayer, a.k.a > SingleTickerAnimationPlayer, to handle the existing logic (single > effect). SingleTickerAnimationPlayer owns only one AnimationTicker as > the AnimationPlayer does today. > - Currently a AnimationTicker is created upon creating AnimationPlayer. > In this patch, tickers are created separately and added to the player > afterwards. Tickers that the player owns may belong to different targets > therefore the player needs to coordinate with AnimationHost regarding > this situation. > - Adjust existing unit tests according to the changes above. > > Bug: 767043 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: Ibd2ed2f396effec9fbc206ff52c7b94474342d39 > Reviewed-on: https://chromium-review.googlesource.com/742162 > Commit-Queue: Yi Gu <yigu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532244} TBR=vollick@chromium.org,flackr@chromium.org,majidvp@chromium.org,yigu@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767043 Change-Id: I7547dfad1e8835d1218b2c704ba1ee69a09544a8 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/890918Reviewed-by:
-
Matt Falkenhagen authored
This uses promise_test for each test case instead of an all-or-nothing result, which makes the test easier to extend and debug. It also adds more explanatory comments. R=horo, shimazu Bug: 780435 Change-Id: I3ac77448cd19e66b9db806e6b8b5530857713c6c Reviewed-on: https://chromium-review.googlesource.com/890694 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#532339}
-
Nico Weber authored
This CL was uploaded by git cl split. R=kouhei@chromium.org Bug: 177475 Change-Id: I09a969c86b5250e6104caf8b0d7ba1672425a8d3 Reviewed-on: https://chromium-review.googlesource.com/889945 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#532338}
-
Hajime Hoshi authored
Now it is assured that all the tasks in a task runner are executed before the task runner is deleted, it is no longer needed to set the default timer task runner when shutting down the document. This is part of efforts to replace non-per-frame task runners with other appropriate per-frame task runners in the renderer. Bug: 804694 Change-Id: I03150b0412df185f2d61abfd8dcab44bfbdc2a12 Reviewed-on: https://chromium-review.googlesource.com/885691Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532337}
-
Hwanseung Lee authored
values attribute should be immutable to prevent cyclic references in CSSMathMax, CSSMathMin, CSSMathProduct, CSSMathSum. Bug: 803687 Change-Id: Ibb93165ffd7a279a80febba0543ac186b67dbe56 Reviewed-on: https://chromium-review.googlesource.com/890558Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532336}
-
Rune Lillesveen authored
According to the css-scoping spec, ::slotted() matches flattened slotables. Slot elements which are assigned to other slots are not part of the flattened slotables. The test currently fails because slots are not included in the flat tree. Bug: 660265 Change-Id: Ifbcb03d3212db59d762d173a221382ed79ccbd0e Reviewed-on: https://chromium-review.googlesource.com/887950Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#532335}
-
Takuto Ikuta authored
-g0 flag reduces size of some large test files * components_unittests from 918MB to 206MB * unit_tests from 1023MB to 258MB with args.gn of linux_chromium_rel_ng. Current linux buildbot is GCE VM running with 500GB persistent disk which has 60MB/s write throughput. https://cloud.google.com/compute/docs/disks/#introduction This IOPS limit affects link step necessary to write large binaries on buildbot. This patch is for speed up link by reducing binary size written to disk on buildbot. I assumed followings for symbol configs * no_symbols: no guarantee of amount of symbol. * minimal_symbols: include symbols to show function name in stack trace. * symbols: include symbols used for debugger. ## FAQ - Does this keep symbols, function name, file path and line number necessary for stacktrace? Partially yes. Symbols for function is stored in symbol table, which are not removed unless we pass -Wl,--strip-all to linker. File path and line number of function are not shown in stack trace when unittests crashes, but it is true even when we use is_debug=true and symbol_level=2. File path and line number have been shown only for detected failure in lsan/asan builder. https://clang.llvm.org/docs/ThreadSanitizer.html#usage - How much amount binary size is reduced? Without this patch, building all generates 65GB binary. $ ls -aSl out/linux_chromium_rel_ng/ | tail -n +1 | awk '{sum += $5}END{print sum/1024/1024 "MB"}' 65673.4MB With -g0, building all generates 14GB binary. $ ls -aSl out/linux_chromium_rel_ng/ | tail -n +1 | awk '{sum += $5}END{print sum/1024/1024 "MB"}' 14602MB - How fast link step will be? I show some ninja traces for link time comparison ninja build trace shows that this flag improves link time of some large binaries. trace from this patch: https://chromium-build-stats.appspot.com/ninja_log/2018/01/25/slave645-c4/ninja_log.slave645-c4.chrome-bot.20180125-034227.4651.gz/trace.html - taken from https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/630949 https://chromium-build-stats.appspot.com/ninja_log/2018/01/24/slave287-c4/ninja_log.slave287-c4.chrome-bot.20180123-214259.6113.gz/trace.html - taken from https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/630946 https://chromium-build-stats.appspot.com/ninja_log/2018/01/24/slave182-c4/ninja_log.slave182-c4.chrome-bot.20180123-213611.16740.gz/trace.html I estimate this CL reduces the duration of link time from around 400s to 100s on linux_chromium_rel_ng. Bug: 794423 Change-Id: Id840df30b90e3ac177004edb5c1673a6d8e9b3ca Reviewed-on: https://chromium-review.googlesource.com/826842 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532334}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4a49068fafa8..ba3ed69a4ee4 $ git log 4a49068fa..ba3ed69a4 --date=short --no-merges --format='%ad %ae %s' 2018-01-28 fmalita [skottie] Cache attached assets Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ie80e102f9fe57959087a2d14b1c7107e188d4167 Reviewed-on: https://chromium-review.googlesource.com/890723 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532333}
-
Makoto Shimazu authored
This reverts commit 22e3eede. Reason for revert: This change looks causing failures on Mac ASan 64 bot. Original change's description: > Add MacMDDownloadShelf to fieldtrial_testing_config.json > > Change-Id: I00799bf180fc94b3a8b30e0a77bdc7473cf58ca4 > Bug: 589943 > Reviewed-on: https://chromium-review.googlesource.com/887385 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532044} TBR=isherman@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 589943 Change-Id: Id1a2fbef9c06dcd035e30974ab0da18cb9021377 Reviewed-on: https://chromium-review.googlesource.com/890840Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=dtapuska@chromium.org Bug: 177475 Change-Id: I2c3ed9b3cbab13e6f120cf542119fc9005490bc7 Reviewed-on: https://chromium-review.googlesource.com/890005 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#532331}
-
Zhuoyu Qian authored
InputType not inherit InputTypeView after CL(crrev.com/1913133002), this FIXME is not needed, remove it. BUG= R=tkent@chromium.org Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ifb38d529082a126d582702d6b64ca24a0a3d587d Reviewed-on: https://chromium-review.googlesource.com/886205Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#532330}
-
Adam Rice authored
Test handshake throttling from layout tests. This involves adding a test-specific throttle, content::TestWebSocketHandshakeThrottle, which is used when the --run-layout-tests option is supplied. It looks for a content-shell-websocket-delay-ms query parameter in the WebSocket URL and applies the specified delay if it exists. As a result it does not interfere with other tests. Includes a regression test for crbug.com/786776. This verifies that a message sent by the server is delivered even when the open is delayed by throttling. BUG=786776 Change-Id: If8b2be86ac617d037bc1ee0059512b5d950a313d Reviewed-on: https://chromium-review.googlesource.com/867806 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#532329}
-
Makoto Shimazu authored
This reverts commit 1423331f. Reason for revert: speculative attempt due to unhappy MSan ChromiumOS bot. See also crbug.com/806638. Original change's description: > mus: Fix event processing for touch events in unified mode > > This refines my earlier work done in: http://crrev.com/c/842467 > > Move event target nulling and root location use to WindowTreeClient, to ensure events reach MusUnifiedEventTargeter. > Otherwise, WindowEventDispatcher::GetInitialEventTarget will use the touch gesture recognizer's target (returned by GetPriorityTargetInRootWindow) before performing the mirror display transformation on the event's location. > > Inline DispatchEventToTarget for additional clarity. > > Bug: 805714 > Test: Mus touch events work in Chrome OS's unified desktop mode. > Change-Id: Ic4844c85cc24a9f9885e7705ff27cb57b305d245 > Reviewed-on: https://chromium-review.googlesource.com/887250 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532030} TBR=sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805714 Change-Id: I02333546f91d0d0f495153c8556aa9820612673d Reviewed-on: https://chromium-review.googlesource.com/890841Reviewed-by:
-
Yuzu Saijo authored
This CL adds a new trybot to mb_config. Change-Id: I3947f570e393ac01c01eaf2aef8ef2e6fc7ed2f8 Reviewed-on: https://chromium-review.googlesource.com/885381Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#532327}
-
Matt Falkenhagen authored
This can be simplified since PlzNavigate shipped. Follow-up to r528894. Change-Id: Ib8044a689882456c519fc522d96846e6572f7abb Reviewed-on: https://chromium-review.googlesource.com/890678Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/e76240044631..d1434c048145 $ git log e76240044..d1434c048 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 jmadill Revert "Use ImmutableString for HLSL texture references" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I687bf0d075b9d1549196d5dc0f6447b9de7db9aa Reviewed-on: https://chromium-review.googlesource.com/889937Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532325}
-
Sasha Bermeister authored
* Move QuotaDispatcher from content/ to blink/ (and adds a TODO for it to be removed altogether) * Change the lifetime of QuotaDispatcher to be a supplement per ExecutionContext, rather than a thread global * Move QuotaDispatcherHost to be per-frame/worker rather than per-process (moving it from RenderProcessHost to RendererInterfaceBinders and RenderFrameHostImpl, with a TODO to move it to just RenderInterfaceBinders - see crbug.com/775792). This is pre-work to remove the |origin| parameter (although this is blocked on a race condition, see crbug.com/595685#c26). * Remove QueryStorageUsageAndQuota() and RequestStorageQuota() from the public APIs (Platform and WebFrameClient, respectively). * Remove render_frame_id from the QuotaDispatcherHost mojo, getting it directly from the RenderProcessHost instead * Add DEPS rule to allow mojo includes from Source/modules/quota * Remove QuotaDispatcher and StorageQuotaClient Bug: 781643 Change-Id: Id8b36ebf67fd19b2949ef7ba045c2c0225dac376 Reviewed-on: https://chromium-review.googlesource.com/851592Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532324}
-
Jaebaek Seo authored
Previously, --use-zoom-for-dsf check (enabled/disabled) was done by IsUseZoomForDSFEnabled() in content/common/content_switches_internal.h, but it cannot be used for AndroidWebview. crrev.com/c/773924 added UseZoomForDSFEnabled() to content/public/common/use_zoom_for_dsf_policy.h in order to overcome this limitation. To get rid of the duplicated same function, this CL removes the one in content/common/content_switches_internal.h and changes the name of the one in content/public/common/use_zoom_for_dsf_policy.h as IsUseZoomForDSFEnabled(). Bug: 737777 Change-Id: I68640f3d506fa53c041d188796bdf8bc1223cdb4 Reviewed-on: https://chromium-review.googlesource.com/885162 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532323}
-
Yuri Wiitala authored
This reverts commit 52c31b74, to re-land the original CL (https://chromium-review.googlesource.com/884996). The viz_content_browsertests were failing because of a bug in the posix shmem impl (in base/memory/shared_memory_helper.cc) when the pool is being run in the VIZ process. For now, the tests have been added to the viz_content_browsertests filter file; and once the root-cause issue has been resolved, they can be re-enabled. TBR=xjz@chromium.org,kylechar@chromium.org Bug: 806635, 785072, 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0f419ce2aee170a0fbd966ff8e10bb99c3b7067f Reviewed-on: https://chromium-review.googlesource.com/889934 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532322}
-
Makoto Shimazu authored
This reverts commit 734de963. Reason for revert: This looks causing a failure in MSan bots. See also https://crbug.com/806634. Original change's description: > Make PUSH_PROMISE headers URL-parsing more robust and conform to HTTP/2 spec. > > Change-Id: If94561f453bbc56b86238918d374baf8c2254646 > Reviewed-on: https://chromium-review.googlesource.com/887970 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532202} TBR=rch@chromium.org,wangyix@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I210f101bfa5c43a238f2a21e8a9c513731c877dd Reviewed-on: https://chromium-review.googlesource.com/890838Reviewed-by:
-
Nico Weber authored
Fixes a bug where GetDataFormat() would return the wrong thing for GL_SHORT and GL_RGB_INTEGER. This CL was uploaded by git cl split. R=jbroman@chromium.org Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I452c81dec7e65d6daa4231091cc734aefe34c040 Reviewed-on: https://chromium-review.googlesource.com/889733Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532320}
-
Ian Kilpatrick authored
This adds the ability for display to accept two new functions layout() and inline-layout(). I was careful to keep the bits for all the typical display types on the ComputedStyleBase object, hence the display property now is a primitive type. The name of the custom layout is defined as an extra field. As a result of this split, (display now not just accepting a keyword) the display property doesn't use as much auto generated code now. I.e. EDisplay is not automatically generated. Currently inline-layout(foo) isn't to spec, as there needs to be separate work to change display into a two keyword longhand property. I.e. https://drafts.csswg.org/css-display/#the-display-properties I've filed bug: crbug.com/804600 to track this. Bug: 726125 Change-Id: I36f6131b5c8308a97639f4813cebd3eb7ceb45ad Reviewed-on: https://chromium-review.googlesource.com/879135 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Han Leon authored
This CL mojofies the 2 legacy IPCs: ServiceWorkerHostMsg_SkipWaiting ServiceWorkerMsg_DidSkipWaiting BUG=772793 Change-Id: Ieed08b0eec8da72d87b93500f82f74d85803545c Reviewed-on: https://chromium-review.googlesource.com/880602 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL moves reddit to resource_loading_list, because reddit has been flakily timing out with a resource load. Change-Id: I886f418863c1f3a1834441b5215dbd04a5604ba7 Reviewed-on: https://chromium-review.googlesource.com/882643Reviewed-by:
-
Charles Zhao authored
(1) Add generic logstic regression to support preprocessed model. (2) Also add validation logic in binary classifer to prevent misuse preprocessed_model with non-preprocessed_model. Change-Id: Idf3f531c8d7bd45d31a45f6e54be0752a02334d1 Reviewed-on: https://chromium-review.googlesource.com/885541 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532316}
-
Naoki Fukino authored
In some vide files, there is no I-frame after the first frame. In this case, seeking to some position may end up loading entire video. To avoid the issue in Image Loader, we should abort loading video file when we don't receive 'canplay' event for a while. Bug: 777521 Test: Manually tested using the video on the issue. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb37b457d7753c46592894993a235840d0c92fd7 Reviewed-on: https://chromium-review.googlesource.com/888233 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532315}
-
Ryo Hashimoto authored
GURL::ExtractFileName() does not unescape the string. Bug: 806192 Test: unit_tests --gtest_filter="ArcFileSystemBridgeTest.*" Change-Id: I31409e7554ae361de9cca809dfbe1a6ef6111b0e Reviewed-on: https://chromium-review.googlesource.com/888189Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#532314}
-
Andrew Grieve authored
If an apk had a post-process action defined, and then later it was removed, the post-process depfile would become the process_resources.py depfile. Change-Id: I1b5d26f800772db6c25bd6a34ce5a7a3bed75f1c Reviewed-on: https://chromium-review.googlesource.com/890172Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532313}
-
Megumi Hattori authored
Before this CL, the reply icon color was opaque white regardless of whether the textfield is empty or not. This CL Changes the icon color to transparent white (opacity: 38%) when textfield is empty. BUG=803759 Change-Id: Id7824e62fd44b0700ea5608b222cdda4de03048c Reviewed-on: https://chromium-review.googlesource.com/886204Reviewed-by:
-
