- 16 Mar, 2020 40 commits
-
-
Peter Wen authored
See go/faster-javac for a detailed analysis of why turbine was chosen to speed up our java builds. The current implementation is an initial implementation that can be further optimized. It already gives savings of 10-30% of our java incremental builds depending on the target in question (see go/project-turbo for timing details). This implementation does remove some of the benefits of the previous way that java_library_impl was implemented, namely when a target's .interface.jar file changes, it no longer short-circuits dependent targets from being built since we now use group(target_name). This is arguably more correct as prebuilts depend on javac jars directly. In the future (after the androidx migration and other build improvements) this can be improved by having prebuilts depend on the interface jars instead. Bug: 1056299 Change-Id: I49d18604203749cf447ce77c54a8f8469c83eae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105415 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#750651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/98b339fb3c01..c6be6446360c git log 98b339fb3c01..c6be6446360c --date=short --first-parent --format='%ad %ae %s' 2020-03-16 tvanderlippe@chromium.org Remove run_old_devtools scripts 2020-03-16 tvanderlippe@chromium.org Add karma-sourcemap-loader to node_modules Created with: gclient setdep -r src/third_party/devtools-frontend/src@c6be6446360c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iafcda475105124de37ef1dbe1e8df294af508f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750650}
-
Alex Turner authored
Subframes which have their initial load aborted (e.g. due to a Document.write() call) currently never have the subresource filter activated. We change the behavior so that a failed provisional load triggers filter creation if a filter has not been already set. As no navigation has occurred, we use the parent's activation in this case. In line with this change, we rename a number of variables and functions. While this change will affect some SubresourceFilter.* histograms, we don't version them as we expect the number of affected frames to be small. Bug: 1052362 Change-Id: I6852fcf1ae72da92b2fe666b3c77c216209d8a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064474 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750649}
-
Adrienne Walker authored
This was accidentally disabled in: https://chromium-review.googlesource.com/c/chromium/src/+/2090878 Bug: 1015214,346399 Change-Id: I49a660ceff9333b48be450335a339a34f83bc505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105956Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#750648}
-
Ehimare Okoyomon authored
Add check to update CookieControlsService if necessary when the toggle is clicked on android. Bug: 1061383 Change-Id: I8b7a759ec2e149a20b133f76e221f757660659c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105338Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#750647}
-
chrome://safe-browsing/#tab-deep-scanDaniel Rubery authored
If a scan is hanging, it's useful to see information about it early. Previously we were only adding the request after the response had came back. Change-Id: Iecda3038e46941356d908427266b6b9847e2500a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101703 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#750646}
-
Xianzhu Wang authored
Bug: 1061995 Change-Id: I9e2e5ca1ba35e979ce2976ea4a722fcee2570f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104013 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#750645}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/86eb5d9703db..06c7095bc7db git log 86eb5d9703db..06c7095bc7db --date=short --first-parent --format='%ad %ae %s' 2020-03-16 ilnik@webrtc.org Make video quality tests to always take a fixed duration 2020-03-16 philipp.hancke@googlemail.com remove mslabel and mslabel ssrc-specific attributes 2020-03-16 handellm@webrtc.org RtpTransceiverInterface: add header_extensions_to_offer() 2020-03-16 peah@webrtc.org APM: Replace most usages of AudioFrame with a stream interface 2020-03-16 kiran.thind@gmail.com Fix: rename ms_per_buffer to buffer_duration 2020-03-16 danilchap@webrtc.org Cleanup AddRtpHeaderExtension for RtpSenderVideo 2020-03-16 yekuang@google.com Use luci-go isolate client in mb.py 2020-03-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0c9b27ea..e0496bdb (750227:750459) 2020-03-14 hbos@webrtc.org [Adaptation] Refactor AdaptationTarget. Peek next restrictions. 2020-03-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3874769f..0c9b27ea (750095:750227) 2020-03-13 phoglund@webrtc.org Apply some more hacks. 2020-03-13 phoglund@webrtc.org Also apply all bins hack to the out file. 2020-03-13 phoglund@webrtc.org Remove the least important WebRTC video tests. 2020-03-13 hbos@webrtc.org [Adaptation] Adapter: Inform the module why there is no next target. 2020-03-13 phoglund@webrtc.org Restructure uploader script so imports are less likely to break. Created with: gclient setdep -r src/third_party/webrtc@06c7095bc7db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452,chromium:1051821,chromium:1059167 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I118ca16b18cfdb14239b3c7254456679b1fcf9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105407Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1059780 Change-Id: I75f74fcd70eee7fbd61a6a32aa9104e148b4d9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102637Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#750643}
-
Demetrios Papadopoulos authored
A <span hidden> within an <option> tag does not work as normally does, since <span> is not a valid child for a <select>, which was the reason for the incorrect behavior. Fixed: 1061324 Change-Id: Ib7e3e6a67f1471d578c0b82ec689825e6be7e147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103444 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#750642}
-
Gayane Petrosyan authored
BarcodeDetector creation takes long time and triggers strict mode violation warning therefore should be created on a worker thread. Also some cleanup - new tab now can be created from worker thread as it is launching an intent instead of going through tab manager. Bug: 993920 Change-Id: Ic974ebe2cae41c7a82fca87976656335799f5ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081615 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#750641}
-
Sigurdur Asgeirsson authored
Bug: 1003391 Change-Id: I8ae906ddb5d3e0ca3a4501e9304703abab70571d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103073Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750640}
-
Jamie Madill authored
Uses the recommended check for WINAPI_FAMILY instead of outdated code. If this patch sticks and is stable I'll submit a pull request to the official zlib repo. Bug: 1061905 Change-Id: I48fa8c884e8f78bbf890cc7f41ac610395833fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105453Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#750639}
-
Stepan Khapugin authored
Adds a startup sequence for when the flag is enabled. Many features are disabled, but it allows booting up and even opening a second window. Details: * uses scene notifications to connect main+scene controllers * uses scene notifications for app delegate level plumbing * fixes window creation w/ flag set Change-Id: I3f85f430ca916e9a866477582e646ca5b92ce4df Bug: 1045547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097990 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#750638}
-
Yu Han authored
Prior to this CL, calling imperative slot API does not check the validity of the slot element or its assigned nodes. However, after the last TPAC Meeting, https://github.com/whatwg/html/issues/3534#issuecomment-537802687, the members agree to not allow manual assignment of any light-tree descendant other than the host's direct light-tree children. This CL validates the slot element and its assigned nodes when calling imperative slot API. The checks are: shadow root is V1, shadow root is in manual slot assignment mode, and assign nodes are children of slot's host element. Bug: 869308 Change-Id: I4b0a1a1a3af6bf159e22af5eafe32ed44172b021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096958Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750637}
-
Jose Leal Chapa authored
Temporarily disable tests to land Devtools ContentProvider.js migration Frontend changes: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2097337 Fix and re-enable Tests https: //chromium-review.googlesource.com/c/chromium/src/+/2096018/ Bug: 1011811 Change-Id: Ibc9189b6d8a553374c7fab73bd514da70c11ea33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106113Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jose Leal <joselea@microsoft.com> Cr-Commit-Position: refs/heads/master@{#750636}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8926292ad6bb..0663bde5f91e git log 8926292ad6bb..0663bde5f91e --date=short --first-parent --format='%ad %ae %s' 2020-03-16 inglorion@chromium.org chromeos_config: Enable new distributed ThinLTO support for nocturne 2020-03-16 morg@google.com Refactor MakeBuildTarget for Android uprev tool 2020-03-15 cindyb@google.com Instantiate M82 Builders 2020-03-14 gredelston@google.com Move STRICT_SUDO overwrite into main() 2020-03-14 engeg@google.com Revert "chromite: add dev-libs/icu to OTHER_CHROME_PACKAGES" 2020-03-14 inglorion@chromium.org Revert "cbuildbot: make builders/stages subdirs python3 only" 2020-03-13 vapier@chromium.org cbuildbot: make builders/stages subdirs python3 only 2020-03-13 dburger@chromium.org Add default retries for tast vm tests. 2020-03-13 lamontjones@chromium.org api/builder_config: Finish toolchain artifact rename. Created with: gclient setdep -r src/third_party/chromite@0663bde5f91e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ifd7e0120cea0b716671ec0f4e551b1f9554d2924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105587Reviewed-by:
-
Anatoliy Potapchuk authored
This CL moves out AutoclickMenuButton into a separate class so it can be in the future reused by other menus that may want those buttons. Bug: 1061068 Change-Id: Ie776231ea5f319f3405eb7d2b04c09497efe7b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100792Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#750634}
-
Xianzhu Wang authored
The feature is not currently used anywhere. Also didn't find any usage when we forked blink. Change-Id: I2d84ab693b08075aaa39e57b2eddaffeb44c9b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104431 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#750633}
-
Eugene But authored
This reverts commit 84f7a1d8. Reason for revert: Accidentally landed before consulting with the team. Original change's description: > Adjust battery level threshold for animation disabling experiment > > I looked at existing Study and the number of entries is too low for > statistically significant experiment. We should get more events by > disabling the animations even if battery life is higher than 20%, > so we can determine if animations affect PLT. > > This CL raises threshold to 50%, which is arbitrary chosen number. > The experiment is only running on dev and canary, and not intended > for beta or stable. > > Bug: 1006431 > Change-Id: I8b6f0cb1ba876c7db11ec23169136e41c21b058e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096170 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: David Jean <djean@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750595} TBR=eugenebut@chromium.org,gambard@chromium.org,djean@chromium.org Change-Id: I58a1d408036f0eadc01a3fe5e343435dec9b929b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105426Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#750632}
-
Daniel Rubery authored
The server team has created a new scope for Safe Browsing OAuth tokens, which we will use for all authenticated communications. Bug: 1041912 Change-Id: If3abd64bc853d2ff65c742dab1a556075385e9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103400Reviewed-by:
-
Dan Harrington authored
Updated protos so we can access the xsurface data. Updated proto converter to grab that data. Bug: 1044139 Change-Id: I25e5f8584a0be4dc27c20ac8000cfa1957fc6fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105420Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#750630}
-
Adam Langley authored
GoogleG2 and G3 are retired. Instead include the new GTS roots. Change-Id: Iea2952ad55c4e4ec26f5d7421a89ead93196f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105402 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#750629}
-
Xiaocheng Hu authored
Font = FontDescription + FontFallbackList In canvas font resolution, the result is just a FontDescription. However, we currently cache the resolved fonts as Font objects with a null FontFallbackList, and pass Font objects to CanvasRenderingContext2DState::SetFont(), which is unnecessary. Hence, this patch changes the code to use FontDescription instead. This patch also makes the code easier to analyze, so that we can eventually eliminate Font::Update(font_selector). Bug: 1049295 Change-Id: I1e3c5a34347355aad2a24f26d35685e9125f7c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103136Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750628}
-
Xiaocheng Hu authored
The site creates a new ComputedStyle(), and then immediately uses its FontSelector, which is always nullptr at the moment, to call Font::Update(). Hence, this patch simpilies it with nullptr. This is preparation for eliminating Font::Update(). Bug: 1049295 Change-Id: I7279993d62c0a6a25e34fbfce8b5cd3dc6e6a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103647Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750627}
-
Marc Treib authored
Test-only cleanup: Before this CL, BubbleObserver::AcceptUpdatePrompt accepted a |form| parameter that it didn't use. This CL removes the param and updates call sites accordingly. Bug: none Change-Id: I4798237434dd02b7ff852a29f70a6cd891234fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105300Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#750626}
-
Xiaocheng Hu authored
This function does the following: 1. Create a temporary ComputedStyle |font_style| 2. Make |font_style| adopt its current FontSelector, which is always nullptr at the call site 3. Use StyleResolver::ComputeFont() to resolve font-related properties, which overrides the FontSelector of |font_style| with the underlying document's FontSelector This isn't correct, as it switches the FontSelector of |font_style|, while ComputeFont() can already use the document's FontSelector. The null FontSelector is actually never used. Hence, this patch removes the adoption of null FontSelector. Bug: 1049295 Change-Id: I2d3b2d1affd9317c6535933c1e4cc2421f5be1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103258Reviewed-by:
-
Charlie Harrison authored
I was staring at some code trying to figure out why ruleset updating worked from the case of an invalid ruleset and wrote out a test with documentation. Bug: None Change-Id: Ibc49461eed421a6a834e966df6a10ea24503429e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1228441Reviewed-by:
-
Alison Maher authored
Refactor the fieldset Layout() function to increase readability. This CL should have no functional change. Bug: 875235 Change-Id: Ie9081f419fd06f99a50c3def3747b48d08471c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102765 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#750623}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71e412b29c10..e27c5b9cb084 Created with: gclient setdep -r src-internal@e27c5b9cb084 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I731999e155e41a8ebcd8f038556a347da3dadffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105583Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750622}
-
James Cook authored
I accidentally left in an old version of a comment. TBR=treib@chromium.org Bug: none Change-Id: I6fdb1761e840b58e3fe76b9079343a094b7a2ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104988Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#750621}
-
Sean Gilhuly authored
Fixes for these tests have been landed in Skia. Re-enable them on the SkDawn bot. Bug: 1021566 Change-Id: I83dc03e3c855b23aceb6244d9feff3e19c19c6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105394Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#750620}
-
Kyle Ju authored
Improve logging for unprocessable entity 422 issue because GitHub does not return an informative HTTPError. 422 error is caused by (1) branch already exists but somehow create_pr is reached (2) missing Change_Id in the original CL. Bug: 1056378 Change-Id: I92e0c59f30c5436121ac88af3972a3be0e2a46bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097156 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#750619}
-
Nicolás Peña Moreno authored
Bug: 1050727 Change-Id: Ie8a33b4b63a3bbec0e85b7d3c9f1dc82a8db59cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101541 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#750618}
-
Dave Tapuska authored
Implement DragMsg_SourceSystemDragEnded as a FrameWidget message. This change is mostly plumbing giving blink the ability to bind and acquire Widget based mojo channels. BUG=1007957,1039255 Change-Id: I1a619fbb9270a21795411b210dcda70356c45594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090297 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#750617}
-
Toni Barzic authored
Adds an animation to shelf drag handle and gesture contextual nudge for login shelf gesture controller. The login shelf gesture handler is active during the last step of OOBE, where the user can swipe up from the shelf to start the session. This CL adds an animation that moves the drag handle and the contextual nudge up and down, to bring more attention to it. Also, updates the drag handle size and color based on the updated specification. BUG=1061627 Change-Id: Iab380a84e8ff769ae16f82f5591fe9c8befaa980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103655 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750616}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/717aa4d9..3c330b35 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9fcf9826563de6bd53e76d8c401172bf3deb36b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105733Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750615}
-
W. James MacLean authored
This test is also flakey on Linux, and to some extent Win. TBR=mkwst@chromium.org Bug: 1060175 Change-Id: I95c4c0cca2a42ae2883254d89f6c2fcd1f56f0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105756Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#750614}
-
Adam Langley authored
With this change, the caBLE authenticator will advertise with it's long-term keys and (always) exchange pairing information when doing QR handshakes. This removes the need to do a QR pairing for every operation. BUG=1002262 Change-Id: I1999e3de347f278a460f126c491d185d1cb18e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101288 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#750613}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f94815068d75..6c138716e9ad git log f94815068d75..6c138716e9ad --date=short --first-parent --format='%ad %ae %s' 2020-03-16 hcm@google.com fix up release notes file for milestone 83 2020-03-16 csmartdalton@google.com Remove GrMesh::setVertexData 2020-03-16 csmartdalton@google.com Rearrange Vulkan asserts for samplers 2020-03-16 mtklein@google.com begin refactoring SkTDynamicHash and SkTMultiMap 2020-03-16 mtklein@google.com Shrink SkTHashTables 2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 907b992f..6d7621ab (422 commits) 2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6963f58c7678..cb9a86a9d867 (13 commits) Created with: gclient setdep -r src/third_party/skia@6c138716e9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: If9a160f7f413276aca518068af73eb309b292f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105580Reviewed-by:
-
