- 04 Nov, 2020 40 commits
-
-
Antonio Gomes authored
.... over chromeos::TabletState::Observer. This CL is a follow up of crrev.com/c/2491517. It gets rid of chromeos::TabletState::Observer class in favor of display::DisplayObserver::OnDisplayTabletStateChanged(). The CL also removes the use of the `friend class` declaration in chromeos::TabletState: ash::TabletModeController now sets the tablet state through display::DisplayManager -> display::DisplayObserver::OnDisplayTabletStateChanged(). Last, the CL deliberately did not got rid of chromeos::TabletState class. Reason: TabletState can continue to be a central read-only class for query the tablet state from any where in the source base. BUG=1113900 R=jamescook@chromium.org Change-Id: I532e8511c1173139937c36c5e4c282311ea17576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518128 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823963}
-
Bartek Nowierski authored
On most systems partition page size is 16kB, but there are systems where it isn't true. Bug: 1144990, 11297512 Change-Id: I7c0b00e15b0ed210b293f0d17f33743c6974c82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517229 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#823962}
-
Henrik Boström authored
If the source and destination formats are identical, a "fast path" is triggered to avoid an unnecessary copy - the source pixel buffer is returned. Thus a destination pixel buffer is never needed. This CL avoids creating a destination pixel buffer when the "fast path" is triggered by moving the condition up for an earlier return. Bug: chromium:1132299 Change-Id: Iac8fa014af8e9d5a6d0735cc222a2b178e9603c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517528Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823961}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Iae372cb4fba850543fa62ea4ce9942f50bd82dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519234 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823960}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib5447ba1416c12f2612a5baee27aa2f5ff34e364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823959}
-
Tanmoy Mollik authored
This reverts commit 2aa0b3d2. Reason for revert: The flakiness seems to be due to some issues on the golden server rather than the test itself Original change's description: > Disable flakey SyncErrorCardPreferenceTest > > TBR: triploblastic@chromium.org > Bug: 1139399 > Change-Id: Ie13bb7d23ee953f871bfd98426d7bb73cf563381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480888 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818053} TBR=skym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1139399 Change-Id: I5bbc961a41349ad37630a328070986a583261dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489426Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823958}
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517500 R=aerotwist@chromium.org Bug: 1011811 Change-Id: I2f99d233ff919992beb5d38feba08533754f6532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517526 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#823957}
-
Corentin Wallez authored
This fixes the roll of Dawn into Chromium after the addition of .cpp files to the dawn_platform target. TBR=enga@chromium.org Bug: None Change-Id: Ia1d34e7f5eaee615dda9138524a516fd35e80535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517525Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#823956}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604415585-a805ae049e5b36d9f91fb3f359143964051762d5.profdata to chrome-win32-master-1604458456-6d8a68b0c784483d981d5c288d37192b762edfa5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibab7e4db48d0f04feadaa1290588295158c91686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519122Reviewed-by:
-
Christian Dullweber authored
The tests started to fail on https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests when https://crbug.com/1113513#c16 was landed. The revert was supposed to fix other failures. Tbr: karandeepb@chromium.org Bug: 1113513 Change-Id: Ia800eba3f90cf3be44bd800c999d7a694f819573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517567Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823954}
-
Regan Hsu authored
When OnActiveNetworksChanged() is called shortly after starting a disconnect to a ConnectionStateType::kConnecting |tether_network_|, the |tether_network_|'s ConnectionStateType may still remain in the ConnectionStateType::kConnecting state. This may happen if on the phone, hotspot is off but bluetooth tethering is on, and a connection attempt is made, but the user does not acknowledge the notification to connect on their phone, and subsequently decides to disconnect while |tether_network_|'s ConnectionStateType is still ConnectionStateType::kConnecting. By the time OnDisconnectCompleted() is called, the connection state is properly updated to ConnectionStateType::kDisconnected, so a fetch may be necessary to promptly update |tether_network_|, as neither OnActiveNetworksChanged() nor OnNetworkStateListChanged() may be called shortly afterwards with the latest network information. Fixed: 1143041 Bug: 1106937 Change-Id: Ieb5c6071cc661fed1a3310a24c57b1927348f9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510876 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#823953}
-
Sigurd Schneider authored
This CL adds a list of available APIs to the frameNavigated event, which are then shown in DevTools. Bug: chromium:1139899 Change-Id: Ic0b44e869901113d44df165f3f3db492721a8510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514378Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#823952}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/47c3ca108898..19f01495a8a1 2020-11-04 capn@google.com Fix LLVM alloca array size type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I43a3407a088954ab45c5861fb78f5ba127ec9b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519298Reviewed-by:
-
Christian Dullweber authored
Revert "Roll ChromeOS Atom AFDO profile from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4314.0-r1" This reverts commit 17b811fe. Reason for revert: Probably broke build on https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel/25410 https://crbug.com/1145472 Original change's description: > Roll ChromeOS Atom AFDO profile from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4314.0-r1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/cros-afdo-atom-chromium > Please CC c-compiler-chrome@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: c-compiler-chrome@google.com > Change-Id: I0c582170559f3a344ae5922dd5ba902ead37061c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519353 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823938} TBR=manojgupta@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Bug: 1145472 Change-Id: I4c9ab02d8c2d63ea2d4847dd95a1140d4bade55a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518051Reviewed-by:
-
Christian Dullweber authored
This reverts commit 0ae8a002. Reason for revert: Try to revert again after stopping autoroller crbug.com/1145472 Original change's description: > Roll AFDO from 88.0.4312.0_rc-r1-merged to 88.0.4314.0_rc-r1-merged > > This CL may cause a small binary size increase, roughly proportional > to how long it's been since our last AFDO profile roll. For larger > increases (around or exceeding 100KB), please file a bug against > gbiv@chromium.org. Additional context: https://crbug.com/805539 > > Please note that, despite rolling to chrome/android, this profile is > used for both Linux and Android. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/afdo-chromium-autoroll > Please CC gbiv@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: gbiv@chromium.org > Change-Id: Ic3a9f7301ba0c015b24ee828d31c5f6649b7b11d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518820 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823885} TBR=gbiv@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Bug: 1145472 Change-Id: Id8179b2f0feb668d408d37a773d04be280016d10 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518050Reviewed-by:
-
Antonio Gomes authored
This CL hooks ozone/wayland with the newly added 'layout_mode' event, from zaura_shell EXO extension. It also introduces a new path to set the global tablet state: display::DisplayObserver. Next, ash/wm/tablet_mode/tablet_more_controller.cc|h will switch over to it, and rest chromeos::TabletState. BUG=1113900 R=jamescook@chromium.org, rjkroege@chromium.org Change-Id: Iae832c4247c04c47429255721ff69c3ba0762455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491517Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Wei Lee authored
Currently there are two scenarios which will trigger SetPhotoOptions(): 1. takePhoto() from ImageCapture API 2. applyConstraints() from MediaStreamTrack object For (2), we don't need to reconfigure photo stream. Bug: 1142931 Test: Manually Change-Id: I2481d6925d2b4d8f3e99b24f9a03a9e1721c99c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517232 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823947}
-
Patrick To authored
Enables WebXR's makeXRCompatible API to support machines with more than one GPU. The feature is controlled by the blink::features::kWebXrMultiGpu flag. The WebXRMultiGpu Blink runtime enabled features was added only to enable the feature flag in tests. Bug: 792657,876140 Change-Id: If3a2e71a58da98066b1171d8ca54ef07bc2946fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503840Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823946}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/944e8f15ba21..af90f011ae79 2020-11-04 the.derekli@gmail.com Show pretty-printed files in multi-file search 2020-11-04 petermarshall@chromium.org Add showSurvey and canShowSurvey to InspectorFrontendHost If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0196cee24a181c1f54a352ded20a3917cfb57e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519410Reviewed-by:
-
Bret Sepulveda authored
Bug: 1110905 Change-Id: Ia514d54ce5ca83f72de5d310a681c800811f5836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513652 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823944}
-
Christian Dullweber authored
This reverts commit d90a3ba0. Reason for revert: This breaks inputs.VirtualKeyboardChangeInput.stable because it refers to "US keyboard" by name. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/12881 Original change's description: > [InputMethodNames] Update English-related strings > > Proposal: http://go/cros-input-methods-naming > Proposed names: http://go/cros-input-methods column C > Screenshot view: http://screen/9RB3jeFjhWq4kvS > > Bug: 889763 > Change-Id: I5393f7e64ecc5251ab31127f9337ebe2b579a417 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517402 > Commit-Queue: My Nguyen <myy@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823898} TBR=xiyuan@chromium.org,myy@chromium.org Change-Id: Ia59ebb17355dca65e4221e4ecfbcc24b4a372c89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517565Reviewed-by:
-
Christian Dullweber authored
This reverts commit ba7d8814. Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164 Original change's description: > [AF] Add account indication footer to AutofillSaveCardInfoBar > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > Screenshot with feature enabled in light mode: > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > Screenshot with feature enabled in dark mode: > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > Bug: 1135847 > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > Commit-Queue: Anne Lim <annelim@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#823710} TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com Change-Id: I5f235bc5843acf4ea504a78762907a019576e656 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852Reviewed-by:
-
Igor Britsky authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): ../../components/autofill/core/browser/data_model/ autofill_structured_address_regex_provider.cc: In function 'std::__1:: string autofill::structured_address::{anonymous}:: ParseFirstMiddleLastNameExpression()': ../../components/autofill/core/browser/data_model/ autofill_structured_address_regex_provider.cc:270:61: error: no matching function for call to 'CaptureTypeWithPattern(autofill:: ServerFieldType, const char [953], <brace-enclosed initializer list>)' Bug: 819294 Change-Id: I6149c53fda0f5357f66eae56446d61f010bccb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506573Reviewed-by:Dominic Battré <battre@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#823941}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc1c1cb562bb..265c5fa9a7e0 2020-11-04 syoussefi@chromium.org Vulkan: Fix scissor update in FramebufferVk::syncState If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I47720da0eab8c8e93e7b3d68bceab648b4bcaee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519352Reviewed-by:
-
Sylvain Defresne authored
The CL https://gn-review.googlesource.com/c/gn/+/10140 was brought by the roll of gn. This CL causes the --root-target to have two conflicting meaning. Remove the parameter from //ios/build/tools/setup-gn.py to allow the script to successfully generate an Xcode project. The drawback is that more target than necessary may be built when building "All" in Xcode. Bug: 1133101 Change-Id: I97073fffbea37c0f61691b9599ff0982e4c027c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517585 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823939}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4314.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0c582170559f3a344ae5922dd5ba902ead37061c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519353Reviewed-by:
-
Wei Lee authored
When there are multiple requests for setting photo options callbacks, pushing the callbacks into a queue instead of storing the latest one only. Bug: 1142931 Test: https://1142931.glitch.me/?timeout=100 Change-Id: Ia4feac88de5600b696cf05f31fd0cea7c2612223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513809Reviewed-by:
-
Christian Dullweber authored
Bug: 1077766 Change-Id: I1b30c374cdc95632f42080cad20d121127abad42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517439Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823936}
-
Ioana Pandele authored
Bug: 1092444 Change-Id: I6e22b168718cb6271171d4a219301e9fa2f55101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516541 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823935}
-
Henrik Boström authored
With eshr@'s libyuv::MJPGToNV12() being rolled into chromium, it is now possible to do MJPEG -> NV12 with a single libyuv function. This CL gets rid of the MJPEG -> I420 -> NV12 paths and makes use of the new libyuv function. This also simplifies the MJPEG -> I420 path. Bug: chromium:1132299 Change-Id: Ia7271703e70b731391873baea009684c00764828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516703Reviewed-by:
-
Luciano Pacheco authored
Files: - util.js - mock_entry.js - files_app_entry_types.js Bug: b/172300267, chromium:1133186 Change-Id: I8819f4ce6fbf1ab4bd137d4edaa6a87ea5955928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519331 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Ziran Sun authored
The test that fails in Chromium related to calc() serialization is due to: https://bugs.chromium.org/p/chromium/issues/detail?id=1050968 The test that fails in Firefox related to resolving percentage grid rows is due to: https://bugzilla.mozilla.org/show_bug.cgi?id=1481876 BUG=767015 R=jfernandez@igalia.com Change-Id: Ie219396d0e62181056ddf6c84b7b60f8251aeb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436821 Commit-Queue: Ziran Sun <zsun@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#823932}
-
Kent Tamura authored
In LayoutNG, selection background is painted to fill the line-height. The <span> in the test should be inline-block so that its height contains line-height. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Bug: 1040826 Change-Id: Ib64c337645f82e7fd54f3a0ba31347a94f85e475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517193 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823931}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9876740171a399762b3506beb7dee742ab71ce41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519391Reviewed-by:
-
Jan Scheffler authored
The cl in devtools-frontend: https://crrev.com/c/2514441 Bug: chromium:1138757 Change-Id: If6c14fd84e3650f143a968abe97fd6a38ed9e934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517680 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823929}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68ad76f4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox external/wpt/css/css-sizing NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I8fb95994790436f1fa855cff59284d69cb97cec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519270Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823928}
-
Hua, Chunbo authored
Bug: None Change-Id: I961d82b32465546f935fcec5047b005fdec370a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513352Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#823927}
-
Hiroki Nakagawa authored
This reverts commit 0ae8a002. Reason for revert: This is a speculative revert to fix compile failures on Android bots: https://ci.chromium.org/p/chromium/builders/ci/android-official/2647 Original change's description: > Roll AFDO from 88.0.4312.0_rc-r1-merged to 88.0.4314.0_rc-r1-merged > > This CL may cause a small binary size increase, roughly proportional > to how long it's been since our last AFDO profile roll. For larger > increases (around or exceeding 100KB), please file a bug against > gbiv@chromium.org. Additional context: https://crbug.com/805539 > > Please note that, despite rolling to chrome/android, this profile is > used for both Linux and Android. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/afdo-chromium-autoroll > Please CC gbiv@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: gbiv@chromium.org > Change-Id: Ic3a9f7301ba0c015b24ee828d31c5f6649b7b11d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518820 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823885} TBR=gbiv@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: If97762d7a58a5628dfd375b23c369621f32a7031 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517352Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823926}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604447854-866c4fbc99bb4ac6773d7af35f2f82c41a890e4c.profdata to chrome-linux-master-1604468747-3cefb59c2b4481c91d9a2d5b4d4a31bc448420c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia36eec03336b5e7bce91cd41c24629d2cfe2e027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519351Reviewed-by:
-
Krzysztof Olczyk authored
Before the change, the "Time" struct from //mojo/public/mojom/base/time.mojom is marked as a Stable interface, while the other two testructs (TimeDelta and TimeTicks) are not. This adds consistency and allows stable interfaces to depend on these basic types. Change-Id: Icae41a542bddde9e6e8ab7b63cb01d4af3a4662f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517479 Commit-Queue: Krzysztof Olczyk <kolczyk@vewd.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823924}
-
