GitLab

Update names to match latest finch beta config names.

Bug: 832666
Change-Id: Ic108cf7f545fd174209d0b2eee517999c7875b43
Reviewed-on: https://chromium-review.googlesource.com/1171223Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582306}

We plan on shipping this via a finch experiment to Canary/Dev soon, and then
enable it by default if we don't encounter major issues. This should only affect
the DirectComposition pixel tests since we force-enable overlays for those
tests. Other tests don't exercise DirectComposition code because those code
paths are disabled unless the hardware supports it.

Bug: 869677
Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a
Reviewed-on: https://chromium-review.googlesource.com/1170385Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582305}

Metrics for the Manage Cards view, which appears when the user clicks on the credit card icon after saving a card locally.

bug: 855186
Change-Id: I036b16bc4a5a4f48115212263909e49371e9778f
Reviewed-on: https://chromium-review.googlesource.com/1162900Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#582304}

As part of the mash work we're going to have multiple aura::Envs at the same
time. Code that may run in Ash now gets the Env from aura::Window, rather than
using Env's static GetInstance(). This patch converts exo to remember the
Env so that it can get the right one.

BUG=847992
TEST=covered by tests

Change-Id: I5fd1c6120868b3847ccd68a063039eec5b54a3b6
Reviewed-on: https://chromium-review.googlesource.com/1169590
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582303}

Previously, these histograms were recorded prior to startup
temperature evaluation, which caused almost (*) no data to be
recorded in temperature-suffixed histograms. With this CL,
the values are stored in global variable and recorded to
appropriate histograms after the startup temperature is
evaluated.

(*) Most of the time, the browser window is displayed
    before startup temperature evaluation. However, if
    Chrome is launched with --silent-launch, the first
    window can be displayed later. That may explain why
    we see a few samples in temperature-suffixed
    BrowserWindowDisplay histograms. With this CL, any
    browser window display that happens after normal
    startup won't be recorded to an histogram.

Bug: 580207, 589118
Change-Id: I8419df6f42df64f60be0858462159a276d17557e
Reviewed-on: https://chromium-review.googlesource.com/1167470Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582302}

After we migrated native side callback to |OnceCallback|, it exposed
that we sometimes call |askUserForSettingsReply()| more than once. The
|DCHECK(callback_)| in |PrintingContextAndroid::AskUserForSettingsReply|
was violated.

Since |Printingcontext.askUserForSettings()| will call
|askUserForSettingsReply()| for sure, we don't need to call it in
other places.

This CL removes a call site of |askUserForSettingsReply| in
|PrintingControllerImpl|.

Bug: 863297
Change-Id: If1c34a4a89acaca461074231ab1bef8edef9baae
Reviewed-on: https://chromium-review.googlesource.com/1161604
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582301}

Bug: 855690
Change-Id: I19d0b1ca0770c9016b0197bf435cf47affe49a94
Reviewed-on: https://chromium-review.googlesource.com/1159840
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582300}

Bug: 872437
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idb0d69320ddfa2dcfe02e493cd117573618459d5
Reviewed-on: https://chromium-review.googlesource.com/1169624
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582299}

This will currently not pass with new versions of HarfBuzz.

Bug: 731894
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib5ae456bf44bfdedd6a0edf36b54dbbf12bae18a
Reviewed-on: https://chromium-review.googlesource.com/1169774
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582298}

This CL adapts GetClientTag() to what integration tests use.

Change-Id: Ie2fbc9c5fd193d0a3635b231e58de7fdf94b3077
Reviewed-on: https://chromium-review.googlesource.com/1171222
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582297}

Use network quality tracker instead of network quality estimator (NQE)
to obtain network quality when attaching network quality
client hints for main frame resources.

Network quality tracker can provide network service when network
service is enabled as well as when network service is disabled.

Change-Id: Iafa641ecb487bb00aecc0d3f1a18cfcdabba3de8
Bug: 819244
Reviewed-on: https://chromium-review.googlesource.com/1170568Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582296}

All calls to this function have been removed and it's no longer in use.

Bug: chromium:867557
Change-Id: I8334510e9fe4b685c7c724f7e35f098435c24bb6
Reviewed-on: https://chromium-review.googlesource.com/1170991Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582295}

A tabindex of -1 on the GuestViewContainer element allows it to be
focusable but not reachable via sequential keyboard navigation.

There does not appear to be any further need for the GuestViewContainer
element itself to be focusable given that we override the focus method.
Previously, we had a focus event listener on the GuestViewContainer
element in order to propagate the focus to the internal element which
would explain why this was needed.

See
https://crrev.com/6476573b7d9099b04002736d90a078550c8651eb
https://crrev.com/53ba951bb6ed4df0998240520fed9d00a7ffff67

Bug: 231664, 803274
Change-Id: If6ffb6f7282db86a1a7ab9e856785e6f51d79a80
Reviewed-on: https://chromium-review.googlesource.com/1170988Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582294}

This CL adds the setting to select the following mode of the lock
screen notification to the Chrome OS setting.
- Hide: don't show notifications on the lock screen
  (default, same as the current behavior)
- Show: show notifications on the lock screen
- Hide Sensitive: show notifications, but hide sensitive contents
  (with a flag to disable this, since this may not launch at the same time)

PRD: go/notification-on-lock-screen

Bug: b/111391270
Change-Id: Ieba42369923472ecef02eac85df9e9009df3ad84
Reviewed-on: https://chromium-review.googlesource.com/1165723
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582293}

Bug: 828996,868093
Change-Id: Ic1dd75cc142bd22b2b9edc31bd5b90abe150e081
Reviewed-on: https://chromium-review.googlesource.com/1170430Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582292}

This is the main body of code required to support MojoVideoDecoder for
hardware decode of WebRTC streams. It tries to be as similar as possible
to RTCVideoDecoder so that a transition can be managed slowly.

The implementation actually supports any media::VideoDecoder, in
particular FFmpegVideoDecoder works well for testing.

Bug: 857111
Change-Id: I0a4dc37a0a133b4c112a55a215aba8058cca598b
Reviewed-on: https://chromium-review.googlesource.com/1117837
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582291}

https://chromium.googlesource.com/angle/angle.git/+log/04c084dd3cf4..077cd858b2d4


git log 04c084dd3cf4..077cd858b2d4 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 theoking@google.com Vulkan: Introduce Command Buffer Perf Test


Created with:
  gclient setdep -r src/third_party/angle@077cd858b2d4

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ie4d97da1f754b092c895391c9215b052d2005e30
Reviewed-on: https://chromium-review.googlesource.com/1171164Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582290}

Sometimes the commit IPC really is for |navigation_request_| even when
the URL checks at the top of RFHI::TakeNavigationHandleForCommit
indicate a mismatched URL.  Examples of when this can happen are XFO
checks (see https://crbug.com/870815) and CSP/frame-ancestors checks
(see https://crbug.com/759184).

Before this CL, in the cases above |navigation_request_| would be
leaked.  This CL fixes the leak.

Bug: 872803
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ia09f355e69f182479386b3deeea1f7f0c8996813
Reviewed-on: https://chromium-review.googlesource.com/1169865
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582289}

Change how boolean flags are initialized and stored in NGConstraintSpace
and NGConstraintSpaceBuilder. Use a single flag field storing a mask for
each option instead of a separate boolean for every one. This simplifies
passing the options from the builder to the ConstraintSpace constructor.

Furthermore it simplifies addition of new options as they are guaranteed
to be passed from the builder to the constructor correctly and that copy
and compare operations take them into account without any extra changes.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ibd2cfca11f67fa0f526a21cf56a6e461c6ad376f
Reviewed-on: https://chromium-review.googlesource.com/1064892
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582288}

Bug: 870202
Change-Id: Id1afc62ba99ce648068b773e900f1373413cb8d7
Reviewed-on: https://chromium-review.googlesource.com/1168144Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582287}

Change-Id: I6418f338f95a564d85c246b3b65d3fec27480bb4
Reviewed-on: https://chromium-review.googlesource.com/1170589Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582286}

Fix ODR violation with ExecutionMode by declaring the streaming operator in the
same header as the type, and add back the GetParamNameForTest calls that use
that operator.

Also add a streaming operator for ChromePromptValue so that all types declared
in constants.h can be pretty-printed.

R=proberge

Bug: 872748
Change-Id: Idfe3f6044f97b003f17d83c6985d442f9b4103f6
Reviewed-on: https://chromium-review.googlesource.com/1170852
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582285}

SwiftShader is now usable on Fuchsia.
Requires sister cl to roll into chromium:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/20208

Bug: chromium:739182

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8be1f554da7633a46ecb888975911d9897f07c78
Reviewed-on: https://chromium-review.googlesource.com/1170040Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582284}

This CL implements downloading the billing blacklist
and then triggering the billing interstitial UI.

The page info bubble is updated to support the billing
interstitial.

The billing page info and the interstitial UI is placed
behind a new safebrowsing feature flag,
"BillingInterstitial".

Bug: 867518
Change-Id: Id87463b272a9dcc4a3e3d95faaa48a942a2cb664
Reviewed-on: https://chromium-review.googlesource.com/1163286Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582283}

Removes gold-style section orderfile, as that is now not possible to
generate with ThinLTO in lld.

Bug: 869997
Change-Id: I9d6970cf9c251cefdc69fbef6c87118fde844374
Reviewed-on: https://chromium-review.googlesource.com/1162221
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582282}

https://chromium.googlesource.com/catapult.git/+log/615ae9b6f35a..5a4110982f31


git log 615ae9b6f35a..5a4110982f31 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 dtu@chromium.org [dashboard] Stop sending 'None' as the comparison_magnitude.


Created with:
  gclient setdep -r src/third_party/catapult@5a4110982f31

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:873022
TBR=sullivan@chromium.org

Change-Id: I2d7a717b179bc4d5b613689b9fca13b6a3f62c07
Reviewed-on: https://chromium-review.googlesource.com/1171162Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582281}

https://pdfium.googlesource.com/pdfium.git/+log/4174b5ab6ac9..e1a7e8589a8c


git log 4174b5ab6ac9..e1a7e8589a8c --date=short --no-merges --format='%ad %ae %s'
2018-08-10 tsepez@chromium.org Remove const_cast<> from CFX_LZWDecompressor::Decode() caller.


Created with:
  gclient setdep -r src/third_party/pdfium@e1a7e8589a8c

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I09961c58c5a521d64ae17af1a762ef100096a1a9
Reviewed-on: https://chromium-review.googlesource.com/1171043Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582280}

If the policy is set, remove restrictions that were put into place for public
sessions.

Bug: 865947
Change-Id: Ifdecf36916d9999ee2f90145dc69b7f46e18d0e1
Reviewed-on: https://chromium-review.googlesource.com/1160651
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582279}

This adds a ScopedTouchIdTestEnvironment class to allow convenient
faking functionality of the Touch ID authenticator that requires
hardware support or user interaction.

TouchIdContext is modified to:
 - allow injection of fakes through TouchIdContext::Create, in order to
disable fingerprint prompts;
 - allow overriding the value returned by
TouchIdContext::TouchIdAvailable, which determines hardware support and
configuration status for Touch ID.

The Keychain wrapper class is modified to allow injection of a fake into
the singleton returned by Keychain::GetInstance. (FakeKeychain
implementation will be done in a follow-up CL).

Change-Id: I1b801b5bbe9b787965a5958206e6772a9a5eb09a
Reviewed-on: https://chromium-review.googlesource.com/1162946
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582278}

Make bundle modules depend on the secondary ABI libraries. This should
fix a build race condition where we fail if we build the Monochrome
bundle module before the APK.

Bug: 872998
Change-Id: I756b779ac390e806666f398e00936df29f93cdaf
Reviewed-on: https://chromium-review.googlesource.com/1171217
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582277}

R=luoe@chromium.org
TBR=lushnikov@chromium.org

Bug: v8:7486
Change-Id: I332f979fb91d97c80f08f7dadd47d8929439c3fc
Reviewed-on: https://chromium-review.googlesource.com/1169777Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582276}

https://skia.googlesource.com/skia.git/+log/6ed63968a391..4eac21fee047


git log 6ed63968a391..4eac21fee047 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader d7622ffdd25e..dd662d210afc (1 commits)
2018-08-10 bungeman@google.com Subpixel in Viewer from -1 to 1.
2018-08-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 9b6a3f926032..04c084dd3cf4 (1 commits)
2018-08-10 herb@google.com Rename GrTextUtils::Target to GrTextTarget


Created with:
  gclient setdep -r src/third_party/skia@4eac21fee047

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: Ifd7584067a7fd1dff4d00a87ecf636c88e7257cd
Reviewed-on: https://chromium-review.googlesource.com/1171122Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582275}

Bug: 870270
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I17c9c1494d2622dbf61398065c0b556a1183075f
Reviewed-on: https://chromium-review.googlesource.com/1171203Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582274}

Bug: 872197
Change-Id: Ie98bf0737a9755312fda763053c9c15316b566be
Reviewed-on: https://chromium-review.googlesource.com/1168283Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582273}

Also, makes CalculateBorderScrollbarPadding equivalent to
ComputeBorder + ComputePadding + GetScrollbarSizes.

This also makes the padding set on the fragment more correct.

R=eae@chromium.org

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8db38ca5955d30fa789a636e5c6deb2ec1fd1829
Reviewed-on: https://chromium-review.googlesource.com/1169321
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582272}

This change updates the close button style. The color of the 'x' is now
white. There is no background unless the user hovers over the icon. In
this case, there is a grey circular background.

As part of this change, CloseIconButton is created to account for the
hover behavior.

Bug: 872098
Change-Id: I90a53c5e42d6377db4ee45b47633689315865c18
Reviewed-on: https://chromium-review.googlesource.com/1168732
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582271}

Uses the new WritableUnalignedMapping class, which changes the ownership
semantics. See the bug for details on the overall plan.

Bug: 849207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idacc45e249291bd9d42ff7bf9a8abffe8636f6cf
Reviewed-on: https://chromium-review.googlesource.com/1117692
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582270}

This is a reland of f86a758d with fix for x86
bots that have VR disabled.

Original change's description:
> [vr] Make VR Java android_library and separate VR JNI registration
>
> This CL does two things:
>
> - In order to move VR Java code into its own module move the code into a
>   separate android_library target.
>
> - As a result of the separate library target we may miss making the VR
>   JNI registrations (in case VR moves out of chrome_public_apk). Thus,
>   separate the JNI registration generation for VR and register VR JNI
>   calls in VR code.
>
> Bug: 862694
> Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355
> Reviewed-on: https://chromium-review.googlesource.com/1158715
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581576}

TBR=agrieve@chromium.org,mthiesse@chromium.org

Bug: 862694
Change-Id: If069e04fe7897f95ce7634b5fd6199eece3a6f73
Reviewed-on: https://chromium-review.googlesource.com/1167770
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582269}

Currently the code falls through to "if (command) then open in
background." This change breaks out the variation if shift is
also pressed.

Bug: 870789
Change-Id: Ie96d355c7c75bec276ed5322aac03f0d3f472a9b
Reviewed-on: https://chromium-review.googlesource.com/1170860Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582268}

Bug: 872804
Change-Id: I2cac9c78c0d7c1fdde72741509f275b7273b7b12
Reviewed-on: https://chromium-review.googlesource.com/1169778
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582267}