- 17 Sep, 2016 21 commits
-
-
dgozman authored
This prevents the toggling when user just wanted to select text. Note that simple click usually clears the selection and element will be toggled. BUG=none Review-Url: https://codereview.chromium.org/2346873005 Cr-Commit-Position: refs/heads/master@{#419353}
-
xdai authored
BUG=626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2332483002 Cr-Commit-Position: refs/heads/master@{#419352}
-
piman authored
BUG=646814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2344273003 Cr-Commit-Position: refs/heads/master@{#419351}
-
pkotwicz authored
These includes are included as part of the runtime_library_javatests target BUG=None Review-Url: https://codereview.chromium.org/2344953002 Cr-Commit-Position: refs/heads/master@{#419350}
-
jbudorick authored
BUG=619055 Review-Url: https://codereview.chromium.org/2348693004 Cr-Commit-Position: refs/heads/master@{#419349}
-
vmpstr authored
This patch adds checks to see which call site is invoking a CheckAndIssueSignals without a tile_task_manager_. Code inspection didn't point at any obvious culprits. Hopefully these checks will. R=danakj BUG=642927 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2341323003 Cr-Commit-Position: refs/heads/master@{#419348}
-
boliu authored
BUG=625089 Review-Url: https://codereview.chromium.org/2349043002 Cr-Commit-Position: refs/heads/master@{#419347}
-
eroman authored
BUG=634443 Review-Url: https://codereview.chromium.org/2337373003 Cr-Commit-Position: refs/heads/master@{#419346}
-
dschuyler authored
Updating Polymer to get mouse cursor change from Pull Requests we submitted. BUG=425627 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2346073003 Cr-Commit-Position: refs/heads/master@{#419345}
-
foolip authored
In dictionary_v8.cpp, the extra null check was wrong or redudant depending on nullabilty: * If the member isn't nullable, then passing null should throw TypeError. * If the member is nullable, then a null check is already emitted earlier, and so that part of the condition is always true. The affected dictionaries were identified by looking at the resulting changes in the generated bindings. Any affected member was made nullable so that this change in itself is not observable, but the right behavior is achieved if those changes are individually reverted. A few cases that were not given TODOs: * MessageEventInit, because the existing TODO is appropriate. * MediaStreamEventInit, because it has no spec and MediaStreamEvent's corresponding attribute is already nullable. * SpeechRecognitionEventInit, because it has no spec. SpeechRecognitionEvent's attributes were made nullable because they can now in fact be null. A number of spec issues were discovered, linked with the TODOs. BUG=647693 Review-Url: https://codereview.chromium.org/2342393002 Cr-Commit-Position: refs/heads/master@{#419344}
-
yuweih authored
Previously we assumed that DestopView.onAttachedToWindow() will only be called after DesktopView.init() is called but this is not true when we enter split screen mode. Since the lifecycle of View.onAttached... and View.onDetached in relate to Activity.onCreate() and Activity.onDestroy() is not well documented and behaves quite surprisingly, it may be better to just rely on the lifecycle of the activity itself. This CL removes DesktopView's onAttachedToWindow() and onDetachedFromWindow() overrides and handles initialization and invalidation by Desktop's onCreate() and onDestroy(). BUG=647823 Review-Url: https://codereview.chromium.org/2348563004 Cr-Commit-Position: refs/heads/master@{#419343}
-
piman authored
BUG=632626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2349613002 Cr-Commit-Position: refs/heads/master@{#419342}
-
mmenke authored
BUG=none Review-Url: https://codereview.chromium.org/2346863003 Cr-Commit-Position: refs/heads/master@{#419341}
-
tedchoc authored
BUG=560466 Review-Url: https://codereview.chromium.org/2348583002 Cr-Commit-Position: refs/heads/master@{#419340}
-
kbr authored
BUG=618447, 619264 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=cwallez@chromium.org, zmo@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2350503002 Cr-Commit-Position: refs/heads/master@{#419339}
-
khushalsagar authored
This is the final patch in the series that abstracts the LayerTreeHost class to provide an implementation that run the impl thread components in-process (single-threaded and threaded compositor). This renames that existing implementation to the LayerTreeHostInProcess. Next up, we add an implementation that handles remoting the content provided to the compositor across a network boundary. BUG=625283 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2340143002 Cr-Commit-Position: refs/heads/master@{#419338}
-
rajendrant authored
BUG=646184 Review-Url: https://codereview.chromium.org/2333063002 Cr-Commit-Position: refs/heads/master@{#419337}
-
sczs authored
UIApplication OpenURL(). The function will use the non deprecated method if its available (iOS10+) BUG=622735 Review-Url: https://codereview.chromium.org/2340873002 Cr-Commit-Position: refs/heads/master@{#419336}
-
djacobo authored
Some links open a new tab while navigating, given that we redirect some of the traffic to ARC, it can be necessary to close any unused tab. Since we are closing the contained WebContents on a tab, we need to make sure the callback within the UI doesn't get called twice, since intent picker has an observer for the WebContents. BUG=647806 TEST=manual test Review-Url: https://codereview.chromium.org/2347273002 Cr-Commit-Position: refs/heads/master@{#419335}
-
prasadv authored
Revert of Add a broken page to dummy_benchmark.noisy_benchmark_1 (patchset #1 id:1 of https://codereview.chromium.org/2334323003/ ) Reason for revert: Reverting the changes to as we have enough revisions to perform bisect FYI jobs Original issue's description: > Add a broken page to dummy_benchmark.noisy_benchmark_1 > > *PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1 > for intergration testing purpose. > > BUG=646628 > NOTRY=true > > Committed: https://crrev.com/522a347da44b43e8bbf58ad29e246dc3dab3872c > Cr-Commit-Position: refs/heads/master@{#418971} TBR=nednguyen@google.com,sullivan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646628 Review-Url: https://codereview.chromium.org/2345393002 Cr-Commit-Position: refs/heads/master@{#419334}
-
kainino authored
Enables support on non-ANGLE desktop platforms (Mac/Linux) and GLES platforms supporting NV_sRGB_formats (Tegra). This is tested by WebGL conformance test conformance/extensions/webgl-compressed-texture-s3tc-srgb.html BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2337833002 Cr-Commit-Position: refs/heads/master@{#419333}
-
- 16 Sep, 2016 19 commits
-
-
bradnelson authored
BUG=None TEST=None R=sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk BUG=646185 Review-Url: https://codereview.chromium.org/2342353003 Cr-Commit-Position: refs/heads/master@{#419332}
-
dschuyler authored
This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG=645190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2341593002 Cr-Commit-Position: refs/heads/master@{#419331}
-
dschuyler authored
This CL moves the circle/dot part of the toggle button slightly. It also adjusts the shadow and translation. These adjustments are needed for the compact toggle button. BUG=646003 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2344083002 Cr-Commit-Position: refs/heads/master@{#419330}
-
rockot authored
Passes an IPC::Channel* to OnFilterAdded instead of IPC::Sender*. This is changing so that filters can use more than just the Sender interface of the Channel, and namely so they can get at remote associated interfaces. BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2349713003 Cr-Commit-Position: refs/heads/master@{#419329}
-
yusufo authored
Adds no-op APIs to cache navigation info for custom tabs like url, title and content screenshot and send them via a callback to the client app. BUG=647342 Review-Url: https://codereview.chromium.org/2348573002 Cr-Commit-Position: refs/heads/master@{#419328}
-
slan authored
Currently, HTTP/1.0 requests are causing http_server.cc to crash. Code shouldn't crash when it is supplied with bad data. Simply move into an error state and close the connection instead. BUG= Review-Url: https://codereview.chromium.org/2314073003 Cr-Commit-Position: refs/heads/master@{#419327}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/1a9a50a459c9e3c081719d3e835cac213c319136 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/7e16cf303221bbcf81d632924e19ddc888da9c3b owners.py: partial fix for owners-check perf regression (nick@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=642793 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2349733004 Cr-Commit-Position: refs/heads/master@{#419326}
-
dtseng authored
https://docs.google.com/document/d/1IZ7HtM0BZlMgNyYo6AUHGL84k RTnH4qt3fd-hXqfjvs/edit# Review-Url: https://codereview.chromium.org/2339093003 Cr-Commit-Position: refs/heads/master@{#419325}
-
sczs authored
Xcode 8 should be installed upstream already, so in order to land changes than use iOS10 SDK we need to update the bots. BUG=none Review-Url: https://codereview.chromium.org/2347943002 Cr-Commit-Position: refs/heads/master@{#419324}
-
sandersd authored
This size was incorrectly reduced in commit 8cbe5d69. This commit also adds DVLOG()s to most methods. These should have been there from the beginning. BUG=647723 Review-Url: https://codereview.chromium.org/2345633006 Cr-Commit-Position: refs/heads/master@{#419323}
-
fdoray authored
This CL makes most SequencedWorkerPoolTest a TestWithParam. The parameter controls whether redirection to TaskScheduler is enabled. BUG=622400 Review-Url: https://codereview.chromium.org/2285633003 Cr-Commit-Position: refs/heads/master@{#419322}
-
dpranke authored
Revert of Update MB to use `gn analyze`. (patchset #9 id:160001 of https://codereview.chromium.org/2298403002/ ) Reason for revert: Need to add "aura_builder", probably others ... Original issue's description: > Update MB to use `gn analyze`. > > Now that GN supports a form of `analyze` directly, this patch > updates //tools/mb to use it rather than working awkwardly through > `gn refs`. The MB implementation now is mostly responsible for > mapping ninja targets to labels, calling GN, and then mapping returned > labels back to ninja targets. Eventually we should update the > recipes to just pass labels around instead. > > One significant change is that now we need entries in gn_isolate_map.pyl > for every target listed in 'additional_compile_targets' and > 'isolated_scripts' as well as in 'gtest_tests', because we have to remap > everything to the GN labels, not just tests for swarming. > > We should switch everything to using GN labels directly, but that'll require > follow-on CLs. > > R=brettw@chromium.org > BUG=555273 > > Committed: https://crrev.com/9aba8b21177df3ed3e897d5c500d845fbf5523e6 > Cr-Commit-Position: refs/heads/master@{#419315} TBR=phajdan.jr@chromium.org,brettw@chromium.org,kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555273 Review-Url: https://codereview.chromium.org/2341403004 Cr-Commit-Position: refs/heads/master@{#419321}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2341393002 Cr-Commit-Position: refs/heads/master@{#419320}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) https://crrev.com/79d8d758281609aa49b9b9af7e18cc187c2ee814 Disable CompilerInfoCache for a while (shinyak@chromium.org) https://crrev.com/a8f07009101d46553ea5d4bce1353ecb365dd3a5 Revert "Roll recipe dependencies (nontrivial)." (tandrii@chromium.org) https://crrev.com/cbca79967afa4f28df6b0ede337db6138eeb167b Add asan=1 to GYP_DEFINES for Dart asan builds (whesse@google.com) https://crrev.com/25b922d8edc1927c3af4bb4a8f7db6434096dca0 WebRTC: Disable iOS API Framework Builder. (ehmaldonado@chromium.org) https://crrev.com/769dbabae3b7ff11023dd1b393fcd2a12e165c65 Make sure goma_ctl is running during wasm_llvm build (sbc@chromium.org) https://crrev.com/2e89429885f7c2503565cb12d564d0f6f58a42f1 Fix Webkit capitalization for N CTS tests. (mikecase@chromium.org) https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267 crashpad/continuous: Use bot_update. (dnj@chromium.org) https://crrev.com/f74386f7e19ff3f32693d222262d1a3ee79799ef Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org) https://crrev.com/15a248123d9032061486cd2d4b3f64369c93a9a5 Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ ) (tandrii@chromium.org) https://crrev.com/7f245d07b2282f9847072fccddf7162a7e632a2d Bump git-on-windows bleeding edge version to 2.10.0. (vadimsh@chromium.org) https://crrev.com/6ac12ffd596e338c43e25dc3889e8ac552c2e885 Make bot_update.py print git version it uses. (vadimsh@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=635641,chromium:647812,webrtc:6372,647446 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2343293002 Cr-Commit-Position: refs/heads/master@{#419319}
-
dmazzoni authored
Shares some of the build rules from ChromeVox, but with no extension tests or Closure compilation rules yet. We can add those later as needed. If you run Chrome with the --enable-experimental-accessibility-features flag, then toggling the Select-to-speak checkbox in the accessibility preferences loads or unloads this component extension, as verified by the presence of the (empty) background script in chrome://inspect BUG=593887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=rdevlin.cronin Review-Url: https://codereview.chromium.org/2216433004 Cr-Commit-Position: refs/heads/master@{#419318}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/b6318bf44dd8..67ac33e1f1a1 $ git log b6318bf44..67ac33e1f --date=short --no-merges --format='%ad %ae %s' 2016-09-16 bungeman Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. 2016-09-16 msarett Fix filling of incomplete images in SkSampledCodec 2016-09-16 halcanary SkPDF: Implement /ActualText to make text extraction correct. 2016-09-16 mtklein format GN files, and invert if->config to config->if 2016-09-16 tomhudson Improve ColorStopOptimizer safety BUG=647481 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2348003002 Cr-Commit-Position: refs/heads/master@{#419317}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/57bf8bed..485e2dcf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2348823003 Cr-Commit-Position: refs/heads/master@{#419316}
-
dpranke authored
Now that GN supports a form of `analyze` directly, this patch updates //tools/mb to use it rather than working awkwardly through `gn refs`. The MB implementation now is mostly responsible for mapping ninja targets to labels, calling GN, and then mapping returned labels back to ninja targets. Eventually we should update the recipes to just pass labels around instead. One significant change is that now we need entries in gn_isolate_map.pyl for every target listed in 'additional_compile_targets' and 'isolated_scripts' as well as in 'gtest_tests', because we have to remap everything to the GN labels, not just tests for swarming. We should switch everything to using GN labels directly, but that'll require follow-on CLs. R=brettw@chromium.org BUG=555273 Review-Url: https://codereview.chromium.org/2298403002 Cr-Commit-Position: refs/heads/master@{#419315}
-
dmazzoni authored
BUG=647049 Review-Url: https://codereview.chromium.org/2333333004 Cr-Commit-Position: refs/heads/master@{#419314}
-