GitLab

Separated out basic performance metrics gathering in the PerformanceMonitor to run independently from the metrics/events database code. The former will now run even without the performance-monitor-gathering flag.

Added an UMA event which triggers when the browser process never runs below X CPU utilization over a period of Y seconds.

BUG=279660, 273320

Review URL: https://codereview.chromium.org/23825004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226466 0039d316-1c4b-4281-b951-d872f2087c98

> Change _ITERATOR_DEBUG_LEVEL to 1 on Release builds
> 
> VS2010 changed the default to 0 meaning weaker checks in our
> release builds.  This commit changes it back again.
> 
> BUG=289691
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/23464081

TBR=wfh@chromium.org

Review URL: https://codereview.chromium.org/25445003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226462 0039d316-1c4b-4281-b951-d872f2087c98

The listeners were being removed in the completion callback to
chrome.cookies.set instead of in the chrome.cookiesonChanged
listener. Nothing guaranteed the order of these two, so the test
begun failing when delete started waiting for flush in
<https://chromiumcodereview.appspot.com/18032002>.

Simplify the tests by using listenOnce/listenForever.

BUG=302914

Review URL: https://codereview.chromium.org/25677004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226456 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226455 0039d316-1c4b-4281-b951-d872f2087c98

cause:
bookmark bar state in Browser wasn't updated when BrowserView::OnActiveTabChanged queries it to update the bookmark bar.

fix:
determine new bookmark bar state in Browser before calling BrowserView::OnActiveTabChanged.

BUG=299131
TEST=verify per bug rpt

Review URL: https://codereview.chromium.org/25500003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226454 0039d316-1c4b-4281-b951-d872f2087c98

This caused files to be sometimes retained as directories, making it
impossible to restore access to them.

BUG=301692

Review URL: https://codereview.chromium.org/25443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226453 0039d316-1c4b-4281-b951-d872f2087c98

Rename IBusLookupTable to CandidateWindow, and move the code location from dbus/ibus/ibus_lookup_table.h to chromeos/ime/candidate_window.h

Along with this rename, this patch also renames variable names from (table or lookup_table) to candidate_window.





BUG=293117

Review URL: https://codereview.chromium.org/24946003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226452 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/25619002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302993
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/25587003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226450 0039d316-1c4b-4281-b951-d872f2087c98

CLD2 returns zh-Hant insteaad of zh-TW, but this is an incompatible behavior.  I fixed it by simply converting it in Chromium.

Some other language codes than zh-TW/Hant are also changed, but they doesn't affect the Translate feature.

BUG=301360

Review URL: https://codereview.chromium.org/25212002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226449 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302156
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/25665005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226448 0039d316-1c4b-4281-b951-d872f2087c98

92d47e4 improve VP8L signature detection by checking the version bits too

BUG=

Review URL: https://codereview.chromium.org/25563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226447 0039d316-1c4b-4281-b951-d872f2087c98

VS2010 changed the default to 0 meaning weaker checks in our
release builds.  This commit changes it back again.

BUG=289691
NOTRY=true

Review URL: https://codereview.chromium.org/23464081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226446 0039d316-1c4b-4281-b951-d872f2087c98

This class is a controller of ModeIndicatorWidget.

BUG=177765

Review URL: https://codereview.chromium.org/25670002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226445 0039d316-1c4b-4281-b951-d872f2087c98

This is the last change required to enable the Ethernet EAP policy on ChromeOS.

BUG=126870
(For preferences_browsertest.cc)
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/23451044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226444 0039d316-1c4b-4281-b951-d872f2087c98

This improves a fix in r218251, after which the signinDelegate on the
signin view would not be replaced when the model changes, but when
both models were signed out.

BUG=297437
TEST=Have the OSX App Launcher enabled and a single, signed out profile.
Delete the profile from chrome://settings, then click sign in on the app
launcher. Chrome should not crash.

Review URL: https://codereview.chromium.org/25649004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226443 0039d316-1c4b-4281-b951-d872f2087c98

NICE_TO_HAVE will pre-render the soon-bin, which is based on both
velocity and distance. Previously, EVERYTHING will also pre-render the
eventually bin. NICE_TO_HAVE is a better fit for the Android WebView
memory management model where we assume a webview will not go berserk
with memory.

Note that this can still fill up on fling.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/25648003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226442 0039d316-1c4b-4281-b951-d872f2087c98

One developer on my team was writing a browser test, but the test would just
hang. Turns out he forgot to start the embedded test server.

I think we can make the failure a lot clearer by adding a DCHECK which will
clearly point out the problem. I know that GetURL doesn't mean the test makes
a request to the server as such, but the returned URL will almost always be
fed into a NavigateToUrl request, so checking for this here will probably
be helpful in almost all cases.

R=phajdan.jr@chromium.org
BUG=301625

Review URL: https://codereview.chromium.org/25238003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226441 0039d316-1c4b-4281-b951-d872f2087c98

This is the expected behavior if the user agent intends to not attempt to fetch
the resource until the user requests it explicitly.

Review URL: https://codereview.chromium.org/23797004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226440 0039d316-1c4b-4281-b951-d872f2087c98

TBR=juberti@chromium.org
BUG=298300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226436 0039d316-1c4b-4281-b951-d872f2087c98

rebuildMenu was only rebuilding the NSMenu, not the menu Model. Do both.

Also add tests, and remove the unused AppListMenu::CURRENT_USER, to fix
a broken test related to the test not observing the user model properly.

BUG=302882
TEST=Open the App Launcher on OSX. Go to chrome://settings and add a
user. The new user should appear in the App Lanucher profile selctor.

Review URL: https://codereview.chromium.org/25535006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226435 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none
TEST=less TODOs

Review URL: https://codereview.chromium.org/25409002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226434 0039d316-1c4b-4281-b951-d872f2087c98

Make UploadDataStream::Reset public.
Call Reset() from HttpNetworkTransaction's dtor.
Add tests.

BUG=244725
TEST=net_unittests --gtest_filter="*HttpNetworkTransactionTest.CancelDuringInitRequestBody*"

Review URL: https://codereview.chromium.org/25217002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226433 0039d316-1c4b-4281-b951-d872f2087c98

Test introduced in r226182.

BUG=302908, 295758
TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/25474004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226431 0039d316-1c4b-4281-b951-d872f2087c98

TBR=juberti@chromium.org
BUG=298300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=kalman
NOTRY=TRUE

Review URL: https://codereview.chromium.org/25665002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226429 0039d316-1c4b-4281-b951-d872f2087c98

Split ConnectToNameOwnerChangedSignal() from ConnectToSignalInternal().
Add WaitForServiceToBeAvailable()
Add test.

BUG=141009
TEST=dbus_unittests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/25488002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226427 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=158649:158674&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/25654002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226426 0039d316-1c4b-4281-b951-d872f2087c98

MessagePumpDefault was incorrectly using system time instead of monotonic time
for PostDelayedTask. This was fixed in r226378 so we don't need this workaround
any more.

BUG=293736

Review URL: https://codereview.chromium.org/25628004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226425 0039d316-1c4b-4281-b951-d872f2087c98

Left in by mistake in https://codereview.chromium.org/3129003

NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/25479002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294465

Review URL: https://codereview.chromium.org/25444004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226423 0039d316-1c4b-4281-b951-d872f2087c98

Gets rid of run-time division. In the new empty read test, goes from ~8.7
million iterations/second to ~9.7 million iterations/second (and in perf makes
VerifyUserPointer() go from ~10% to ~0.5%).

R=darin

Review URL: https://codereview.chromium.org/25323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=covered

Review URL: https://codereview.chromium.org/25286002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226421 0039d316-1c4b-4281-b951-d872f2087c98

DirectoryContent had basically two functions.
1) The list of entries.
2) The scanning entries from backend.
This CL extracts 2) part from DirectoryContent and create ContentScanner to
simplify the code path. At the same time, some events sent from
DirectoryContent was resorted, and their handlers in FileManager is fixed at
the same time.

BUG=279614
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.

Review URL: https://codereview.chromium.org/25278002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302908
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/25679003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298398

Review URL: https://codereview.chromium.org/25144002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226416 0039d316-1c4b-4281-b951-d872f2087c98

original review: https://codereview.chromium.org/24538008/
difference to original review: android test updated.

1) fill Wallet phone number data in a format that's more similar to Autofill (i.e. whole number without any formatting)
2) display Wallet phone numbers in rAc in US-national format
3) display Autofill phone numbers in rAc in user-supplied format, unless there is no formatting. In that case add formatting.

BUG=297204
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/25092011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226415 0039d316-1c4b-4281-b951-d872f2087c98

R=derat@chromium.org

Review URL: https://codereview.chromium.org/25058009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226414 0039d316-1c4b-4281-b951-d872f2087c98

This is just a refactor to reduce some code duplication and homogenize features processing a bit.

Review URL: https://codereview.chromium.org/23867003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226413 0039d316-1c4b-4281-b951-d872f2087c98