- 23 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2ce1d927e98a..ade9a5235c73 2020-10-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 8f7c80347dc6 to 88d705dc85ff (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: If0f17e3ce868e598e7d14effb356bb4cb14c7426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820151}
-
Maggie Cai authored
This CL updates the naming NATIVE_CHROME to CHROME for PreferredPlatform to make the language inclusive. TBR=djacobo@chromium.org Bug: 1097644 Change-Id: I53f160583f010dd612ea0f71e0f8992d679bc7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494262 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#820150}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7bc3356fbcb9..871500da9041 2020-10-22 mbonadei@webrtc.org Trigger bots. 2020-10-22 jakobi@webrtc.org Revert "Default enable WebRTC-SendSideBwe-WithOverhead." 2020-10-22 sprang@webrtc.org Makes aborting probes after a > 10ms scheduling timeout the default. 2020-10-22 jakobi@webrtc.org Default enable WebRTC-SendSideBwe-WithOverhead. 2020-10-22 hta@webrtc.org Move initialization of WebRtcSessionDescriptionFactory to SdpHandler 2020-10-22 Byoungchan Lee Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." 2020-10-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5ce796bc..1fe005a7 (819379:819750) 2020-10-22 mbonadei@webrtc.org Trigger bots. 2020-10-21 deadbeef@webrtc.org Avoid duplicate usrsctp_init if the last usrsctp_finish failed. 2020-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bdce889..5ce796bc (819224:819379) 2020-10-21 perkj@webrtc.org Offer VideoLayersAllocation if field trial enabled 2020-10-21 alessiob@webrtc.org RNN VAD: LP residual optimized (part 2) 2020-10-21 philipp.hancke@googlemail.com doc: move bug reporting instructions to the repository 2020-10-21 alessiob@webrtc.org RNN VAD: LP residual optimized (part 1) 2020-10-21 gustaf@webrtc.org AEC3: Prevent transparent mode from leaking low volume echo 2020-10-21 hta@webrtc.org Make WebRtcSessionDescriptionFactory depend on SdpOfferAnswerHandler 2020-10-21 hta@webrtc.org Remove friendship between PeerConnection and SdpOfferAnswerHandler 2020-10-21 alessiob@webrtc.org rtc::ArrayView reverse iterators 2020-10-21 philipp.hancke@googlemail.com Reland "introduce an unsupported content description type" 2020-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9e057d1b..4bdce889 (819118:819224) 2020-10-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cbcae3bb..9e057d1b (818998:819118) 2020-10-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a07e999..cbcae3bb (818869:818998) 2020-10-20 hta@webrtc.org Delete the "initialize" method of PeerConnectionFactory 2020-10-20 danilchap@webrtc.org In Vp9 wrapper allow to use ScalableVideoController with simulcast structures 2020-10-20 olka@webrtc.org Cleanup after sorting out dependencies of OutputRateCalculator 2020-10-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5939e063..0a07e999 (818652:818869) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1138878,chromium:1140452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd8850052cd3991310c9d21f603f707be28c2bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493097Reviewed-by:
-
dpapad authored
This will be leveraged in follow up CLs, to auto-generate parts of webui_resources.grd. Bug: 1132403 Change-Id: I5bd5f8a411c2cbc1f023220a779d74be209e902c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489920Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820148}
-
Anne Lim authored
Screenshot with feature enabled in light mode: https://screenshot.googleplex.com/BhwpMvUVBhWh4rD Screenshot with feature enabled in dark mode: https://screenshot.googleplex.com/5qyLr4ZMHm3HQLx Bug: 1135847 Change-Id: I6010f72c413b8c33814f178545861081fab2b32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469363 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Anne Lim <annelim@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820147}
-
yiyix authored
The CanvasImageProvider in CanvasResourceProvider keeps a set of images locked, up till a certain budget, since continuous lock/unlock with GPU discardable caused a regression with cases of repeated draws with the same image. Locked_image is added to solve this issue. However, it causes a big overhead to maintain the set of images or to track these images externally. It also causes bugs on memory leakage and other areas. So that the benefits it adds are diminished. In this cl, I am removing the locked_images logic from the code. Bug: 927834 Change-Id: I9425cc3dc9ff862b84d8a524d50841e05f44acae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422584 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820146}
-
Yu Su authored
- remove the temporary implementation for shopping menu item with Prime - delete #classifyImage from LensController. The clank implementation is deleted in https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3355632 Change-Id: I4d772729c77f20f8a693f23aa30618c212ac5037 Bug: b/171421941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493002 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#820145}
-
Melissa Zhang authored
This CL adds a label when there are no targets in the sharesheet. Waiting on mocks for label typography which will be updated in a follow up CL. This CL also switches main_view grid layout to boxlayout for simplicity. Bug: 1138037 Change-Id: Iebec778996c1db648a7fe7880f637dea554c6293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487743 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53281c712159..734a27a2f391 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 502ec4ce to e47bf15e (424 revisions) 2020-10-22 johnstiles@google.com Allow SkSL compilers to reuse SkSL Pools without reallocating. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I9779f497757ef51be869a43a6dc482e29f302201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493732Reviewed-by:
-
Renato Silva authored
Update PIN Autosubmit policy to reflect that it only works with PINs that are between 6 to 12 digits long. Change-Id: I0979f8da62199832420e787ded4253705b0f3976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490521Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#820142}
-
Ryan Hansberry authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/13e275d7e504..acf8878dcf83 $ git log 13e275d7e..acf8878dc --date=short --no-merges --format='%ad %ae %s' 2020-10-01 dlunev cryptohome: Have a specific error for vault recreation trigger. 2020-10-20 mcchou system_api: bluetooth: Add ConnectDevice method constant 2020-10-02 cherieccy system_api: Add GenerateVirtualFileId and OpenFileById to VirtualFileProvider Created with: roll-dep src/third_party/cros_system_api Bug: 1140471 Change-Id: Id9e38673017c7e01fc7f7be6f45504d3e98d4f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492967 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#820141}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7993c228. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Idde116dc6b0a6c201a7910d6baea8e6956a1c0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493542Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820140}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ef6970472eb9..7dee50774b30 2020-10-22 johnchen@chromium.org [Catapult] Add check for Android package data path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106954 Tbr: oysteine@google.com Change-Id: I55aa6721902b852755364f59c52b15a0a914a274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493249Reviewed-by:
-
Chris Davis (EDGE) authored
This change adds a listener for power state change GUID_SESSION_DISPLAY_STATUS which is triggered when the display is put to sleep. We can then treat it as an occlusion case to save battery. Bug: 1137910 Change-Id: Id28d6b2b14c982356f859d3116e65951569965b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487069Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820138}
-
Peter Kasting authored
Bug: 772945 Change-Id: I6a4be66c0e1e002f2573bdf8ec1f6c95ab8b8985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490663Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820137}
-
Xianzhu Wang authored
This lets pre-CompositeAfterPaint also use a single PaintController for each local frame tree to reduce the differences between CAP and pre-CAP. Each GraphicsLayer will create a subsequence. During paint, when we don't need to repaint a GraphicsLayer, we copy the cached subsequence for the GraphicsLayer. Bug: 1132717 Change-Id: I27abe8f0f8380b8d4de73b47d3e1fd9f4860365c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466266 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820136}
-
Christopher Lam authored
Bug: None Change-Id: I4485ddbb595ade6ef078abda2436fa887a0d8b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489060 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820135}
-
Yoav Weiss authored
`navigator.sendBeacon()` was not handling DOMArrayBuffer and URLSearchParams inputs properly, resulting in failing WPTs related to the sent Content-Type, as well as in the wrong data sent in the case of DOMArrayBuffers. This CL fixes that. Bug: 876671 Change-Id: I17674b3041aa0f0bdbd1a570ab34be48b0dd98b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489986 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#820134}
-
Min Qin authored
With trending tiles, users could click on some trending tiles and then leave the score in tile store forever. This CL will clean them up if the tile doesn't show up. We are doing tile stats cleaning in sorting stage is to save the cost of doing another tree traversal to get all the tile IDs. BUG=1096224 Change-Id: Iee421bd24d382234730adda4baea48fd2bf6015c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490555 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820133}
-
Ye Kuang authored
Plan for the migration - Submit this CL, which includes the function to translate Py args to Go format. - Add a flag, '--use_go_args' to the custom trigger script itself, which indicates which format the customer is using. If '--use_go_args' is set, do not do the translation. - Modify the caller side's args to the Go format - Remove the py->go translation _convert_to_go_swarming_args() - Remove '--use_go_args' Bug: 1127205 Change-Id: I032ff9af1a2e95ce55a39c96cfefd7c44832a846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409883 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#820132}
-
Ramin Halavati authored
StartupBrowserCreatorPickerTest is updated to cover ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I93deffade9f2b003b58f71448b46709d8376d7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490042Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#820131}
-
Shakti Sahu authored
This CL adds a feature flag to selectively disable NTP while still being able to show the omnibox UI. TBR=dtrainor@chromium.org Bug: 1141672 Change-Id: I0569cc46fa9d0a5eb0311e4daa8c277d08ce6855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493663 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820130}
-
Glen Robertson authored
This reverts commit ae799285. Reason for revert: Origin trial skipped for M87, which has now branched. Want to start origin trial in M88. Original change's description: > digitalgoods: Remove origin trial for DigitalGoods. > > This reverts commit 13771712. > > Reason for revert: Decided not to move to OT in M87. Delay to M88. > > Original change's description: > > digitalgoods: Add origin_trial_feature_name and _os for DigitalGoods. > > > > Origin Trial on Android only for now. > > > > Bug: 1032423,1096428 > > Change-Id: I8329c798138d800156bbe3f90de6d05f2d9662b2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404284 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Auto-Submit: Glen Robertson <glenrob@chromium.org> > > Commit-Queue: Glen Robertson <glenrob@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#807337} > > Bug: 1032423 > Bug: 1096428 > Change-Id: If0f670b5901c8efc3452bb557bc33d2f5f3aecf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437719 > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812519} Bug: 1032423,1096428 Change-Id: I787a43ce82820136a65363c5be46ec035cb79ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494187 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#820129}
-
Mei Liang authored
Android Tab group is not enabled by default, to avoid fetching the server for unnecessary grouping suggestions, we need to gate the fetching logic by the TabGroupAndroids flag. This CL disables TabSuggestionServerFetcher if TabGroupAndroids flag is disabled. Bug: 1076538 Change-Id: I5715438f4cf579a90aae015fee9ba076944d8184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488720 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
David Maunder <davidjm@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820128}
-
Mei Liang authored
Change-Id: If09f238bd56ab67ac37f86e576b3c20f83300a80 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487881 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
-
Maggie Cai authored
This CL updates the naming MacNative to MacOs for PickerEntryType to make the language inclusive. TBR=sky@chromium.org Bug: 1097644 Change-Id: I5d787d45bc64a236a043f7154e67e883034fa274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491587 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Darren Shen authored
DecoderEngine::OnReply will try to parse every message as public protos but in production it'll receive private protos too. Parsing private protos as public protos will silently fail and cause a a crash. Guard the parsing code with a flag to avoid issues in production. Change-Id: I202420054bcf1a37a58396dd27f987ffdfccbc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493202 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820125}
-
Jamie Madill authored
This removes the final references to the Chromium-based ANGLE GTests from CI. After this we can switch ANGLE over to building standalone tests by default. Bug: angleproject:5124 Change-Id: I1577318ee0883cd76dceb43bbe5b0b3e29b43e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491518 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#820124}
-
Luciano Pacheco authored
Change the tabindex=0 from .xf-panel-label-text to its parent .xf-panel-text to have the .xf-panel-secondary-text content included in the a11y for Chromevox. This makes the estimated time progress available to screen reader users. Bug: 1086053 Change-Id: Id39560b2249fb12ff4f49fb39c7439746fc1271c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494400 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820123}
-
Thomas Guilbert authored
Chromium style guide recommends grouping overrides for a given interface together, with no new line in between methods. This CL applies the rule to blink::Platform implementers. Change-Id: I27fc748361d63a1bb18b8a705b46572aadeae80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492667 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#820122}
-
Liquan (Max) Gu authored
Before: Compiling //components' PaymentManifestWebdataServiceAndroid in //weblayer would fail because it depends on //chrome's payment_manifest_webdata_service_android. Changes: Move //components' PaymentManifestWebdataServiceAndroid into //chrome. After: PaymentManifestWebdataServiceAndroid lives in //chrome and wouldn't be compiled when //weblayer compile //components payment targets. Going forwards, PaymentManifestWebdataService will only be used in Chrome payment, WebLayer payment will find a replacement for it. Bug: 1140637 Change-Id: I4a07761c5220c930cf3c0abd05d9072b63179693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488548Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820121}
-
Alex Danilo authored
Bug: 1138282 Change-Id: Ice4b0f604d6bc5e4aa216c30066cd49777cf15e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490962Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820120}
-
Xianzhu Wang authored
This avoids red webkit_lint step on bots and sheriff efforts to fix that. Also gives developers warning for manual redundant test expectations. Change-Id: I29a46031686812372a38e394e89f67d2da441c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490825 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#820119}
-
Chong Gu authored
Add filters for flaking webgl_conformance tests. Add maps tests to Fuchsia x64 CI bot. Increases bot time per run by ~4 minutes. Bug: 1133540 Change-Id: Ic064b2a7608e0bbf97c02163908c9264c906d737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493783 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#820118}
-
Ian Struiksma authored
Changes to Autofill Interactive UI tests have been made, removing the test filters for Win7 to see if those changes helped these flaky tests as well. Bug: 967588 Change-Id: I89738958f3caba7ecca4eb8d90af1cf1040d716f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491979Reviewed-by:
-
Kent Tamura authored
Bug: 1040826 Change-Id: If834f99a2d97c295cbe0e574538b891533992443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494182 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#820116}
-
Alex Danilo authored
Bug: 1138281 Change-Id: I3d9feb0156ead58ee3b2765522a888ab8e2a42ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490966Reviewed-by:
-
Carlos IL authored
This reverts mixed forms inside iframes to the pre-mixed form warning behavior, they are silently blocked from submitting, and a console error is shown. Bug: 1141628 Change-Id: Ibabdc6d250a347bde8475d94c37402b971c0bdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493302 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820114}
-
chrome://flagsTed Meyer authored
Bug: 1110617 Change-Id: I02c5dcfe640355074dbbf4698ac510b5cdb074fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493839Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820113}
-
Jamie Madill authored
Total runtime drops: Linux x64: 65m 39s -> 19m 40s Linux x86: 83m 35s -> 22m 53s Win x64: 93m 57s -> 25m 30s Win x86: 103m 25s -> 27m 44s Bug: angleproject:5124 Change-Id: I2215e7adad8802120ad5656bbb85ce126422ea14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490987 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
