- 05 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a4f34b76f3a..f3d4109a793b git log 4a4f34b76f3a..f3d4109a793b --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mtklein@google.com add (x,y) params to shader program() Created with: gclient setdep -r src/third_party/skia@f3d4109a793b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I98b7940bee73a02e8eedc5aa6f726dbbc500b2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712434}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::SubresourceFilterAgent using AssociatedReceiver and PendingAssociatedReceiver. Bug: 955171 Change-Id: Iedd96df27c643c1bd307980d77c35231650631c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897396Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#712433}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Iaf90f1afcc14e22a8695b22f00b9b2e6b1c5d2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897807Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712432}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=wjmaclean@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I08632c1a3a1b69fec27fa626b6d35b61da6bfe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895641Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712431}
-
dpapad authored
Bug: None Change-Id: I7923e5168b2f0e8a1df4b2e9af7db2b10d332f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895077 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#712430}
-
Antonio Gomes authored
The following files were moved to third_party/blink/renderer/platform/mediastream from third_party/blink/public/platform/modules/mediastream: - media_stream_audio_level_calculator.h - media_stream_audio_processor_options.h - media_stream_audio_source.h - webrtc_uma_histograms.h Whereas the following files were moved to third_party/blink/renderer/platform/mediastream from third_party/blink/renderer/platform/export/mediastream - media_stream_audio_level_calculator.cc - media_stream_audio_processor_options.cc - media_stream_audio_processor_options_test.cc - media_stream_audio_source.cc - webrtc_uma_histograms.cc - webrtc_uma_histograms_test.cc Note that there are still headers left over deliberately in the public directory: (included in content/renderer): - media_stream_audio_track.h - web_media_element_source_utils.h - web_media_stream_audio_sink.h - (included from other public headers): - media_stream_audio_deliverer.h - media_stream_types.h - secure_display_link_tracker.h - web_media_stream_audio_renderer.h - web_media_stream_sink.h - web_media_stream_video_renderer.h - web_platform_media_stream_source.h - web_platform_media_stream_track.h web_media_stream_audio_renderer.h web_media_stream_audio_sink.h BUG=919392, 787254, 704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I40c0268fed8dafb2aa40620a5e4781324d4342a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891072 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712429}
-
Andrew Grieve authored
This was always the intention. Change-Id: I7f49676d6cb682999dc0a3dcb1878f831d6a5f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898947 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712428}
-
Sergey Ulanov authored
Bug: 999736, b/141714552 Change-Id: I9abf0f01c2bbed6df322b6e822993960ff7bffdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898134 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712427}
-
Jinsuk Kim authored
The only callsite outside chrome.browser.tab package now caches its own TWCDA to avoid getting the reference through the Tab API. The API can then be a package private method. Moved TabTestUtils to target chrome_java_test_support. It now contains a helper method for tests to use to get TWCDA. Bug: 995903 Change-Id: I4614cc917710cd21f8be2e426dfcb29f0a4ba8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881004Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712426}
-
Wez authored
Content is typically rendered into a surface by the GPU process, and displayed into a window owned by the Browser process. In the Scenic Ozone platform this was implemented using import/export Nodes connecting the GPU & Browser. Content rendered to a ScenicSurface by the GPU process is now exported for display by a ScenicWindow via a nested View. This is a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1661389 with additional changes to restrict what the embedded View can do with input. Bug: fuchsia:29945, 974826 Change-Id: Ib674ea1eab8f013e29606432300b368cdc582137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895745Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712425}
-
Mingjing Zhang authored
This CL adds a trace string that represents frame reporting events and will be output as part of the DCHECK message when the DCHECK fails. Each letter in the trace string represent one reporting function call. The length of the trace string is capped at 2,000 characters. Bug: 1017291 Change-Id: I377737730b1f78a7ca87e53db6acba591ee00090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895379 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712424}
-
Matt Menke authored
Nothing populates it yet, other than a test this CL adds. Bug: 997049 Change-Id: I19012744ce7333cf88a7a82e79fc4a4cc99b6cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895859Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712423}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1776a0ea..d3f9d9a2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id39f9d10783280bf091e69369d3a5ba90af7fb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898176Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712422}
-
Megan Jablonski authored
Bug: 1012746 Change-Id: I86a77ff45517796cfd12bff2eef7590b6fd04aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888119Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712421}
-
Min Qin authored
Bug: 1013759 Change-Id: I089b87ee804dfc7151f332f0d967eccaf3573dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891472 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712420}
-
Glen Robertson authored
Also fixes bug where web app would not be considered installed if replacement_web_app_url did not match start_url specified in the web app's manifest. https://docs.google.com/document/d/18ILBOp7lPP9faAC7mF9hwBC40egzrnGS8GUSkAdG3Lk/edit Bug: 1007860 Change-Id: I6e70d5ae4dda797b4760dad4b4876ff205873dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847609 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#712419}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bfec1fd1dc3..8a0420a05d13 Created with: gclient setdep -r src-internal@8a0420a05d13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: I3b0216deeeded8d4e2824cf44d477fe15b73b1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712418}
-
Miguel Casas authored
Some test-only files under media/gpu/test use LOG_ASSERT(), which causes the test binary to crash and leave an unsymbolized callstack when run on the CrOs Tast infra. This CL changes some of those refs to GTest's ASSERT_TRUE(), that is equivalent to EXPECT_TRUE()+return (not all LOG_ASSERT()s are that easy to replace since they are inside functions returning something). Replacing video_decoder_client.cc should fix the VP9.2 not being initialized (since it's disabled temporarily)- the test is expected to fail but not to crash. Bug: 1020776 Change-Id: Iddd6ed9080db4abe62f93730c84e77bfcbc9305f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897358Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#712417}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=ksakamoto@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I5386adf1e71f5cd42566fdb64a6cdf5ba183849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893537 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#712416}
-
Aaron Colwell authored
Temporary fix that creates an exception for 'no access' URLs like chrome-native://history. These URLs can cause a origin mismatch in the commit code because of slight differences between how url::Origin and blink::SecurityOrigin handle 'no access' URLs. This is intended as a low risk change that can be easily merged to the M79 branch. Bug: 1016711 Change-Id: I20734fe68b6919c06849a1ce1439624d6332898c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896863 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712415}
-
Hiroki Sato authored
crrev/c/1875853 wired Android's ImportantForAccessibility to chrome's ignored state. This made all WebView nodes ignored as they don't have importance. This CL fixes it by checking whether it's a native web node and it's focusable. Bug: b:143435799 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I01b52b2542d771749c50f44be361572bb30916da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890407 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#712414}
-
Takashi Sakamoto authored
This reverts commit c5f7284b. Reason for revert: suspect causing base_unittests failure on linux-chromeos-google-rel and chromeos-betty-google-rel: - StackTraceTest.OutputToStream Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8635 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8897671078839178960/+/steps/base_unittests/0/logs/Deterministic_failure:_StackTraceTest.OutputToStream__status_FAILURE_/0 Original change's description: > [base] Cleanup StackTraceTest.OutputToStream #ifdef soup. > > Change-Id: I7e43ea82867177c1aeab089f8f1e35abb802d1a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712377} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I082cc38b748df06ce86324b13d2cd45dbdf1c7a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898888Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712413}
-
Erik Chen authored
There's no need for android kitkat to run lint or errorprone java compiler. These are already run by android_compile_dbg. See discussion at https://bugs.chromium.org/p/chromium/issues/detail?id=1020714#c2. Change-Id: Ibf82c9d46044855b3c25242e30200ae95906d578 Bug: 1020704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896053Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712412}
-
Leon Han authored
As we have NDEFRecord#data now with which users can do whatever they want, so we just remove these helper getters for simplication. The spec change: https://github.com/w3c/web-nfc/pull/384 BUG=520391 Change-Id: I054b521b474433e81b4e8fd93dad0772698ac8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897480Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#712411}
-
Leon Han authored
Makes it use the util function GetBytesOfBufferSource() to retrieve bytes from a BufferSource object. BUG=520391 Change-Id: I31684c36a7a98dc08520f48fcbc4a3618d8b92f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896899 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
-
Leon Han authored
Before, we have both 'opaque' and 'json' NDEFRecord for reading/writing TNF_MIME_MEDIA records, and we just serialize the JSON object provided by users to get the payload bytes for the 'json' NDEFRecord. Now with the goal of making web nfc more of a low level API, this CL unifies them as a new 'mime' type that serves for reading/writing TNF_MIME_MEDIA records. TNF_MIME_MEDIA <---> 'mime' type NDEFRecord The spec change: https://github.com/w3c/web-nfc/pull/373 BUG=520391 Change-Id: If4052c70e48100185e72cb07da8363f5de92b4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896154Reviewed-by:
-
Jinsuk Kim authored
WebContentsObserver.didFinishNavigation that PreviewTab is listening to can come before its views are ready. This CL stops updating caption in such case to prevent NPE reported in the bug. Bug: 1020888 Change-Id: I9240e32015e0df631c3b80546c99d8e9e0a97c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898152Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712408}
-
Lei Zhang authored
Bug: 925165 Change-Id: Ibf858e7112066876c996fada5b7518ad88c81562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895881Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#712407}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=sdefresne@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Iccc6ccf09b2e15f52c75ddba0ec63ff3e927efa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894884 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712406}
-
Taylor Bergquist authored
Also updates the tooltip with the same information. Bug: 999557 Change-Id: Iee27b98e70385e23f7d517622c024d2315a8d491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889945 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#712405}
-
dpapad authored
This is in preparation of turning on web_dev related PRESUBMIT checks for components/. Bug: 1019312 Change-Id: I3226df6b609bc0e16b72d041234084a5615219fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895896 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712404}
-
Jun Mukai authored
I just happened to notice that these two properties don't follow the naming convention. Right now no one is actually using them (though some Tast tests are going to use them), so changing their names should be safe right now. Bug: 1021353 Test: build passes Change-Id: I3f578f1a891fdaa68110b4656006dffe1baaed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894246 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712403}
-
Henry Jian authored
Previously, I forgot to apply masking to adaptive icon in the notification bar, making the icon in notification bar inconsistent with other icons. This CL fixes the bug. Bug: 977173 Change-Id: If42d7f59c3d126dd23f53d4547112455add9fca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898634 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712402}
-
Long Cheng authored
Bug: 1013732 Bug: b/34248841 Change-Id: Ia6cf9a39efc6880d3458b8e33af2ef4225f0290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887748 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712401}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcAnswerOptionsPlatform directly. Similar to https://crrev.com/c/1884931 . BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I24915fd592e3ebd551717cd5dd8a4faccb525596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890794Reviewed-by:
-
gogerald authored
Bug: 1020663 Change-Id: Ica6eff7c7bf1e04636b24068a0b966f3cd50dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894467 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#712399}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc836871cb18..4a4f34b76f3a git log cc836871cb18..4a4f34b76f3a --date=short --no-merges --format='%ad %ae %s' 2019-11-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-04 brianosman@google.com Fully embrace skcms types in SkColorSpace API Created with: gclient setdep -r src/third_party/skia@4a4f34b76f3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I44ac76ba7234893811b31d155a6a6a98702eb4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896389Reviewed-by:
-
Xiaohan Wang authored
Instead of creating the Renderer in PipelineController before pipeline start which includes Demuxer initialization, this CL moves Renderer creation to PipelineImpl as a step in PipelineImpl::Start() so that the Renderer is only created after the Demuxer has been initialized. This makes it possible to have more flexible Renderer creation, e.g. create different Renderers based on different stream or CDM. Bug: 1018372, 827990 Test: No functionality change. Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 1016036 Change-Id: I9c2125d7b2fe11c08f7fa7024155ae25f4a0360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898713Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#712396}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=kmarshall@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I9d65b702148140bab94514de52e0a551f4cb9d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895647 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712395}
-
