GitLab

I suspect that we are encountering back to back begin frame requests
that cause use to write out two begin frame responses which cause
us to crash. Ensure that the begin_frame_response_valid_ is false
when we generate a BeginFrame.

BUG=885124

Change-Id: I21332bccaea142f8daf18a15805142f03f59c339
Reviewed-on: https://chromium-review.googlesource.com/1231733Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592390}

Bug: 758566
Change-Id: I9ec28cc5bb1be7baac6ac232bd9db1a10870b3cc
Reviewed-on: https://chromium-review.googlesource.com/1233595Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592389}

Change-Id: I78b9172711cad010a754ad4d524758df39af5e61
Reviewed-on: https://chromium-review.googlesource.com/1233337
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#592388}

The scheduler assumes that all database tasks succeeded and continues
accordingly. This change propagates the errors, and if there are any,
the scheduler will abandon the fetch.

Change-Id: I813ab23107369799ada4cc39a5eee9944433ed44
Reviewed-on: https://chromium-review.googlesource.com/1228015
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592387}

RequestQueueStore and RequestQueueStoreSQL were combined.

I went ahead and added a test fixture for request queue tasks. This ensures
we actually delete the database in TearDown.

Bug: 883938
Change-Id: Ia56698061685440402d82b5a6836c827f30b546a
Reviewed-on: https://chromium-review.googlesource.com/1227134Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592386}

This reverts commit 673081e3.

Reason for revert: Test complete. One day in the field is sufficient.

Original change's description:
> Field crash if histogram bucket creation isn't as expected.
> 
> There are reports from the field that the "maximum" of a histogram
> does not match what was configured.  The working theory is that it is
> due to rounding errors in the creation of exponential buckets.
> Verify this assumption.  If it's behaving wrong, it should crash
> during the creation.
> 
> Bug: 836238
> Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d
> Reviewed-on: https://chromium-review.googlesource.com/1228840
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592128}

TBR=asvitkine@chromium.org,bcwhite@chromium.org

Change-Id: I0c7ecfc65d31aa2d161f1b689a178432a9364e27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836238
Reviewed-on: https://chromium-review.googlesource.com/1233893Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592385}

To shrink LayoutBlock back to its previous size, store the
constraint space as a pointer again. This seems to actually have a
slightly positive effect on performance according to pinpoint (?!)

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9de7205eefbce457a9b7a82a6d5529adb13d58c4
Reviewed-on: https://chromium-review.googlesource.com/1232584Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592384}

This avoids having a destructor being run when terminating the process.
These destructor could have ordering issues wrt to the destruction of
the AtomicStringTable. Using DEFINE_STATIC_LOCAL also shrinks the binary
a bit. (The android-binary-size bot says -16375 bytes.)

Remove some redundant '\0' characters for some additional (but minor)
savings.

Change-Id: I4f5c19fceb9b668e74d3ef9bad58b104182ddb86
Reviewed-on: https://chromium-review.googlesource.com/1233700Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#592383}

Bug: 886549
Change-Id: Id0576ecc1e66b79e4dfeae708c1849231dad49ab
Reviewed-on: https://chromium-review.googlesource.com/1233696Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592382}

The tests perform operations on sockets that are expected to fail,
and verifies they fail as expected. Unfortunately, some platforms
can return one of two errors. This CL updates the tests to allow
both errors.

Also removes a bunch of extraneous "network::"'s

Bug: 880492,880493
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id085ece9ef0cf2e0b1581d6969f0295dd86910b8
Reviewed-on: https://chromium-review.googlesource.com/1231737Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592381}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aa61ad05..e4c6d03d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic6d71829b0d5861d8deaec7f1e019148ba15d395
Reviewed-on: https://chromium-review.googlesource.com/1233184Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592380}

On Mac, the spacebar activates buttons on keydown; on other platforms it
activates them on keyup. Not implementing this behavior here caused the
following bug:

1) User focuses the bookmark bar star
2) User hits space to activate it, which opens the bubble
3) User tabs to the "Remove" button
4) User hits space to activate that button
5) The "Remove" button activates on keydown and the bubble dismisses
6) The star gets keyboard focus again
7) The star immediately handles the keyup and reopens the bubble!

The fix is for PageActionIconView to honor the platform spacebar affinity. There
is an old TODO in this code to merge it with views::Button but I would not want
to merge such a change back to beta so this small fix seems more expedient.

Bug: 712341
Change-Id: If932928bb069493e61f78f2d34e95a0aa45fb504
Reviewed-on: https://chromium-review.googlesource.com/1230437Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592379}

This exposes a parameter on WebContents::DispatchBeforeUnload which causes
the beforeunload dialog to automatically cancel itself if the beforeunload
handler returns a non-empty string.

This also adds plumbing to expose the value of |proceed| to the existing
WebContentsObserver::BeforeUnloadFired.

A follow-up CL will use these changes in order to create a "beforeunload"
helper to determine whether or not a page contains unsaved user data, and
is therefore unsafe for proactive discarding.

BUG=877550

Change-Id: I3d7b09709985656dc48bbbf408f8b2bdf87b186c
Reviewed-on: https://chromium-review.googlesource.com/1220307
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592378}

Using the border inset directly, instead of trying to recompute it from the
MenuConfig, avoids positioning bugs when the submenu will have a border applied
to it.

Bug: 834934
Change-Id: Ic6c23f7dd5e34b643724c346bb89dac038dd58e4
Reviewed-on: https://chromium-review.googlesource.com/1231736Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592377}

Before this CL, opening an accessory sheet would cause weird states when
requested while opened from within a contextual search.
As there currently isn't any reason to provide the accessory (log in can
not happen and interaction with new sites will happen in a new tab),
disable the accessory for the duration of a contextual search.

Bug: 885106
Change-Id: Iaf71ccb79650618a79fc7f61ec47af2168f2b91d
Reviewed-on: https://chromium-review.googlesource.com/1232960Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592376}

Add Internals>GPU>Metrics component for rendering.desktop
and rendering.mobile benchmarks.

Also, update the scripts to point to the correct script.

BUG=none

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ib1e1899d21d14033518ccad09166a131fd4a1f3a
Reviewed-on: https://chromium-review.googlesource.com/1232515
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592375}

Bug: 884675
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9a7ac9b2cd525d976a3e5d5644004067cdb9d982
Reviewed-on: https://chromium-review.googlesource.com/1228056
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592374}

They no longer fail.

BUG=392771,869308

Change-Id: I8c9dd48eb481ade4626327f737c8e577da577665
Reviewed-on: https://chromium-review.googlesource.com/1233105Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592373}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e67e094d0bb..ce2e95b6cc38


Created with:
  gclient setdep -r src-internal@ce2e95b6cc38

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib6b31983016ee44bcb6e49cbce73ab0a216aad22
Reviewed-on: https://chromium-review.googlesource.com/1233633Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592372}

Using wpt-import in Chromium 987b42a8.
With Chromium commits locally applied on WPT:
87da8d40 "[Background Fetch] Miscellaneous cleanups."
29028a2d "[css-tables] Force layout when colgroups are removed or added"
66a74d2f "Revert "[css-tables] Force layout when colgroups are removed or added""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24833

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I0c4a80566dbf05d4427cb7d50bc2f0041ea8c83f
Reviewed-on: https://chromium-review.googlesource.com/1233183
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592371}

Replace |std::unique_ptr<base::Value>| with |base::Value| wherever
possible.

Change-Id: Id11c694a6d997118a96f6330b5ed23c8a1740289
Reviewed-on: https://chromium-review.googlesource.com/1228375
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592370}

Since any object can be an IDL callback interface, web author can
pass a cross origin object as an IDL callback interface. However,
in case of a remote context (e.g. oopif/site-per-process), the
cross origin object does not have a creation context of
v8::Context, and it causes crash.

This patch fixes the issue by checking whether an object has a
non-empty creation context.

http/tests/dom/eventlistener-with-remote-context.html
demonstrates the issue and its fix.

Change-Id: I3251f1caf8df3add3505afa75a1a056786c87c7c
Bug: 883643, 886588
Reviewed-on: https://chromium-review.googlesource.com/1226893Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592369}

This CL changes the interface of Platform::Initialize() so each embedder just
needs to pass a WebThreadScheduler for the main thread. This simplifies the
Blink initialization and reduces the necessity of WebThread in content/ and
elsewhere.

Some dirty workaround is necessary to deal with the issue on blink_platform_
unittests. This test suite does not set up a global task environment; instead,
each test sets up one in its test fixture. This does not work well with how
SimpleMainThread works. See comments in the CL for details.

Bug: 826203
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id527762b9329ae15acfa90e64576573b992189c6
Reviewed-on: https://chromium-review.googlesource.com/1206171Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592368}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/604c50c8..aa61ad05

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If0586e0b77e61d7cbd22c2e23eed5587c03c0994
Reviewed-on: https://chromium-review.googlesource.com/1233182Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592367}

Adding 3 histograms to track issues related to -[WKHTTPCookieStore
getAllCookies:]. Those histograms are used by crrev.com/i/678070.

+ Signin.SSOWKWebView.GetAllCookies.Request:
    Tracks start and end for each call.
+ Signin.SSOWKWebView.GetAllCookies.CookieCount:
    Counts the number of cookies returned by the call.
+ Signin.SSOWKWebView.GetAllCookies.Duration:
    Tracks the time waited until the callback is called.

Bug: 880981
Change-Id: I8223febe436b15d53a64a52b33a88768f0d41a8b
Reviewed-on: https://chromium-review.googlesource.com/1228179
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592366}

Many of them are failing due to different issues,
some already known and some news bugs that have been reported.
In the TestExpectations entries the bugs related to each test
have been linked.

Change-Id: I38a307927758e30bfe16d9c763deb24c88c412c6
Reviewed-on: https://chromium-review.googlesource.com/1233555Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592365}

This CL migrates the final callers of BrowserDistribution::GetStateKey
to install_static::GetClientStateKeyPath. As a result,
BrowserDistribution and AppRegistrationData no longer have any
consumers. This allows for removal of them and related classes
(including Product).

Additionally, this CL contains a few small cleanups such as removing the
dead IsChromeActivelyUsed function and gently massaging some function
parameters.

BUG=879568

Change-Id: Id4957b9e269706678c84ea2fac8c24c490a99b0f
Reviewed-on: https://chromium-review.googlesource.com/1230016
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592364}

This adds a ?client variant to navigation-redirect.https.html, which
does a lot of redirect tests. This tests the following:
- resultingClientId is the id of the client, if one was created via
  that request.
- get(resultingClientId) for requests that did not create a client
  resolves with undefined.
- resultingClientId is reset on cross-origin redirects.
- Client.url is the creation URL.

Bug: 778497
Change-Id: I08387e96a97df4656d800637862b67b7c8466e14
Reviewed-on: https://chromium-review.googlesource.com/1206054Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592363}

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef form:

1. with @IntDef first, @Retention second and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

There are also done one or two trivial code formatting changes...

Change-Id: I0763d62db7f93b418baf3e608f8b230ed0773be4
Reviewed-on: https://chromium-review.googlesource.com/1215202
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592362}

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we send GetClient Mojo message from within Blink, no longer need
the GetCallback (one subclass of WebServiceWorkerClientCallbacks) to
help cross the boundary of Content and Blink.

The follow-up CL (part 2) will remove blink::NavigateClientCallback
(another subclass of WebServiceWorkerClientCallbacks), then remove
WebServiceWorkerClientCallbacks completely.

BUG=879019

Change-Id: Ib2c469fc7f7476bd734e14c42850bb16266e37b6
Reviewed-on: https://chromium-review.googlesource.com/1227618
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592361}

Add metric for Copy Image via context menu. ImageCopier will record when
user copies image, and relevant events happen during the Copy Image procedure
like alerts popping up or user canceling the copy.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I611852404fc564595b530f4e2afba7a45c6a20b4
Reviewed-on: https://chromium-review.googlesource.com/1215704
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592360}

This temporary waterfall is because I'm rewriting all the configs while
also porting chromium.webrtc.fyi to LUCI. It will be removed later.

The configs are just copies from chromium.webrtc.fyi.

Bug: 877018
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ibe26cdf714a7048f90373dfc0a7eec8ddcead1e2
Reviewed-on: https://chromium-review.googlesource.com/1230023Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592359}

DeviceOAuth2TokenServiceFactory has an undesirable dependency on
g_browser_process. It uses it to obtain LocalState and
SharedURLLoaderFactory. This CL removes the dependency on
g_browser_process by passing in these dependencies explicitly.

Note that the tests still depend on TestingBrowserProcess -
this dependency will also be removed in a follow up CL
(for tests in the settings package).

See go/cros-untangle2

Bug: 446937
Change-Id: I9a046b04175bef6b5af0945d03b03fe1e777fb90
Reviewed-on: https://chromium-review.googlesource.com/1228153
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592358}

It's no longer used after
https://chromium-review.googlesource.com/c/chromium/src/+/1224790.

Bug: 883722
Change-Id: Ie55a7941fca82f6558cd2f2ecf0a65f2b345b701
Reviewed-on: https://chromium-review.googlesource.com/1224792Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592357}

Using wpt-import in Chromium 01f04032.
With Chromium commits locally applied on WPT:
87da8d40 "[Background Fetch] Miscellaneous cleanups."
29028a2d "[css-tables] Force layout when colgroups are removed or added"
66a74d2f "Revert "[css-tables] Force layout when colgroups are removed or added""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24832

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org:
  external/wpt/css/css-text-decor
jfernandez@igalia.com:
  external/wpt/css/css-align

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ib82ef8fef99b6188c5fc2ef96f75476f1b5d808b
Reviewed-on: https://chromium-review.googlesource.com/1233124
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592356}

When a folder is renamed all its children entries in the DirectoryTree
gets stale, because their |fullPath| property are outdated.

Change DirectoryTreeNamingController to force update the renamed
folder's children, so they have the new |fullPath|. This fix the linked
bug because when navigating to children folder the breadcrumbs is
generated based on |fullPath|.

Bug: 885328
Change-Id: I02c39d5289454243d2996d765d5631e17e08b31e
Reviewed-on: https://chromium-review.googlesource.com/1233274
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592355}

Bug: 885088
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5d11b0b736b1b040674aef1911ca8a9510e9402c
Reviewed-on: https://chromium-review.googlesource.com/1230676
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592354}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fbd3c8eb530..69f640ec0900


git log 2fbd3c8eb530..69f640ec0900 --date=short --no-merges --format='%ad %ae %s'
2018-09-19 machenbach@chromium.org [buildbucket] Fix printing build url


Created with:
  gclient setdep -r src/third_party/depot_tools@69f640ec0900

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:711249
TBR=agable@chromium.org

Change-Id: I1bf30df417fec0219431a849f3274e45e039d985
Reviewed-on: https://chromium-review.googlesource.com/1232630Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592353}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a8d9e908573..0e67e094d0bb


Created with:
  gclient setdep -r src-internal@0e67e094d0bb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Idf607c2ba76b3a9cc4aa7569dbbc1042193f4948
Reviewed-on: https://chromium-review.googlesource.com/1232631Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592352}

This gets rid of a non-trivial (exit-time-)destructor.

Previously a (null) String was returned, but it seems that returning an
empty ("") String is more appropriate (if this is reached at all.)

Change-Id: Iba329053ea463883b41000ccb9970b3025da1ae7
Reviewed-on: https://chromium-review.googlesource.com/1230736Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#592351}