- 20 Oct, 2020 40 commits
-
-
Vitaly Buka authored
This experimental build option to mark binaries as compatible with Shadow Stack of Control-flow Enforcement Technology (CET). THe option is not any close to enable in official builds, it's here for convenice of evaluation. As it passes base_unittests and components_unittests. Bug: 1136224 Change-Id: I6fcd61c2e76066b444cc37c88228273838300243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454988Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#819145}
-
Ian Struiksma authored
This causes no change in generated json, but allows the migration to newer win10 version to be more straightforward. Bug: 1124829 Change-Id: I483eedee77cb247d81fd32ec874675f53c26b18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488679 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#819144}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/299fe92af960..e03bf7b4af92 2020-10-20 thestig@chromium.org Prevent undefined behavior in CFX_DIBBase::GetOverlapRect(). 2020-10-20 tsepez@chromium.org Make core/fxge/{fx_dib.h,dib/fx_dib_main.cpp} consistently named. 2020-10-20 tsepez@chromium.org Move some FXDIB_Format functions from .h to .cpp file 2020-10-20 tsepez@chromium.org Make FXDIB_format an enum class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097499 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3388f2c572925d3853eb8b3cf8c6e09c8df3c3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819143}
-
Michael Irani authored
If you navigate to "Manage what you sync" page and then back, the arrow pointing back to "Manage what you sync" is not highlighted when in ChromeVox mode Steps: 1. People 2. Sync and Google Services 3. Manage what you sync 4. Back button Bug: 1029954 Test: Manual Change-Id: I92fc08efdb1f2ea5f1e06232e08df23ab6f03910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488603 Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819142}
-
Katie Dillon authored
[scheduling] Don't pass a queue to record task time on budget pools for find in page and compositor experiments. The cpu time budget pool doesn't use the queue that it is passed when it records task run time, so we will pass nullptr in those spots instead. This will allow us to avoid passing a raw pointer to a TaskQueue in a spot we don't need it as a pre-requisite to this CL: crrev.com/c/2453591. Change-Id: Ifc7de7e94e667c1de1d4bc4de30203becc03fafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485346Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#819141}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I8bcde93c568033282759908ec3e9c212d5ce756b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469464 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#819140}
-
Gang Wu authored
This reverts commit 65967617. Reason for revert: compile failed on https://ci.chromium.org/p/chrome/builders/ci/chromium-internal-arm-builder-rel/5946 Original change's description: > Chime: Add an initialize method. > > Chime needs to be initialized during ChromeApplication.java's startup > code. > > This CL adds ChimeSession.initialize() entry point API, and a upstream > placeholder function for Chime DFM. > > Also clean up the feature flag JNI call for Chime, now it can directly > depends on chrome/browser/flags:java. > > Bug: 1136305 > Change-Id: Id8424fc22d2f419860318b12bd8753da448cd50b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466897 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818755} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I2936cf940241987cc92c12af396658cafc953ace No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487816Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819139}
-
Victor Costan authored
Bug: 1140635 Change-Id: Idfc0091f79e3efccd3a22de879db698b9bf2bc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487837 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819138}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4deb1ed9573d..0ce89c83f8ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1121527,chromium:1134209,chromium:1140474,chromium:912681 Tbr: reillyg@google.com,mcnee@google.com Change-Id: I71cc641e663c5f205f2cf1de16b81260e2851730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488388Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819137}
-
Thomas Lukaszewicz authored
The tab search feature will only support a fixed entry point in the tab strip region view going forward. This change removes the implementation of the tab search button that sits flush with the new tab button in the tab strip. This reverts most of the changes introduced in the following CLs: https://crrev.com/c/2333341 https://crrev.com/c/2377550 Bug: 1099917 Change-Id: I4013e3724968374b8616550c54d562da1366d0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487252 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819136}
-
Eric Orth authored
All configured DoH providers should now only be queried at most once per DNS transaction. Recent timeout logic has extended the time period Chrome will wait for these servers in cases where there is no fallback available to non-DoH. Bug: 1109792,1105138 Change-Id: I661a8ff480dac4b73fb4f66cd28a237139e54433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471717 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819135}
-
Peter Kasting authored
Bug: none Change-Id: I979c06fa784573603570fd82eff7f55b20029cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483382 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#819134}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I186efa519eaafc7673399d948538d6709b70424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487812Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e557087870b0..e9c99e93e75e 2020-10-20 dsinclair@chromium.org Add algorithm include. 2020-10-20 jdapena@igalia.com IWYU: unique_ptr usage in ChunkedCommandSerializer requires including <memory> 2020-10-20 dsinclair@chromium.org Remove HOMEPAGE_URL from cmake project. 2020-10-20 dsinclair@chromium.org Use CMAKE_CURRENT_SOURCE_DIR for third_party/khronos. 2020-10-20 dsinclair@chromium.org Skip None paths when looking for modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:957519 Tbr: dsinclair@google.com Change-Id: I42ffe871e35ffd718c54b3e5325dec36b0003234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488581Reviewed-by:
-
Ian Struiksma authored
We are not yet migrating chrome.tests pool. Until we move bots from 1703 to 1909, keep chrome_sizes on previous version so they are not starved for resources. Bug: 1124829 Change-Id: I780bb5e6e4b23ccb30c27efb769afd14eb6f6116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488740Reviewed-by:
-
Yuke Liao authored
This CL enables also_build_ash_chrome gn arg on linux-lacros-rel to support building both lacros chrome and ash-chrome inside the same checkout. Bug: 1129223 Change-Id: Ic549cd1c00ca2830314b4e8fd8e7fb700dc59b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487696Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819130}
-
Tim Volodine authored
Extend expiration milestone for the BatteryStatus.StartAndroid histogram. Also add second owners line with a path reference to the owners file. BUG=1088646 Change-Id: I99dcfd289bcfcc3bc491bf50fa7a80c6908bcd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485152 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819129}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3fc3588cdf37..2fb0633adec8 2020-10-20 bsheedy@chromium.org [devil] Dump dmesg on pkill failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: skyostil@google.com Change-Id: I0f423ac84b7911796dc03c38583ab63d981d3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487949Reviewed-by:
-
Koji Ishii authored
1. css/css-text/hyphens/hyphens-auto-010.html This test requires the last word of the paragraph to be hyphenated, which Blink currently intentionally doesn't today. Changes the test not to require this behavior because this test is for testing general hyphenation behavior, not the behavior of the last word. 2. css/css-text/hyphens/hyphens-auto-inline-010.html This test requires "guidelines" to be hyphenated, but the Minikin engine does not hyphenate this word. Replace it with "regulation", which is used in `hyphens-auto-010` above. TBR=yosin@chromium.org, tkent@chromium.org Bug: 1022415 Change-Id: I9e0abafa618cd03a4989df668ea49308408e81a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483724Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819127}
-
Shengfa Lin authored
Capitalize does not work well for unicode in the middle of a word. Patch Selenium atoms code regular expression to handle this case Bug: chromedriver:3611 Change-Id: I99dc7cbfef6af7db9590ad2e9e4d94e5bd765d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430768Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#819126}
-
cfredric authored
This makes the expectations more declarative, and makes it easier to express more complicated invariants. Note that in the previous implementation, kV8Screen_Height_AttributeGetter was listed twice among the expected keys, but the test did not verify that the |metrics| map contained two such keys (not that that is possible). |IsSupersetOf| is built on the idea of a multiset, so it does support checking for repeated expected elements. Change-Id: Ia2d617ed826b023bd67f5352e7094fd1136a6e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480964Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#819125}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/browser/renderer_host. Bug: 1113033 Change-Id: Idd9eb8b885f092cc0c30792b1efc9d6a040bc1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472342 Commit-Queue: Norman Rosas <normando@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819124}
-
Robert Ogden authored
This is redundant, but will help direct changes to the right reviewer. Change-Id: Ic4e92f3364d503bbe66864011efc249065592df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488704Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#819123}
-
Gang Wu authored
This reverts commit 987fb106. Reason for revert: crbug.com/1140670 this CL make org.chromium.chrome.browser.sync.ManageSyncSettingsTest#testTrustedVaultKeyRetrieval flaky on Lollipop Phone Tester Original change's description: > [Android] Don't subclass ChromeActivityTestRule in SyncTestRule > > Removes subclassing of ChromeActivityTestRule in SyncTestRule. This > subclassing meant that every test using SyncTestRule would start > ChromeActivity before starting the test. This was producing several > issues: > 1. It's hard and confusing to use SyncTestRule in tests that start > other activity types: FRE tests, bookmark tests, settings tests. > 2. It makes tests longer. > 3. It might make tests flaky. > > Some tests need ChromeActivity to be started, so this CL adds a bunch of > explicit ChromeTabbedActivityTestRule fields along with calls to > startMainActivityOnBlankPage. > > This CL also fixes and cleans up FirstRunTest. Tests will be enabled in > a separate CL (in case they're still flaky). > > Bug: 616456, 1135990 > Change-Id: I5a3d4a27f051cdfc4df2d4dc12a27899084b91db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450291 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818891} TBR=treib@chromium.org,bsazonov@chromium.org Change-Id: I5182024c7f07cb2bf038f4baf18833073474b751 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 616456 Bug: 1135990 Bug: 1140670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488344 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
-
Rafael Cintron authored
gfx::GpuFenceHandle already has a notion of a null handle on all supported platforms. Hence, we don't need to have the corresponding mojo fields also be nullable. Bug: 1131616 Change-Id: Ie31775da704aefd26da41516455d397b67c67a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485629Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819121}
-
Gang Wu authored
This reverts commit 9cad3c10. Reason for revert: test still flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=FirstRunTest Original change's description: > [Signin][Android] Re-enable FirstRunTest > > Enables FirstRunTest that was fixed in https://crrev.com/c/2450291. > Enabling is done in a separate CL to simplify the revert in case these > tests are still flaky. > > Bug: 616456 > Change-Id: I289ccf035a22835b38917680fd74fb8ce9b3e761 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487104 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818931} TBR=treib@chromium.org,bsazonov@chromium.org Change-Id: I568904663d59c88976e55285d30a2d9805a36b0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 616456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488343Reviewed-by:
-
Willie Koomson authored
This change implements ArcMetricsService::ReportAppKill, which is called by the guest to report lmkd and OOM kills. These are passed on to MemoryKillsMonitor, which manages the corresponding UMA metrics. BUG=b:165194376 TEST=atest lmkd_unit_test; monitor Chrome log file to verify that MemoryKillsMonitor has received kill events. Change-Id: I55f1800856388e248a29de0478bb983d3f87a4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463770 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819119}
-
Toby Huang authored
FamilyUserMetricsProvider currently causes a crash in guest mode. This CL fixes the crash and categorizes guest users into the other bucket. This CL also restructures the FamilyUserMetricsProvider to an observer-based approach that improves stability and avoids unnecessary work by caching results. Bug: 1137352,1103077 Change-Id: Ie421861970f6b26def1cf7390bd89480081bcab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476897Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819118}
-
Maggie Chen authored
Damages from render passes with pixel-moving filters are now added to |surface_damage_rect_list_| in SurfaceAggregator::ProcessOverlayDamageList() Because pixel moving filters are not supported in hardware overlays. overlays on Windows are skipped if any pixel-moving filters is enabled. Bug:1064390, 1117235 Change-Id: Ifbb697ffe95b21da0327ecc4a1d10c1b4374b732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452249 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#819117}
-
Xiyuan Xia authored
Bug: 1127644 Change-Id: I09de59f1ea6c53f240480e967ddb31c8ffbc904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487839Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819116}
-
Pranav Batra authored
Bug: 1138145 Test: tast run -buildbundle pita <DUT> printer.* Change-Id: Id27fd480de1ff3b65c0680e2d8021764fde1c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469374Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/common. Bug: 1113033 Change-Id: Ieb6348a46a003f72e8a272bf80180b1649aa0ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472340Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#819114}
-
Kyle Horimoto authored
(1) features::kWebUIDarkMode. A base::Feature for this functionality already existed, but it was not part of chrome://flags and was difficult to enable for Chrome OS users. This CL adds an entry to chrome://flags on Chrome OS. (2) blink::features::kForceWebContentsDarkMode. This flag was present in non-Chrome OS builds but was disabled on Chrome OS due to https://crbug.com/1011696. This CL enables the flag for Chrome OS but does not enable any variants/experiments for this platform. Change-Id: Ie907255a95c09f3be70bd91f2eb850ca68a08c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486660Reviewed-by:dpapad <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819113}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/arc. Bug: 1113033 Change-Id: I561520fccfe728311edd65e770b52b608ecafaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472423Reviewed-by:
-
Koji Ishii authored
This patch adds hyphenation dictionaries necessary for |web_tests| to |data_deps| of |blink_web_tests_support_data|. The dictionaries were added to |blink_platform_unittests| in r818929 crrev.com/c/2483725 but |web_tests| needs to add it to |//BUILD.gn|. Also updates |WebTestContentBrowserClient| to use the directory, and update |TestExpectations|. Bug: 1139950 Change-Id: Ibf20385ad133e523d420fd39ea2f9ed54bd6cd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487020Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
bttk authored
Prevent NullPointerException after destroy() was called. Bug: 1140333 Fixed: 1139100 Change-Id: I3a8cd6117bf9a01e8c43d98d44798db59da9f0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481289 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819110}
-
Renjie Tang authored
Change-Id: Ia6df5a2ab8689d946652ff0945461f2d72692eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486562Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819109}
-
Gordon Seto authored
Screenshots: https://screenshot.googleplex.com/3FZ8v9G68ciNaBv.png https://screenshot.googleplex.com/8JZjZ2vYWB4fNAF.png https://screenshot.googleplex.com/kj6ecX2LXmUETHc.png https://screenshot.googleplex.com/9ehmffRYvQznfM8.png https://screenshot.googleplex.com/5JxoZNqQGPAFfWR.png Bug: 1093185 Change-Id: Ib2bb4b04c6a627a5fd107f7d8a352f22c7e7a996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453445Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#819108}
-
Daniel Cheng authored
Bug: 1140588 Change-Id: I0644c5b7dc043f7d6f04450c580d7116b9eccbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487687 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#819107}
-
Ben Pastene authored
This suite takes up ~75% of the current pool. So crrev.com/i/3351483 moves that many bots from the VM pool into chromium.tests. Will land that at the same time as this. Bug: 1132206 Change-Id: Iead4e4d571ee0ae95e005df080a9d6b1df3a4159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487783Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#819106}
-
