GitLab

We've decided to not ship this feature and focus on other isolation
modes instead.

Bug: 884842
Change-Id: I5895e12f4c80fa22e9fef8ea7045a1bb6a7913bb
Reviewed-on: https://chromium-review.googlesource.com/1228944Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595635}

During the conversion to ws2 a handful of aura unittests got an early out.
This adds comments as to why these tests fail with MUS, and updates one to
work with MUS. For the ones I didn't update I didn't feel fixing the test was
worth it, given we get coverage in the LOCAL case.

BUG=866502
TEST=test only changes

Change-Id: If6d1d0bd50c79b727fd9f38c3662312a76ca7d53
Reviewed-on: https://chromium-review.googlesource.com/1256011
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595634}

Previously a voice interaction was only started if in tablet mode. Now,
we'll also factor in user preference to start a voice interaction on
Assistant entry.

This CL is reliant on and cannot be submitted before:
https://chromium-review.googlesource.com/c/chromium/src/+/1244441

Bug: b:115843337
Change-Id: Ia50b992843e542027e26faa2b522f3d4d48aa58e
Reviewed-on: https://chromium-review.googlesource.com/1252631
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595633}

The word "should" here is odd to read in some context. For example, in
tests, when we "should bundle widevine CDM", we run tests that requires
the CDM. This CL simply drops the word "should" so the gn/build flag
becomes "bundle_widevine_cdm", which is more definitive.

This CL also refactors widevine.gni to better support common variations.

Bug: 349182,843649
Test: No functionality change. Rename only.
Change-Id: Iaa8c6c29a33409bb1b31be86cb6202ff3f4b7cd9
Reviewed-on: https://chromium-review.googlesource.com/1249736
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595632}

StrCat is 2-4x faster, so use that instead of Printf/Appendf.

This CL lands server changes 211484351 by dzetkulic and
215218657 by bnc.

BUG=488484

Change-Id: I5b6cab6db94c1cb5f75106832d45858a92924875
Reviewed-on: https://chromium-review.googlesource.com/1252161
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595631}

The Clear Browsing Data dialog is updated:
 - A footer is added to display the sync account
   information.
 - The string descriptions for the data items
   depend on the sync state.
 - Information on how to resolve sync errors is
   added.

Screenshots:
https://drive.google.com/drive/folders/1AFV0ttCuS5g4IEOypktqeH3MGk8d_ac1?usp=sharing

Bug: 889137
Change-Id: Ie79e9ff4bb68ec3f0a9b5a0231aaee707875618c
Reviewed-on: https://chromium-review.googlesource.com/1251627
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595630}

According to the reference doc of InputConnection.commitText(),
we should clear the current composition text when commitText() is called
instead of commiting the current composition text.

Bug: 845079
Test: Typing text wiht Google Japanse Input app and it works well.
Change-Id: Ie2d9cd73d64f5728dc82f3f441d73af7a2740836
Reviewed-on: https://chromium-review.googlesource.com/1252226
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595629}

PointerWatcher is no longer needed with Ash hosting the Window Service.
Add StylusEventHandler to notify PaletteTray on stylus events.
Fix odd logic for showing the bubble; remove event handler when done.

Convert PaletteWelcomeBubble to EventHandler and simplify show/close.
Update tests and perform some minor cleanup.

Bug: 872450
Test: No (bad) behavior changes in palette tray / stylus welcome bubble.
Change-Id: If8d6da88d6a70979978f227f10ebb8357fb0d34e
Reviewed-on: https://chromium-review.googlesource.com/1252910
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595628}

Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd
Reviewed-on: https://chromium-review.googlesource.com/1254341
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595627}

Currently, the only identifier for showing Bluetooth authenticators on
WebAuthN UI modals is the authenticator ID which represents the MAC id
of the device. As this is not user friendly, add human-readable
authenticator_display_name to AuthenticatorReference.

Bug: 877344
Change-Id: I2d3b35db669d8f8f61e9989870122a211d80e80f
Reviewed-on: https://chromium-review.googlesource.com/1247681
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595626}

This reverts commit af3f31af.

Reason for revert: Breaks Android buildbot runs with errors like:
  ```../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/IncognitoToggleTabLayout.java:18: error: cannot find symbol
  import org.chromium.chrome.browser.widget.TintedImageView;```
 
Full run here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933828868736954944/+/steps/compile__with_patch_/0/stdout


Original change's description:
> [Android] Replace TintedImageView and TintedImageButton
> 
> This CL replaces Chrome-specific tinting view classes with their
> AppCompat equivalents: TintedImageView -> AppCompatImageView and
> TintedImageButton -> AppCompatImageButton.
> 1. Entries in XML layouts have fully qualified names because some
>    layouts are inflated outside AppCompatActivity, so AppCompat magic
>    doesn't work for them.
> 2. AppCompatImageView doesn't have setTint, so
>    ImageViewCompat.setImageTintList is used instead.
> 3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
>    so these are replaced, too.
> 
> Bug: 727723
> Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1
> Reviewed-on: https://chromium-review.googlesource.com/1245786
> Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595500}

TBR=tedchoc@chromium.org,twellington@chromium.org,bsazonov@chromium.org,huayinz@chromium.org

Change-Id: I83efa81fce074f24f330281460b2685f1765f0e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 727723
Reviewed-on: https://chromium-review.googlesource.com/1255456Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595625}

BUG=b:116761000
TEST=None

Change-Id: I353b0b183df8242b9a799face70be560f186e56c
Reviewed-on: https://chromium-review.googlesource.com/1252386Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595624}

BUG=b:116761000
TEST=None

Change-Id: I005557605a60296cc77f7dd4fd949b5ff4ff75f2
Reviewed-on: https://chromium-review.googlesource.com/1253211Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595623}

Motivations behind this change are:
- To track time spent executing fetch event handers
- To track IPC delay for navigation case (renderer -> browser).
- To track thread hopping delay for subresource case
  (renderer SW thread -> renderer background thread).

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Bug: 877972
Change-Id: I1ea2e17e3270c9f79e6b5104885562b96ac497b0
Reviewed-on: https://chromium-review.googlesource.com/1242579Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595622}

Enable timer notification by default. We can disable the feature by overriding the flag to false with finch.

Bug: b:110107505
Change-Id: Ide23cebd82ec2a51727abf6b87b408c98623aed3
Reviewed-on: https://chromium-review.googlesource.com/1251631
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595621}

When using ChromeOS on ARM with a 64bit userspace, the early sandbox
blocks the Mali/GLES/EGL libraries from loading, because only the
32bit paths are allowed. Whitelist the 64bit paths when building for
aarch64 on ChromeOS.

BUG=882033
TEST=Device boots, GPU process is sandboxed

Change-Id: Iba2e696291b96c23aaaafc417d4eb96f084f4f46
Reviewed-on: https://chromium-review.googlesource.com/1230066
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595620}

Thanks to a clang fix (*) things work fine on Mac now.

(*) rC342600 fixes https://bugs.llvm.org/show_bug.cgi?id=38896

Bug: 881875
Change-Id: I8c65848bf09f1a7f80f640e8b2e09bb2ef1e3789
Reviewed-on: https://chromium-review.googlesource.com/1249837Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595619}

BUG=696822

Change-Id: I77b3ed6aba80cf1c41e27148b560fbe7094fb19e
Reviewed-on: https://chromium-review.googlesource.com/1222158Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595618}

The tests seem to pass now.

Bug: 630357,845389
Change-Id: I7e74c1a41f578dc70866d533742e36bafb787f63
Reviewed-on: https://chromium-review.googlesource.com/1251327Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595617}

https://chromium.googlesource.com/webm/libvpx.git/+log/3448987ab20a..2beb5c9f91e7

$ git log 3448987ab..2beb5c9f9 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 jingning Remove deprecated get_arf_buffer_indices()
2018-09-28 jingning Remove deprecated arf_update_index from GF_GROUP
2018-09-27 paulwilkins Fix minor bug in calculation of max arf group length.
2018-09-28 paulwilkins Adjustment of GOP intra factor for multi-layer.
2018-09-25 huisu Add ml_var_partition experiment
2018-09-28 paulwilkins Revert "Merge "Adapt GOP size threshold to the allowed layer depth""
2018-09-27 jingning Add MID_OVERLAY_UPDATE frame type
2018-09-27 jingning Refactor gf_overlay frame type update
2018-09-27 huisu Fix a loophole in nonrd_pick_partition()
2018-09-27 jingning Remove deprecated variables from GF_GROUP structure
2018-09-27 jingning Remove unused for-loop in multi-layer arf bit allocation
2018-09-26 jingning Adapt GOP size threshold to the allowed layer depth
2018-09-26 angiebird Add vpx_clear_system_state to new mv search func
2018-09-26 angiebird Change mv color to red
2018-09-26 johann.koenig add cfi sanitizer
2018-09-26 johann.koenig CONFIG_WEBM_IO: include webmids.h
2018-09-25 angiebird Call vp9_full_pixel_diamond_new in tpl mv search
2018-09-25 angiebird Add vp9_full_pixel_diamond_new
2018-09-24 angiebird Add vp9_refining_search_sad_new
2018-09-24 angiebird Add vp9_diamond_search_sad_new
(...)

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I0dc3ae4855a3faaa94086bfa9e4a5cb022f09689
Reviewed-on: https://chromium-review.googlesource.com/1254753Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#595616}

https://pdfium.googlesource.com/pdfium.git/+log/2b4d11c0f133..ce342184e625


git log 2b4d11c0f133..ce342184e625 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 thestig@chromium.org Update some third_party/base headers.
2018-10-01 thestig@chromium.org Make header guards consistent in third_party/base/*.h.
2018-10-01 thestig@chromium.org Fix #include ordering / formatting.
2018-10-01 thestig@chromium.org Initialize more CXFA_Node members in the header.
2018-10-01 thestig@chromium.org Remove some "exceptions" from reedsolomon code.
2018-10-01 thestig@chromium.org Use size_t and FX_ArraySize() for some arrays.
2018-10-01 rharrison@chromium.org Add XFA JPG pixel test
2018-10-01 rharrison@chromium.org Add XFA GIF pixel test


Created with:
  gclient setdep -r src/third_party/pdfium@ce342184e625

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If39e1827d0a99dc2b2e7d1701ecbfa4e617f7417
Reviewed-on: https://chromium-review.googlesource.com/1255302Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595615}

Regressed in recent commit: d0567449

Bug: 890360
Change-Id: I1589295c40eff98a6255d9dd01ad9c2a66817dc4
Reviewed-on: https://chromium-review.googlesource.com/1255888Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595614}

Bug: 885232
Change-Id: I08943ff79a7dfae036acb8842bc67e8fe90c2999
Reviewed-on: https://chromium-review.googlesource.com/1253073Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#595613}

Here is the call stack when the crash happens:
(chrome - scoped_refptr.h: 191)	libgtkui::SelectFileDialogImplGTK::OnFileChooserDestroyThunk(_GtkWidget*, void*)
(chrome - select_file_dialog_impl_gtk.cc: 98)	libgtkui::SelectFileDialogImplGTK::~SelectFileDialogImplGTK()
(chrome - select_file_dialog_impl_gtk.cc: 89)	<name omitted>
(chrome - ref_counted.h: 414)	DownloadFilePicker::~DownloadFilePicker()
(chrome - select_file_dialog_impl_gtk.cc: 284)	libgtkui::SelectFileDialogImplGTK::FileSelected(_GtkWidget*, base::FilePath const&)

A dialog is destroyed in FileSelected(), but it seems that the same
dialog is destroyed again in OnFileChooserDestroy.

BUG=880073

Change-Id: I1f47bbc26b4af81b4c73d7cf03ac684edc4f97fd
Reviewed-on: https://chromium-review.googlesource.com/1256020
Commit-Queue: Joone Hur <joone.hur@intel.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595612}

This resolves the connection error log spam seen in suites like
content_unittests.

Change-Id: I26d1959b9be67247af10c454b21159755b68eb72
Reviewed-on: https://chromium-review.googlesource.com/1256019
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595611}

https://chromium.googlesource.com/angle/angle.git/+log/5ddbdbf70c50..624fbdcf55b0


git log 5ddbdbf70c50..624fbdcf55b0 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 oetuaho@nvidia.com Refactor CompileProgram utility
2018-10-01 thakis@chromium.org Remove an exit-time destructor from a frequently-included header.
2018-10-01 geofflang@chromium.org Vulkan: Implement robustness extensions.
2018-10-01 jmadill@chromium.org Vulkan: Record blit commands inside blit methods.
2018-10-01 geofflang@chromium.org Reland "D3D11: Resolve multisampled EGL surfaces at eglSwapBuffers"
2018-10-01 jmadill@chromium.org Vulkan: Use copyImageDataToBuffer in Texture mipmap gen.
2018-10-01 syoussefi@google.com Vulkan: Add support for VkPipelineCache


Created with:
  gclient setdep -r src/third_party/angle@624fbdcf55b0

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:887403
TBR=cwallez@chromium.org

Change-Id: If26142dca4cbbae4598e48f346fbc5b3d0b4af1f
Reviewed-on: https://chromium-review.googlesource.com/1255508Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595610}

This makes it easy to organize the doc and find files.

This CL does minimal reordering of the files listed in the current
README, with some rough grouping. It is expected that we'll
improve the structure of the file gradually over time.

Bug: 818048
Change-Id: I8f19fa388d6cd599fc32824b91d184bd49b2767a
Reviewed-on: https://chromium-review.googlesource.com/1253207Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595609}

Lazy init (https://crrev.com/578223) doesn't work for
TextSuggestionHost whose UI gets triggered by native from Blink.
It expects the related components (java TextSuggestionHost and
blink::mojom::TextSuggestionHost) to be ready before it makes
the first call. This CL initializes the objects in eager fashion.

Bug: 884214
Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24
Reviewed-on: https://chromium-review.googlesource.com/1253312Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595608}

Using wpt-import in Chromium 49993008.
With Chromium commits locally applied on WPT:
92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25734

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
msisov@igalia.com:
  external/wpt/webvtt
timvolodine@chromium.org, reillyg@chromium.org:
  external/wpt/orientation-event

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I21f8093510ab47bb9505f3e3058b47ff94fb63ab
Reviewed-on: https://chromium-review.googlesource.com/1255153
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595607}

The default for 3rd-party cookies in content shell has
been changes from "deny" to "allow" by
https://chromium-review.googlesource.com/1196547
However, we still reset it to "deny" when resetting
the TestRunner between tests, which causes inconsistent
behavior for tests that depend on default value.

Bug: 890000
Change-Id: If85535e617eb884e5fdd64c928d558f9fa84bb29
Reviewed-on: https://chromium-review.googlesource.com/1250165Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595606}

* If no catalog is present, requests one from the network and displays
  default images.  When request finishes, updates the category images.
* Updates category images right away if not requesting from the network.
* Fixes the query in GetCatalogTask so that if there is no "current"
  catalog, it will use the "downloading" catalog instead.

Bug: 867488
Change-Id: Ic307f77a4b3ae2ededa711f619059b1aed562012
Reviewed-on: https://chromium-review.googlesource.com/1252908
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595605}

The client area insets of a top-level need to be propagated to the
ClientSurfaceEmbedder.

BUG=869501
TEST=covered by tests

Change-Id: Id5aca98e46d596e8e43c7ea71150f59a0db638da
Reviewed-on: https://chromium-review.googlesource.com/1252145
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595604}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d46dfc57..6d7c52f8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I27de39197801350ac95f29ef306811de43cfe3b4
Reviewed-on: https://chromium-review.googlesource.com/1254381Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595603}

This reverts commit a55d47e1.

Reason for revert: The breakage that caused this revert was only present on the M70 branch and never happened on master. It was due to this CL referring to a drawable that was renamed in M71. This CL uses the new name so it broke the M70 build when it was cherry picked.

Original change's description:
> Revert "Horizontal tab switcher use tab toggle"
> 
> This reverts commit 61bed816.
> 
> Reason for revert: Broke [Build Non-Channel Targets] build step
> 
> Original change's description:
> > Horizontal tab switcher use tab toggle
> > 
> > Replace the HTS Incognito Button with a toggle.
> > 
> > Bug: 851166
> > Change-Id: I5c431abb508930ee1a9a24792f2299ea08d944cf
> > Reviewed-on: https://chromium-review.googlesource.com/1246453
> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> > Commit-Queue: Pedro Amaral <amaralp@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#594780}
> 
> TBR=yusufo@chromium.org,amaralp@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 851166
> Bug: 890673
> Change-Id: I3631d88c29bd950beea9280e97e0ff50ed332bc8
> Reviewed-on: https://chromium-review.googlesource.com/1253741
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595411}

TBR=yusufo@chromium.org,tobiasjs@chromium.org,amaralp@chromium.org

Change-Id: Iaee562d9f3c393480028749e265550b84cad4ae1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851166, 890673
Reviewed-on: https://chromium-review.googlesource.com/1256104Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595602}

https://chromium.googlesource.com/catapult.git/+log/ac93684421fa..69f64b270397


git log ac93684421fa..69f64b270397 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 oysteine@google.com Allow bindId for separate begin/end slices as well
2018-10-01 simonhatch@chromium.org Dashboard - Create histograms per bot for alert statistics
2018-10-01 cbruni@chromium.org [pinpoint] Redirect to raw results.html on job completion
2018-10-01 pasko@chromium.org Avoid running Android background jobs


Created with:
  gclient setdep -r src/third_party/catapult@69f64b270397

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:890025,chromium:876233,chromium:890424,chromium:881384
TBR=sullivan@chromium.org

Change-Id: I3fa5e360f1c7c98152f5078c58d9d41e34b66ebc
Reviewed-on: https://chromium-review.googlesource.com/1254685Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595601}

BUG=737995,881371
TBR=pkasting

Change-Id: Ifd8b41626747ae8e52fd7db67e86af5d87b9994f
Reviewed-on: https://chromium-review.googlesource.com/1255594Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595600}

This patch adds code to skip subtree walk if it was forced for
a reason that is blocked for isolation.

R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I80b0010bbda722d03a07e4293d13e494b5da53e1
Reviewed-on: https://chromium-review.googlesource.com/1252941
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595599}

When a preview is client blacklisted, this should be reported to the
Data reduction proxy pageload metrics pingback. However, the boolean for
this is not properly copied before content moves the navigation data
cross thread. This is resulting in never reporting the client blacklist
blocking the optimization.

Another bool (offline_preview_used) is also not copied, but it is only
used on the IO thread currently, so there is not functional bug.

Bug: 890983
Change-Id: I6fafaa91d875b590ee5c5c725bc6f487e63395c4
Reviewed-on: https://chromium-review.googlesource.com/1255889Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595598}

* Get rid of #define OS_CHROMEOS
* Stop using GetActiveUserProfile.
* Separators between functions
* Remove ctors and DISALLOW_COPY_AND_ASSIGN for conciseness.
* Consistency in declarations.
* Consistency in use of DVLOG
* Match order of functions in header and cc.
* Remove kOnlyAvailableOnChromeOSError

BUG=None
TEST=browser tests, vm_sanity

Change-Id: I0b6900886642479a84c70387c69042c51b9ad5ea
Reviewed-on: https://chromium-review.googlesource.com/1251261Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595597}

This cl converts middleClickAutoscroll.js and the middle click autoscroll
layout tests that are using it to use gpu benchmarking.

Bug: 875945
Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6
Reviewed-on: https://chromium-review.googlesource.com/1251901Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595596}