- 03 Jan, 2020 18 commits
-
-
Kurt Horimoto authored
This CL creates OverlayResponseSupport, which allows objects to specify support for a subset of OverlayResponse types. This will allow for the removal of OverlayDispatchCallbackStorage, which uses templated container objects to associate callbacks with their required response info types. Support for a variety of responses can be specified by constructing OverlayResponseSupports with a vector of support instances to aggregate. OverlayRequestSupport was also updated to use a similar constructor for consistency, and AggregateOverlayRequestSupport was deleted. This CL also adds OverlayResponseInfo, a template to be specialized for OverlayUserData used to configure OverlayResponses. This template declares a static ResponseSupport() that returns a support for responses created with that info type. Bug: none Change-Id: I7d1cd13f9a05511c3dc95739055347284e7f7060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984464 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#728089}
-
Caleb Rouleau authored
The arguments that the run_performance_tests.py script does not recognize are by default passed through to the Telemetry executable. Now that we have gtest on the same shard, those passthrough arguments are confusing the gtest perf tests. Example: https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=0e33146297150a5de344790520644a01710927c7&as=benchmark_log.txt is broken because of the added arguments -v --browser=android-chromium --upload-results --assert-gpu-compositing . For Gtest you can instead add flags to the shard itself. In the future, we should figure out how to put the passthrough arguments onto the shard map for Telemetry as well, but for now this will fix the immediate problem. Bug: 921353 Change-Id: Ie5d853aa402fc84e21a4f2f3cf180cb150f7e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981100 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728088}
-
Theresa Wellington authored
Move some classes out of widgets and into more feature-specific packages: - prefeditor/ is used for autofill/payments pref/profile editing and has depenencies on the autofill package, so it moved to org.chromium.chrome.browser.autofill.prefeditor. - tile/ is used for most visited tiles on the NTP and explore sites and moved to org.chromium.chrome.browser.suggestions.tile. Most of the tile code already lived in this package. - RoundedIconGenerator is used to create fallbacks when a favicon/site icon is not available. It moved to org.chromium.chrome.browser.favicon. BUG=951455,1010192,1010196 Change-Id: I038707fe908a42cd8b15aa06bfdde355b0dc0474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986225Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#728087}
-
David Bertoni authored
When the Web Request API was moved to the UI thread, there was a fair amount clean up to do be done. This CL cleans up a bit more. Bug: 980774 Change-Id: I6a4ab52eda0508aa14c677a6fd5fddc393d3e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982687Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#728086}
-
Philip Rogers authored
This has shipped and the associated flags can be removed. Bug: 967076 Change-Id: Ieccdce6cf8daece164047046be06f87c2a146676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982659 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728085}
-
Dana Fried authored
With all of the new identity and animation stuff in the toolbar, it's important to know which button view just barfed all over any given test. Bug: 1038567 Change-Id: Ia7832558a87cb29bedbfff0e5ece8794f2b8a8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986227Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#728084}
-
nancy authored
The reason is AppServiceAppItem calls LoadIcon as well to load ARC icon, which could cause the more updates then expected. Add a ModelUpdater to check whether AppServiceAppItem has finished loading icons. When AppServiceAppItem load icon is done, create ArcAppIconLoader to valid the load icon function. BUG=1030009 Change-Id: Id85f50624e1e365d82c120e1bfa28aa960bfa340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981409 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728083}
-
Tomasz Wiszkowski authored
non-decorated suggestions are presenting a highlight cut at the beginning of suggestion text. This change ensures the highlight stretches to the right end of the suggestion area instead Bug: 1037868 Change-Id: I0e5a345b47387d7055977b9c115e0b90478e0e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985130Reviewed-by:
-
James Cook authored
For SplitSettingsSync we want the browser settings UI for sync to behave like other platforms as much as possible. Add the settings-sync-account-control Polymer element to the Chrome OS build and show it in the sync section if SplitSettingsSync is enabled. Screenshot: http://screen/wZkgztB5EnJ TODO: Make the "Turn on" and "Turn off" buttons work properly. Right now "Turn on" assumes the DICE identity model (not used on Chrome OS) and "Turn off" tries to sign out the user (not supported on Chrome OS). Bug: 1013466 Test: existing browser_tests for settings Change-Id: I5780e42e6ca199c379da41f181d1487dc6f9aeae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978844Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Istiaque Ahmed authored
https://chromium-review.googlesource.com/c/chromium/src/+/1970854 should have fixed ServiceWorkerBasedBackgroundTest.UpdatePackedExtension test and this CL enables the test. Bug: 1003244 Change-Id: Iabc65e87b2f718987de007f029a63adff8992316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984751Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f3b0f52a1eb1..256dd2b58411 git log f3b0f52a1eb1..256dd2b58411 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 michael.liao@microsoft.com DevTools [Common - ARIAUtils]: making ARIAUtils.alert() element inaccessible Created with: gclient setdep -r src/third_party/devtools-frontend/src@256dd2b58411 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006368 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I382578444cb07308185158aef449ba39c619da50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728079}
-
Simon Pelchat authored
R=sophiechang@chromium.org Bug: 1030920 Change-Id: Ic205ef4badac845d6c4d7ac630a0781a5d0442cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951891 Commit-Queue: Simon Pelchat <spelchat@chromium.org> Auto-Submit: Simon Pelchat <spelchat@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728078}
-
Sadrul Habib Chowdhury authored
Add some trace-events to track the peak gpu memory usage, and the steps when the peak usage changes. Screenshot: https://i.imgur.com/VXtOodN.png BUG=908462 Change-Id: Ic03d69f20ab4de06606f6ca5f4449b7993a8cb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984899 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#728077}
-
Ken MacKay authored
Merge-With: eureka-internal/348424 Change-Id: I3a3971c4e0130c80dc1016d3fddf9c1e9f726c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982704Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#728076}
-
liberato@chromium.org authored
Previously, we allowed P to call surfaceDestroyed on the UI thread, rather than the dialog overlay thread. This was due to a framework bug. However, it seems that the bug still exists in Q, so the workaround is allowed for >= P instead. Bug: 1029445 Change-Id: Idd0eb15f388450d8cb91c63fe87356b34c9571f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985234Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728075}
-
Ian Kilpatrick authored
The content_size parameter for ComputeBlockSizeForFragment within MainAxisContentExtent wasn't accounting for a scrollbar if present. This resulted in an undersized flexbox. Bug: 845235 Change-Id: Ie1407ae71e2d3929359742539ebc938175e5222d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981689 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728074}
-
Ian Struiksma authored
Need to update expected value to fix issue with offset changing on the new year 2019-2020. Here is the diff between cipd versions: nordstrom.test 238c238 < "expectedValue": "7", --- > "expectedValue": "8", Bug: 1038779 Change-Id: I54aa15c35c5d0fc112f679646deb0c3a5ea11715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985335 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728073}
-
Avery Musbach authored
Bug: None Change-Id: Iaf0c5d02293d89dcf8581f6cf3418aff5d6d0c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985338Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#728072}
-
- 02 Jan, 2020 22 commits
-
-
Ian Kilpatrick authored
In order to get use the correct min/max sizes for flex-items we need to perform a layout *before* calling ComputeMinMaxSize. (This is yet another reason why we should merge the min/max sizes pass with regular layout). Additionally this patch implements the: LayoutBox::HasTopOverflow LayoutBox::HasLeftOverflow methods to correctly calculate the scrollable overflow. Bug: 845235 Change-Id: I3059dfa72969c690abe3808629166194c84fcd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978103 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Mason Freed authored
Prior to this CL, some parts of FormControlsRefresh were keyed off of the base::Feature, while others were based on the RuntimeEnabledFeature. That made it difficult to reason about when the feature was enabled or disabled. E.g. an attempt to set the default for the RuntimeEnabledFeature to "test", to enable it for testing only, would result in only part of the feature being enabled in that case. With this CL, the RuntimeEnabledFeature has been removed, and all of the new look and feel is controlled solely from the base::Feature. The feature can be enabled with: --enable-features=FormControlsRefresh Bug: 1012106, 1035510 Change-Id: If3ea206cb5a89beb8c21dc105df7ba36ba41f0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984748 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Works around a StrictMode violation coming from ArCore by allowing disk writes when checking for ArCore APK availability. Bug: 1038757 Change-Id: I0fbc469d243d89e14068b5d9ab3fca19999f122b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986246Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728069}
-
Caleb Rouleau authored
Note that this change also reshards the Win 7 Builders, which may cause false positive regressions. In the event of perf regressions, this CL should not be reverted, since it is not causing the regression; it is just moving the test to run on a different device (of the same model and OS). Also, move to only use 4 shards instead of 5. We are seeing that these bots die sometimes (examples: crbug.com/1038720, crbug.com/1038719), so it is better to keep one device in reserve to help out if another one dies. See https://chromium-review.googlesource.com/c/chromium/src/+/1983326 for background. This moves all the gtest perf tests on Win 7 Perf and Win 7 Nvidia GPU Perf into the performance_test_suite and onto the shard maps. This allows us to run them in parallel with the Telemetry benchmarks and account for their runtime within our system. Bug: 921353 Change-Id: I284924447435325da2263131e0b7df6411b04e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985134 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
-
Christopher Cameron authored
We don't send the color space to the browser's ui::Compositor on macOS. This has been broken on macOS for an unknown period of time. It didn't actually make a difference because - that only set the raster space for browser UI, which is sRGB anyway - the renderer got the correct color space for raster via RenderWidgetHostImpl::GetScreenInfo - we would draw using CoreAnimation (not GLRenderer) >99.9% of the time, so the ui::Compositor's GLRenderer's color space didn't matter Because of rounded corner rects, we hit the GLRenderer more often, causing this bug be visible. Change RecyclableCompositorMac::UpdateSurface to take a required color space argument, ensuring that all callers specify a value. Bug: 1038723 Change-Id: Icde934718371802356c5c26277a628361705009f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985127Reviewed-by:
-
Haiyang Pan authored
Bug: 986990 Change-Id: I0a6d4f292fa5faea259af45cee83f271ac7cdcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985129Reviewed-by:
-
Devlin Cronin authored
I'm not currently looking at these; update ownership to the web ui team and extend the expiration date. Bug: 1037109 Change-Id: I54a78afd636883954ef057899f135e6583e1d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981061Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This adds several more features/flags to the Dev UI flags Activity. This changes makes a small change to the build file so common_java can depend on common_commandline_java so we can use a string constant. Bug: 981143 Test: Manual - verify the new features show up in the UI Test: Manual - toggle committed SB interstitials, observe behavior \ Test: change in demo app (CI currently creates an extra net error) Change-Id: I034a06f30739a1c33950de7745e1bb39de05ca76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981193Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728064}
-
Ayu Ishii authored
Bug: 1007667 Change-Id: I9323b7df3b276263bc5e09acb3e8aa5aae36b265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979012Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#728063}
-
Philip Rogers authored
Hit test rects depend on the size and location of an object and need to be invalidated if this changes. Change-Id: I1eda93969818d4c21be15882f027e3c134a64c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984463Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728062}
-
Michael Irani authored
Change-Id: I5ca6113546e431318b55fd4435ce4cc7896c33db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981138Reviewed-by:
-
Nate Fischer authored
This refactors developer mode logic, so the implementation can be shared by both the developer UI and the embedded WebView code. This also renames the ContentProvider so it can be used more generally in the future. Bug: 1036533 Test: Manual - verify flags Activity continues to work Change-Id: I6cb4b0dfb751cd04884af3768f051ebe6795ea5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982232Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0bad0c3f9858..f3b0f52a1eb1 git log 0bad0c3f9858..f3b0f52a1eb1 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 anubmat@microsoft.com DevTools: Add Supporting function for Performance panel a11y tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@f3b0f52a1eb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I83d6c3f5112a4350c134e69e69ad6c70e032f9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986174Reviewed-by:
-
Andrew Grieve authored
This reverts commit 90164da9. Reason for revert: Underlying issue was fixed (see bug) Original change's description: > Revert "Remove native deps from chrome_junit_tests" > > This reverts commit 4b1723f2. > > Reason for revert:crbug.com/1035586 > > Original change's description: > > Remove native deps from chrome_junit_tests > > > > And adds an "assert_no_deps" to prevent regressions. > > Would be nice to assert that the junit target does not depend on //base, > > but it looks like all grit targets depend on //base, and fixing that > > would require a larger refactor. > > > > Bug: None > > Change-Id: I970cdb458d50a32f55165756a10e66857470d75a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953400 > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#723080} > > TBR=wnwen@chromium.org,agrieve@chromium.org,mattreynolds@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: I5f5d1e67637e6aa4d1008b8227c84ce114bcf867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974586 > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726168} TBR=wnwen@chromium.org,agrieve@chromium.org,mattreynolds@chromium.org,alcooper@chromium.org Bug: 1035586 Change-Id: Ie3ffcc34137302d07d0114099281107b8402a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985556Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728058}
-
Jeremy Roman authored
On the way, refactor how the Portal <-> WebContentsImpl pointers are maintained, as this work caused the raw WebContentsImpl* to dangling while writing the main code of this CL, which made for a confusing bug. This refactoring is mainly a mechanical gathering of the code responsible for updating these into a small nested class. Bug: 964481 Change-Id: I8a63e1a5531de4807569b35ea0f3fcb19baf343c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976000Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728057}
-
Takashi Toyoshima authored
Since WebView launch is planned at m81, and launch metrics review will need them, we need to keep them for a while after m81 stable promotion. Current expiry date is defined as after M82, and it effectively means around Apr 4, 2020. So, it's better to keep them for one more milestone. Bug: 1037154 Change-Id: If1f479c1802690a37915f39a5b60761e4684b402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981248 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Eugene But authored
This histogram can be useful for detecting URL spoofing bugs in WKWebView. Bug: 1037354 Change-Id: I85e2c50912b93097f55140305edb7bb157e95e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980905 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This is a followup to https://crrev.com/c/1977309 to fix cellular network technology icon inconsistency. The previous CL adds checks for network technology changes when checking for active network changes. This CL makes changes to NetworkStateHandler that ensures that these checks are run for network technology property changes in the first place. Unit tests were also added. Fixed: 994445 Change-Id: I7790c3794f27c26e099eaab9e7db718b00aff73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982238Reviewed-by:
-
Dana Fried authored
Moves slide animation up from account toolbar icon container to the base ToolbarIconContainerView code, so all containers (currently, account and extensions) use that animation. Bug: 1038571 Change-Id: I2ee636e6df388255699157ceaa09b854b9ced716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985165 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Pavel Yatsuk authored
This change drops SnackbarTest's dependency on ChromeActivity, allowing test to be moved to chrome/browser. BUG=1028382 R=twellington@chromium.org Change-Id: Ia22613b9666a934e5bb6be1aeb7325e9022ed1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986219Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#728052}
-
Alex Cooper authored
Currently, getPose for a screen tap on a sensorless inline session fails because there is no "MojoFromViewer" pose available. In a sensorless session "Mojo" Space and "Viewer" space are the same, so this should return identity. Fixed: 1031596 Change-Id: Ic09590be6bbeff84cfaad894a2c1702ed7d3f896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978901 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#728051}
-
Dana Fried authored
Exactly what it says on the tin: icons (save credit card, save passord) now slide out from under the profile icon instead of just appearing. Updated a couple of browser tests to make sure we don't have flaky behavior due to the new animations. It looks pretty cool tbh. Bug: 1037946 Change-Id: I70803e204e8ccb14273ce2e57f21f808e947d068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981334 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
