- 09 Nov, 2018 40 commits
-
-
Kristi Park authored
Remove the Most Visited 'loaded' event listener after the 'loaded' message is sent. This was interfering with other domAutomationController listeners in subsequent script executions. Bug: 903265 Change-Id: Iccd33d3eb04330a23880735b48a00d2f97a50866 Reviewed-on: https://chromium-review.googlesource.com/c/1327425 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606920}
-
Tom Tan authored
Some assembler directives are OS specific, like .type and .hidden only make sense in ELF. They are not valid for Windows ARM64 even with the same assembler syntax. This change defines macro to select directives according to target OS. This looks like a convention for assebmly source code. Bug: 893460 Change-Id: I7b5a8dc1648987932f11422d3b393513b6b69fbe Reviewed-on: https://chromium-review.googlesource.com/c/1327884Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#606919}
-
Roman Aleksandrov authored
Just simple refactoring. Bug: 792774 Change-Id: I90e97fb8fd4e1ab5bb91f03b19ec8031eeb24375 Reviewed-on: https://chromium-review.googlesource.com/c/1326145Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#606918}
-
Michael Lippautz authored
Bug: 902286, 843903 Change-Id: I2f4a836bfb448e092a7301a326c0caed722d607e Reviewed-on: https://chromium-review.googlesource.com/c/1329175Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606917}
-
Bailey Berro authored
Adds is_chromeos checks to the build files for the add-smb-share-dialog Bug: chromium:887135 Change-Id: I7ba729324c9e523f82924927f6eab86be8e4247f Reviewed-on: https://chromium-review.googlesource.com/c/1323806Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#606916}
-
Sky Malice authored
Bug: 901331 Change-Id: I597c20c8726c0d25c37de04c1001502e535bf6f5 Reviewed-on: https://chromium-review.googlesource.com/c/1318831Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606915}
-
Katie Dillon authored
Missed changing these two perf tests while making this change: https://chromium-review.googlesource.com/c/chromium/src/+/1318390 Bug: 903445 Change-Id: I8d151bfc464aae4cc1d0bd8fa993607cde25d18d Reviewed-on: https://chromium-review.googlesource.com/c/1327524Reviewed-by:
-
Sadrul Habib Chowdhury authored
Report when the presentation-timestamp reporter by the driver is earlier than the swap-time. Report this metric on all platforms. Change the metric for reporting presentation-timestamps from the future to be reported on all platforms (instead of just android). This also removes DumpWithoutCrashing() for the future-timestamps. BUG=894440 Change-Id: I663fdeab41b3f7de3e76f0e0ae440efbdae79bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1325417 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#606913}
-
Sergey Poromov authored
Together with CRX_INSTALL_ERROR_* reason, the details of the failure are reported in a separate "Extensions.ForceInstalledFailureCrxInstallError" histogram. Bug: 787970 Change-Id: Icd76bf2f1b15f219aa99f37385e77a63eb3573f2 Reviewed-on: https://chromium-review.googlesource.com/c/1323652Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606912}
-
sczs authored
Since the InfobarView is no longer communicating its size to Infobar.cc there's no need to have the machinery necessary so Infobar.cc communicates with our InfobarContainerView. The InfobarContainerView will be updated via the VC viewDidLayoutSubviews which was the change made on https://crrev.com/c/1321849/ Adds an extra test case. Bug: 892376 Change-Id: I5457c17a8e1e586b02b5ca9906abd4341e5a56d4 Reviewed-on: https://chromium-review.googlesource.com/c/1325034Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606911}
-
James Cook authored
Ash has a transitive dependency on the device fingerprint service, so the test-only ash_shell_with_content won't start up without declaring that requirement. Bug: none Test: run ash_shell_with_content, it starts Change-Id: Id8acd41c154738a9470b8b19f63da93fede1740f Reviewed-on: https://chromium-review.googlesource.com/c/1329623Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#606910}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5fc6c2c52e7b..7b37bbfad45f git log 5fc6c2c52e7b..7b37bbfad45f --date=short --no-merges --format='%ad %ae %s' 2018-11-09 lalitm@google.com trace_processor: fix ordering of slices in trace storage Created with: gclient setdep -r src/third_party/perfetto@7b37bbfad45f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2743499d550e8c172a3ef0bc894051d09c8515b8 Reviewed-on: https://chromium-review.googlesource.com/c/1329981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606909}
-
Vlad Tsyrklevich authored
TBR=caitkp@chromium.org Bug: 896019 Change-Id: I59ead55fbc258d981092c7e99d935a2a518a8921 Reviewed-on: https://chromium-review.googlesource.com/c/1324873 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606908}
-
Mike Wittman authored
Starts sending a small amount of data using the new format written by the new profile builder, for initial testing. Bug: 851163 Change-Id: I1b8f5adae4ac5eeed2ab30e79e49790b5916f6dc Reviewed-on: https://chromium-review.googlesource.com/c/1327808Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606907}
-
manuk authored
Bug: 891303 Change-Id: I682561e9427a0f2dedf356744bc66d28eff64ccb Reviewed-on: https://chromium-review.googlesource.com/c/1329444Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606906}
-
Ehsan Chiniforooshan authored
The flags were accidentally removed in crrev.com/c/1318395. Bug: 903312 Change-Id: I89c20ceb807bb68ebb35f24bccf83fbc9482a117 Reviewed-on: https://chromium-review.googlesource.com/c/1329548 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#606905}
-
kylechar authored
If we don't have a valid shared memory handle return early and don't try to map the memory. Also move check for duplicated ids earlier in the function. Bug: none Change-Id: I53b113cc3da2149d15fa70afa8bc8d52bc362e8d Reviewed-on: https://chromium-review.googlesource.com/c/1326842 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606904}
-
Xiaohui Chen authored
Bug: 870515 Test: locally build and run Change-Id: Ic2b5be8d7ff3bf694ddbb8cb29511b3bb5ad610e Reviewed-on: https://chromium-review.googlesource.com/c/1318691 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#606903}
-
Ivan Sandrk authored
One of the new disclosure strings on the login screen was deemed a bit too strong on the words and was causing people to be distressed, therefore we are reverting it to the previous version. Bug: 903810 Change-Id: I761b978fb553024bcfb2ac2efd7e208d513ee703 Reviewed-on: https://chromium-review.googlesource.com/c/1329781 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#606902}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a5a766d7. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I5d99a196dac4514f62d75d2ea68d038358c7fd12 Reviewed-on: https://chromium-review.googlesource.com/c/1329441 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606901}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=sky@chromium.org Bug: 766678 Change-Id: I3b6193072a7049433d38a61ff62c1f34454c7b5e Reviewed-on: https://chromium-review.googlesource.com/c/1324454 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606900}
-
Steven Bennetts authored
This CL moves SendKeyEvent to ChromeVirtualKeyboardDelegate which is the only place it is used. It also: * Uses aura::EventInjector instead of EventSink::OnEventFromSource so that events will be injected properly in Mash. * Removes the undocumented histogram (without documentation it is very unlikely that it is used): VirtualKeyboard.KeystrokesBetweenBackspaces Bug: 876138 Change-Id: I39836f5593587c32ccb229ca32a2126199500533 Reviewed-on: https://chromium-review.googlesource.com/c/1313208 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606899}
-
Yi Su authored
This CL let iOS SearchEngineTabHelper extend FaviconDriverObserver so that it has equivalent functionality as the SearchEngineTabHelper in /chrome/browser/ui/search_engines. Bug: 433824 Change-Id: If49d1b46d90b2250c2b378d77d9e3cea5cdd96a5 Reviewed-on: https://chromium-review.googlesource.com/c/1329171 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit 4ff885a1. Reason for revert: CHECK not reached. The URLLoader to blame was the WebRequestProxyingURLLoader. Original change's description: > BlobUrlLoader: Instrument for bug 882661. > > In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody > without sending OnReceiveResponse before. > > Add instrumentation to check this never happen with this class. > > Bug: 882661 > Change-Id: Ia9df5debbc03f0a5296c64edbcf6d975806bc021 > Reviewed-on: https://chromium-review.googlesource.com/c/1304435 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605181} TBR=kinuko@chromium.org,mek@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882661 Change-Id: I16e8a5709f34d6909445c9cb0f674f07702ff594 Reviewed-on: https://chromium-review.googlesource.com/c/1329782Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606897}
-
Douglas Creager authored
Piece by piece, we are moving the Reporting and NEL processing code from URLRequest and friends into HTTPNetworkTransaction, to make sure that we produce reports for network requests as defined by the spec (e.g., for redirects and cached responses). This patch moves the processing of the Report-To configuration header. Bug: 895823 Change-Id: Id6f51eefdb9afc43ad3841fb3c3f6d6b39fd2943 Reviewed-on: https://chromium-review.googlesource.com/c/1293555 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#606896}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c244c2fbbbf8..ef4709b7850d git log c244c2fbbbf8..ef4709b7850d --date=short --no-merges --format='%ad %ae %s' 2018-11-09 mtklein@google.com move blend-row routines to SkBlitter_ARGB32.cpp 2018-11-09 mtklein@google.com get familiar with SkBlitMask_D32.cpp 2018-11-09 egdaniel@google.com Revert "Have a GrBackendFormat be stored on gpu proxies." 2018-11-09 mtklein@google.com remove unused typedef 2018-11-09 halcanary@google.com SkQP: script: fix non-existant build path 2018-11-09 reed@google.com remove guards for hinting in google3 2018-11-09 nathanrogers@google.com Fix another typo in SkSize comments 2018-11-09 nigeltao@google.com Merge SkFooAdapterCodec impls into one impl Created with: gclient setdep -r src/third_party/skia@ef4709b7850d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:903701 chromium:903756 TBR=allanmac@chromium.org Change-Id: I49bf07d7c1d1b5a67bf3317b67cd93e5bcb44e6b Reviewed-on: https://chromium-review.googlesource.com/c/1329504Reviewed-by:
-
Mario Sanchez Prada authored
Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually creating the browser's state by providing specific factories, and then use the APIs from IdentityTestEnvironment, instead of SigninManagerBase. Also remove an unnecessary DCHECK in clear_browsing_data_manager_unittest.mm, as pointed out post-review when fixing crbug.com/890826 (CL 1318974). Bug: 903703 Change-Id: I9d4dd625441005a36c962628fe3fe1f15ab56bb6 Reviewed-on: https://chromium-review.googlesource.com/c/1328985Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#606894}
-
Mohamed Amir Yosef authored
Change-Id: I04dcc33b375f552a8e4e6dbc8b5ae75869ddfa08 Reviewed-on: https://chromium-review.googlesource.com/c/1329783Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606893}
-
Peng Huang authored
The WebGL content is a flipped TextureQuad. SkiaRenderer only flips the Y coordinate for drawImageRect(with canvas->scale(1, -1)). It will draw the image outside of the Window (y < 0). To fix this problem, we use canvas->translate(0, quad_rect.bottom()) to move it back into the window. Bug: 901822 Change-Id: I6b98f82fba896021e1c2878632b26a3bd8029845 Reviewed-on: https://chromium-review.googlesource.com/c/1324137 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Bin Wu authored
Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look." This reverts commit 683a3487. In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/steps/net_unittests/0/stdout The msan error goes away after I changed the following bzero(s) into memset(s): diff --git a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h index 94f055f35564..198e266dfdf2 100644 --- a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h +++ b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h @@ -102,7 +102,7 @@ class QuicMMsgHdr { } storage_.reset(new char[StorageSize()]); - bzero(&storage_[0], StorageSize()); + memset(&storage_[0], 0, StorageSize()); int i = -1; for (auto it = first; it != last; ++it) { diff --git a/net/third_party/quic/platform/impl/quic_socket_utils.cc b/net/third_party/quic/platform/impl/quic_socket_utils.cc index c25f4697dbef..1f252e50f953 100644 --- a/net/third_party/quic/platform/impl/quic_socket_utils.cc +++ b/net/third_party/quic/platform/impl/quic_socket_utils.cc @@ -78,7 +78,7 @@ void* QuicMsgHdr::GetNextCmsgDataInternal(int cmsg_level, if (cmsg_ == nullptr) { DCHECK_EQ(nullptr, hdr_.msg_control); - bzero(cbuf_, cbuf_size_); + memset(cbuf_, 0, cbuf_size_); hdr_.msg_control = cbuf_; cmsg_ = CMSG_FIRSTHDR(&hdr_); } else { R=rch@chromium.org Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106 Reviewed-on: https://chromium-review.googlesource.com/c/1329348 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#606891}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Change-Id: Ia0a6622596753d87888e480401e38f7ef61ae539 Reviewed-on: https://chromium-review.googlesource.com/c/1326013Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/827de2c806ba..5fa11106b909 Created with: gclient setdep -r src-internal@5fa11106b909 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie1b9b04d41e2a6dfe8e4fa45f0d25892052660e1 Reviewed-on: https://chromium-review.googlesource.com/c/1329503Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606889}
-
Fady Samuel authored
viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an allocation time for that viz::LocalSurfaceId. The purpose of this allocation time is to determine how long it takes for a surface to get embedded once an ID has been allocated for it. There was some concern raised about drift between LocalSurfaceIds and allocation times and so a previous CL bundled the two together in a class. This CL plumbs LocalSurfaceIdAllocation to more places to ensure the two quantities remain in sync with one another. This CL plumbs removes various accessors on ChildLocalSurfaceIdAllocator and ParentLocalSurfaceIdAllocator that return an allocation time or LocalSurfaceId independent of the other. This is to encourage future plumbing of LocalSurfaceIdAllocation instead. Bug: 655231 Change-Id: I3118cc06e0afa04914a0e2e7457ffdfd5ad5778d Reviewed-on: https://chromium-review.googlesource.com/c/1327573Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606888}
-
Joe DeBlasio authored
This CL modifies fixes a bug in which metrics were not being recorded on Android when notification permissions were revoked. It adds a missing ScopedRevocationReporter for Chrome-visible changes, and adds detection code for when notification permissions are revoked in Android O+ system channel settings. Bug: 782126 Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75 Reviewed-on: https://chromium-review.googlesource.com/c/1324394 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606887}
-
Sky Malice authored
Bug: 901179 Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615 Reviewed-on: https://chromium-review.googlesource.com/c/1315358 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s' 2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles" Created with: gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958 Reviewed-on: https://chromium-review.googlesource.com/c/1329505Reviewed-by:
-
https://crrev.com/c/1272937Hayato Ito authored
Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target can be null when GetElement() returns nullptr. Bug: 892970, 893449, 902287 Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1322177 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606884}
-
Mathias Carlen authored
Before this patch the payment request UI did not properly handle cancel and back button. This patch notifies the Autofill Assistant controller to shut down gracefully with a 'give up' message whenever the payment request UI has been canceled. Bug: 806868 Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1326499 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606883}
-
Lan Wei authored
After we expose test_driver.Actions API to web users, we add their implementation in our testdriver file, and fix the wpt tests of Actions API. Bug: 893480 Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c Reviewed-on: https://chromium-review.googlesource.com/c/1289119 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606882}
-
Becky Zhou authored
Bug: 891877 Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b Reviewed-on: https://chromium-review.googlesource.com/c/1325082 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
