- 03 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e18a2584ca06..b711c4303271 2020-06-03 kahinds@microsoft.com Fix keyboard-focus indication on animation playback speed button-group 2020-06-03 brcui@microsoft.com Add --chrome-binary argument to unittest script If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086421 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25e024174434758eba930720e2e9a40b501c8fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774806}
-
Tim Volodine authored
Extend expiration date for: Android.WebView.onReceivedError.ErrorCode Android.WebView.onReceivedHttpError.StatusCode No change in logic. BUG=1057673,1057674 Change-Id: I87a281a8c88c0811b09f023c7e404d33ace451d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212130 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774805}
-
Mike Dougherty authored
Bug: 1082892 Change-Id: I10a20600fcea65a32e32a2a656f1e3a2f3a01f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226779 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774804}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3fdc49f35718..64c8b811b55a 2020-06-03 senorblanco@chromium.org Dawn: fix memory corruption in DawnTestContext. 2020-06-03 kjlubick@google.com [canvaskit] Publish v0.16.0 2020-06-03 ethannicholas@google.com Fixed sample_matrix_constant GM 2020-06-03 wtc@google.com Fix comments for SkYUVColorSpace 2020-06-03 ethannicholas@google.com Reland "Revert "Omit dead SkSL functions"" 2020-06-03 kjlubick@google.com [canvaskit] Add JS optimization for int color 2020-06-03 herb@google.com simplify loop in updateTextureCoordinates 2020-06-03 kjlubick@google.com [canvaskit] Make SkCanvas.drawColor/clear take SkColor4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10311 Tbr: tdenniston@google.com Change-Id: I7aeaeac4a6a116283f57d8054e55e5dbfafb0c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774803}
-
Daniel Hosseinian authored
Essentially a reland of crrev.com/741291 with the correct feature name. The original CL used a wrong and non-existent feature name. Consequently, the config was detected as stale and was removed in crrev.com/742702. Bug: 1021350 Change-Id: Iee460cd6b7eac51134c8a7aba79e68e1f1fd655d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225484Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#774802}
-
Denis Kuznetsov authored
Bug: 981472 Change-Id: Iae40ce334e798a2eee0c0f8d458f11dae6189921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228317 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774801}
-
Domenic Denicola authored
This adds console warnings when header-based origin isolation is requested, but not granted, or when it is not requested, but is imposed. Along the way, a bug with the use counter code for the Origin-Isolation header was discovered. Fixing this is best done via similar mechanisms as adding the warnings, namely saving some state early in the navigation lifecycle to be reported later. Bug: 1087562, 1066931 Change-Id: I5dce9f48c64f4dd62dcdcea60be94e6492ab9085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220358Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774800}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/6dfe58d86e80..4026f6e15a $ git log 6dfe58d86..4026f6e15a --date=short --no-merges --format='%ad %ae %s' 2020-06-02 quiche-dev Delete Quartc 2020-06-01 dschinazi Replace quic_enable_version_t050 with quic_disable_version_t050 2020-06-01 fayang Deprecate gfe2_reloadable_flag_quic_stream_id_manager_handles_accounting. 2020-06-01 dschinazi Deprecate quic_remove_android_conformance_test_workaround 2020-06-01 fayang Deprecate gfe2_reloadable_flag_quic_break_session_stream_close_loop. 2020-06-01 fayang Internal QUICHE change 2020-06-01 quiche-dev Enabling rolled out flags. 2020-06-01 wub Deprecate --gfe2_reloadable_flag_quic_ignore_msg_too_big_from_buffered_packets. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src add flags, remove quartc R=dschinazi@chromium.org Change-Id: If152dc8e30134a97bd5d97cd30db8d4699882929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227372 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#774799}
-
Doug Arnett authored
Bug: 1089125,1089130,1089134,1089135 Change-Id: I062d817cb441c4c0c86f007b6915977e0c597574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228138Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#774798}
-
Francois Doray authored
TBR=fdoray@chromium.org Bug: 1059468 Change-Id: I050e2d843fc1c303944dd7be4483423d793b0d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229424Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774797}
-
Dominic Mazzoni authored
This reverts commit 50b3e1fd. Reason for revert: crbug.com/1090992 Compile failures: FAILED: obj/chrome/browser/browser/recovery_component_installer.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../chrome/browser/component_updater/recovery_component_installer.cc:419:3: error: too few arguments to function call, expected 3, have 2; did you mean 'base::ThreadPool::PostTask'? base::PostTask(FROM_HERE, base::BindOnce(std::move(callback), result)); ^~~~ base::ThreadPool::PostTask ../../base/task/thread_pool.h:95:15: note: 'base::ThreadPool::PostTask' declared here static bool PostTask(const Location& from_here, OnceClosure task); ^ Original change's description: > [base] Remove implicit-destination PostTask > > No TaskTraits implcitly meant base::ThreadPool. The migration away > from this paradigm is complete (task APIs v3 is bringing explicit > API-as-destination). Remove this right away before we're ready to > completely remove post_task.h to avoid the addition of new callers > without an explicit destination. > > Bug: 968047, 1026641 > Change-Id: I54d04872498d340cfd8ec02aa88b3e9cba1a7547 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225541 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774758} TBR=gab@chromium.org,skyostil@chromium.org Change-Id: Ia6e764cf3293ef9ac789ce6f173951ab8e4736fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047, 1026641, 1090992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229410Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774796}
-
Connie Wan authored
Followup to comment in crrev.com/c/2212812 Bug: 1085560 Change-Id: I457a29d6420b88935412054bc46c7d772a98a2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225280Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#774795}
-
John Abd-El-Malek authored
Right now this is just a dcheck, but in the foreseeable future we can make it CHECK in canary/dev builds to get more data (e.g. those based on experiments). Bug: 1085309 Change-Id: I82b9321226471ed1e79b158fc3c5837b12ac262d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215704 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774794}
-
dpapad authored
Specifically: - cr_search_field_tests.js - cr_slider_test.js - cr_splitter_test.js - cr_tabs_test.js Bug: 1000989 Change-Id: Ia3c15641dbee6970e1d26399aeaac501b88fb628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227180 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#774793}
-
Prashant Nevase authored
Implements cache for inverted colors using WTF::LruCache so that paint ops can use the cached values over calculating heavy invert color operations using color filters. With cache, the filter operations are improved by 15x to 20x if all colors are stored in cache and 20% to 30% if there are more colors than cache size. This patch improves the dark mode paint ops by 2%. Bug: 1060899 Change-Id: Ia9d1fe0912d50c72835f597a731be137169a6819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102388Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#774792}
-
Francois Doray authored
R=dpapad@chromium.org TBR=fdoray@chromium.org Bug: 1090931 Change-Id: I54130c0b9a08766b8f162c2abcfc6ae04ddf2c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228128Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774791}
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: Ib1711e1ee47ca14d448b32fb680d061c658a2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159578 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774790}
-
Kenneth Russell authored
This reverts commit 79c629a2. Reason for revert: underlying flaky GPU process crash has been worked around. Original change's description: > [gpu/mac] suppress failing webgl_canvas/tex-3d-rgb8ui-rgb_integer-unsigned_byte.html > > On Mac Asan, > conformance2/textures/webgl_canvas/tex-3d-rgb8ui-rgb_integer-unsigned_byte.html > started failing. Suppress the test. > > TBR=kbr@chromium.org > > Bug: 1087083 > Change-Id: I0ece6b3d187199308e3c486f7bf927b07c59cdbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219030 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Robert Kroeger <rjkroege@chromium.org> > Auto-Submit: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772444} TBR=rjkroege@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1087083 Change-Id: Ibfda1b3e7e359f07987edcd78eb76c6309770ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229009Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774789}
-
Siyu An authored
Bug: 1070799 Change-Id: Ic0eae913e6b64ccb17a859ce246e8afe3d35fd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227330Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#774788}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/f80e88872394..c1765573149e $ git log f80e88872..c17655731 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 jianj Add NV12 support 2020-05-27 angiebird Add extra check / unit test to SetExternalGroupOfPicturesMap() 2020-05-26 angiebird Add functions to compute/observe key frame map 2020-05-26 angiebird Init static_scene_max_gf_interval in vp9_rc_init() 2020-05-26 angiebird Make SetExternalGroupOfPicture support no arf mode 2020-05-23 angiebird Add GOP_COMMAND 2020-05-18 angiebird Refactor decode_api_test and realtime_test 2020-05-19 jzern vp9_decoder: free postproc_state.prev_mip Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: I5ca97b01b15aee32514a9283f8576c58d3963ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228986Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#774787}
-
Peng Huang authored
Without OOP-R and GPU-R, there are many vulkan queue submissions per frame. It is bad for performance. So always enable OOP-R and GPU-R for vulkan unless related commandline arguments are specified. Bug: 1087063 Change-Id: I4e370af0353ea793e006f8e0b66287306daf64c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226734 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#774786}
-
Dan Sanders authored
Bug: 1075632 Change-Id: If17f71f395e7f0eea2e128edc712004458ab4039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220701Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774785}
-
Martin Kreichgauer authored
This reverts commit 9f151687. Reason for revert: The original change makes an invalid assumptions about the lifetime of FidoDiscoveryFactory (crbug/1087158). Instances of FidoDiscoveryFactory generally belong to the AuthenticatorRequestClientDelegate and as such should outlive the WebAuthn request. As an exception, instances obtained via AuthenticatorEnvironmentImpl::GetDiscoveryFactoryOverride() may be unregistered and freed before the request finishes. This revert is safe because the caBLE data reset by ResetRequestState (a) only gets set in the first place if the WebAuthenticationPhoneSupport flag is on (which is default-off); and (b) gets set anew for every single request, so it will never be reused across requests. Bug: 1087158 Original change's description: > fido: add FidoDiscoveryFactory::ResetRequestState() > > FidoDiscoveryFactory instances generally outlive a WebAuthn request, but > some of the state is specific to a single request (caBLE pairing and QR > code generation keys). This is currently not an issue, because > AuthenticatorCommon explicitly resets all that state at the beginning of > the request. But I worry that we accidentally break that and leak state > between requests. To mitigate, introduce an explicit ResetRequestState > function and call it in AuthenticatorCommon::Cleanup(). > > Change-Id: I8333a3b14d189d7977cde17cbfe44b4b8dcf6ee2 > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/1793792 > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696593} Change-Id: I3b1ea46b9b1d5912cbc7ab9a82851e5132335ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228136Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#774784}
-
Chris Harrelson authored
This CL implements the design in this document: https://docs.google.com/document/d/1ySFETbeEqD14Z8FSeuv3rlc1Vl3exhILSXqkgr2Fspc/edit# 1. Add a compositing reason for “compositing container has backface-visibility: hidden”. 2. Add more rules to ComputedStyle::HasGroupingProperty() 3. Make LayoutObject::ComputeIsFixedContainer depend on the computed style of preserve-3d, not used style. 4. Cause flattening for all DOM nodes in PaintPropertyTreeBuilder, not just ones where NeedsTransform returns true. 5. Allocate a TransformPaintPropertyNode for the “compositing container has backface-visibility: hidden” compositing reason. 6. Update LayerShouldBeSkippedForDrawPropertiesComputation and FindLayersThatNeedUpdates to return true for a backface-visibility: invisible layer if it is invisible relative to its 3D rendering root (same sorting_context_id in cc::TransformNode) Bug: 1008483 Change-Id: Idb8c8d3f9471e8ca9c730ea3b3d307a30193501e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188132Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774783}
-
Torne (Richard Coles) authored
We've identified the issue in Android which can lead to multiple copies of the same app process existing at once through no fault of the application's; retrying the lock is the only real workaround on the WebView side. We've observed process lifetime overlaps of 350-400ms in bug reports and this may not be the worst case, so a maximum timeout of 400ms is far too conservative. UMA data also shows that each increment of 100ms up to the current limit was allowing more app launches to succeed, with little dropoff. Therefore, increase the timeout to 1.5 seconds for now. While this will add a significant delay to apps in some cases, it's better than crashing, and should still be short enough not to change ANR rates significantly; Android 11 uses a 2 second timeout in the fix for this issue. We can monitor UMA data and tune this to be shorter if it shows a clear dropoff. Extend the histograms for monitoring this to give us several releases' time for tuning. Bug: 558377 Change-Id: I75bcd1b5dbf39694d78c1d9dab90af889645d8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228989Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#774782}
-
Nicolas Boichat authored
The metrics is still in use and unlikely to be dropped before end of 2023. Bug: 1089269 Change-Id: Ic4d9e7fa54044b15ffb771455f0940c46b8e0378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226098Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774781}
-
Robert Sesek authored
Bug: 1052560 Change-Id: Id7546c72f246c9910eadd6edcb49b71bb9ec8d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227858Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#774780}
-
Robert Liao authored
Interest in this metrics will exist as long as there are tabs and windows. Fixed: 1089571 Change-Id: Ib9f0d92471c0fc8842270ec2155a40203ffd6b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225492 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#774779}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7bb7115d07b9226145f7e6a15aff51953b0dbb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774778}
-
Francois Doray authored
TBR=fdoray@chromium.org Bug: 1090937 Change-Id: Ie0db29a4028ce87458ca16c32509ac9e56b9001e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229017Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774777}
-
Fletcher Woodruff authored
Push back the expiration date 5 releases. Bug: 1088720 Change-Id: If9ebf9dd252f01e75d17c6d91508a999b0f6404e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224972 Auto-Submit: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774776}
-
Nate Chapin authored
This reverts commit 46c7d082. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1090597#c4 Original change's description: > Remove all non-DocumentLoader uses of LocalDOMWindow::InstallNewDocument > > LocalFrame::ForceSynchronousDocumentInstall and a few unit tests > manually replace the Document of a LocalDOMWindow. They can be switched > to go through the static-response navigation commit path relatively > easily. This establishes the rule that only DocumentLoader is allowed > to create a LocalDOMWindow or replace its Document. > > Bug: 1029822 > Change-Id: I84b37f35be5387556999f9bc24f7ba5fa74b4ff8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222776 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773720} TBR=dcheng@chromium.org,haraken@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029822 Change-Id: I58b897f7bb5327765c86f907a5179bb76fcccf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229104Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#774775}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia13e5a77a126b0f4ee14365a938501ddbf26cdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229300Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#774774}
-
Chris Lu authored
Change-Id: I22d295b2e3f014b2d279ef6729e405399dd15349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227394Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#774773}
-
Ali Juma authored
This changes PolicyDecisionStateTracker's destructor to invoke the state tracker's callback if it hasn't already been invoked. Destroying the callback without ever invoking it can result in a WKWebView-provided callback never getting invoked, which triggers an NSException causing a crash. In the linked bug, the PolicyDecisionStateTracker is destroyed as a result of MainFrameUrlQuery::operator= implicitly releasing its old response_callback, which owns the state tracker. An alternative fix would be to change that method to invoke the old response_callback. However, the change made by this CL is a more general fix for the problem, and should prevent similar issues in the future. Bug: 1079471 Change-Id: Ib8782b2278cace0f24692dbe951d498792111095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229201 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#774772}
-
Juanmi Huertas authored
This reverts commit 69917e2b. Reason for revert: Removing the fallback broke Android tests. Original change's description: > Removing CPU fallback in webgl::getImage > > According to comment below in line 787, this method > expects the canvas resource provider to provide > always GPU resources. > > This also currently passes all the existing tests, > so it's probably safe to remove this fallback. > > Bug: 1035589 > Change-Id: I82a426d29a8a37755ee36d2a14f006bd62fa5bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225479 > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774683} TBR=jdarpinian@chromium.org,juanmihd@chromium.org Change-Id: I6dcffe3cbeb3389509f4b4abcd14f3e681a6357a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035589, 1090962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227884Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#774771}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/341434e4da2c..a4dfe24d7696 2020-06-03 titovartem@webrtc.org Add missing deps for android libs to unblock chromium roll 2020-06-03 danilchap@webrtc.org in libaom decoder use public control function instead of internal one 2020-06-03 handellm@webrtc.org AudioDeviceMac, AudioMixerManagerMac: remove lock recursions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I81d1470b2e70fb3174f58a3f737cdf4b01fc45f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774770}
-
Matt Wolenetz authored
Previous fragmented mux of this test file marked nonkeyframes in input as keyframes in output. Remux fixes that, though the MOOV's duration and creation date are cleared, so test is updated to expect the stream to appear to be "live". The test is also updated to expect the correct sequence of emitted key and nonkeyframes. TEST=MP4StreamParserTest.MPEG_XHE_AAC BUG=1079034 Change-Id: I9c7fd981fe4cea92e1ff0a90058ea1f10905d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225244 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#774769}
-
Sebastien Marchand authored
Bug: 1030399 Change-Id: I5a6bea720e63716033d1e8a4bd22acfcfed4e643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225382 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774768}
-
Mirko Bonadei authored
As compression_utils_portable is been used by client code instead of only internally in zlib helpers, there is the need to properly export the right flags (i.e. header include paths) as some OSes (e.g. Fuchsia) may have issues properly building/linking with zlib. Bug: 1076580, 1087999 Change-Id: Ic54a55db40301dead92402e05c5da5613eb29c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228311Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774767}
-