- 02 Dec, 2020 40 commits
-
-
Yoshifumi Inoue authored
This patch makes |ComputeAdjustedSelection()| to utilize |IsCollapsed()| of |EphemeralRange|[1] to simplify source code for improving code health. Note: This patch doesn't change behavior. [1] http://crrev.com/c/2550834: [editing] Ranges with equivalent positions should be collapsed Change-Id: Iab464fafb0f02f90d346bc1cbc0a2734d6744138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567146 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832722}
-
rbpotter authored
settings, print_preview tests, welcome, NTP Change-Id: I8a79acecc8499f63c45b20a41477eb1004562a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568265 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#832721}
-
Mirko Bonadei authored
These tests have been failing reliably for weeks so this CL skips them. The idea is to upgrade CI to newer macOS versions and try to fix the more restrictive resource access policies by updating the test launcher. Bug: 1128470 Change-Id: I518734c6c84dec7e3cdffb9077ab5a8a82d707d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567772Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#832720}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606737320-benchmark-89.0.4339.0-r1 to 89-4324.9-1606737320-benchmark-89.0.4342.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I49a0c6c134405273eee6604b9354059e07e0621b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569336Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832719}
-
Sreeja Kamishetty authored
ClosedTabCache is a desktop feature to instantly restore the closed tabs. To able to do that, each tab should be identified by a unique id which in our case is SessionID. To accommodate this, we need to send the SessionID whenever user tries to restores the tab using AddRestoredTab. This CL plumbs through CreateRestoredTab which restores the WebContents from the cache in the event of a cache hit. Now passing SessionID as an optional argument through the function calls for AddRestoredTab. BUG=1100946 Change-Id: I05366c8ef3ced9b901aa5c124d85b025a7fd463f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564812 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#832718}
-
Jiawei Shao authored
BUG=dawn:529 Change-Id: If23c63afeb72cae42bf800a945b5af22626cfdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567635 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#832717}
-
Alice Wang authored
This CL moves IdentityServicesProvider to signin.services target. Bug: 1152718 Change-Id: I3188b04ceadc6f1644b761544ea2de1879ad2791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567871Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#832716}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606733211-benchmark-89.0.4339.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4342.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If3a74a8429a0cd296c1355937404d11249c3a554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569335Reviewed-by:
-
Toni Barzic authored
BUG=None Change-Id: I3c4a9e632dfa932c46fce8f9c4e3d8ed3fd18c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556456Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832714}
-
Hajime Hoshi authored
This reverts commit 6545f679. Reason for revert: crbug.com/1154558 Original change's description: > Enable migration from default Chrome apps to default web apps > > This CL enables the migration from default installed Chrome apps to > default installed web apps. > > This still needs feature launch approval: > - Chrome OS: https://crbug.com/1099150 > - Desktop: https://crbug.com/1130075 > This migration is being enabled to get test coverage and user reports > in canary. > If this is not approved by branch point it will be disabled again. > > Test: ExternalWebAppMigrationBrowserTest > Bug: 1058265, 809304 > Change-Id: I22f8b43631708a40b5333a7ce1bd4177e9792b49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562922 > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832669} TBR=alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org Change-Id: I4ee2e3b938bfc9cc434c025fb9b0b01776d20199 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058265 Bug: 809304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568995Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832713}
-
Alex Danilo authored
Progress center groups are not used, remove the code. Move ProgressCenterItem array to progress_center_panel.js to replace the equivalent from progress_center_item_group.js Bug: 1027012 Change-Id: I7e9584aa8992ca0ece616bc7a046fb2da50f69a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568919 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#832712}
-
Joel Hockey authored
I just discovered some flakiness locally doing --gtest_repeat on Trash/FilesAppBrowserTest.Test/trashMoveToTrash. this.trashDirs_ can be cleared by removeFileOrDirectory(), so we should add an extra check and only run removeOldItems_() when the inProgress_ set exists. Bug: 953310 Change-Id: Ie9db7ac577c473241c39cf9e8f03c75581e9d14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567844Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#832711}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/de5da1203dda..5d7848d54df9 2020-12-02 chrche@microsoft.com Reland "[Loc] Migrate changes tool to localization V2" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92acc31b35ca9cd3af627d5b40dcdafc3d5cde31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569170Reviewed-by:
-
Batalov Vladislav authored
The browser UI doesn't receive information about new FullscreenOption on recursive fullscreen activation. On first activation with: document.body.requestFullscreen({ navigationUI: 'show' }) the browser UI keeps showing system navigation panels. But when some inner video element requests fullscreen without navigationUI: my_video_element.requestFullscreen({ navigationUI: 'hide' }) the browser UI doesn't know about it and keeps showing system navigation panels. BUG=1145537 Change-Id: I4ab037b092bf1fbcbe9c452ed995d15c1dc37595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516499Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#832709}
-
Sreeja Kamishetty authored
ClosedTabCache is a desktop feature to instantly restore closed tabs. To own ClosedTabCache, this CL adds a KeyedService called ClosedTabCacheService and a BrowserContextKeyedServiceFactory, ClosedTabCacheServiceFactory, to retrieve the service. ClosedTabCache design doc: https://docs.google.com/document/d/1SF230MYWgroe4WikDMn82ETd3-HFRzylKtIk0HZRaOU/edit?usp=sharing BUG=1100946 Change-Id: I397aa3abbebd9098694b20b9385fe75a7958c484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564966Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |StartOfDocument()| to take/return |Position| instead of |VisiblePosition| to reduce usage of |VisiblePosition|. Note: This patch doesn't change behavior. Bug: 657237 Change-Id: I3832f42b8c08b63dee92a390945e7993f92bcc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567843 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Oriol Brufau authored
VisiblePosition::Create canonicalizes positions using MostBackwardCaretPosition and MostForwardCaretPosition. For positions based on the DOM tree, this happened in the DOM tree too, so they might consider two positions to be visually the same, even though in the flat tree there was some content between them. To solve the problem, this patch makes them convert the Position into a PositionInFlatTree, canonicalize in the flat tree, and then convert the result back into a Position, but clamping to avoid crossing shadow boundaries. Bug: 1145595 TEST=EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot TEST=EditingUtilitiesTest.lastEditablePositionBeforePositionInRoot TEST=EditingUtilitiesTest.NextVisuallyDistinctCandidate TEST=VisiblePositionTest.ShadowV0DistributedNodes TEST=VisibleUnitsLineTest.endOfLine TEST=VisibleUnitsLineTest.isEndOfLine TEST=VisibleUnitsLineTest.isLogicalEndOfLine TEST=VisibleUnitsLineTest.isStartOfLine TEST=VisibleUnitsLineTest.logicalEndOfLine TEST=VisibleUnitsLineTest.logicalStartOfLine TEST=VisibleUnitsLineTest.startOfLine TEST=VisibleUnitsTest.characterAfter TEST=VisibleUnitsTest.characterBefore TEST=VisibleUnitsTest.mostForwardCaretPositionAfterAnchor TEST=VisibleUnitsTest.nextPositionOf TEST=VisibleUnitsTest.previousPositionOf TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/* TEST=All/ParameterizedVisibleUnitsWordTest.EndOfWordShadowDOM/* TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/* TEST=third_party/blink/web_tests/editing/execCommand/insert-list-with-progress-crash.html TEST=third_party/blink/web_tests/editing/selection/collapse/collapse_before_select.html Change-Id: I793c07c7ffbecdaf6cc619c6043f90475c922fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517686 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832706}
-
Tarun Bansal authored
This CL adjusts the logic in NQE to not return low HTTP RTT values when the underlying RTT value is unreliable. This primarily happens on Desktop non-POSIX platforms where Chrome does not have access to RTT at TCP layer, and there are lot of hanging requests which affect the estimation accuracy. Change-Id: Ib31dd31bfc616289e7236be156e33491057da91a Bug: 1101529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445029Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832705}
-
Youkichi Hosoi authored
We have changed the MyFiles path inside Android to use its UUID. As a result, we need to accordingly change the path constant defined in RecentArcMediaSource to avoid a duplicate entry in Files app Media View. BUG=1040386 BUG=1148625 TEST=Edit an image file under MyFiles (by e.g. renaming, rotating). TEST=Confirm that no duplicate entry for the file is found under the TEST="Images" and "Recent" tabs in the Chrome OS Files app. Change-Id: Ib0c72a883b4c959f429af2dea3ad73b29d1563b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560082Reviewed-by:
-
Yoshifumi Inoue authored
Get rid of VisiblePosition version of Adjust{Back,For}warddPositionToAvoidCrossingEditingBoundaries() This patch gets rid of |VisiblePosition| of |Adjust{Back,For}warddPositionToAvoidCrossingEditingBoundaries()| by expanding it at caller, because it is used once, second usages are not needed, to reduce source code and reduce usage of |VisiblePosition|. Note: This patch doesn't change behavior. Bug: 657237 Change-Id: I6e68860c0e1c37a2a4770d99f9bc3c59ff86b4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569011 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Koji Ishii authored
This patch removes |NGPaintFragment| support in |Paint|. By eliminating |NGFragmentItem| specific code, |LayoutNGBlockFlowMixin::Paint| becomes equivalent to |LayoutNGMixin::Paint| that it is removed. Bug: 1154531 Change-Id: Iac72b27256a5e6219eb49a689e671f0477f03e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567145 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#832702}
-
chrome://flagsMike West authored
The `--isolation-by-default` flag enables a few behavioral changes that will hopefully get us closer to origin-level isolation by default. Currently, that includes enabling COOP `same-origin-allow-popups` by default, and requiring embedees to opt-into embeddings. Bug: 1140371 Change-Id: I3708745ea0bdb704776bbb2cab0bfc570061752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485158 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#832701}
-
Joel Hockey authored
http://go/chrome-ss/8aec11c357971886d745aa9ea5b89356399956d2 Added restore-from-trash command which is shown in the Trash root as both a top bar action, and a file context menu command. Modified delete action so that it shows for Trash root (even though the Trash root FakeEntry is read-only), and added remove() and removeRecursively() functions to TrashEntry which deletes both the filesEntry and infoEntry. Background restore() code previously expected the supplied TrashItem would come only from the TrashItem returned by removeFileOrDirectory(), but now that it can be set directly from the restore-from-trash command, it requires a change to the TrashConfig lookup and path prefix validation. Bug: 953310 Change-Id: I2cdf018fd1daab8f57f0ab7f679d47eeba2109b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564841Reviewed-by:
-
Gavin Williams authored
The first iteration of Scan app will not support having two instances open at once so we will not allow the app to be opened in a browser tab. Bug: 1059779 Change-Id: I900e4a8d5d8f38460330d5a358ad12a9df1b3b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568826Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#832699}
-
Esmael El-Moslimany authored
Bug: 1146987 Change-Id: I81866a1302d3029d169bb76bb1586f58675fa963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535190Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832698}
-
Thanh Nguyen authored
This CL add the json ChromeOSReinstallApps json config so that we can start ramping up the experiment. Bug: 1154520 Change-Id: I3ee97832853334ad199657b70ac8375481f47a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567144Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832697}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606813079-a344323d078b1a32606141a981583fdc5b0903fc.profdata to chrome-win32-master-1606856354-fc38cf84d3ff4fdfaa4b246b52b741b3d145638e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic954dbda8ffa332ed7ab938c12b84a6d7ecebadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568642Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6d300e3738db..2f460d3c3411 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3cee0164673db056ddd403bf2401b58568525208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569036Reviewed-by:
-
Ramin Halavati authored
WebUIFactory is updated to deny bookmarks and new-tab-page for ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I2ca675330402d656eb2afc5a691e4d59a2385f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567395Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#832694}
-
Koji Ishii authored
This patch adds |NGPhysicalBoxFragment::IsOutlineOwner|, by moving the logic from a static function in |NGOutlineUtils|. By exposing the |InlineContainerFragmentIfOutlineOwner|, |AddOutlineRectsForInlineBox| no longer needs to traverse all fragments. Instead, it now creates an |NGInlineCursor| only for the container fragment. This patch has no behavior changes. Bug: 1145048 Change-Id: Ia4a084d5708d870a38800bed3494bcd869daf175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567842 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Adam Rice authored
The stable leg of the experiment that uses this histogram has been postponed until next year, so extend its life by 6 months. BUG=1140054 Change-Id: Ia7348b345141e4a90d9bc23d8efa77263698eb3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567540 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Joel Hockey authored
Bug: 953310 Change-Id: I9631628ae0ae8697ffa1df445cda9b84896d2fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567510 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
James Zern authored
this allows flagging the code with -msse4.1; fixes a build failure with clang-cl as for msvc builds sse4 support is assumed, but clang-cl requires the -m flag to enable it. Bug: 1151489 Change-Id: I3d29e5c3d4985b76ad44e9ca15886c0428c5c140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561030 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#832690}
-
Joel Hockey authored
The inProgress_ Set was meant to stop removeOldItems_() deleting entries which are currently in progress. For this to work properly, we must ensure that item are not removed from the inProgress_ Set whilst removeOldItems_() is running. The single Set is replaced with Map<string, Set> so that each TrashConfig is independent. Entries are only ever added to the set, which is deleted once removeOldItems_() is run for each TrashConfig. Bug: 953310 Change-Id: I2f07e7f3c3cf8733e3c91fade20f37d9ffc95afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563390 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a599cfcd6638..86ca37f5fef0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hajimehoshi@google.com Change-Id: I5b7149e8e6fe287f669372b90c1a292e4cc4e96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568842Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832688}
-
Oriol Brufau authored
Before this patch, for an ephemeral range created with different but equivalent positions, IsCollapsed() would return false. Analogously, for a selection created with an extent different than but equivalent to the the base, IsCaret() would return false. This could result in SelectionTypeAdjuster::AdjustSelection trying to create an ephemeral range with an end position preceding the start one, producing a DCHECK failure. Therefore, this patch changes the EphemeralRangeTemplate constructor and SelectionTemplate::Builder::Extend so that the end (or extent) position is set to the start (or base) one if they are equivalent. However, this is not done if the start (or base) position is a <br>, since editing/deleting/delete_after_block_image.html would fail. Bug: 1143292 TEST=EphemeralRangeTest.EquivalentPositions TEST=SelectionTest.EquivalentPositions Change-Id: I3e9194b09c4bda893c05a70fdae858aa6aa22f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550834 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Alan Cutter authored
This CL updates Chrome OS default web apps to be deployed to Chrome OS's app surfaces (app list, app search and app management) while maintaining the "do not deploy to OS" logic for non-Chrome OS. This CL upstreams the "do not deploy to OS" logic in GetPreinstalledWebApps() up to ExternalWebAppManager::PostProcessConfigs() where it can apply to all preinstalled web app configs uniformally. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478376&signed_aid=ic4Nc7r-RtFyMKtH3FYXtA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478378&signed_aid=VMFIAzHdQv62wv7H0Cvz7Q==&inline=1 Bug: 1153233 Change-Id: Idcbb0d15fc8d3f333d1d59e27b8ff624fe7b1c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562625 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#832686}
-
Hajime Hoshi authored
BackForwardCache: Rename SchedulingPolicy::RecordMetricsForBackForwardCache to DisableBackForwardCache Bug: 1147300 Change-Id: I17c1578a3ea7b71a09f7640bafc6dc5ef076a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567060Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832685}
-
James Cook authored
The main IsAccessAllowedInternal function has several #if blocks. Extract the per-platform logic into IsAccessAllowedChromeOS() and IsAccessAllowAndroid() helper functions. This simplifies the #if blocks in the main function, and allows all #ifs to be positive-sense (no !defined anymore). No functional changes -- this is just cleanup before I add yet another #if for lacros. Bug: 1150934 Test: existing unit_tests Change-Id: Ic0fb5ad7cc2d8b1d566c12baf8a7c8cb0d8898f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568813 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#832684}
-
Megan Jablonski authored
page_needs_translation() tells us if translation is allowed, not if the page needs translation. It should be renamed to page_level_translation_critiera_met. We can offer translation if the page doesn't have notranslate and the determined language isn't empty. Bug: 1152884 Change-Id: I647b17f4775787d04f34ee2076b32d53b330af55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561293 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832683}
-
