GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=177136

BUG=379147
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/359073002

git-svn-id: svn://svn.chromium.org/blink/trunk@177153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a use after free during preferred logical width
calculation when we have autosizing enabled. This is a speculative
local fix to see if more of these regressions pop up; the final fix
will need to address crbug.com/389648 as well.

BUG=385268

Review URL: https://codereview.chromium.org/358163002

git-svn-id: svn://svn.chromium.org/blink/trunk@177152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eseidel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/355213003

git-svn-id: svn://svn.chromium.org/blink/trunk@177150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All entrypoints in SVGTextQuery start with check if the text content
element has any boxes. If it doesn't, a value representing "empty" is
returned. In all cases this value is the same as the default value of the
corresponding query-data. SVGTextQuery::executeQuery itself has no
problems handling this case (and will return 'false' as expected.)
Removing these early-outs means a few more cycles is needed in these
"degenerate" cases, although that seems like a small (and hopefully
reasonable) price to pay for less code (and duplication/exit-paths).

Review URL: https://codereview.chromium.org/358033005

git-svn-id: svn://svn.chromium.org/blink/trunk@177149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Perform an intersection of the involved ranges to reject fragments early,
while still avoiding calls to mapStartEndPositionsIntoFragmentCoordinates.
This means the "cache" added in https://codereview.chromium.org/349223003
can be dropped, since we'll now never even reach it. This gives a moderate
speed-up - a few percent - on the original TC compared to using the cache.

BUG=267504

Review URL: https://codereview.chromium.org/359783002

git-svn-id: svn://svn.chromium.org/blink/trunk@177148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Jim.

R=abarth@chromium.org
BUG=389681

Review URL: https://codereview.chromium.org/356273002

git-svn-id: svn://svn.chromium.org/blink/trunk@177147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adam says this is no longer used.

BUG=389681
R=abarth@chromium.org, abarth, dpranke

Review URL: https://codereview.chromium.org/360553005

git-svn-id: svn://svn.chromium.org/blink/trunk@177146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This testing framework is horrible.  When you have a syntax error
you have to go digging in the console to fine it, it doesn't notice.

BUG=389681
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/359813002

git-svn-id: svn://svn.chromium.org/blink/trunk@177145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL deletes RenderLayer::updateLayerPositionsAfterDocumentScroll and
unwinds all the complexity it created. Now that we're always passing
IsOverflowScroll, we can remove all the other flags for deciding when to clear
the clip cache. Also, now we always start the walk at RenderLayers that would
trigger HasSeenAncestorWithOverflowClip, so we can just assume that flag is
set.  That means there are no flags left!

Also, finally delete RenderLayerClipper::clearClipRects. Now everyone clears
all the descendant clip rects too.

Review URL: https://codereview.chromium.org/331653004

git-svn-id: svn://svn.chromium.org/blink/trunk@177144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a replaced element has a percentage height specified then its height should
compute to 'auto' when its containing block does not have a height 'specified
explicitly'. We were taking this to mean when its containing block's specified
height value is 'auto' - in fact it means when the containing block's computed
height is auto. This brings us into line with IE and Firefox.

http://lists.w3.org/Archives/Public/www-style/2014Jun/0079.html

BUG=385877

Review URL: https://codereview.chromium.org/347053007

git-svn-id: svn://svn.chromium.org/blink/trunk@177143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On linux use_webaudio_ffmpeg is true and when it is platform needs to
depend on //third_party/ffmpeg. This target is set up in the GN build now
(at least for this platform), so it's safe to re-enable.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/353943003

git-svn-id: svn://svn.chromium.org/blink/trunk@177142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The server version has won. Any features missing
from the server version should be added there.

BUG=389681
R=abarth@chromium.org, abarth, dpranke

Review URL: https://codereview.chromium.org/351873005

git-svn-id: svn://svn.chromium.org/blink/trunk@177141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some folks still probably run GOM locally, but
it's not worth the burden on the code to keep this around.
If we want this we should re-build it to be web only.

R=abarth@chromium.org, abarth, dpranke
BUG=389681

Review URL: https://codereview.chromium.org/355193005

git-svn-id: svn://svn.chromium.org/blink/trunk@177140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=177119

BUG=381683
TBR=jkarlin@chromium.org

Review URL: https://codereview.chromium.org/339613004

git-svn-id: svn://svn.chromium.org/blink/trunk@177139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=177023

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/353213002

git-svn-id: svn://svn.chromium.org/blink/trunk@177138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's dead.  The auto rebaseline bot won.

BUG=389681
R=abarth@chromium.org, abarth, dpranke

Review URL: https://codereview.chromium.org/358173003

git-svn-id: svn://svn.chromium.org/blink/trunk@177137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Skia change: https://skia.googlesource.com/skia/+/bccac6cbf128147587bfc2bc1bdeb46c08175bca
Rolled into Chrome at r278948.

TBR=fmalita
BUG=379147

Review URL: https://codereview.chromium.org/355203004

git-svn-id: svn://svn.chromium.org/blink/trunk@177136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't include trailing space in linewidth calculations when deciding
if a float can fit on a line.

Merge http://trac.webkit.org/changeset/148622

Review URL: https://codereview.chromium.org/343663004

git-svn-id: svn://svn.chromium.org/blink/trunk@177135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Not sure why the tests changed from expecting '' to undefined,
but I doubt it matters.  Useful to be able to start from
all tests passing.

TBR=ojan@chromium.org
BUG=389681

Review URL: https://codereview.chromium.org/353183003

git-svn-id: svn://svn.chromium.org/blink/trunk@177134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows us to remove a redundant squashing-related property in RenderLayer,
and is also a step towards not having non-compositing code know about how the layers
are positioned & drawn.

BUG=384520

Review URL: https://codereview.chromium.org/358913003

git-svn-id: svn://svn.chromium.org/blink/trunk@177133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=386944

Review URL: https://codereview.chromium.org/356183002

git-svn-id: svn://svn.chromium.org/blink/trunk@177132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was a race between the event arrived into timeline and the script that was evaluated in the page.

BUG=316150

Review URL: https://codereview.chromium.org/351873003

git-svn-id: svn://svn.chromium.org/blink/trunk@177131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a TextIterator is created for a range that contains a replaced
element then one ',' (comma) will surely be emitted. This way the
length of the created TextIterator will be at least 1. In spite of
this, the WebCore::PlainTextRange::createRangeFor method assumes that
the length of the iterator only can be one if that one character is a
newline. The patch fixes this wrong assumption.

R=tkent@chromium.org
BUG=385630

Review URL: https://codereview.chromium.org/342483002

git-svn-id: svn://svn.chromium.org/blink/trunk@177130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This comment is about ASSERTing the consistency of state that no long exists.
Also, remove m_canSkipRepaintRectsUpdateOnScroll because it's just
renderer()->isTableCell().

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/356123004

git-svn-id: svn://svn.chromium.org/blink/trunk@177129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We would eventually like to implement position: sticky, but the current
implementation isn't designed in a way that integrates well with the existing
scrolling and compositing system. For example, position: sticky relies upon
updateLayerPositionsAfterDocumentScroll to function correctly, but that
function has no other purpose and can otherwise be removed. Similarly,
position: sticky doesn't work at all with composited overflow scrolling, which
is now the default mechanism for driving scrolling in the engine.

Once we've got our scrolling and compositing house in order, we should return
to position: sticky and implement the feature in a way that integrates well
with the rest of the engine. For now, however, this CL removes our current
implementation so we can focus on improving our implementation of the scrolling
features we've already shipped.

R=eseidel@chromium.org, esprehn@chromium.org
BUG=389638, 231752

Review URL: https://codereview.chromium.org/346603007

git-svn-id: svn://svn.chromium.org/blink/trunk@177128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When emulation is unavailable (on device), only show the message about it.
When emulation is available, but without responsive design mode, move
toggle button to the OverridesView.

BUG=none

Review URL: https://codereview.chromium.org/358973003

git-svn-id: svn://svn.chromium.org/blink/trunk@177127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[TypeChecking=Nullable] on a nullable attribute meant that the C++ getter
wasn't called with a "bool& isNull" argument, instead the C++ value in a
boolean context was used to determine nullness.

This was only used for attributes where the C++ value was a pointer, and
made perfect sense for such attributes. So much sense, in fact, that it
makes sense to let that be the default behavior for such attributes.

Review URL: https://codereview.chromium.org/352643005

git-svn-id: svn://svn.chromium.org/blink/trunk@177126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds type checks on some Node arguments in the generated bindings
code, and lets us drop the corresponding manual null checks and exception
throwing code in the implementations.

The type of exception thrown changes from DOMException (NOT_SUPPORTED_ERR)
to TypeError as a side-effect. This matches the Web IDL specification.

Review URL: https://codereview.chromium.org/360463005

git-svn-id: svn://svn.chromium.org/blink/trunk@177125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related to the test failures seen in the worker-data-view-test.html test I think this will fix the issue. Basically postpone the sweep until after we have left the safepoint. I am still testing/trying to reproduce.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sof@opera.com, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/351253002

git-svn-id: svn://svn.chromium.org/blink/trunk@177124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

containingBlockIgnoringAnonymous serves as a stop condition of tree visits
(previousInPreOrder). Before the patch, containingBlockIgnoringAnonymous was not
the root RenderObject of the previous continuation chain, and thus
the previous continuation was not cleared properly.

This patch relaxes the stop condition by using isAnonymous() instead of
isAnonymousBlock() so that the tree search can skip all anonymous wrappers
including RenderTableRow or RenderTableCell.

BUG=389285
TEST=unminimizable test from clusterfuzz
R=inferno@chromium.org

Review URL: https://codereview.chromium.org/358133002

git-svn-id: svn://svn.chromium.org/blink/trunk@177122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Creating a new StyleResolverState while in the context of a
style recalc is completely unnecessary for the purposes of
StyleResolver::createAnimatableValueSnapshot().

Moving the StyleResolverState creation inside createAnimatableValueSnapshot()
to only where it's necessary fixes crashes involving HTMLOptionElements
attaching themselves to a shadow DOM tree.

BUG=387225

Review URL: https://codereview.chromium.org/358793003

git-svn-id: svn://svn.chromium.org/blink/trunk@177121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Srcset's 'w' descriptor parsing accepted descriptors of the form "400pw".
This CL fixes that by making their parsing stricter.
It also adds a bunch of tests to prevent it from regressing, and to make sure
float based descriptors are properly parsed as well.

BUG=389575

Review URL: https://codereview.chromium.org/355953003

git-svn-id: svn://svn.chromium.org/blink/trunk@177120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

platform over time.  Not worth constantly rebaselining.  Remove
navigator.connection.type from window tests as it's already well
tested in netinfo/* tests.

BUG=381683

Review URL: https://codereview.chromium.org/356833006

git-svn-id: svn://svn.chromium.org/blink/trunk@177119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During console migration on viewport revealing search results was
forgotten.
This patch fixes this.

BUG=388718
R=pfeldman

Review URL: https://codereview.chromium.org/354013002

git-svn-id: svn://svn.chromium.org/blink/trunk@177118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While CORS is concerned with the access control headers that come
back in the response and not its status code, an error response
(status code >= 400) containing no CORS headers is most likely an
indication of the server not being configured correctly.

To potentially help the user/developer more quickly diagnose that as
the problem, include the status code in the console message that's
emitted for the failed CORS resource sharing check.

R=
BUG=269192

Review URL: https://codereview.chromium.org/332633006

git-svn-id: svn://svn.chromium.org/blink/trunk@177116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this particular case both OS() and PTHREAD_KEYS_MAX are used as a guard, even though using PTHREAD_KEYS_MAX as a guard is sufficient. Not only that this solution works not just for ANDROID but also for other systems where chromium might be ported to (in or out of the tree). 

As an example the proposed change would work on HURD systems as well (the support for HURD is not maintained in the tree, but it demonstrates that the change handles those systems as well).

Review URL: https://codereview.chromium.org/351683007

git-svn-id: svn://svn.chromium.org/blink/trunk@177115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The gyp build for core does some strange things put in place in ancient
times to fix ancient problems. There's no need nowadays to:

*) list all core svg files in both webcore_files and webcore_svg_files
 only to filter the webcore_files entries with a regex

*) exclude 'opentype', 'cf', etc files from core with a regex

*) exclude platform-specific directories in core - we've moved all
that to Source/platform

These funky rules are hard to maintain in gyp and impossible to do
so in GN, so let's get rid of them.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/354973002

git-svn-id: svn://svn.chromium.org/blink/trunk@177114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We request the image of max size avaliable but resize canvas to match the size of actual image returned from device.

Depends on https://codereview.chromium.org/351633002/

BUG=387557

Review URL: https://codereview.chromium.org/347143002

git-svn-id: svn://svn.chromium.org/blink/trunk@177113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=389286
TBR=yurys@chromium.org, timloh@chromium.org, fmalita@chromium.org

Review URL: https://codereview.chromium.org/361463002

git-svn-id: svn://svn.chromium.org/blink/trunk@177112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

paintTextWithShadows had unused parameters, and identical logic for
constructing a text shadow draw looper existed in three places.

Review URL: https://codereview.chromium.org/356123002

git-svn-id: svn://svn.chromium.org/blink/trunk@177111 bbb929c8-8fbe-4397-9dbb-9b2b20218538