- 26 Feb, 2020 40 commits
-
-
Mark Cogan authored
This CL removes the use of TabModel from the BVC unit test, and does other minor clean-up. As part of this, the long-spurious CommandDispatcher parameter is removed from the BVC initializer. Change-Id: Idf7a2d02f5c54964458a62db0f9b02ad1afea1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072162Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744663}
-
Rune Lillesveen authored
We still cannot use the keyword since we don't ship color-scheme aware system colors, but this is closer to the end state. This should not result in any web-observable changes. Bug: 939811 Change-Id: If2bdfbabb2390c1b720658705d683be5666875be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033144 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#744662}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2f0f850da8aa..a9d7d478429d git log 2f0f850da8aa..a9d7d478429d --date=short --first-parent --format='%ad %ae %s' 2020-02-26 enga@chromium.org Add Toggles to disable base vertex and base instance rendering Created with: gclient setdep -r src/third_party/dawn@a9d7d478429d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id9b0d6c89a923772c88b15e2fe94d5d7ff3d20d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744661}
-
Vasiliy Telezhnikov authored
With Viz For WebView enabled we support surface embedding. Some embeddees (e.g Unaccelerated OffscreenCanvas) will try to fallback to SharedBitmaps for resources. This CL adds SharedBitmapManager to avoid crash. We can't draw this bitmaps, but for resourceless software draw we do not support embedding and we don't support software compositing on Android, so the draw won't happen either way. Bug: 1055877 Change-Id: I9e3073a46f4d2b0b63b1025489b48e91be15f71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072655 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744660}
-
Elly Fong-Jones authored
This makes it hopefully more clear which events can cause the dialog buttons to change visibility. For CardUnmaskPromptViews, whether the Ok button is visible or not depends on whether the autofill client is in a persistent error state. For LocalCardMigrationDialogView, the existing code never calls DialogModelChanged, so presumably the value of `controller_->AllCardsInvalid()` is constant across the lifetime of that dialog. Bug: 1011446 Change-Id: I5921f086b3078e68aa417945560ad73a357fe190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067874Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744659}
-
Igor Makarov authored
- added .style.yapf files - reformat *.py files in third_party/blink/renderer/build/scripts Bug: 1051750 Change-Id: I340904259718b4c8e1bea554c9c65e6e2a8d1fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061152Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744658}
-
Makoto Shimazu authored
This CL plumbs the COEP value to the URLLoaderFactory going to the NetworkService. However, COEP doesn't take effect if it's being registered. Bug: 1039613 Change-Id: Id6ca28b686db82b3479becc1e927c8d7ff2e2c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065696 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#744657}
-
Anders Hartvoll Ruud authored
If a shorthand contains invalid var()-references, we would return from ResolvePendingSubstitution with CSSUnsetValue before getting a chance to mark the property as dependent on a variable. This would cause StyleResolver to incorrectly cache the style in the matched properties cache, causing bugs in subsequent recalcs. Moving the call to MarkHasVariableReference before we attempt to resolve var()s fixes the issue. Drive-by: Remove some comments that should not have been committed in the first place. Bug: 1055035 Change-Id: I0749da2e8d3f8a74e2bc9418078704a319124fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074237Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#744656}
-
Michael Lippautz authored
Instead of spreading all support of HeapVectorBacking over all different GC-internal traits keep all required overrides in a single file per data structure. Users should be able to use MakeGarbageCollected to allocate the data structure (internal or external). Change-Id: I8e028ee4d44015cb8b3e1d7356050154fb128007 Bug: 1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072043 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#744655}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b146d522e7b..cb6ff74d970a git log 1b146d522e7b..cb6ff74d970a --date=short --first-parent --format='%ad %ae %s' 2020-02-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cb6ff74d970a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4384a344334365fe596ee3948aec3a0ac841465f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073790Reviewed-by:
-
Mohamed Heikal authored
third_party/android_deps/BUILD.gn has some manual modifications due to the migration of the android support library to androidx. This cl fixes the warning output by the fetch_all.py script so it is more clear. Bug: 896775 Change-Id: I490d50828cb19e2d1b47234aa1d9b777c097e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072589 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#744653}
-
Nico Weber authored
Bug: 1040247 Change-Id: Ib96f493c30c3a822929ed5bafa885bc4abd4eced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074857 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#744652}
-
Jaeyong Bae authored
This patch means adding a message which indicates that there is no result when searching for a password. Bug: 1040875 Change-Id: If980d685a3f0bc3eec3d5717b484edb3f03c4cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049424 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#744651}
-
Jan Wilken Dörrie authored
This change modifies CompromisedCredentialsProvider to also implement the SavedPasswordsProvider::Observer interface. This allows the provider to also react to changes in the list of saved passwords. Bug: 1047726 Change-Id: I1904f8a0eb1c785aee97f3be5a8640025776e5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070163 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Kevin Ellis authored
Bug: 1052217 Change-Id: I9495cf7fb844083c88f796214561cbe0476b19c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072653Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744649}
-
Andreas Haas authored
Apparently https://crrev.com/c/2044272 caused double accounting of memory in the GC, which lead to an increased number of garbage collection runs. With this CL the external memory is unregistered once it is moved on the GC heap. R=haraken@chromium.org Bug: 1054347 Change-Id: I49a6bdd593298776bad9116d34793b1eec05dafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066733 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744648}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/908dc2208b7c..de3b97eb1f52 git log 908dc2208b7c..de3b97eb1f52 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 8910ea5f1c7b..70f888131ede (2 commits) Created with: gclient setdep -r src/third_party/angle@de3b97eb1f52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I4bdc4e76cc73c41f570256c644a37ce45e5ddc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073783Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33f26eae. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 6532b4a4 "WPT: Remove XMLDocument#load test from html/.../query-encoding/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I727f28c89d11bbf19b39b41cd3477115d66b6a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073711Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744646}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4db5c0713efc..f5b262e88b96 Created with: gclient setdep -r src-internal@f5b262e88b96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99b1ca8d3db2bf155f13615e30f9a9a98e4fb97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073781Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744645}
-
Josh Karlin authored
This reverts commit 7bb2910f. Reason for revert: Perf bots showing possible perf regressions. Other suspicious candidates landed around the same time but reverting this one to see if it helps. Original change's description: > Enable AsyncStackAdTagging by default > > To be cautious we landed this patch behind a feature to make sure it > wasn't hurting performance. We're not seeing anything in 28 day data > on canary/dev to suggest that it's problematic, so launching via > waterfall. > > Bug: 851531 > Change-Id: I77fc899170d8b5f76e7d50a4db3a4e33e88b40ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053411 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743597} TBR=dcheng@chromium.org,jkarlin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851531 Change-Id: I24c12ce6fb9258a8aad683a4b09901740a78f49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074317Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744644}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d188dce4..413603ba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I216a1cf76395b09b54637a00bdb659ebeb370404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073960Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744643}
-
Sylvain Defresne authored
Enable ARC (automatic reference counting) when building iOS specific files from components/policy/core/common and remove the use of scoped_nsobject. Also modernize the BUILD.gn file to not depend on the global sources_assignment_filter and to use "frameworks" instead of "libs" to list dependencies on frameworks. Bug: 1051997, 1018739 Change-Id: I1b727f2659cbb093754ffc75e911bd96027a2a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074477Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#744642}
-
Richard Knoll authored
This deprecates and removes collection for the following metrics: - Sharing.ClickToCallReceiveDeviceState - Sharing.ClickToCallPhoneCall Bug: 1053140 Change-Id: Idb835aa31950b074f79e797d2a93e3619a6bf5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071889Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744641}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b1b5d932a2a..98057db7097e git log 9b1b5d932a2a..98057db7097e --date=short --first-parent --format='%ad %ae %s' 2020-02-26 fmayer@google.com Merge "Check if target app is still running at end of test." Created with: gclient setdep -r src/third_party/perfetto@98057db7097e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia18136ce0b296cfd93ab23af0ec9480f0b6c2587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073788Reviewed-by:
-
Sylvain Defresne authored
Most of the include are obsolete. The remaining one can be removed as all the code is compiled with ARC thus there is no need to have a C++ smart pointer to call retain/release when the compiler can do it automatically. Bug: 1051997 Change-Id: Ic203bd716eb38c864db3f39c14ca9c2fe0d41264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074437Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#744639}
-
Gauthier Ambard authored
This CL fixes the error page injection by loading a blank page before injecting the HTML, preventing JS rewrite of the JS methods used to inject the JavaScript. It also updates the virtual URL of the item to reflect the URL of the error page. Bug: 991608 Change-Id: Ie79fcd7e21d3f0bb8bcb1be8bf202d9e4ec503d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054156Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744638}
-
Omer Katz authored
This was broken by http://crrev.com/731804 Bug: 974061 Change-Id: Ic6855a24a4c58d42dcbeec078741e02880ee3d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074219Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744637}
-
Rainhard Findling authored
* Adds the safety check passwords child element * On an update state change, adapts the child icon, icon color, secondary label, and user action UI components accordingly Bug: 1015841 Change-Id: I44bcedad91961b1f021cfcb3e1d4b48d702dcedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072237 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744636}
-
Nazerke authored
This CL modernizes the SigninCoordinator, AddAccountSigninCoordinator, AdvancedSettingsSigninCoordinator, UserSigninCoordinator to use self.browser to get browserstate value. These coordinators are already using browser in initializers. Bug: 1029346, 1054825, 1054824, 1054823, 1054822. Change-Id: I37a4aee333d49efc4d24fed23ffb3d1686bafb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071939Reviewed-by:
-
Dominik Röttsches authored
Bug: 1056163 Change-Id: I6cd3320bbfcc729ba36a074a4062a588b4f10b7a Tbr: hidehiko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074301Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#744634}
-
Dominik Röttsches authored
Fixed: 1056021 Change-Id: I0c2974c16f158f05ba72fca72d2f2fd63453db87 Tbr: mattcary@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074478Reviewed-by:
-
Andreas Haas authored
R=leszeks@chromium.org Bug: v8:10126 Change-Id: I09a97fad71cd230acb9e13fd1f9071a856fb8dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073723Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#744632}
-
Anders Hartvoll Ruud authored
The link_match_type stored on the MatchedProperties object is only relevant and correct if we're inside a link, hence we need to override the effective link_match_type at some point. Previously, we would do this apply-time, and not as part of the rule- collection. This CL instead proposes that ElementRuleCollector take the link-status into account, and perform the adjustment before storing the link_match_type on MatchedProperties, such that no further adjustments are required later. This fixes a bug in the CSSCascade path, where we would incorrectly not apply anything for selectors such as *:not(:link):not(:visited), even for elements that are not inside links. (See AddLinkFilter in cascade_expansion.cc. We would switch on the value 0, and then enter the default case, causing a filter to be added on kProperty, which causes all properties to be rejected. This is correct for elements that are inside links, but not for elements that aren't). Bug: 1055715 Change-Id: I2b63de41753fb0fa7b637a4be5bd009c2f165fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072223Reviewed-by:
-
Rune Lillesveen authored
System colors used in CSS should per spec depend on the used color-scheme for that element. Since the used color-scheme may not be the same as the preferred color-scheme, we need to provide the system colors for both light and dark at the same time. This CL temporarily sets the appearance to light and dark aqua to retrieve those colors. TEST=StyleEngineTest.InitialColorChange Bug: 929098 Change-Id: I4bb9553cf1b2fc4e98cd1c7c13041adce3e50353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860023 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744630}
-
David Jean authored
Bug: 1049638 Change-Id: Ia577c0ab73a9107c19cbf38b4b21dbab793fcbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074158Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#744629}
-
Hirokazu Honda authored
VideoFrameValidator compares a video frame passed on Process() with the model frame. The model frames are set at Initialize() and VideoFrameValidator keeps them during the test. The memory usage of the model frame can be large if we use VideoFrameValidator for encoder test. We would rather give VideoFrameValidator a callback to get a model frame, so that we can keep model frames needed at that time in the test. Bug: 1044452 Test: image_processor_test on kevin Change-Id: Id3a4a76c8d149bb5e4b349ab67a087bc9bdaf45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024769 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#744628}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I502cdf3c58ea37dc11fe23eeed3de9204f0f5d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073786Reviewed-by:
-
Morten Stenshorne authored
Some tests have started to pass, presumably due to NGFragmentItem improvements. TBR=kojii@chromium.org Bug: 982194, 1043787 Change-Id: I827d10c8f7794b73592a2fe2e436adf6ef5ab123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073883Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#744626}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1c105ca31096..1b146d522e7b git log 1c105ca31096..1b146d522e7b --date=short --first-parent --format='%ad %ae %s' 2020-02-26 mathias@chromium.org Revert "[e2e] Add user metrics tests" Created with: gclient setdep -r src/third_party/devtools-frontend/src@1b146d522e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e6d6f4afb108fd2ac9318964fa7d4361a5cf138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073785Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a6db9c8fe927..c310889ec791 git log a6db9c8fe927..c310889ec791 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 sprang@webrtc.org Revert "Reland "Refactors UlpFec and FlexFec to use a common interface."" 2020-02-26 hta@webrtc.org Remove deprecated AddContent function in session_description.h 2020-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e1d61e44..159524df (744256:744393) Created with: gclient setdep -r src/third_party/webrtc@c310889ec791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052323 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1017db1fb95a2c00fb4eea555813c88fa61c8a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073784Reviewed-by:
-
