GitLab

UIKit has fixed orphaned word in UILabel since iOS 11.
Our custom implementation of fixing orphaned words
is no longer necessary.
Furthermore, adding an arbitrary new line in a UILabel
has unintended consequences, such as failing EG tests
that would otherwise pass.

Change-Id: Ifc5ca16d8fca83aa67306d94ceac9db132ded45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129241Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755082}

This reverts commit 4a7fe529.

Reason for revert: The loading behavior is designed wrong.

The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is.

Currently: the behavior is observed when rendering is delayed by font preloading.

What's actually needed: the behavior is observed when font preloading occurs

Original change's description:
> Record split UMA histograms when rendering has been delayed for font preloading
> 
> This patch adds split histograms of the following metrics when
> rendering delay for web font preloading has been triggered:
> - PaintTiming.NavigationToFirstPaint
> - PaintTiming.NavigationToFirstContentfulPaint
> - PaintTiming.NavigationToLargestContentfulPaint
> - LayoutInstability.CumulativeShiftScore
> 
> This will help us understand the effectiveness of this optimization, and
> adjust the length of the delay to the best value.
> 
> Bug: 1040632
> Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754771}

TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org

Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755081}

This is a reland of 2412286a. Is not
the culprit for https://crbug.com/1066455, the cause of the revert.

Original change's description:
> Propagate main frame document dimensions through frame intersections.
>
> This change calls OnMainFrameDocumentIntersectionChanged for the main
> frame. The RenderFrame resets the main frame's intersection when the
> frame commits a navigation to ensure we propagate a new intersection
> for each committed navigation (otherwise we may lose updates when the
> render frame observer propagates values for uncommitted loads to
> page load metrics).
>
> This allows consumers to compare frame intersections with the main
> frame's rect. This is a precursor to measuring page ad density.
>
> BUG=993453
>
> Change-Id: I689505c086ed0216af9f216ed4dd3d13f9c3ec1d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105622
> Commit-Queue: Justin Miron <justinmiron@google.com>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: John Delaney <johnidel@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754626}

Bug: 993453
Change-Id: I5c08939d9cb8181eb4dac2d7fa5d55919fe848c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128984Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#755080}

Blink moved from WTF::RefPtr to base::scoped_refptr long time ago, but
the poor GC compiler plugin was forgotten...

Bug: 763844
Change-Id: Ie61bfcf7fe4ff3c159d573282e09af7c5174bce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130786Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755079}

This is needed to call it on const objects.

NOPRESUBMIT=true

Bug: none
Change-Id: Ib6159b35e56b3e9983b27caea181983f8acb7f5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126250
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755078}

These tests passed on the WPT fyi bot but weren't tested in the
layout tests because the testdriver-vendor.js didn't have plumbing
for the non chromedriver path.

Since our waterfall generally runs this path it is wise to add this
support to this code path.

BUG=626703

Change-Id: I9f0c91198146535a2d5cdb71baa29d463820ddd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129017Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755077}

This is a follow up of [1], where test expectation were using
chrome-specific scrollbar dimensions. The issue has been identified
and logged on mozilla's bugzilla [2].

[1] https://crrev.com/c/2120544
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1625764

Note that, despite fixing the chrome-specific scrollbar issue,
the test won't completely pass on Firefox.
By loading the test on the browsers (eg Firefox and Chrome),
it is possible to observe that the failures actually manifest
as a visual rendering difference between both engines.
This needs to be investigated further.

BUG=1063749
R=cbiesinger@chromium.org, dgrogan@chromium.org

Change-Id: I9e45be0ba836d83483edd8220491a35f22aba00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130046Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755076}

Bug: 1066209
Change-Id: I8ac47add1032e2a4ce6c490602977e312a3d3300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128095
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755075}

This mirrors the WPT functions for assert_throws_{dom, js, exactly}, and
provides a clearer API for what is being tested. (Previously the code
would guess based on the type of the input).

Bug: None
Change-Id: I916636d9cf3561c3d6cde7cbb0b73a4a8c436dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128379
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755074}

Python 3 doesn't support implicit relative imports.
Fix this by adding the current directory to the search path, so all the files can be found.
This works on both Python 2 and 3.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/bindings/scripts/collect_idl_files.py", line 14, in <module>
    import blink_idl_parser
  File "C:\Google\chromium\src\third_party\blink\renderer\bindings\scripts\blink_idl_parser.py", line 74, in <module>
    from idl_parser.idl_parser import IDLParser  # pylint: disable=import-error
  File "C:\Google\chromium\src\third_party\blink\renderer\bindings\scripts\..\..\..\..\..\tools\idl_parser\idl_parser.py", line 38, in <module>
    from idl_lexer import IDLLexer
ModuleNotFoundError: No module named 'idl_lexer'

Bug: 941669
Change-Id: Ib0e7c88100fd0cc1eee90d252ad8c557e1e25197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124475
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#755073}

This reverts commit fb30c93b.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1066610

Original change's description:
> WebApps: Fix PWA initial positions in certain configs
> 
> Similar to Bug: 783199, when user have two monitors that set to
> different scales, PWA may relaunch off the screen.
> This change does a similar fix for PWA as the original change did
> for devtools.
> 
> Bug: 1046481
> Change-Id: I63230b01c59c5f277298c5bc5e51c8703cc6f54a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074799
> Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#755007}

TBR=pkasting@chromium.org,mjackson@microsoft.com,lomitch@microsoft.com,juxiao@microsoft.com

Change-Id: I8bfbcdb7d1c36492bb116b45464d5e09ca13e01a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131009Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755072}

Change-Id: I45493078cf97dbe35366b5254e356880c3466359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130668
Auto-Submit: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755071}

This was originally left out of https://crrev.com/d255670 due to an
error when trying to use assert_throws_js. After investigation, it turns
out just to be that the function using assert_reports_js was not passing
a TypeError from the right global.

Bug: None
Change-Id: I8067949ddf6e9108bd862287cb49eef7aa788eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128243Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755070}

Troublesome Privacy Page UMA logging tests were disabled in anticipation
of a major UMA rework. That rework has come and gone but erroneously
did not renable the privacy_page specific tests.

Fixed: 1066182
Change-Id: I9291aa353aeebd581f164615e9e6033d9e53dbad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129698
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755069}

Bug: chromium:1053803, chromium:1063472
Change-Id: Iffa81bf28b74be04772384d690e6cd55b65c95ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130226
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755068}

Bug: 890452
Change-Id: I06a5603ee5a3ce7ba192112070d76729e674f598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128942
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755067}

Bug: 1065555
Change-Id: I45b4a8b788ea585f4fc6a655e435c9b54573b7d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127433
Commit-Queue: Sam Bowen <sgbowen@google.com>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755066}

It's no longer used.

Bug: 894447
Change-Id: Ic81eb4d6bd34ad067e1f753af9300db444dc543b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129283
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755065}

One instance of this was already fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/1874486.  This
CL simply covers the other.

Bug: NONE
Change-Id: Ic0dc4ce2fdc1ca0daa414b50d2f9cf5a59f676ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130667Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sajjad Mirza <sajjadm@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755064}

https://chromium.googlesource.com/angle/angle.git/+log/dbb23ec3589f..06f4f3e13c49

git log dbb23ec3589f..06f4f3e13c49 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 cnorthrop@google.com Capture/Replay: Disable binary formats when FrameCapture is enabled
2020-03-31 jmadill@chromium.org Vulkan: Observe staging buffer changes in TextureVk.

Created with:
  gclient setdep -r src/third_party/angle@06f4f3e13c49

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Id3e72ad7c72d56af16dd39730352071e8c4ba7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130327Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755063}

Support for report_java_assert is no longer needed.
This CL removes it.
In addition, this CL removes BuildHooks.java as
report_java_assert is the only thing BuildHooks.java
is used for.


Bug: 1024346
Change-Id: I0235718b771d717f258575ab005acdb261612c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123316
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755062}

Timing out frequently, possibly due to crrev.com/c/2125464

Change-Id: Iee1d7d9965bdb2858930d40d6f9d0fb56f99aabc
Bug: 1066570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129999Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755061}

Chromium targets now depend directly on the Fuchsia SDK's own GN rules
for FIDL, prebuilt, and C++ libraries, so remove the Chromium-generated
rules for those.

Bug: 1050703
Change-Id: I96300722aa0973d72161f143c9ddf3979f70fd2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061756
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755060}

Pass the next likely navigations from external Android apps
to observers of navigation predictor keyed service.

For current two observers (isolated prerender and optimization
hints manager), this CL adds logic to return early if the
prediction source is an external Android app.

Bug: 1014210
Change-Id: Ie6db1927fb76d8d4e651e7d7680031d2eb8c641d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125693Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755059}

These tests seem to be failing. Create a specific bug for them and
assign to CSS team.

BUG=626703,1066577

Change-Id: I99d66e54382c44ced9a1f59e82e4c89e9ff18420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130686Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755058}

The cause of flake is reverted, so enable them to resume test coverage:
https://chromium-review.googlesource.com/c/chromium/src/+/2122818

Tbr: ntfschr@chromium.org
Bug: 1065173
Change-Id: I2b7e13541de564e6bf92831115199329b14355a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124076Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755057}

The Chrome UI Overrides allowed extensions to override the bookmarks UI,
but never shipped. This CL removes most of the remaining core bits.
Specifically,
- The _manifest_features.json entry
- The manifest_types.json entry
- The associated ManifestHandler (UIOverrides)
- The associated FeatureSwitch (enable_override_bookmarks_ui)
- The associated constants
- The associated commandline switches
  ("enable-override-bookmarks-ui")

Bug: 894447
Change-Id: I673485dcb5f5e414c449476cd6169f862c48aa69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129282Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755056}

I accidentally deleted the else which led to always using the
search icon.

Bug: 1066568
Change-Id: I872989d4f0ecb66be1b1f967a092caa58c44ed7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130250
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755055}

Extensions lite was an emergency feature, launched in response to the
COVID-19 crisis, to enable supervised users to temporarily install
extensions, such as Zoom, from the ExtensionInstallWhitelist policy.

While all extensions are currently blocked for supervised users,
themes are not. The current implementation of extensions lite will
block all themes for supervised users, since not every theme is
included in the policy whitelist. This CL checks for and excludes
themes from StandardManagementPolicyProvider::UserMayLoad(), to
restore supervised users' ability to install themes.

Bug: 1066244
Change-Id: I9a90d2408545de6d28ec38c90627f1037cf143d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128374Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755054}

No change to logic, only docs.

This adds general documentation for how to launch Dev UI, and provides
information for how Dev UI interacts with Finch.

Fixed: 1058571
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Icc7234807935d764886a66305ff8cd5653701f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123334Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755053}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba238d8eed6d..af705142bcc4


Created with:
  gclient setdep -r src-internal@af705142bcc4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I80dd5a0b9a44f8342d808afca8233db0db58588b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130286Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755052}

Bug: 985905

Change-Id: I65cb5cc35a8f4f61322e14cda76e63ee34ed7a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128932
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755051}

Update PageInfo to get SecurityLevel and VisibleSecurityState from the
delegate, which moves a lot of duplicated logic from wherever PageInfo
is constructed into the delegate, and will also make componentizing
ConnectionInfoPopup and PageInfoController easier, because the
dependency on SecurityStateTabHelper won't be necessary.

UpdateSecurityState and ComputeUIInputs don't need SecurityLevel and
VisibleSecurityState, and have been updated to get them directly from
the delegate instead.

PageInfoTest was setting custom values for these, and so a test-only
method to set security state has been added.

Bug: 1052375
Change-Id: Icf09eba58654d46ca9f9bf075364c1f00793db91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128107
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755050}

Add check to shouldCaptureThumbnail that informs the ntp if the cookie
controls state is incorrect.

Bug: 1065391
Change-Id: I6b7fb5e5ce88975e1ebb844f5c402a8540176858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128311
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755049}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06101933267d..17ffd9875c34

git log 06101933267d..17ffd9875c34 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 ehmaldonado@google.com git-cl: Fix git-cl split.

Created with:
  gclient setdep -r src/third_party/depot_tools@17ffd9875c34

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I3fcb7f664f576bf644da5d75645a5792f812abd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130185Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755048}

Also, reorder two strings in the list for readability.

Bug: 1032584
Change-Id: I2dcf03bb795a3f920d4d0a9be0a9db3e21dc5c35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107629
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755047}

Add Unwinder as optional param in StackSampler that's used if present.
This is necessary for follow up NativeUnwinderAndroid that doesn't have
a default constructor.

Late creation of StackSampler in StackSamplingProfiler is also removed
because this won't be possible with NativeUnwinderAndroid. Instead, StackSampler
is always created in constructor or injected.

Bug: 989102
Change-Id: Ib90416659f28d7139baed8d7adba62836337b13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095372
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755046}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/143da7b3..3acfab72

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I419e9583a897af3566ea8893924f844c5bb54626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130067Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755045}

Use crosAddAccountEdu flow name for Child users.

Bug: 1043108
Change-Id: I5598f05105cd3817e544d82a74d7b6aaebea5f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120361
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755044}

has_key() has been removed in Python 3.
Use the 'in' operator which works in both Python 2 and 3.

Traceback (most recent call last):
  File "../../gpu/config/process_json.py", line 961, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../../gpu/config/process_json.py", line 935, in main
    process_software_rendering_list(
  File "../../gpu/config/process_json.py", line 810, in process_software_rendering_list
    process_json_file(
  File "../../gpu/config/process_json.py", line 771, in process_json_file
    write_entry(entry, total_features, feature_tag, unique_symbol_id,
  File "../../gpu/config/process_json.py", line 677, in write_entry
    write_conditions(entry_id, False, -1, entry, unique_symbol_id,
  File "../../gpu/config/process_json.py", line 525, in write_conditions
    if driver_version.has_key('value2'):
AttributeError: 'dict' object has no attribute 'has_key'

Bug: 941669
Change-Id: Ib0f629fdcd7d1a72c4b1dd5f846a33007154e46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130267Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#755043}