- 09 Apr, 2020 40 commits
-
-
Natalie Chouinard authored
This resolves "Unable to create logdog client" errors on Swarming jobs created with run-swarmed.py. Change-Id: I62a9bbe5539d2e3bf15d11926b48be75184817e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144906 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#758051}
-
Gang Wu authored
From previous enabled test run, https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_shell_test_apk&tests=ClipboardTest%23testCopyDocumentFragment It seems most of failure happened on slow devices, like x86. So increase the timeout for CriteriaHelper.pollUiThread(). Bug: 791021 Change-Id: I89430d2fbf89196a3813b1e175d2fd56090e079b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144814Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758050}
-
Piotr Pawliczek authored
This is a part of implementation of class Uri. This CL contains implementation of getters along with algorithm to encode disallowed characters with % sign. Other CLs: - https://crrev.com/c/2103143 - https://crrev.com/c/2123640 BUG=chromium:821497 TEST=on my workstation Change-Id: Iabe72b7d9907743345a886fe3ffb2dc19b1b76b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118426 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#758049}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8026364968ac..1926de0638b6 git log 8026364968ac..1926de0638b6 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 rharrison@google.com Remove ambiguity in comment of pointer vs Klein star for * (#1037) Created with: gclient setdep -r src/third_party/shaderc/src@1926de0638b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Iae8d8d29910a13fe12da98dc39b9ad2ffc214b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758048}
-
Zhongyi Shi authored
Save response headers and return to the caller when receive a redirect but URL fetcher stops on redirects. Bug: 936350 Change-Id: I933f362c966676d4a6dbbc0704afd69851edc248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143652Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758047}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/masking/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I02f8b56439403ebb0c0f70743649434816b99fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142116Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#758046}
-
Martin Šrámek authored
Per UI feedback. We can simply reuse the existing "Advanced" string from the main settings page, as its string resource description fits the new use as well. The previous string is not used anywhere else, and can be removed. Bug: 1069601 Change-Id: Iba34a77e33b3ad4d7dc4f8abd55d35a684bbf2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144043Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758045}
-
Domenic Denicola authored
Bug: 1042415 Change-Id: I771434df7a4dbcf8b26ea0bceded1f3e7b136ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116833 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#758044}
-
Maggie Chen authored
Release_Load() was used for an experiment. Now it's not needed. Change it back to Nobarrier_Load(). Bug:949839 Change-Id: I32faf515046b52a46165c741b80fd5bed1aea13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144681 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#758043}
-
Lei Zhang authored
It is nearly identical and not as complete as printing::IsColorModelSelected(). Bug: 1069266 Change-Id: I094307d5b679708ab974cfed18033cbbc2e14b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140959Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#758042}
-
Nicolás Peña Moreno authored
Bug: 543598 Change-Id: I9dab81aaa58b331fe9f5e7e102a3872152c8b09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142100 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#758041}
-
Kevin McNee authored
Bug: 1058496 Change-Id: I425c7e02b05fef6378fc30ad2ffa9bc2cb6b16ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142483Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758040}
-
Kai Ninomiya authored
Deprecates GPUTextureDescriptor.arrayLayerCount. Bug: 1069302 Change-Id: I2f3c327c793e6e9cba1df7f3d5e3ae07cda0b3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143379 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758039}
-
Garrett Beaty authored
The following changes were made to the console: * Builders with no category were moved to the beginning of the console; builders with no category always appear before builders with a category. * Builders in the ToT Windows category were moved before builders with more deeply nested categories; less-nested builders always appear before more-nested builders. Bug: 1067057 Change-Id: Ic79da7461bdf945bf04265f110f06a96e396fbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139420 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758038}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/56e977406c83..83844953c478 git log 56e977406c83..83844953c478 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 btolsch@chromium.org Add port to discovery e2e test service configs Created with: gclient setdep -r src/third_party/openscreen/src@83844953c478 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1fe9f4282bc35a1e28595f3ab817f8f8f183a230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758037}
-
Yue Zhang authored
Bug: 1065664 Change-Id: I2b423b9b5749db97a7dc2216307db0b4ee0994ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125953 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758036}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c53a40f4. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" ca551bc6 "[css-filters] Move multiple-references-id-mutate-crash.html test to WPT" c53a40f4 "Update size.attributes.parse.trailingjunk" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idfadb6d2493bb3d909119755660f57cbbb7b099c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143939Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758035}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0571c7d7..1eaaf114 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c80af12b66e8e131e6a45613473029fb7eeff50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144513Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758034}
-
Tibor Goldschwendt authored
The share dialog opens when clicking the share button on simple and animated doodles. The dialog lets the user share the doodle via Facebook, Twitter, email, and copy the doodle URL. + Add doodle description tooltip. + Remove TODO about the share button focus ring working for dark doodles. We decided it's an edge case and doesn't warrant fixing. Bug: 1039910 Change-Id: Ib2b8d9ca9447a2d6363d3c76167b393f914f60e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138792Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758033}
-
Lei Zhang authored
Change-Id: I3ba220a79a2094ea3bb9c338215c8a14c363ecef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142717 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#758032}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/08dd1a3ca3a5..605c93fb246c git log 08dd1a3ca3a5..605c93fb246c --date=short --first-parent --format='%ad %ae %s' 2020-04-09 tmathmeyer@chromium.org Catch json parsing error in media tab Created with: gclient setdep -r src/third_party/devtools-frontend/src@605c93fb246c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4080755f2991934df7bd0046d1d81ba6962c46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758031}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f6ff832d99a..059c1b75eb67 git log 9f6ff832d99a..059c1b75eb67 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9fa8abd9..ca551bc6 (757716:757925) 2020-04-09 henrika@webrtc.org Adds tiny rtc::StringFormat utility 2020-04-09 peah@webrtc.org AEC3: Remove deprecated parameter Created with: gclient setdep -r src/third_party/webrtc@059c1b75eb67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I41d896c70c06a42d4c9a0bf8aa40cc005f9ab5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758030}
-
chrome://appsDaniel Murphy authored
This adds back the "Create Shortcut" functionality to chrome://apps for the BMO system. R=loyso@chromium.org Bug: 1009302, 1069298 Fixed: 1069293 Change-Id: Ic14e71155a0eb7a6a02fb5a82aab9c3362f8b015 Tested: Manually, with BMO turned on and off Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121421 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758029}
-
Charlie Hu authored
This CL makes DocumentPolicyParserTest use mocking feature, instead of real feature in document policy. Change-Id: Ib49b6b0f73f8a5fe85450104d3837f746039a9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134580Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#758028}
-
Lily Chen authored
This adds a NetworkIsolationKey field to ReportingReport, which represents the report to be sent via Reporting API to some previously configured endpoint. This NetworkIsolationKey will eventually be filled in with the NetworkIsolationKey of the request for which the report was generated. For now this field is always empty, except in tests. Bug: 993805 Change-Id: Ie957d4600007f4a46c4fc32b3381d55f518b1a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137924 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758027}
-
Ben Joyce authored
Bug: 896775 Change-Id: Ia8b56274328b16b1255038c05bd49cba94c97471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144817Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#758026}
-
Tiancong Wang authored
New Clang update reports new warnings when C++ code provides anonymous typedef structs. The suggested solution is to either add a tag to the name or use C++-style struct. This patch fixes the warnings for the next toolchain update. Bug: 1068297 Test: Tested on Chrome OS Change-Id: I6863bc10d9094497b0d634ddee04891df8372906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144413Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#758025}
-
Jerome Jiang authored
New static library libvp9rc is added. Bug: 1060775 Change-Id: I3a641b096cf2a975f2abcc80c0fac34b9dbaa7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140903Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Auto-Submit: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#758024}
-
Kartik Hegde authored
BUG=chromium:956783 TEST=unit_tests --gtest_filter=NetworkDiagnosticsRoutineTest.* Change-Id: Idaefb63874cb26360a7d22f1ad7ed9cfe4da7810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113736Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#758023}
-
Mathias Bynens authored
A V8 CL [1] improves the terminology that’s used for internal promise state. Per the spec [2], a resolved promise may be “pending, fulfilled, or rejected”, but previously V8 incorrectly used the term “resolved” instead of “fulfilled”. This change is user-observable through the DevTools Console, and so a previous patch [3] updated the affected test’s expectations and temporarily disabled it. This patch re-enables the test. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/2144011 [2]: https://tc39.es/ecma262/#sec-properties-of-promise-instances [3]: https://chromium-review.googlesource.com/c/chromium/src/+/2144095 Bug: v8:6751, v8:5416 Cq-Depend: chromium:2144711 Change-Id: Id31fcbf5b21476d0e94fea4545824230946b9520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144068 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#758022}
-
chrome://discardsSigurdur Asgeirsson authored
While I'm in there add a style to make the swimlane dividers impossible to select, which was a persistent nuisance. Bug: 1068233 Change-Id: Ie4b1b10fe39823102e9ec36d6396865b49e5de32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144261 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758021}
-
Garrett Beaty authored
Change-Id: Ieaa7dd3aab2e677967f3af9bd48d1a793c56c23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142832 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758020}
-
Dan Harrington authored
- Learn more, send feedback, download page - Each counts as a feed interaction (Feed.EngagementType) - We'll add histogram or user actions for these events later. Bug: 1044139 Change-Id: I4965f637abdbff6f6630d88a28e7814ef7ef59ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138236 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758019}
-
Greg Thompson authored
This reverts commit 0c6bc2e3. Reason for revert: reverting to avoid perf analysis surprises -- to be relanded with a trace event. Original change's description: > Take user data snapshots on canary builds for each minor upgrade. > > Bug: 958893 > Change-Id: I987a99d3db2b659babe46d2f15cfac6627bc573c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134396 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757835} TBR=grt@chromium.org,ydago@chromium.org Change-Id: Ie5bc93a13e952ae13ab90249adb93623eb3261c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144173Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758018}
-
Kai Ninomiya authored
Deprecates GPUBindGroupLayoutEntry.textureDimension. Bug: 1069302 Change-Id: Idbf0928116bf01f702808f95ecc6d0a63a2caea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143378Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758017}
-
Nicolás Peña Moreno authored
This CL removes flakiness in the FCP-only tests by: * Adding a 50ms wait when FCP is not expected. This way, tests that would surface FCP would have enough time to do so. * Rely on PerformanceObserver to verify that FCP is surfaced in the cases where it should be. * Use a 300 ms timeout to declare that FCP was not surfaced when it is expected. This is larger than the non-FCP wait time since it sometimes requires waiting on CSS images to load. Bug: 1062984 Change-Id: I876b5bcdba3c795dc63326839899f3d5bb7a7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139362Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#758016}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aad6472eff7b..99ccc1759668 git log aad6472eff7b..99ccc1759668 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 treehugger-gerrit@google.com Merge "Rename smaps table to profiler_smaps." Created with: gclient setdep -r src/third_party/perfetto@99ccc1759668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7b9ded6e0ed5342f3f9291c9d6ae532adcf2ed66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758015}
-
Sean Harrison authored
Add a dialog to confrim a user want to disable safebrowsing Bug: 1067288, 1032584 Change-Id: Iddd781a3f369f5ee6359afb94ac18230b231a388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137404 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758014}
-
Danyao Wang authored
This reverts commit b666bbd0. Reason for revert: broke tests: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.payments.ExpandablePaymentHandlerChangePaymentMethodTest%23testThrowBasicCard Original change's description: > [Web Payments] Use PaymentAppServiceBridge JNI in PaymentAppService. > > This CL contains the final steps to make the Java PaymentAppService > invoke the C++ PaymentAppService: > - Moved remaining PaymentHandlerFinder functionality, namely, > onInstalledPaymentHandlerFounder() and onInstallablePaymentHandler() > from ServiceWorkerPaymentAppBridge to PaymentAppServiceBridge. > - Exposed the native method fireCanMakePaymentEvent() via a static > method on ServiceWorkerPaymentAppBridge so it can be used by > PaymentAppServiceBridge. > - Proxied ServiceWorkerPaymentAppBridge.setCanMakePaymentForTesting > to PaymentAppServiceBridge. This will be cleaned up in a subsequent > CL. > - Fixed a bug from a previous CL to pass payment apps to callbacks by > value instead of by reference. > > Bug: 1063118 > Change-Id: I87e254d6dc11e12f890353c9a0a6dde6cca73c9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141436 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757827} TBR=rouslan@chromium.org,danyao@chromium.org,maxlg@chromium.org Change-Id: I73fda6a9cf222a684d05e1b24229cfc26ae3630c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144682Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#758013}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d1c16380705..73e334469e89 git log 5d1c16380705..73e334469e89 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 reed@google.com fix computation for localToWorld 2020-04-09 bungeman@google.com Take MorphologyImageFilter radii as SkScalar. 2020-04-09 kjlubick@google.com [infra] Update dimensions for Golo Windows machines 2020-04-09 mtklein@google.com example of overdraw CF that we can JIT 2020-04-09 egdaniel@google.com Fix PinnedImageTest to make current original context at end. 2020-04-09 robertphillips@google.com Clean up GrText-related headers a bit 2020-04-09 reed@google.com Add markCTM(id) api, to replace functionality of saveCamera. 2020-04-09 tdenniston@google.com Sort viewer slides by filename when traversing a directory. Created with: gclient setdep -r src/third_party/skia@73e334469e89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068726 Tbr: csmartdalton@google.com Change-Id: I5dcaca1ad872b265fe4a99ce6a09df640870237c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758012}
-