- 02 Oct, 2018 29 commits
-
-
Jordy Greenblatt authored
Screenshots from both tablet and standard modes on PixelBook: https://drive.google.com/drive/folders/18lSB22-hWttyVZxNI7ASAE6m1Qvub8vI?usp=sharing Bug: 890088 Change-Id: I9367c87dc85a61b076d0db4ed1997980a308da86 Reviewed-on: https://chromium-review.googlesource.com/1256162Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#595678}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d7c52f8..4b7de4a5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84169c88a268ff4499a2824423975f5d241430fb Reviewed-on: https://chromium-review.googlesource.com/1256056Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595677}
-
Dan Sanders authored
VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED must be retained until all reads have been completed. Such frames are produced when software frames are uploaded to GpuMemoryBuffers. The VideoResourceUpdater handles this, but PaintCanvasVideoRenderer implemented only sync tokens. As a result, WebGL reads of software-decoded frames can tear when the storage is reused for later frames. This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to the VideoFrame until it completes. This ensures that the memory is not reused until after the reads complete in the GPU process. TBR=pfeldman@chromium.org Bug: 819914 Change-Id: Id181a476b78e2799bdbff149c9655427ae552743 Reviewed-on: https://chromium-review.googlesource.com/1252962 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595676}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/624fbdcf55b0..d082819ca2ad git log 624fbdcf55b0..d082819ca2ad --date=short --no-merges --format='%ad %ae %s' 2018-10-01 ynovikov@chromium.org Fix format support conditions 2018-10-01 jie.a.chen@intel.com Vulkan: Vertex buffer should be format aligned. 2018-10-01 geofflang@chromium.org Vulkan: Expose the unimplemented GL_EXT_occlusion_query_boolean extension. 2018-10-01 jgilbert@mozilla.com Stream support for R16*_UNORM and P010/P016. 2018-10-01 fjhenigman@chromium.org Remove PixelPackState from PackPixelsParams. 2018-10-01 oetuaho@nvidia.com Improve test coverage of constant folding Created with: gclient setdep -r src/third_party/angle@d082819ca2ad The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I33954d0598a45faa205139c5019379fcdce4b8a4 Reviewed-on: https://chromium-review.googlesource.com/1256222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595675}
-
Ken Rockot authored
== First some background: The NavigableContentsView client library by default uses views::RemoteViewHost to support embedding of a remote view within a client's own UI on platforms that support both Views and the Window Service. This is fine unless the client is running in the same process as the Window Service, which is in the case for out-of-process Ash. That is, when running Ash outside of the browser process on Chrome OS, we have it share a process with the Window Service. The Window Service implementation defines a ws::ServerRemoteViewHost which serves essentially the same purpose as views::RemoteViewHost but which actually works within the Window Service process. We obviously cannot tolerate the Content Service client library having a dependency on the Window Service (let alone its private implementation!). == What this CL does: Introduces a static NavigableContentsView::SetRemoteViewFactory API which can be called by a client to provide process-wide alternative View creation logic for remote views. If unset, the client library will continue to use views::RemoteViewHost for remote views. Ash uses this static method when setting up its in-process Window Service instance, providing a factory which emits ws::ServerRemoteViewHost objects. No Content Service implementation changes are required to support this, as it's really just a detail of how clients interface with the Window Service to support remote views. Bug: 854367 Change-Id: Ic6b09502ea2f84c3a4594e69e2a531a4efc1e3da Reviewed-on: https://chromium-review.googlesource.com/1237376 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595674}
-
rbpotter authored
(1) Fix an issue where icons were shrinking with browser window size (2) Related: To make the fact that the destination-list-item uses display:flex more clear, move all styling for this item into its own HTML file, rather than splitting with its parent list. (3) Remove margin which was not needed since the item uses padding. (4) Ensure max-height never gets set below min-height, and set a min-height for the list container. Bug: 890700 Change-Id: I4f91e43024faea494dbc5a48f6590ca3b863136e Reviewed-on: https://chromium-review.googlesource.com/1256004Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595673}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69f64b270397..2ba11d1c2b02 git log 69f64b270397..2ba11d1c2b02 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 eakuefner@chromium.org [Dashboard] Key histogram uploads by revision timestamp if necessary 2018-10-01 benjhayden@chromium.org Add option-group for v2spa 2018-10-01 sadrul@chromium.org trace-viewer: Add a close-button to hide a process. 2018-10-01 benjhayden@chromium.org Add column-head for v2spa 2018-10-01 simonhatch@chromium.org Dashboard - Add a diagnostic for the build url. 2018-10-01 benjhayden@chromium.org Add cp-toast for v2spa. 2018-10-01 mlippautz@chromium.org tracing: Fix Blink metrics and add unified GC total sum Created with: gclient setdep -r src/third_party/catapult@2ba11d1c2b02 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884961,chromium:889396 TBR=sullivan@chromium.org Change-Id: Ica59de5ef959096a97c5d76b961b0bd56d06df0a Reviewed-on: https://chromium-review.googlesource.com/1255570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595672}
-
David Trainor authored
- We currently prune out cancelled and non-resumable failed/interrupted downloads from downloads home. In the V2 version this didn't happen, so this adds the filter to address this. - In the process of adding the filter, I realized that the filter's onItemUpdated() logic does not handle items updating to/from a filtered out state. So this also adds that support as well as tests for it. BUG=889213 Change-Id: I5ae6b836abf77f914bd3f106a2d21b015e03aad2 Reviewed-on: https://chromium-review.googlesource.com/1244123 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595671}
-
Weilun Shi authored
When changing the font size on the settings, changing on the remove button is different than changing on the right span container for the other two buttons, that's why we see the inconsistent behavior. Therefore, adding additional left span for the remove button. Screencast: https://screencast.googleplex.com/cast/NDkxMzQ4OTQ4NzMzMTMyOHw5N2Y4MzQzMS0yYQ Bug: 883192 Change-Id: I398402cfdec9d8a93e95802fb4d99f6ded552cd0 Reviewed-on: https://chromium-review.googlesource.com/1255612 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595670}
-
Eric Aleshire authored
This enables selecting a value from a drop-down. As part of this: * I move "execute javascript against element" to a common function in Automation actions, since we use it in this action also. * I add a unit test for this action, and modify the web page we serve for unit testing to contain a dropdown. Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0dfdef2f94c2c5e2e5523e50ba3f89de2d420870 Reviewed-on: https://chromium-review.googlesource.com/1240913 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595669}
-
Sammie Quon authored
Test: manual Bug: 890493 Change-Id: I6dc5b284e27ae3861cbcfda0736a37c318f596a3 Reviewed-on: https://chromium-review.googlesource.com/1255609Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#595668}
-
Min Qin authored
In redirection error cases, we call DownloadResponsehandler::OnComplete(). And when connection is closed, OnComplete() could get called again, causing an NPE exception. This CL fixes the issue by early return on the 2nd OnComplete() call. BUG=890525 Change-Id: I2222a7980d7f53ff885b66b96ab2bdd1d963db75 Reviewed-on: https://chromium-review.googlesource.com/1255882Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595667}
-
David Black authored
In some situations we may destroy ManagedWebContents before it has run its callback to indicate contents are ready for embedding. This can occur, for example, if the user navigates to Assistant Settings and then closes Assistant UI prior to the contents being loaded. In such situations we still need to run the callback. Bug: b:116817905 Change-Id: I9ef8d3bcdd68d31a9cebb49300a6a9b465a85c4c Reviewed-on: https://chromium-review.googlesource.com/1249078 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595666}
-
Ben Kelly authored
This CL sets a default ResponseTime when a Response object is created. This will be overriden with the real ResponseTime when created via fetch() or Cache API. Synthetic Response objects created using the constructor, however, will end up using this default value for their ResponseTime. Bug: 747718 Change-Id: Id8c56c875d6ca00285048ebd51f92c0380dcfed1 Reviewed-on: https://chromium-review.googlesource.com/1255423Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#595665}
-
Jinho Bang authored
The event handler is triggered when the user changes payment method. This CL only defines the event in Blink side. A follow-up CL will make the event fire when user changes payment method on UI. This feature is still behind runtime flag(PaymentMethodChange). Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/e8Zrmy52r9w Related spec link: https://w3c.github.io/payment-request/#paymentmethodchangeevent-interface Bug: 824760 Change-Id: Ica77b46cbeeee78184a2bd66ce2198aae39b0c7a Reviewed-on: https://chromium-review.googlesource.com/1226774Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595664}
-
chrome://safe-browsingDaniel Rubery authored
Change-Id: Iade20c998ceed292eb16595ef23ae30d3bf03202 Reviewed-on: https://chromium-review.googlesource.com/1256013Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595663}
-
Xiaohan Wang authored
Now Widevine support is controlled by "enable_widevine" gn arg and this header is not used on Android at all. These were missed from previous CLs. Bug: 349182 Test: No functionality change. Change-Id: I651ec23a394d566c78a6c43e6cc9e06ff18d17fc Reviewed-on: https://chromium-review.googlesource.com/1256005 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595662}
-
Zhenyao Mo authored
The previous code is hardwired to youtube site. Now it's more generic, although it still doesn't work anywhere. BUG=867155 TEST=manual R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ief21731f484bbe2d0b2500483d304abdd27511de Reviewed-on: https://chromium-review.googlesource.com/1242453 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595661}
-
John Rummell authored
(Also updates one ffmpeg_regression_tests that now works properly.) https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/bbe6b81a6c31..458e9fd3f8e8 $ git log bbe6b81a6..458e9fd3f --date=short --no-merges --format='%ad %ae %s' 2018-10-01 liberato Don't rebuild ffmpeg configs / patches / etc. if already committed. 2018-09-28 jrummell Improve handling of .gclient file in script 2018-10-01 liberato Run handy regex to summarize gn file differences. 2018-09-28 liberato Push merge commit and set tracking branch. 2018-09-28 jrummell Chromium patches file 2018-09-28 jrummell GN Configuration 2018-09-14 michael avcodec/diracdec: check that GetBitContext has not ended in codeblock() 2018-09-14 michael avcodec/diracdec: Propagate errors from codeblock() 2018-09-12 michael avcodec/bintext: Use ff_get_buffer instead of ff_reget_buffer and simplify 2018-09-12 michael avcodec/bintext: Check input size before allocating the input image (...) Created with: roll-dep src/third_party/ffmpeg BUG=890005 Change-Id: I62781916144e5f9b919e985a0a182efb2e7eb159 Reviewed-on: https://chromium-review.googlesource.com/1255887Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595660}
-
Malay Keshav authored
This patch changes the accessor name from sk_bitmap() to GetBitmap. This is done to prepare for the addition of Paint records which will require a non inline function. Bug: 882507 Change-Id: I3e05ec775d8978461b7e68e585a5eb9d8e2fbb16 Component: ImageSkiaRep, Bitmap, ui Reviewed-on: https://chromium-review.googlesource.com/1255901Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#595659}
-
Wez authored
Change-Id: I3e7af0dcb90af2d8f8fe325291a9c31c1cfccd36 Reviewed-on: https://chromium-review.googlesource.com/1256202 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595658}
-
Bill Orr authored
Currently VR APIs on desktop are hosted in an unsandboxed process when enabled. After this change, VR Apis may be hosted in an AppContainer low-integrity process when a flag is enabled. This allows debugging sandbox issues before enabling VR by default. BUG=795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie16dd86cfa23171b0025359cd7e2d4db7997a9e7 Reviewed-on: https://chromium-review.googlesource.com/1162763Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595657}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ef78eae9311..a7a52b9de36c git log 8ef78eae9311..a7a52b9de36c --date=short --no-merges --format='%ad %ae %s' 2018-10-01 stani@google.com Fix error at run time to load skottie_android.so 2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 810f3db8264a..f1d777c71f03 (1 commits) 2018-10-01 herb@google.com Move remote glyph cache DFT handling to painter Created with: gclient setdep -r src/third_party/skia@a7a52b9de36c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I7913e9fab90ef5484670cb40d2e360bdfcbe67cb Reviewed-on: https://chromium-review.googlesource.com/1255511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b448050d611..2a44a65dc4a9 Created with: gclient setdep -r src-internal@2a44a65dc4a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I850898e28b36553e9a4f625f5a6117517c724fad Reviewed-on: https://chromium-review.googlesource.com/1255566Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595655}
-
Chris Palmer authored
It is breaking macOS GPU tests. Bug: 890752 TBR: ajwong Change-Id: I3f686473483cab053fc43e3d4b719a2900bdd71b Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1255592Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595654}
-
Andrey Kosyakov authored
Originally regressed by https://chromium-review.googlesource.com/c/chromium/src/+/876657 Bug: 878524 Change-Id: I3526eea2063a795b6f9049008cc564ca65c1ba04 Reviewed-on: https://chromium-review.googlesource.com/1255606Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595653}
-
Amos Lim authored
Add DocumentAndElementEventHandlers as per the spec[1] and remove oncopy, oncut, and onpaste from Document and Element. [1]: https://w3c.github.io/html/single-page.html#documentandelementeventhandlers Make Document, HTMLElement, and SVGElement include DocumentAndElementEventHandlers. Bug: 835570 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie81d7995dbe0824ad3a66ccbfabcdbe5e3864fa4 Reviewed-on: https://chromium-review.googlesource.com/1253169Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#595652}
-
Marcin Wiacek authored
According to various sources lambdas can provide profits in some scenarios. According to the https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Lambdas-and-Method-References lambdas are allowed also in Chrome, patch is migrating AnimatorUpdateListener usage to them. BUG=889613 Change-Id: I7d4af5f34e83abe03bd998359e4c0b3cc149e3f0 Reviewed-on: https://chromium-review.googlesource.com/1244440 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595651}
-
Thomas Anderson authored
This reverts commit a8d13c1d. Reason for revert: Suspected causing build failure on win32-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/3631 Original change's description: > Headless: remove devtools protocol network handler > > Network conditions management is now done in content, so support for > this in headless is redundant. > > Change-Id: I559de2c65e659c026b7e8e9d9021340e6271af92 > Reviewed-on: https://chromium-review.googlesource.com/1255610 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595637} TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org Change-Id: I0601d25a065e06cff731df50e1dae614ee194dc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1256166Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595650}
-
- 01 Oct, 2018 11 commits
-
-
David Tseng authored
Bug: 888152 Change-Id: I5584ab2c808b26f7363d214bedae38d080ba9735 Reviewed-on: https://chromium-review.googlesource.com/1246168 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595649}
-
Tatiana Buldina authored
Bug: chromedriver:2079 Change-Id: I5395a899686cb8b5f4d2a48f8ea6d7cfa9939e51 Reviewed-on: https://chromium-review.googlesource.com/1256109Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595648}
-
Kevin Marshall authored
content::NavigationEntry contains more useful data about the page load state compared to |validated_url|, which obscures the URLs that caused page load errors. Add an |is_error| field to indicate if an error occurred during navigation. BUG=890533 Change-Id: If7407cec236ddd5b1474f52ac2538b3a3657a366 Reviewed-on: https://chromium-review.googlesource.com/1252637 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595647}
-
Sophie Chang authored
Bug: 889621 Change-Id: Ibb038ec8ea75a75129dd9ccbfb20c86da750a901 Reviewed-on: https://chromium-review.googlesource.com/1255262Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595646}
-
Bailey Berro authored
- Marks username and password as optional in the add share dialog. Bug: chromium:891020 Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb Reviewed-on: https://chromium-review.googlesource.com/1255900Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#595645}
-
Jinho Bang authored
In the current implementation, memory leaks occur becuase the internal view_stack_ for payment sheet grows incrementally whenver calling retry(). So, this patch uses GoBackToPaymentSheet() instead of ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to reduce stack's size internally. Bug: 861704 Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc Reviewed-on: https://chromium-review.googlesource.com/1255082Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595644}
-
chrome://flagsMoe Ahmadi authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7303af44d7ada834b3d22e1cfdf5245976d7defc Reviewed-on: https://chromium-review.googlesource.com/1249910 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595643}
-
Nate Fischer authored
This implements the Quiet Billing interstitial and adds the approved strings from http://crbug.com/887186 and adds the interstitial to the debug WebUI page (chrome://interstitials). WebView support will come in a follow-up CL. Bug: 887186 Test: browser_tests --gtest_filter=InterstitialUITest.BillingInterstitialQuiet Test: Manual - observe chrome://interstitials page Change-Id: I4ff9811d925bdde81bf1349ac714c2533ad563bb Reviewed-on: https://chromium-review.googlesource.com/1256021Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595642}
-
Matt Menke authored
A recent change (https://chromium-review.googlesource.com/1161479) accidentally resulted in treating 304 responses as downloads. This CL treats them as ERR_ABORTED instead. This doesn't exactly match old behavior, which passed them on to the renderer, which then aborted them. The new code results in correctly restoring the original URL in the omnibox, and has a shiny new test to prevent future regressions. Bug: 882270 Change-Id: Ic73dcce9e9596d43327b13acde03b4ed9bd0c82e Reviewed-on: https://chromium-review.googlesource.com/1252684 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595641}
-
David Black authored
Already we are handling interactions that end in error if they contain TTS. As it turns out, these interactions do not always include TTS so we need to handle this case as well to show a message to the user. Bug: b:116786185 Change-Id: Ic1b281c5d84f4cc2d955e01e31ffe3218cc82503 Reviewed-on: https://chromium-review.googlesource.com/1249077 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595640}
-
Thomas Tangl authored
Record user action for signout button in user menu when the user is signed into Chrome (not syncing) and Dice is enabled. Bug: 891070 Change-Id: I3990093b7a59d047eff3ad07310c5c686c90e3ea Reviewed-on: https://chromium-review.googlesource.com/1255626Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#595639}
-