- 17 Apr, 2020 40 commits
-
-
ckitagawa authored
This CL simply augments FileWStream to support capping the file size. This work is a precursor to allowing a limit on the total capture size. Bug: 1071446 Change-Id: I38590bd52e50221f1007d92d673aca74f127158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152768Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#760090}
-
Theresa Wellington authored
Previously a DEPS rule was limiting import of internal app menu classes in chrome/android/java. This CL uses GN visibility instead, which can be controlled from within the component itself. BUG=966644 Change-Id: I4be0c36f81271259a4f71388db7d0671bd8ba699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934521 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760089}
-
Marc Treib authored
Reason: The underlying state that's being watched (i.e. password_manager_util::IsOptedInForAccountStorage) gets the relevant account-related state from SyncService, not from IdentityManager. So this is more consistent, and ensures that there are no order-of-observers problems. (SyncService itself observes the IdentityManager, so before this CL, the outcome could depend on whether SyncService or PasswordAccountStorageOptInWatcher get notified first.) Bug: 1024332 Change-Id: I916c6035961056d46a2061a3eeb9362467ac8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151871 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#760088}
-
Sahel Sharify authored
This cl disables MultipleRulesetsIndexingTest.StaticRuleCountExceeded on debug builds since it times out frequently. Example build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17957 TBR: karandeepb@chromium.org Change-Id: I05a9b3e69f66694ac9627ab16383d480912433e1 Bug: 1071403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154600 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760087}
-
Devlin Cronin authored
Use WidgetActivationWaiter instead of a custom WindowDeactivatedWaiter in tabs/tab_hover_card_bubble_view_browsertest.cc. This is less code and reuses a common utility. Bonus: It fixes a small typo. :) Bug: None Change-Id: I09c2202ebe2b79dc7c0397d7cb59b2253e353377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151673Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760086}
-
sczs authored
Change-Id: I695b93df9fc6a723f76065891935e979ba48796d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151970Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#760085}
-
Sharon Yang authored
Add SetBlockMediaLoading() to ApplicationController to enable media loading to be blocked, and passes the call to fuchsia.web.Frame. Bug: 1057860 Change-Id: Ib3c53e35d3fd1ffe2e43d01991ab7d85e2f025e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083565 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760084}
-
Roman Aleksandrov authored
Use new method for skipping screen. Add tests for UMA stats. Bug: 1064561 Change-Id: I2dd5ec7255fc748c33935c201d29384fbbc3ada2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151445 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760083}
-
nancy authored
For extensions, AppServiceProxy.Launch can't launch it, because they are not apps, and not saved in AppService app cache. So we have to restore the code change in CL:2049994 to use Extensions and LaunchAppWithParams to launch extensions. b:154201472 Change-Id: I8318a5144788e5b8f036a3369e2acf67c4fb1629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154347 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#760082}
-
Finnur Thorarinsson authored
Part 1 of 2: This CL adds a custom layout to the ClearDataDialog and fleshes out the part when deleting storage for a single origin. The new custom layout includes a new warning for when deleting app data, and changes the title and Clear button text slightly. Bug: 1068710 Change-Id: Ia7f302fb138540b7ebd11aa1ee87bdd8447b2042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153147 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#760081}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bf127479c6d..a19abd58cb38 git log 1bf127479c6d..a19abd58cb38 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 egdaniel@google.com Fix spirv rtheight set. Created with: gclient setdep -r src/third_party/skia@a19abd58cb38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I9119adbe6131c94339cd62abdc44cb3c8dae6d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154563Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760080}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b8fda4b..c572fb7d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7145f55cc41de8a2391c2a3cb77eebbc62b2c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153272Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760079}
-
David Van Cleve authored
This CL adds a test covering trust token issuance against an issuer whose configured batch size (number of tokens to request) is greater than the parameterized maximum batch size. It verifies that the number of tokens requested gets clamped to the maximum. R=csharrison Fixed: 1065388 Change-Id: I212d5e6a0b9dae6c8c812ed2513b2a4a4ff8d145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150304 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#760078}
-
Charlie Hu authored
Previously it is assumed when a frame owner element needs to update required policy, |GetDocument().GetFrame()| should not return NULL. It turns out this assumption is not always true. This CL let HTMLFrameOwnerElement::UpdateRequiredPolicy handle NULL frame explicitly, instead of assuming its not NULL. Bug: 1068100 Change-Id: I15e6ac7cffeff36761da945b67eca3f862719942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149527 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#760077}
-
Patrick Monette authored
This change is meant to make the order of the parameters of the factory functions and the constructor consistent. Change-Id: Icce46b60c7a5da5579fb172ea901eec92ffa566e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147888 Commit-Queue: Patrick Monette <pmonette@chromium.org> Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#760076}
-
Stephan Hartmann authored
Change-Id: Ifbc379adc5bb7242c21e7da0bcfc28f49e4dd06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153111Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760075}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02153f0ed2c9..35ebb85fa793 git log 02153f0ed2c9..35ebb85fa793 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 szuend@chromium.org [issues] Adapt SameSite cookie issues to backend changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@35ebb85fa793 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06c2d0c0e0ed567421e04cd78e66eec5c2152781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760074}
-
Christian Dullweber authored
Add render test to ensure PageInfo is displayed correctly in various states. Bug: 1040091 Change-Id: Ic6334f662ec966e573bfbda5043f38815b83fe59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061754Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760073}
-
Clark DuVall authored
Factored out chrome-specific logic into a delegate, and the protocol handler logic was completely moved to the delegate. The interesting changes are in tab_specific_content_settings*, most of the other changes are adding the content_settings:: namespace. Bug: 1070825 Change-Id: I912e385b10dbb98aa7ab9da1ee138264dab3ec96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151841 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760072}
-
Antonio Gomes authored
Drive-by: some \t are renamed at 4-spaces. BUG=767015, 1063749 R=rego@igalia.com Change-Id: I369fc1fb602c4b87f33d8fe14b517743e82aec02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154460 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#760071}
-
Tina Wang authored
- Add policy handler - Edit policy_test_cases.json to enable unit test Bug: 1066474 Change-Id: Ide9dfceb4c30456113536165066911200c96e627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130632 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#760070}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/307b31ea2a17..6da120098f37 git log 307b31ea2a17..6da120098f37 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 treehugger-gerrit@google.com Merge "Extract basic counters from thread time in state" Created with: gclient setdep -r src/third_party/perfetto@6da120098f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I39321e3f92d27df216fc657e32626c326557808a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760069}
-
Robbie Gibson authored
Text Zoom does not work on iPad because the Javascript property used to change the content size doesn't work on iPad in iOS 13. Bug: 1061119 Change-Id: Icc46da8c2a6990388b72312eaa4d4fd5807bd29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152812 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760068}
-
Guillaume Jenkins authored
- Adds the basic handler for the SavingBrowserHistoryDisabled policy on iOS. - Adds simple unit test for the policy via the boolean test helper. - Adds an EG test for the policy that also tests at the feature level to ensure the end behavior is as expected. - As part of this, small refactors were done to ChromeEarlGrey helpers and to the history EG tests. Bug: 1066488 Change-Id: Ibd466e2689b1aaaffab1b576d2fc92811dc6b9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140712 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760067}
-
Samuel Huang authored
This CL adds tests for the remaining methods in FileUtils: * extractAsset(). * queryBitmapFromContentProvider(). Bug: 1066730 Change-Id: I194c62a83ea9a9d656e04947b304401cb2062281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154383 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#760066}
-
Gauthier Ambard authored
A todo that was left from previous CL. Bug: 1025225 Change-Id: I0f0bfbfbeeef992db102a6b2326eac353a0bf4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144075 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#760065}
-
Colin Blundell authored
This CL dedupes the identical matchResolveInfoExceptWildCardHost() methods of //chrome and //weblayer's ExternalNavigationDelegate impls into ExternalNavigationHandler. This deduping is a preq for removing a bunch of methods from the ExternalNavigationDelegate interface. Bug: 1071390 Change-Id: I0a7d126f08a50397b1e042a3a347cccbf6a7984a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154190Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760064}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25ce8725224..ea66320c09bd git log d25ce8725224..ea66320c09bd --date=short --first-parent --format='%ad %ae %s' 2020-04-17 bclayton@google.com SpirvShader: Fix ASSERT firing in debugger Created with: gclient setdep -r src/third_party/swiftshader@ea66320c09bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I690284df3bd006ce0ddabe78fbf94bbba78eacd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760063}
-
Sasha McIntosh authored
Manually tested by deploying to a CrOS device, rotating and casting the screen. Verified via log statements that occlusion culling is performed. Test: DisplayTest.DrawOcclusionWithMultipleRenderPass Bug: 1022544 Change-Id: I389a658699e4e68c5269151ab7be3d6f0e341341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139433Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#760062}
-
Dave Tapuska authored
This allows us to replace this with a mojo definition in a later CL. TBR=avi@chromium.org Change-Id: I62b500dc091e197bb887feb2ae3dc35d7469784f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153069 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#760061}
-
Victor Hugo Vianna Silva authored
TBR=sky@chromium.org TBR=rouslan@chromium.org Bug: 1057577 Change-Id: Iccb6ae9ad543a63b0764fdb0703e3137bc808f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153070 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760060}
-
Pavol Marko authored
This does a few things: * Bump policies that were documented to be supported starting with M-82 to M-83 or M-84 (depending on the policy author's feedback). * Update docs of policies that were saying they would be removed in M-82 but are still there. * Some version examples mentioned M-82, changed that to M-83 too. Policies that were marked as supported until M-81 were not modified, because that's technically still correct. BYPASS_POLICY_COMPATIBILITY_CHECK=M-82 is skipped so the changes are safe Bug: 1071651, 1016253 Change-Id: I8901c0dd0c2a5cd164d67c3da8d1847cd5ab648a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153028Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a846fe623f6..633ae40e7435 Created with: gclient setdep -r src-internal@633ae40e7435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049042 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I85eac9d0733379c2b7c1ff3a6cf0578eeae71d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154556Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760058}
-
Gauthier Ambard authored
This CL restrict the user agent restoration to iOS 13 and further as iOS 12 has an issue getting the right User Agent. Bug: 1070593 Change-Id: Ie4570efcb9931ccb8662511b16a1298570f0a297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154189Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760057}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1261b5caa386..da6cda839dac git log 1261b5caa386..da6cda839dac --date=short --first-parent --format='%ad %ae %s' 2020-04-17 elrello@microsoft.com Improve outbound-rtp statistics for simulcast Created with: gclient setdep -r src/third_party/webrtc@da6cda839dac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6d2ce79aa75cf4d319d71dfb92d6e2aee7aca52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760056}
-
Nohemi Fernandez authored
The new sign-in architecture modifies the case of several button title labels in the sign-in UI. This causes EarlGrey test failures when we try to use the new architecture exclusively. Move all tests that currently use raw test to use accessibility IDs. Bug: 971989 Change-Id: Ic8b38bef5de13786330c606328d21b5720e0931d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146903 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760055}
-
Avi Drissman authored
There were two different watchers for WebContents destruction in two different test helper files, in addition to lots of tests rolling their own. Consolidate all of them. Bug: none Change-Id: I9b5723758aa997467689cce8767a3def9e8c13e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153747 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#760054}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0173ae54a67a..02153f0ed2c9 git log 0173ae54a67a..02153f0ed2c9 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@02153f0ed2c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5469526d9469011b1945397bc503f46a7db94fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760053}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/748197e6959a..1bf127479c6d git log 748197e6959a..1bf127479c6d --date=short --first-parent --format='%ad %ae %s' 2020-04-17 kjlubick@google.com Reland "Revert "GrDisplacementEffect uses GrTextureEffect."" Created with: gclient setdep -r src/third_party/skia@1bf127479c6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ie0e316f2b3ad1cd7ec503de25ace735ff8a24b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760052}
-
Olivier Robin authored
Attribute is needed for some debug functions in Xcode (e.g. simulated MetricKit payload). Change-Id: I6ee8456a7dd4bc1ecc9e3ebc4e31526b2c5ad506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144039Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760051}
-