- 26 Sep, 2019 40 commits
-
-
Kevin McNee authored
Previously, we've had to wait for readystatechange before defining the guest view custom elements because 1) there were circular dependencies that would cause errors if we tried to perform the definition immediately, and 2) the Custom Elements V0 registration context was scoped to the document rather than the window, so if we defined the elements while the document was still on about:blank, the definition would be available on about:blank, but not for the extension. Now that the circular dependencies are fixed and guest view is migrated to Custom Elements V1 (whose registration context is scoped to the window), it is no longer necessary to wait for readystatechange. We now perform the definition immediately. Bug: 810012 Change-Id: Ib5e8ba6f4e302eaae56c5566765521d64b1a0e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1278287 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#700425}
-
Khushal Sagar authored
Importing an AHB to the client sandboxed process seems to be causing issues, so disable GMBs for canvas resources completely. Using a GMB here is also not useful unless SurfaceControl is enabled. Since the GMB can not be used as an overlay otherwise. R=mcasas@chromium.org Bug: 1003920 Change-Id: If9fd6c965d004775ad79e162a660dfef02ad1a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827857Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#700424}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2bdefbf8162d..70d79b76994e git log 2bdefbf8162d..70d79b76994e --date=short --no-merges --format='%ad %ae %s' 2019-09-26 jonahr@google.com GL: Add state validation functions to GL backend 2019-09-26 jmadill@chromium.org Vulkan: Clean up garbage APIs. Created with: gclient setdep -r src/third_party/angle@70d79b76994e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I608e73c42bebe4ceafce70d4943da1eeaadb75fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700423}
-
Livvie Lin authored
Add enum values to SafetyTipInteraction to record how a user dismisses the Safety Tip. Bug: 1001162 Change-Id: Ib4c86d88d21362593767c0d5c31fa3f0c1ac1edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822498 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#700422}
-
Yuwei Huang authored
This CL implements a GstaticJsonFetcher that actually connects to gstatic to fetch the JSON files. Bug: 1001291 Change-Id: I5dcb34e1ea10b8ab6a80343d73757de5bd08da37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825484 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#700421}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/983111f039f6..e4174f483ee5 git log 983111f039f6..e4174f483ee5 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 mbonadei@chromium.org Add VS 2019 support to package_from_installed.py. 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 ehmaldonado@chromium.org depot_tools: Enable more tests for windows. Created with: gclient setdep -r src/third_party/depot_tools@e4174f483ee5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1006238,chromium:1007580 Change-Id: Ia1456294b6f69fc2ca860a18992cc5a372491693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700420}
-
danakj authored
Merge the method up into SynchronizeVisualPropertiesFromRenderView() and change callers to it elsewhere. One unit test is changed to call SynchronizeVisualPropertiesFromRenderView() instead. The web test synchronous resize mode path is changed to set the sizes without constructing a VisualProperties. R=avi@chromium.org Bug: 1006052 Change-Id: I74bfeec606fba52e793cf4f624a759b3858eb88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825623 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700419}
-
Sigurdur Asgeirsson authored
Bug: 1003391 Change-Id: I27a60bffbf951c92ed1bcf8ffbafd7e473335f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827379Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700418}
-
K Moon authored
Adds a "LayoutOptions" object that is passed from the PDF plugin (via the "documentDimensions" message), through the extension, and back to the plugin (via the "viewport" message). We plan to make layout asynchronous for crbug.com/885110. To accomplish this, we need to carry certain layout state through the JavaScript layer, until the layout change finally is applied. In the future, we may want to modify the layout options in JavaScript (such as for 2-up view), but for now, we just need to pass the exact same object back and forth. Bug: 885110 Change-Id: Iaac57422dbba185399358ceffdbde4e6ad2c7899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815769 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#700417}
-
Scott Violet authored
When OnTabClosing() is called the WebContents has been removed from the model. This is problematic as it's entirely likely for some of the code in OnTabClosing() to trigger a call back to Browser by way of a delegate which then expects the WebContents to be in the model. The fix is to reset the delegate early on in the future, so that none of the code calls back to Browser. TabDetachedAtImpl() also resets the delegate, but TabDetachedAtImpl() may be called in scenarios where OnTabClosing() is not called. BUG=1007379 TEST=none Change-Id: I6d0141a540b39ce52725d7bc198175e1b89a40af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825924Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#700416}
-
chrome://usb-internalsSamuel Huang authored
This CL also serves as a self-contained "vertical" example for how to move a WebUI page to the DevUI DFM. Bug: 927131 Change-Id: I88c5f624d2094ecfd1cf1919d9cb4abe8d1daea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823605Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#700415}
-
Ken Rockot authored
This change allows Mojo client processes to connect to a new process network if disconnected from a previous one. Prior to this change, a process could only belong to one network for its entire lifetime. This new behavior is useful in cases where a client process may outlive its original broker process (for example, if the broker crashes) and should be able to continue operating normally when a new broker process is established in the system. Bug: 813112 Change-Id: Ifb5f16f1b39127cf7b469ee798f2d3da159fa432 Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821743Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#700414}
-
Andrew Xu authored
This bug was introduced by my previous CL (https://crrev.com/c/1811183). In that CL, calculating the edge padding was put before the update of layout strategy. In this CL, replacing the check on layout strategy with calling CanFitAllAppsWithoutScrolling. Bug: 1006379 Change-Id: I74b6e0f85662d1c5c31cdbe0d1139357000a3321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828060Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49c073257022..be4787124940 git log 49c073257022..be4787124940 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 mtklein@google.com hsw::S32_alpha_D32_filter_DX 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 csmartdalton@google.com Remove the resolve rect and resolve types from GrRenderTarget 2019-09-26 ethannicholas@google.com Revert "Revert "remove 'in uniform' support from GrSkSLFP, make rules more clear"" 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 kjlubick@google.com [canvaskit] fix null terminator on drawText 2019-09-26 bsalomon@google.com srgb texture format cleanup. 2019-09-26 michaelludwig@google.com Improve subpixel coverage calculation for thin quads 2019-09-26 bsalomon@google.com Check support for each GL format independently. Created with: gclient setdep -r src/third_party/skia@be4787124940 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:1007154,chromium:1003481 Change-Id: I122e5d54c189ccf2434831f7b6c77939654e7054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700412}
-
danakj authored
Change RenderWidgetScreenMetricsEmulator API back into RenderWidget to be specific to the properties being changed. Then it won't need to take as input the whole VisualProperties in the future. And now it doesn't need to construct a VisualProperties object. Also make turning off the emulator explicit rather than having to destroy it and having the destructor call back into the RenderWidget. We will continue to remove RenderWidget re-entrancy with the emulator in future changes. R=avi@chromium.org Bug: 1006052 Change-Id: Ie751a57117aa52205216b78190fec96777088e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825318 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700411}
-
Jeroen Dhollander authored
Until now the |AssistantServiceManager::State| enum did not distinguish between the state in which libassistant was started (but not ready yet) and in which it is ready. That distinction is needed to be able to add tests using libassistant, as they have to wait until it is ready. So now there are 4 states: - STOPPED: It has not started/it has been stopped (this is the same as the old STOPPED state). - STARTING: |AssistantServiceManager::Start| has been called and the libassistant |AssistantManager::Start| call has not finished yet (this is the same as the old STARTED state). - STARTED: the libassistant |AssistantManager::Start| call has finished, but libassistant has not signalled it is ready yet (this is the same as the old RUNNING state). - RUNNING: libassistant signalled it is ready (this state is new). As this CL also introduces the first unittests for |AssistantServiceManagerImpl|, it also contains a bunch of fake/dummy classes used for the unittests. This CL increases test coverage in //chromeos/services/assistant from 28% to 41%. Change-Id: If38a6b70e22e6392537b6658e5f39eebf6dd9099 BUG: b/141264108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810019 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700410}
-
Darwin Huang authored
Using ImageEncoder will allow for further customization of options. Additionally, as mentioned in [1], we should delete the ui/gfx image encoder, so moving from this encoder may streamline future deletion. No intended functional change. [1]: https://codereview.chromium.org/2891373002 Bug: 1004867 Change-Id: I97ec05b40996f4130dad834d79228dda91d4c14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827244Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700409}
-
Miyoung Shin authored
This change converts InstalledAppProvider mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ic31986ceb75b86691c0db1bed163bd2b7bfd8a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820878Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#700408}
-
Brian Sheedy authored
Adds the necessary Chromium-side changes to fix stack symbolization for non-browser crashes in GPU Telemetry tests on Android. Specifically: 1. Makes the GPU tests use GetStackTrace() on Android instead of LogSymbolizedUnsymbolizedMinidumps(), as this is currently the only way to get stack traces through Telemetry on Android. 2. Adds a --breakpad-dump-location argument to ChromeCrashReporterClient that is functionally equivalent to the existing BREAKPAD_DUMP_LOCATION environment variable, but necessary for Android since we can't set environment variables before launching Chrome on Android. 3. Moves the dump location override to ChromeCrashReporterClient::Create instead of whe retrieving the crash dump location in order to avoid issues with Android calling blocking functions in a scope that does not allow blocking functions. Bug: 949321 Change-Id: I9be2446a73a2359157cd94c889bf34951b78c86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825719 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#700407}
-
Xiaohan Wang authored
This was used in AndroidVideoDecodeAccelerator previously and has been obsolete. Bug: 789435 Change-Id: I870507c35be3856a412217b51a325de12d5fff84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825483 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#700406}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/db4083fd7f19..432efa25b347 git log db4083fd7f19..432efa25b347 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 apodtele@gmail.com * src/base/ftstroke.c (ft_stroker_outside): Speed up clipped miter. Created with: gclient setdep -r src/third_party/freetype/src@432efa25b347 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I039893046df97f0a52890a5cd2c725e28f1d1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#700405}
-
Toni Barzic authored
If omnibox result details are empty, the app list search box should display the provided search result title instead of empty details. (if the details are empty, the target URL is provided as result title) BUG=1007030 Change-Id: Ia9f18a8375eaa562b3e63dd548905f1a7005e579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816147Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700404}
-
Klaus Weidner authored
Avoid using generic names such as "base pose" or "transform", and try to always specifically say which two spaces are connected by transforms. Use the B_from_A naming convention where possible, so that transforms can be chained naturally. Bug: 1008102 Change-Id: I74988f89340375197017f9f518f69d4fd03e7d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825585Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#700403}
-
Johannes Henkel authored
Also, deprecate sendMessageToTarget. Bug: 991325 Change-Id: Ic29e941f0131adb00165dfde8380c4bb1c4ab982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827674Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#700402}
-
Boris Sazonov authored
Settings entry to switch sync accounts has been removed, so this CL removes dialogs that are no longer used. Bug: 1007331 Change-Id: I368b2115404696b41d355997ae297f921347b7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821612 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700401}
-
Eric Karl authored
Now that Blink no longer needs to toggle GPU rasterization, we can remove a bit of code. This change pulls out the gpu rasterization viewport trigger logic from Blink and CC. Because the UI compositor still needs a way to control gpu rasterization on platforms that have not enabled it for UI, we add a new layer tree setting, |gpu_rasterization_disabled|. Bug: 899399 Change-Id: I0dccc5ec6c90e4cff9a703d9cb629e2193ae3e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804183Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#700400}
-
Charlie Hu authored
Bug: 1005779 Change-Id: I915eac43a06592cf2e196632408b4736b4f75f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827823Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#700399}
-
Dominic Mazzoni authored
AXTree::RelativeToTreeBounds has some logic that tries to avoid returning an empty bounding rect. If the current node has zero size, it tries to compute the size either from the union of that node's children, or if that fails, from the bounds of that node's nearest ancestor with a size. There was a subtle bug in this logic if a node has a position but zero size. In a case like this: root (0,0) size (800x600) window (100,100) size (400,300) button (120, 120) size (0,0) The algorithm was returning a position of (220,220) incorrectly. The fundamental problem was trying to fix a bounding box with zero size at the same time as it was trying to walk up the ancestry to turn relative positions to absolute positions. The new algorithm just does it in two passes: first convert relative to absolute, then if the bounds has no size, find the nearest ancestor with a size and expand the current node as much as possible within that ancestor's bounds. Bug: 1005977 Change-Id: Ib4963fa98dabf958be49d3e13d6d932280b01b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815257 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#700398}
-
Vasiliy Telezhnikov authored
This CLs makes sure that GL Context made current inside SwapBuffers and SetEnableDCOverlays to prevent potential crashes inside DirectCompositionChildSurfaceWin. Bug: 1007919 Change-Id: Ib28bd2a72405ea9f11fcbfecea50cecfb4d40760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827484Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#700397}
-
W. James MacLean authored
This modifies the viewport rect passed to OnDraw() to exclude the origin if it's non-zero, since otherwise this adversely affects the compositor clip rect. The non-zero value of the origin is captured in the adjusted transform. Bug: 1007012 Change-Id: I614b8ea3f14219d3dba54ad0a552b3e34145500e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827639Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#700396}
-
Vasiliy Telezhnikov authored
This CL changes SkImage pixel upload logic inside WrappedSkImage to support ETC1 and other format when they are not renderable. Bug: 906794 Change-Id: Ica7da0e7ce4a5feee7dc5286af51a239ae3257f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810759 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#700395}
-
Jonah Ryan-Davis authored
ANGLE creates a child window when using X11. The Expose events from this child window need to be forwarded to Chrome's parent window for the window to be properly redrawn. Bug: 991577 Change-Id: Ibba1ad07110953dc46b7bd1939b03471a316f798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822721 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700394}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6384e38b..e4371bf3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4413320e16bd47ed48e2a858db25c95070f35fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827897Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700393}
-
Joshua Peraza authored
crashpad_main defines the native entry point for the JNI call used to launch Crashpad from CrashpadMain.java. This dependency was mistakenly removed in: https://chromium-review.googlesource.com/c/chromium/src/+/1824018 Bug: 1008383 Change-Id: I20c27a14191611eba8155affb404370ca6523c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827825 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#700392}
-
Fredrik Söderquist authored
We should aim to have these checks around the API "border" and then prevent certain actions when it is true (like scheduling frames). This hoists the check in UpdateAnimationsAndScheduleFrameIfNeeded(...) out into its callers adds TODOs where it seems we shouldn't need to check (per the previous sentence). Bug: 998526 Change-Id: I782a41033c33dba38b4923e96e84531858675c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827422Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700391}
-
Henrique Nakashima authored
Bug: 995916 Change-Id: Ic874d6287e224da3277cff98457604617f5a64dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814919 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#700390}
-
Yue Li authored
Copied from email thread: EnableRequireVoiceMatchVerification option is intended to be used independent of whether or not the user has speaker id models on-device (i.e. Libassistant ignores that option if user has no SID model). The downside of conditionally enabling it would be: If the speech pipeline is already running when that option is set, the change won't take effect until next Speech pipeline restart (b/120241931). Bug: b/120241931 Test: Manual Test Change-Id: I0deef204ef5c6dd9ee36acbb5074d1a2e47731c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824676Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#700389}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b4ffe881cdd7..ee8ee2f10366 git log b4ffe881cdd7..ee8ee2f10366 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 henrika@webrtc.org Avoids update of WebRTC.Audio.SourceMatchesRecordingSession for Android < N 2019-09-26 sprang@webrtc.org Prepares RtpSenderVideo for batch forwarding of generated packets 2019-09-26 nisse@webrtc.org Report payload byte counts in PC-level quality tests Created with: gclient setdep -r src/third_party/webrtc@ee8ee2f10366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I38b2436719273b6b081cb43f6f6fbc54be6fd3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700388}
-
Amr Aboelkher authored
A device policy which controls the select to speak accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_select_to_speak_enabled policy to True, open System Tray => "Accessibility", check that "Select-to-Speak" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Select-to-Speak" is not displayed in the login screen. Bug: 552439 Change-Id: I86bfea61ccf3cac74934f17181c260d5649e04c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816558 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#700387}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 045ed7eb. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" b5630d76 "Convert NFC client to use BrowserInterfaceBroker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib126001e6ac2eaf2343c70dde2665eee664b1696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827612Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700386}
-