- 24 Jul, 2018 37 commits
-
-
Justin Cohen authored
TBR: sczs@chromium.org Bug: 866730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70 Reviewed-on: https://chromium-review.googlesource.com/1147701Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577384}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2bfa78540c37..1116ef0b1c45 git log 2bfa78540c37..1116ef0b1c45 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 tsepez@chromium.org Remove unused CFXJSE_Arguments::GetObject() 2018-07-23 tsepez@chromium.org Remove argument from CFXJSE_Value::ToHostObject() Created with: gclient setdep -r src/third_party/pdfium@1116ef0b1c45 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I01e1215ef5cfdc9d6b7b6a8f84232156c6e6f573 Reviewed-on: https://chromium-review.googlesource.com/1147069Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577383}
-
Victor Costan authored
This CL: * Adds SQLITE_OMIT_COMPLETE, removing command auto-completion logic * Adds SQLITE_HAVE_ISNAN, removing SQLite's custom implementation * Removes -ldl, which was only needed for runtime extension loading Change-Id: I065c2faba028379e336b2d691afad7093328d7c3 Reviewed-on: https://chromium-review.googlesource.com/1146290 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#577382}
-
Fady Samuel authored
We close fallback surfaces in order to speed up the arrival of the primary surface from a child client. That logic was complex and difficult to follow. Now with SurfaceRanges, that logic can be simplified somewhat. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ied2efb4eac61f297fe6784825084f0a88e716dab Reviewed-on: https://chromium-review.googlesource.com/1147114 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#577381}
-
Sam McNally authored
As of https://crrev.com/170137, component extensions/apps are installed when their version changes, performing all the usual extension-install work, including registering the extension with ExtensionPrefValueMap. When a component extension is loaded without a version change, much of this is skipped, leading to ExtensionPrefValueMap::CanExtensionControlPref() hitting a NOTREACHED(). Fix this by including component extensions when initializing extension-controlled prefs, which includes registering the extension with ExtensionPrefValueMap. Bug: 454513 Change-Id: Ic478e5ac5367e3bb22cebd6e9422e9ca5bd48849 Reviewed-on: https://chromium-review.googlesource.com/897223Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577380}
-
Xiaocheng Hu authored
This patch moves the definition of NGOffsetMappingBuilder::SourceNodeScope to the beginning of NGOffsetMappingBuilder before all member functions for better coding style. Bug: 699017 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If0a6d9ea5fad9194a5a3148f4724a45861964d6c Reviewed-on: https://chromium-review.googlesource.com/1147547 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#577379}
-
Tetsui Ohkubo authored
According to UX mock, audio settings button shown on the right of volume slider is wide and has both headset icon and expand icon. Screenshot: http://screen/ei2trCkJcSA UX mock: http://shortn/_EMpEzaBIUx TEST=manual BUG=860600 Change-Id: I477243e757632881dc6ac9043838ebcfafcb69b4 Reviewed-on: https://chromium-review.googlesource.com/1141678Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#577378}
-
tzik authored
While DOMStorageNamespace::Clone constructs an instance, it binds it to a callback, post it to a task runner and returns the instance as a raw pointer. Note that base::BindOnce here retains a reference to |clone| and releases the reference when the callback instance is destroyed. However, if PostTaskAndReply there failed, the callback instance is destroyed immediately and DOMStorageNamespace loses the last reference. Then, DOMStorageNamespace::Clone may return a stale pointer. This CL converts the return value to scoped_refptr, and has Clone() to keep the reference to the resulting instance. Bug: 866456 Change-Id: Ic3a5a02e266bf55f8ad3c4f901eb1eebc2ea9d8e Reviewed-on: https://chromium-review.googlesource.com/1146409Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577377}
-
Ryan Hamilton authored
Change-Id: I74954583abe08aaf4e8211946d1ae96f0c593b12 Reviewed-on: https://chromium-review.googlesource.com/1131832 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577376}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1381813c377d..6a1002b4d937 git log 1381813c377d..6a1002b4d937 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 simonhatch@chromium.org Dashboard - Add nexus 5x to list of supported for Pinpoint 2018-07-23 dtu@chromium.org [pinpoint] Add "Android Go" bot to Pinpoint. 2018-07-23 benjhayden@chromium.org Upgrade PageStates for V2SPA. Created with: gclient setdep -r src/third_party/catapult@6a1002b4d937 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863995,chromium:866251 TBR=sullivan@chromium.org Change-Id: I90c1447744e601493ac2c8d2d8258975268d05e9 Reviewed-on: https://chromium-review.googlesource.com/1147068Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577375}
-
Tim Dresser authored
We no longer test non-webview Nexus 6. Bug: 736497 Change-Id: I22942bb8a57c63e3b295f6f71df570c3a3fc014d Reviewed-on: https://chromium-review.googlesource.com/1143584 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577374}
-
Tommy Martino authored
Currently, we don't draw the background on the separator. This is fine on Win and Mac, because by default we just see white anyway. But on Linux (specifically GTK+) we draw gray by default, giving an ugly gray splotch. Change-Id: I6f6d61d7ade28d30a659858a9a83bf0506aa3637 Bug: 866637 Reviewed-on: https://chromium-review.googlesource.com/1147158Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577373}
-
Erik Chen authored
This class will eventually be responsible for forwarding task and event metadata to the Calculator. This class spans the UI and IO threads, so the threading is tricky. This CL sets up the structure of the class, including all the of threading details, and reentrancy handling. Future CLs will hook up tasks and events. Bug: 859155 Change-Id: I7e8706e82dd07ae54ae9b150a6db7a8113ffdc9b Reviewed-on: https://chromium-review.googlesource.com/1144226Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577372}
-
Wei-Yin Chen (陳威尹) authored
This depends on crrev.com/c/1142484 for non-ARM build. Bug: 338784 Change-Id: If825ffbbf5df78063787bbb97c5e7d3599efdccb Reviewed-on: https://chromium-review.googlesource.com/1139894 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577371}
-
Scott Violet authored
This removes ScreenProvider, WindowManagerClient and most of the WindowManager interface as they are not needed. Additionally this cleans up a couple of functions in WindowTree. Doing this showed a couple of test failures in aura. I'm making them early out for now and will investigate after this. The failures are because previously even though mus was configured some tests created WindowTreeHostPlatform, when I changed that to WindowTreeHostMus the tests started failing. BUG=865689,842365 TEST=none Change-Id: Id5a67d7f513b2015a46a75745593ba122d17f6df Reviewed-on: https://chromium-review.googlesource.com/1146336Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577370}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c4668d00232..b8eeb808d84f git log 1c4668d00232..b8eeb808d84f --date=short --no-merges --format='%ad %ae %s' 2018-07-23 timliang@google.com added integration for non-moltenvk use of SkSLC MSL generator Created with: gclient setdep -r src/third_party/skia@b8eeb808d84f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I5ae3ff1b55afb2d082e2bd087bf484854dd27440 Reviewed-on: https://chromium-review.googlesource.com/1147067Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577369}
-
junweifu authored
The native request first locates all barcodes in the input image, then analyzes each to decode payload. The bounding box of the detected barcode are normalized to the dimensions of the processed image, so the coordinates need to be converted. Forward declaring the necessary symbols in sdk_forward_declarations.h. BUG=848182 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Change-Id: I03b966a1886feaf64a87e778396ad96e3d16b85e Reviewed-on: https://chromium-review.googlesource.com/1142831Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#577368}
-
Devlin Cronin authored
Create a custom element for the runtime host permissions controls in the chrome://extensions page, rather than having them defined in the DetailView element. This will make it easier to test and expand the controls. Pull the controls into runtime_host_permissions.[js|html], and extract the tests from extension_detail_view_test.js to extension_runtime_host_permisisons_test.js. Also add an additional test to verify the runtime host permissions dialog is shown when the 'add' button is clicked. There should be no visible UI changes as a result of this CL. Bug: 844128 Change-Id: I741adc921af95253087dbf31be1800c01fb4185c Reviewed-on: https://chromium-review.googlesource.com/1146999Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577367}
-
Andrey Kosyakov authored
We previously reported redirect responses when the "Request" interception stage was enabled. Since they technically are responses, we will now report them only when the "HeadersReceived" stage is enabled. Change-Id: I5318f8b4167b662d11852b8d93bff4b9db960c8d Reviewed-on: https://chromium-review.googlesource.com/1147507Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#577366}
-
Min Chen authored
- Make fullscreened window can be dragged from the top of the display. - Keep shelf visible if a window is being dragged from the top of the display. - Fling the window from the top exceed the velocity threshold should drop the window into overview mode. - Update the window transform during drag. See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiSnFza0t3bEluUnJ0VVBhUzFiSnNwN0k4eFpv/view?usp=sharing Bug: 847587 Change-Id: I7f9a423f511c65c083fe11a6deb5847afa4c9a35 Reviewed-on: https://chromium-review.googlesource.com/1134575Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577365}
-
Eric Karl authored
Currently, we never check for deleted entries until the client tries to lock an entry. In some cases (transfer cache), the client may never delete or re-lock an entry after creating it, relying on the service side to purge it. In these cases the client should eventually pick up these deletions allowing handles to be re-used. To handle this, we check for deleted entries any time we are about to allocate a new buffer. R=khushalsagar Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib4edbf7e339f213cff7a7df85771ecfeb5113936 Reviewed-on: https://chromium-review.googlesource.com/1147495 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577364}
-
Takumi Fujimoto authored
Replace help center URLs with p-links. There is no change in the actual destination pages. Bug: 852139 Change-Id: I85176c6c2076d331ae58e10f7150ccf9c42da03e Reviewed-on: https://chromium-review.googlesource.com/1147216Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#577363}
-
Eric Orth authored
This reverts commit e5a94e05. Original commit fac52799. Patchset 1 is a clean revert of the revert. Fixes in subsequent patchsets. Only change is fixing some work that was done inside a DCHECK in the tests. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic1649dc90711c23c33255cc5f1ed9d902eb29f07 Reviewed-on: https://chromium-review.googlesource.com/1147140Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#577362}
-
Kyle Horimoto authored
Previously, a log was only printed when the call to set/remove the host failed, but it was hard to tell if/when the call actually succeeded. This CL adds a log for this case. Bug: 824568 Change-Id: I1328460f141faea4f69bb11243403c04d02c86fd Reviewed-on: https://chromium-review.googlesource.com/1145832Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577361}
-
Oriol Brufau authored
Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch replaces all the uses in /ui/webeui Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: I9c77c4374bef006fa518eba96f10db8e9bc9c2eb Reviewed-on: https://chromium-review.googlesource.com/1146930Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#577360}
-
Wei-Yin Chen (陳威尹) authored
FontListTest::Fonts_GetHeight_GetBaseline is still disabled because I couldn't find two fonts with different baseline and different height on Android. This depends on crrev.com/c/1142484 for non-ARM build. Bug: 853281, 489354, 642010 Change-Id: Iacf6124794ee53f5f9e30f59bdd958f3883c7ea2 Reviewed-on: https://chromium-review.googlesource.com/1141175 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577359}
-
Tien-Ren Chen authored
Previously replaced elements only create clip node if a border radius is applied. This CL makes them to also create clip node if the replaced contents may overflow due to object-fit. Also previously the clip was created as InnerBorderRadius node, which is not quite right because replaced elements uses content box instead of padding box to clip. This CL makes it to use OverflowClip node instead. As a side effect, embedded <svg> elements are now also clipped to the content box. This matches the Firefox behavior. BUG=730284 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie91069c11f8e4fc09d09a4a9fa940def6d2ad35f Reviewed-on: https://chromium-review.googlesource.com/1142571 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577358}
-
Chris Mumford authored
The download manager was using the NetworkDownloadURLLoaderFactoryGetter for the filesystem scheme which uses a WrapperSharedURLLoaderFactory for resource requests. This change adds a FileSystemDownloadURLLoaderFactoryGetter for the filesystem scheme. Bug: 849059 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia299ad88bac0ff0fa7ae79190e82c5e946d7b053 Reviewed-on: https://chromium-review.googlesource.com/1127148 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#577357}
-
Ned Nguyen authored
The reason is that logic was never activated, so getting rid of it for simplification. Later CLs will add the retry logic from clean state. Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Iad93ad54c0c5f30c8a207c9b703b10a562f9f04f BUG: chromium:864565 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Iad93ad54c0c5f30c8a207c9b703b10a562f9f04f Reviewed-on: https://chromium-review.googlesource.com/1146145 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577356}
-
Amos Lim authored
'OrphanedFormatString' was only removed in ERRORPRONE_WARNINGS_TO_TURN_OFF. It should be added to ERRORPRONE_WARNINGS_TO_ERROR. It is a follow-up to https://crrev.com/c/1134828. Bug: 834796 Change-Id: I801d2514ec40c22ee48fdb44a0f6975ff892d8d8 Reviewed-on: https://chromium-review.googlesource.com/1144990Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#577355}
-
Jonathan Metzman authored
Change-Id: I5553b7df35bbed19fe8c99645db5265aee67d776 Reviewed-on: https://chromium-review.googlesource.com/1147609 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#577354}
-
chrome://accessibilityJames Wallace-Lee authored
Saves the option to show the internal accessibility tree as the preference kShowInternalAccessibilityTree. Change-Id: Ib16c93f982da3e3cae1728fb8cdb0747a7463549 Reviewed-on: https://chromium-review.googlesource.com/1144271 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577353}
-
Alexei Filippov authored
The class provides support for module lookups for memory addresses. BUG=803276 TBR=dcheng@chromium.org Change-Id: Iaae0d70c6e7091ced6276e321321b74a6496255a Reviewed-on: https://chromium-review.googlesource.com/1132545 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577352}
-
W. James MacLean authored
Now that we know this pathway is involved in the incorrect setting of page scale factors for OOPIFs, convert this CHECK to a DCHECK. Bug: 859428 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d8805056546cc6ada3525e57d307dbcb27e6f55 Reviewed-on: https://chromium-review.googlesource.com/1146329Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#577351}
-
Peter Wen authored
http://b/111756850 Bug: None Change-Id: I7b7038eceb5872970598fcffd3f86c8b661a2140 Reviewed-on: https://chromium-review.googlesource.com/1147496 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577350}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie6de2e359cbe2067f7304e3dfd0fe65cfe390bf7 Reviewed-on: https://chromium-review.googlesource.com/1147666Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#577349}
-
Ryan Hamilton authored
Use a std::unique_ptr<ProofVerifyContext> instead of a raw pointer in the QuicCryptoClientStream constructor. Merge internal change: 203836768 Change-Id: I80e3cefd998af739fd4baa0a6df79034da407613 Reviewed-on: https://chromium-review.googlesource.com/1147492Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577348}
-
- 23 Jul, 2018 3 commits
-
-
Zhiheng Vincent Li authored
Bug: b/111566470 Test: tested on Android Things device Change-Id: I17f09973a3ac9ed5498efb6f21ffc6f87e6c878a Reviewed-on: https://chromium-review.googlesource.com/1142896 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#577347}
-
proberge authored
A spinner previously replaced the icon while scanning or cleaning was in progress. Since the icon is removed, the spinner is now positioned to the right of the text, replacing the action button while scanning or cleaning is in progress. Bug: 803683 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2272ae8280d464c252cb10c00d77bbee35983a03 Reviewed-on: https://chromium-review.googlesource.com/1133318 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577346}
-
Trent Apted authored
Brackets have the "common script" unicode property and need special handling when breaking runs (see http://www.unicode.org/reports/tr24/#Common ). Currently, emoji breaks runs correctly around other bracket and quote mark types, but not around 「」, which is commonly used in CJK languages. Bug: 843426, 396776 Change-Id: Ia5ff5165d5c260aa1876488e2f51d566f2164cd6 Reviewed-on: https://chromium-review.googlesource.com/1146401Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#577345}
-