- 12 Nov, 2019 40 commits
-
-
Toby Huang authored
Currently, ParentAccessServiceTest uses LoginPolicyTestBase to log in as child user for tests. We should deprecate LoginPolicyTestBase in favor of LoggedInUserMixin instead. This CL converts ParentAccessServiceTest to replace LoginPolicyTestBase with LoggedInUserMixin for logging in as child user for tests. Bug: 1014663 Change-Id: I66f8c308e87efd49945ac322d969d162104ff130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909273Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714592}
-
Sigurdur Asgeirsson authored
This CL implements mojo::internal::MessageQuotaChecker, that allows unread message quota checking to be performed at send-time in IPC::ChannelProxy. This in turn allows generating crash dumps with the abusive producer on the call stack, red handed. Bug: 1017827 Change-Id: Ib0a7f5cde2c9df00c89bb79834c1cffa211fa6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899909Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714591}
-
John Rosasco authored
A pending change to skia will delineate GL-only sources from multi-GPU interface source lists in the build configuration. This change serializes the integration of that change between the two repos. Change-Id: I12bdc14228fbc9bd56214301fa7ab02eff5b2efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910870 Commit-Queue: John Rosasco <rosasco@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#714590}
-
Mikhail Khokhlov authored
This CL restores the accidentally deleted fix for repeated --output-format arguments. Bug: 1023796 Change-Id: I247332772af7feb308d00564766b0ca898904cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911790 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#714589}
-
Sharon Yang authored
This change adds functionality to the Accessibility Bridge: * Listens for change in AccessibilityMode from Fuchsia * Gets the semantic tree from Chrome accessibility and sends it to the SemanticsManager * Sends live updates when nodes are added, updated or removed To send updates, this change includes the following: * Creates a ViewRefPair and registers it with the SemanticsManager * Initialize an AccessibilityBridge * Listen for changes in the Chrome Accessibility tree, serializes them to Fuchsia data structures and sends that data to the Fuchsia SemanticsManager Testing: Added AccessibilityBridge browsertests. Bug: 973095 Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714588}
-
Lan Wei authored
When we calculate the element's central location, we need to consider about the overflow case that the element's view area is less than its actually area. For the drop down menu bar, the drop down menu list's parent is the menu bar, which does not have any overlap with the menu item, so we should consider about the parent's boundary when there is no overlap between the element's area and the parent's area. Bug: chromedriver:3205 Change-Id: I39c8292dc730cf23a562ed206ddaccb09a5b36c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908057 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714587}
-
Demetrios Papadopoulos authored
Specifically enable: - clang-format for JS files - Various HTML/CSS/JS checks including ESLint checks. - SVG optimization checks Fixed: 1019312 Change-Id: I01628b5faae9ff95dc5eebefec2a0c4956ed3664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888151 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714586}
-
James MacLean authored
This reverts commit b00bf5ee. Reason for revert: Suspected breaking sync_integration_tests See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/68007 Original change's description: > Roll Fuchsia SDK from 889702604369 to 889700747367 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: I7b689b5ced7d35d672ee08974888f6af810f5554 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910790 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#714470} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I4bd7f9372e94b387bc29181f13604d84eef2cae4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912658Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714585}
-
Mikel Astiz authored
Follow up to the recent https://chromium-review.googlesource.com/c/chromium/src/+/1899374 where one caller (extensions) was fixed and the DCHECK introduced. Since there are many direct or indirect callers to BookmarkModel::Remove() and is difficult to audit them all, this patch upgrades the DCHECK into a CHECK to enforce the precondition. Bug: 1021829 Change-Id: I6590650059ddf94b054ad0b6d22224f0ec531654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911212 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
minch authored
Minimize the browser window or ChromeOS app window if it is at the bottom of back stack. This should work for swiping from left edge of the display, shelf/keyboard back button. And it works only while in tablet mode. See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiN1BFbnNfSGNLaUZzcDcxR2hwZnotV0V4cWk4/view?usp=sharing Bug: 972708, 1002733 Change-Id: I9ec7f048e0fc5c01caf48abf1785e81f153bcf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900093Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
sczs authored
-Creates Strings to be used on the SaveCard Infobar Modal. -Uses these newly created String along others from the saveCardDelegate in order to configure the SaveCardModal. Screenshot: https://drive.google.com/open?id=1V0lJN1hd2aHVprN4K-HPQavA3Dmr27kz Bug: 1014652 Change-Id: I8dfe51d4b06c58966e9946ab365e686a22ae72fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911384Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714582}
-
Josh Nohle authored
Bug: 951969 Change-Id: Id12f9a7513aa73608b4b4586cd233cf5967fbb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831010Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#714581}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bd261c7..a9e0cc38 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I399baa14f3bab714df1e9f5caa8f6917bd097873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911247Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714580}
-
Dominique Fauteux-Chapleau authored
Turns out if was a race condition that logged [FATAL:data_decoder.cc(157)] data_decoder::ServiceProvider::Set() must be called before any instances of DataDecoder can be used. during flakes. Waiting after starting the ExtensionUpdater seems to fix the issue. TBR=rdevlin.cronin@chromium.org Bug: 1023391 Change-Id: Ifc3be2014b7b729ca5a3e091eac1fb2195129bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910285 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by: -
Takumi Fujimoto authored
Record in the MediaRouter.Icon.Click.Location histogram whenever the Cast dialog is opened via the "Cast..." item in the three-dots app menu. Bug: 870032 Change-Id: I11fe3addaab40c1299bdc08dd0991fb3cb58f3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906769 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714578}
-
Maksym Onufriienko authored
List of disabled tests: [PasswordsSettingsTestCase testBlacklistedFormDeletionInDetailView] [PasswordsSettingsTestCase testCancelDeletionInDetailView] [PasswordsSettingsTestCase testDuplicatedSavedFormDeletionInDetailView] [PasswordsSettingsTestCase testExportFlow] [PasswordsSettingsTestCase testSavedFormDeletionInDetailView] Test:https://cr-buildbucket.appspot.com/build/8897021784996062192 Bug:1023619 Change-Id: Ie96bc780e5a8b4a7b828095b032843e3ebaa0576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909280Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#714577}
-
Andreas Haas authored
The internal representation of the size field in the DOMArrayBuffer is already size_t, now we change the constructors to show that as well. R=haraken@chromium.org Bug: 1008840 Change-Id: I35fe71d0b3503244329e527f0df994812bc91387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911782 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714576}
-
David Jacobo authored
This CL regroups HandleCameraResult out of the override block. Also including map due to IWYU. Bug: None Test: Build. Change-Id: I60f3e4b7b9c5e802c41edd221b1b0e6675bf8e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910769 Commit-Queue: David Jacobo <djacobo@chromium.org> Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714575}
-
James MacLean authored
This reverts commit ac0e2c90. Reason for revert: New test is flakey, see https://bugs.chromium.org/p/chromium/issues/detail?id=1023698 Original change's description: > Add RenderTests in StartSurfaceLayoutTest for native tab > > Add one more RenderTest for native tab. Choose NTP in incognito mode > for its consistency. > > Also fix the issue about thumbnails being not freed in > http://crrev.com/c/1903402. > > Bug: 983170 > Change-Id: I68d3f08184cb4b9504935a53f893bb7ea9473ba6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903620 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713961} TBR=wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983170 Change-Id: Iee4a534ad7782848e391953aff168dbbb4aff563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911605Reviewed-by:
-
Cathy Li authored
[Explore Sites]: Extend expiry of explore sites flag and navBackTime histogram to accommodate new launch schedule. Change-Id: I4cbb9bd394cbd6c0f5a349c6c6a0ee63c9cef60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906878Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Qingsi Wang authored
The policy is merged to M79 and the version is updated accordingly. Bug: 1012945 Change-Id: Ib17c819a342acd8b885e95e4134a84ac1b4e6a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904233Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714572}
-
Connie Wan authored
Fixed two issues noticed while working on Tab Groups: 1) The first tab does not have a leading separator even when a group header is to its left. It should have a separator in this case. 2) The last tab in a selection has a trailing separator if it's A) the last visible tab and B) not the active tab. It shouldn't have a separator in this case. This fix produces the correct results for #1 and #2 while still respecting the fade in/out of the separators on hover. I was not able to find any existing unit tests for the separator. I looked into writing one, but the separators are just painted on using canvas->DrawRect(). Let me know if a screencast would help, or I can demonstrate the change locally. Bug: 1022100 Change-Id: Id5ad6c7e03ee00292a63b8f2350ceb84e448c05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899887 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714571}
-
Sophie Chang authored
Bug: 1001194 Change-Id: Iae8a3fbf9d0e65c543deee41849c2a22db0547cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906880 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#714570}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a9c64739fb43..d565d557945e Created with: gclient setdep -r src-internal@d565d557945e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibf0aed3641d108989d87d3c7c0829819a495ec75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912280Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714569}
-
Elly Fong-Jones authored
As of the 10.15 SDK IMP has changed from: id (*IMP)(id receiver, SEL selector, ...); to: void (*IMP)(void); thus requiring a cast to call it. Rather than having this cast at every place that invokes an IMP, this change adds a new method to ScopedObjCClassSwizzler to allow invoking the original method from the swizzler, which accounts for every invocation of IMP in the tree. TBR=avi@chromium.org Bug: 973128 Change-Id: I13eab9a79bab23e9a2c3854fb95e42de61e04d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906334Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714568}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: I591df9b3e68aced4de83d675df36c0553ec31c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906643 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714567}
-
Steven Bennetts authored
ChromeBrowserMainParts::PreMainMessageLoopRunImpl() may return early with chrome::RESULT_CODE_NORMAL_EXIT_PROCESS_NOTIFIED in browser tests. This prevents PreProfileInit() and other stages from getting called, but PostMainMessageLoopRun() is still called, so the code needs to be careful about shutting down singletons initialized in PostMainMessageLoopRun() stages. Bug: 702403 Change-Id: Icfc7dd93da6f78a3ccaf4e207c720fe2073fc1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893376 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
arthursonzogni authored
Generated using: ~~ directories="content chrome components" regex="DisableForRenderFrameHost(\(([^\(\)]++|(?1))*\))" label=$(grep -Pzoh $regex -r $directories \ | tr -d '\000' \ | grep -Po '\"[^"]+"' \ | tr -d '"' \ | sort -u ) echo "<enum name=\"BackForwardCacheDisabledForRenderFrameHostReason\">" for i in $label do hash=$(echo -n $i | md5sum | tr -d ' -') hash=${hash^^} hash=$(echo $hash | head -c 16) hash=$(echo "ibase=16; $hash" | bc) hash=$(echo "($hash + (2^31)) % (2^32) - 2^31" | bc) echo " <int value=\"$hash\" label=\"$i\"/>" done echo "</enum>" ~~ Bug: 1001087 Change-Id: Id2f11f608f7ef8341fb22c3befa56b9d5a28d6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910234 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714565}
-
meacer authored
Bug: 991726 Change-Id: I5bdea1502d1b401dcbe79c0405f8745c226b36ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911281 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714564}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/83304c4e5287..fa04e15e1ad6 $ git log 83304c4e5..fa04e15e1 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 hans Call update.py --package=objdump instead of download_objdump.py Created with: roll-dep src/third_party/ffmpeg This also points ffmpeg correctly at the master branch rather than sushi branch. TBR=tmathmeyer Change-Id: I3ca918bcb38fd40784ed97ed8d14826e5656da6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910763Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#714563}
-
Wei-Yin Chen (陳威尹) authored
When a new tab is created for loading a non-NTP page, skip waiting for NTP loading. This decreases the chance of timeout waiting for NTP loading on slower devices. Bug: 983170 Change-Id: Ibf73a0664865aba2d10b77d12c4cccfef96ed615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911639Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714562}
-
Elly Fong-Jones authored
Bug: None Change-Id: I17ed1cdbd53033429dc4b045c4225e55f838e775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912459 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714561}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/051cae5d11be..2bd2d85f65e8 git log 051cae5d11be..2bd2d85f65e8 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 38612283..3b0967fe (714324:714463) 2019-11-12 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-12 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." Created with: gclient setdep -r src/third_party/webrtc@2bd2d85f65e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I9bcbf7d1022da9060167d96df3700eef37d54049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714560}
-
Jiajun Ou authored
Change-Id: Ie11119d9c018812a17ced065be764547e1dbebef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911919 Auto-Submit: Jiajun Ou <garzonou@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#714559}
-
Thoren Paulson authored
Without it, the manifest merger assumes we're using a library that targets SDK version 1 and adds some permissions we don't need. Bug: None Test: check manifest from CastShellInternal.apk Change-Id: I98b4597a21e94e5c2d920943df4fd26bf97a556c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909641Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Auto-Submit: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#714558}
-
Avery Musbach authored
BEFORE: SplitViewController::SnapWindow bails out if called during the divider snap animation. Callers check for the divider snap animation before calling SplitViewController::SnapWindow, because correct behavior is never achieved just by allowing SplitViewController::SnapWindow to silently fail. AFTER: SplitViewController::SnapWindow has a DCHECK that fails during the divider snap animation. FYI: It behooves me to discuss why snapping a window during the divider snap animation is problematic in the first place. See [1] for my commentary about what can happen if the window becomes snapped and the divider continues to animate. Another idea would be to interrupt the divider snap animation, but that proposition is not as simple as it may sound, because if the divider is animating to an edge of the work area, then split view mode will end. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1480869/1/ash/wm/splitview/split_view_controller.cc Bug: None Change-Id: Ie457e53448ffe440c738f171e4c4b0d0affcf76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911704Reviewed-by:
-
Mike Dougherty authored
These test cases can be moved to unittests. Additionally, EG coverage already exists for AlertCoordinator (which is used by DialogPresenter) from the JavaScriptDialogTestCase tests. Bug: 754642, 987646 Change-Id: I5e6d9c37f0603bf72bdf854d048381519b920aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907203Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad21d47cfa8d..7cb52cb5e67c git log ad21d47cfa8d..7cb52cb5e67c --date=short --no-merges --format='%ad %ae %s' 2019-11-12 senorblanco@chromium.org Dawn: implement dynamic primitive processor texture handling. 2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 31edef751a8d..9da287fd0264 (6 commits) 2019-11-12 jvanverth@google.com Detect whether trying to blit a Metal swapchain texture, and fail if so. 2019-11-12 senorblanco@chromium.org Dawn: fix bug in stencil handling. 2019-11-12 nigeltao@google.com Free SkWuffsCodec frame-count decoder earlier 2019-11-12 bungeman@google.com Track and force opsz axis on Mac. 2019-11-12 herb@google.com Make metrics const on SkStrike 2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 012d15196023..e33c1582b4bc (6 commits) 2019-11-12 herb@google.com WS: SkStrike Created with: gclient setdep -r src/third_party/skia@7cb52cb5e67c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None,chromium:None Change-Id: Iefe95942b57a99d293d1bbc2c4e32211660ce9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911664Reviewed-by:
-
Anastasia Helfinstein authored
Bug: 995052 Change-Id: If782994602e0b1b9d7b723be9417549b0eda125e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902234Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Callum May authored
The analysis and stack trace are in the filed bug. Bug: 1022630 Change-Id: I58523a59f87e6b0fc9c642133f9c8e70427cea2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907268Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Callum May <camay@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714553}
-
