GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/c56c2429b0f6..24b373394918


git log c56c2429b0f6..24b373394918 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 lalitm@google.com trace_processor: fix BestIndex/Filter calls when using OR constraints


Created with:
  gclient setdep -r src/third_party/perfetto@24b373394918

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:80416541
TBR=perfetto-bugs@google.com

Change-Id: I7995b1ad8f88de53e2b5ba13224db5378ef01eb0
Reviewed-on: https://chromium-review.googlesource.com/1124648
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572267}

This reverts commit 3c6537d8.

Reason for revert: block other CL from landing with PRESUBMIT error:

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942003279127111280%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout

** Presubmit ERRORS **
Pylint (261 files using ['--disable=cyclic-import'] on 8 cores) (8.11s) failed
************* Module contrib.orderfile.orderfile
E:109,20: story_class is not callable (not-callable)
W:113,19: Access to a protected member _IterAllSystemHealthStoryClasses of a client class (protected-access)
R:144, 0: Too many ancestors (8/7) (too-many-ancestors)
R:155, 0: Too many ancestors (8/7) (too-many-ancestors)
R:189, 0: Too many ancestors (8/7) (too-many-ancestors)
R:194, 0: Too many ancestors (8/7) (too-many-ancestors)
R:200, 0: Too many ancestors (8/7) (too-many-ancestors)
R:206, 0: Too many ancestors (8/7) (too-many-ancestors)
R:212, 0: Too many ancestors (8/7) (too-many-ancestors)
R:218, 0: Too many ancestors (8/7) (too-many-ancestors)
Presubmit checks took 15.4s to calculate.

Original change's description:
> Orderfile: training and testing benchmarks.
> 
> These benchmarks will be used to train the new production android orderfile.
> 
> Bug: 843561
> Change-Id: Iea097d784773c98ec3076f297aac16558c2a8104
> Reviewed-on: https://chromium-review.googlesource.com/1124561
> Reviewed-by: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572219}

TBR=pasko@chromium.org,lizeb@chromium.org,mattcary@chromium.org

Change-Id: I0f22ff64f7532aaa913bb4dbd844be6cfdb7b5ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843561
Reviewed-on: https://chromium-review.googlesource.com/1124702Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#572266}

The test was flaky because of the rounding errors.

BUG=856955

Change-Id: I089ff4efa05935433c6f1cd3a89f8cbad26879d5
Reviewed-on: https://chromium-review.googlesource.com/1123768Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572265}

Bug:855063
NOTRY=true
TBR=nednguyen@google.com

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ica527284a240bf2251e2a57c26729c541577aa44
Reviewed-on: https://chromium-review.googlesource.com/1124943Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572264}

This patch implements snapping for gesture fling on main thread.
The ScrollManager would implement SnapFlingClient to collect snap
information, schedule animation, and execute the scroll as instructed
by SnapFlingController.

This patch also updates the interface of
SnapCoordinator::GetPositionForPoint() for it to return an Optional
FloatPoint, clearly indicating whether there exists a snap point for
the current scroll.

Bug: 778259
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I196e8c58c238cfad2a96e3f6a1c218f2c4f77a3c
Reviewed-on: https://chromium-review.googlesource.com/1083144Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572263}

Implement sync_file export for fences so we can submit fences with planes
to DRM atomic.

This does not work unless you have a fairly recent kernel (requires
syncobj support, I915_EXEC_FENCE_ARRAY).

Bug: 851997
Test: ozone_demo on eve with USE=vulkan and kernel 4.14

Change-Id: I5859b64690e9b45ccb95698a9ca096f0847ec51b
Reviewed-on: https://chromium-review.googlesource.com/1115570Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572262}

SingleTreeTracker currently implements CTVerifier::Observer
and STHObserver, exposing OnSCTVerified and OnSTHObserved.
However, it's not accessed through either interface - the
only interaction with these methods is through the
TreeStateTracker, which dispatches calls via a direct
pointer to the SingleTreeTracker. Remove the inheritence
to make it easier to track the concrete interface
implementations.

BUG=none

Change-Id: I372c803984a8c808914e254e69ec6527c6ec772b
Reviewed-on: https://chromium-review.googlesource.com/1123921Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572261}

https://pdfium.googlesource.com/pdfium.git/+log/1448cc11b9be..d77e0ed72f73


git log 1448cc11b9be..d77e0ed72f73 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 tsepez@chromium.org Use more UnownedPtr<> in cfxa_ffpageview
2018-07-03 tsepez@chromium.org Remove XFA_LAYOUT_INVALIDNODE


Created with:
  gclient setdep -r src/third_party/pdfium@d77e0ed72f73

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia1596111eb427a42364528bd3b4dcb6ce1d4e28f
Reviewed-on: https://chromium-review.googlesource.com/1124647Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572260}

This CHECK was added to diagnose the leaks covered by
https://crbug.com/813045 which are now well understood.
No longer needed.

TBR=jam@chromium.org

Bug: 826432,813045
Change-Id: I691f4c9a4c4cd9bc5b8823cfae2d9c8bc3cfeabe
Reviewed-on: https://chromium-review.googlesource.com/1124663Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572259}

This reverts commit d4fc9d34.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Remove LayoutTab#mInsetBorderVertical and related logic
> 
> TabLayer::SetProperties() currently has a param, inset_border, that changes the
> geometry logic for showing tabs in the tab switcher. Currently, we're always
> setting the param to true. We then use it to set another variable:
> 
> const bool inset_toolbar = !inset_border;
> 
> which is always false. This is immediately followed by this check, which always
> passes:
> 
> if (!inset_toolbar) {...}
> 
> 
> In addition to being unnecessary, this param is also extremely
> confusing/misleading. We do actually start out with the toolbar inset on top of
> the tab thumbnail (before we fade it into the tab title), and we only inset the
> top and bottom borders, not the ones on the left and right.
> 
> This CL removes this unnecessary logic.
> 
> Bug: 849401
> Change-Id: I5ccfa35f766baf477837be1d886a2974d0009a54
> Reviewed-on: https://chromium-review.googlesource.com/1114330
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Ryan Landay <rlanday@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570971}

TBR=dtrainor@chromium.org,rlanday@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 849401
Change-Id: I124cce58f105b75164acc05ce6b6cb6831db8a91
Reviewed-on: https://chromium-review.googlesource.com/1124820Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572258}

Updated spec says IDL for requestPictureInPicture and
exitPictureInPicture should specify that a new object is returned.

https://github.com/WICG/picture-in-picture/pull/76

Bug: 806249
Change-Id: Iba50455ef30c97d87c3e22b9ac95bc4bc41d546d
Reviewed-on: https://chromium-review.googlesource.com/1122226Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#572257}

We don't have to SendCachedPairedDevices() whenever the adapter is up.
Android knows how to get all paired devices from adapter properties.
SendCachedPairedDevices() will create bogus pair state change to
Android.

Bug: 78593133
Test: Reboot and confirm that paired devices are still there
Change-Id: Ibcb29f3f3abb3ea30c5e9cdd1d13c72e119a1085
Reviewed-on: https://chromium-review.googlesource.com/1120695Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#572256}

In the past, there was a bug where some themes incorrectly got synced
into the EXTENSIONS data type, so we added cleanup code to remove the
bad data. That was long ago and all bad data should be long gone now,
so let's get rid of the cleanup code.

Bug: none
Change-Id: I53fcc8ecb208e9fce6565cda70ec57cc960f9b6c
Reviewed-on: https://chromium-review.googlesource.com/1124680Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572255}

Add a default member initialization for client_pin_availability_
to prevent use of un-initialized memory (found by MSan).

Bug: 859816
Change-Id: I5ab81ee60a6aed657f44a8bee7d094dc14f030b9
Reviewed-on: https://chromium-review.googlesource.com/1123828Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572254}

Change-Id: I956ea3523eb42b6d7f0cf851a126c6a11578912e
Reviewed-on: https://chromium-review.googlesource.com/1121378
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572253}

Makes several changes to VR tests related to the VR controller:

1. Switches VrShellWebInputEditingTest to use the Chrome-side controller
   input mocking rather than VrCore controller emulation since the
   latter was slightly flaky.
2. Adds a null check to VrShellWebInputEditingTest to prevent a rare
   flake.
3. Remove @Manual from all VrShellDialogTest cases. These are mainly
   intended for screen diff tests, but do have some value as functional
   tests.
4. Fix hitting a DCHECK when using Chrome-side input mocking that was
   caused by some recent controller changes.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic3ccda408f7f531e1b8a78a46bae55858f46dc82
Reviewed-on: https://chromium-review.googlesource.com/1123400Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572252}

https://chromium.googlesource.com/catapult.git/+log/c61a0380486a..9f46241c6c03


git log c61a0380486a..9f46241c6c03 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 nednguyen@google.com Add documentation_link diagnostic


Created with:
  gclient setdep -r src/third_party/catapult@9f46241c6c03

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:859524
TBR=sullivan@chromium.org

Change-Id: I9f01f6305f67c46c9bb9723ef4b43eb1cd30a67b
Reviewed-on: https://chromium-review.googlesource.com/1124644Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572251}

Bug: 859685
Change-Id: Ibba0f9e17d04e6385b995ed28bf0536507d209e3
Reviewed-on: https://chromium-review.googlesource.com/1124676Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572250}

Bug: 843161
Change-Id: I705cf2ee2665ebd8245ccafb5e157d2039cf86f5
Reviewed-on: https://chromium-review.googlesource.com/1122410Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572249}

R=tandrii@chromium.org

No-Try: true
No-Tree-Checks: true
Bug: 836232
Change-Id: I9fc2feb8dc92d76411126449615578605419c248
Reviewed-on: https://chromium-review.googlesource.com/1124468Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572248}

https://chromium.googlesource.com/angle/angle.git/+log/92da844eb754..2b06054dd41f


git log 92da844eb754..2b06054dd41f --date=short --no-merges --format='%ad %ae %s'
2018-07-03 jie.a.chen@intel.com Vulkan: Insert a barrier after buffer copy


Created with:
  gclient setdep -r src/third_party/angle@2b06054dd41f

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I6eec1539882837dc7e761518f6108f74506b7303
Reviewed-on: https://chromium-review.googlesource.com/1124642Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572247}

PasswordManager::OnPasswordFormSubmittedNoChecks

The OnSameDocumentNavigation forwards to OnPasswordFormSubmittedNoChecks
and because the former is the only caller of the latter
remove OnSameDocumentNavigation and replace it with
OnPasswordFormSubmittedNoChecks.

R=jdoerrie@chromium.org

Bug: 795462
Change-Id: I2097b748c630559d5922288e2d0832c8b819de83
Reviewed-on: https://chromium-review.googlesource.com/1124472
Commit-Queue: Narcis Gemene <gemene@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572246}

These are not supposed to be widely used per the style guide, and aren't
necessary where we're using them. Also const&& makes no sense.

Bug: none
Test: compile
Change-Id: Id16a193d6dfbeee109a1bd6ade61800afbe07574
Reviewed-on: https://chromium-review.googlesource.com/1118976
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572245}

This CL makes 'signal' member in LockOption non nullable
to be spec conformant. [1]
It also drops a test that is inconsistent with this change.

[1] https://inexorabletash.github.io/web-locks/#idl-index


Bug: 855968
Change-Id: I4faf6582451347a05eeca34f02e25a43217d86cd
Reviewed-on: https://chromium-review.googlesource.com/1121953
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572244}

The histograms are being recorded in code that isn't used when the
network service is enabled. It was decided that these histograms see
little enough use that it was better to remove them, rather than make
them work with the network service.

In particular, the histograms are:
Net.Prefetch.TimeSpentPrefetchingFromCache
Net.Prefetch.TimeSpentPrefetchingFromNetwork
Net.Prefetch.TimeBeforeCancel
Net.LoadPrefetch.Pattern
Net.Prefetch.Pattern
Net.Prefetch.TimeSpentOnPrefetchHit

Bug: 859535
Change-Id: Idc85a43ce4a7b2c959c419401c422d17b07e35d3
Reviewed-on: https://chromium-review.googlesource.com/1122703
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572243}

DocumentState is now created in content and passed all the way down to
FrameLoader::CommitNavigation to be put directly into the DocumentLoader.
In DidCreateDocumentLoader we now only create the DocumentState for
cases where the content layer was never yet aware, such as
DocumentLoader from a frame init and Renderer initiated navigations.

A future patch is on its way to remove PendingNavigationParams and build
DocumentState directly from parameters.

Bug: 789577
Change-Id: Iffe7804784b13afc7f9d708828039d723b36ebbf
Reviewed-on: https://chromium-review.googlesource.com/1105985Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572242}

Bug: 850128
Change-Id: Ifc009ffebaddac9037b7e72175ba571f980ff83a
Reviewed-on: https://chromium-review.googlesource.com/1124759
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572241}

The IPH_BottomToolbarTip feature was added in crrev.com/c/1076131 but
the UMA tracking for this feature wasn't added. This CL adds the right
constants.

Bug: 830635
Change-Id: I4d1b94cdcd1b1b851996fa66ae1bb712e157e4fc
Reviewed-on: https://chromium-review.googlesource.com/1122225Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572240}

This CL adds a histogram to record EQT on renderer processes that do not
host main frames:
RendererScheduler.ExpectedTaskQueueingDurationWithoutMainFrame

While at it, fix a typo introduced in 5ec20588 in histograms.xml.

Bug: 829796
Change-Id: I05b3ce7a7cd3eb5432ce4f54eb54bf7100816b97
Reviewed-on: https://chromium-review.googlesource.com/1120778Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572239}

This is a preparation CL to move AutofillDownloadManager from URLFetcher
to SimpleURLLoader et al. Specifically, it moves some autofill tests away
from using base::Clock, for testing whether a autofill query request is
properly cached/fetched. Still, both CACHE_HIT and CACHE_MISS functionalities
are exercised.

Basically, instead of setting the base::Clock instance with manually configured
valid and expired dates, the following was changed:

- the original test (AutofillQueryTest.CacheableResponse) was spun off into
another test: AutofillQueryTest.ExpiredCacheInResponse.

- The former sets a Cache-Control max-age value to some time in the future
(100 seconds), so that its cached content is valid/reached.

- The later sets a Cache-Control max-age value to 0, and delay execution in
a few milliseconds to ensure the cache content is already expired, and never
hit.

BUG=837830,844929

Change-Id: Ib82ca230fb0169b9e6847d90019574eb571e4c97
Reviewed-on: https://chromium-review.googlesource.com/1122456Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572238}

Change-Id: I7bb88a19e280140a2a8126f1199aa4321fdf56ef
Reviewed-on: https://chromium-review.googlesource.com/1102425
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572237}

Tab Page

In MacViews mode, the 'Always Show Bookmarks' menu item is always checked
regardless of whether the bookmark bar is detached or attached. In Cocoa
mode, this was not an issue because the visibility state is determined by the
bookmark preference value for 'kShowBookmarkBar', which stores whether the
'Always Show Bookmarks' option is checked. In MacViews mode, the visibility
state always returns 'true' because it calls IsBookmarkBarVisible() instead,
which is 'true' if the bookmark bar is in a detached state (on New Tab Page).

Add contact info to AUTHORS


Update 'Always Show Bookmarks' checkmark visibility when toggled on New Tab Page

R=bsep@chromium.org, sky@chromium.org

Bug: 854962
Change-Id: I19f3741cd720474642d0661192f92f4517da075c
Reviewed-on: https://chromium-review.googlesource.com/1123890
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572236}

- Changes the disclore headerFooter subtitle label CompressionResistancePriority to prevent it
being compressed when refreshing the Cell.
- Deletes some un-needed constraints that weren't playing nicely with the TableView dynamic sizing,
causing broken constraints.

Bug: 851929
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifd641c1d7c227592d4767d9af1874dfcb3e556ca
Reviewed-on: https://chromium-review.googlesource.com/1123335Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572235}

There is only one implementation so there doesn't need to be a virtual
base class. Also remove some unused functions.

Bug: 832243
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I581d47639448efa4a0812f604808a03587269320
Reviewed-on: https://chromium-review.googlesource.com/1119122
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572234}

Bug: 843161
Change-Id: Ibaa9c303a72f20af52290471b88a7da071e231e3
Reviewed-on: https://chromium-review.googlesource.com/1120528Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572233}

The test assumed no cache named 'foo' existed, but another test
cache-keys-attributes-for-service-worker creates a cache by that name,
so the test would flakily fail in some runs depending on the ordering
of the tests.

Make the test defensive by deleting such a cache before proceeding.

Bug: 840850
Change-Id: Ia349706c9a32af309cfadf9a63ba5cffea11998d
Reviewed-on: https://chromium-review.googlesource.com/1119104
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572232}

https://pdfium.googlesource.com/pdfium.git/+log/65f38c8fae09..1448cc11b9be


git log 65f38c8fae09..1448cc11b9be --date=short --no-merges --format='%ad %ae %s'
2018-07-03 vmiklos@collabora.co.uk Add FPDFText_GetTextRenderMode() API
2018-07-03 thestig@chromium.org Use GetPos() and SetPos() in CPDF_SyntaxParser::ReadStream().
2018-07-03 thestig@chromium.org Fix indentation in CPDF_SyntaxParser.


Created with:
  gclient setdep -r src/third_party/pdfium@1448cc11b9be

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I287c8ce2b525224970aabd16fdf36a8204b39ede
Reviewed-on: https://chromium-review.googlesource.com/1124640Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572231}

This CL process local updates in the bookmarks model and updates the
tracker accordingly.

Bug: 516866
Change-Id: Idfa2f2e7822029fb71030e3decbc6d8091856737
Reviewed-on: https://chromium-review.googlesource.com/1124164
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572230}

This CL introduces MovableString to hold javascript string
resources. This class may move its data, although this CL only
introduces the simulation of it in order to gather data about such an
approach.

This CL is essentially a port of
https://codereview.chromium.org/1583263002 from hajimehoshi@. It has
been updated to the new conventions and coding style, but is otherwise
equivalent, with changes to histogram collection and triggering.

Bug: 837659,574317
Change-Id: I9028fd941f3d235761f10a2147ab21e31edac6d6
Reviewed-on: https://chromium-review.googlesource.com/1082445
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572229}

https://webrtc.googlesource.com/src.git/+log/46f858a626d5..3bc977a42022


git log 46f858a626d5..3bc977a42022 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 mbonadei@webrtc.org Revert "Add sprang@ as owner of simulcast.cc/h"
2018-07-03 danilchap@webrtc.org Discard frame self-dependency when parsing genric frame descriptor
2018-07-03 buildbot@webrtc.org Roll chromium_revision f6935ecd..ce19c6d8 (572058:572160)


Created with:
  gclient setdep -r src/third_party/webrtc@3bc977a42022

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:859281,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iafdb693db9daef07e8dac90bdc685e15e154e8df
Reviewed-on: https://chromium-review.googlesource.com/1124641Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572228}