GitLab

Roll Chrome Mac PGO profile from chrome-mac-master-1590767663-c9c32cda7f7963eb3f000a0ebfa31cdf13cf0117.profdata to chrome-mac-master-1590782199-5f9cc23c2c468b4d853caca7f19fea68cbc16f21.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I95dc79e686001bc279f02a33e31cb92ad2ee7f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222787Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773379}

Test-only for fixed bug by NG. No behaviour change.

Bug: 903224
Change-Id: I268ae2b8a49dd84fdb23fe49e2da551d550976c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223002
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773378}

This script was previously used with Grit, but that is no longer
the case since r682948.

Bug: None
Change-Id: I67446b17949c16493963d307f89e91ec43b06a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222765
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773377}

This change updates chrome/installer (as a whole) to use nullptr
rather than NULL consistently.

BUG: 1083987
Change-Id: Ic08b41e1356983113d907e719a022c2e1f7b88e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218560
Commit-Queue: Brian Manthos <brianman@microsoft.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773376}

Move the comment, which adds a break to the sources list, and its
associated files into a separate section. As is, the break in the
sources list often confuses people, and that leads them to add files to
the wrong part of the sources list.

Change-Id: I1c969cec45ee678fc2d0c90ab76809d44d98e9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219605Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773375}

1. Add having any kind of inner contents that is currently audible
   as a qualifying condition for a contents being audible. This
   encompasses portals.

2. Correspondingly, add attaching/detaching an inner contents as
   a possible reason for the audio state changing. Detachment can
   happen implicitly during contents destruction (which already
   deals with this, and would otherwise attempt to access
   destructed members), so this case is excluded.

3. Currently the timeout that the tab actually observes is the
   one issued directly by AudioStreamMonitor, but an inner contents
   AudioStreamMonitor may already be destroyed (along with its
   owning contents) at the time the 2-second timer expires. It
   notifies using the navigation state signal.

   The outer contents RecentlyAudibleHelper is aware of the correct
   state, but pending the resolution of crbug.com/846374 does not
   notify the tab strip of this. Until that is resolved, add a
   notification directly from the helper.

   This may duplicate the AudioStreamMonitor notification, but
   this appears to be harmless (we'll just recompute the alert state
   twice) and in any event will go away when crbug.com/846374 is
   fixed.

4. Browser tests that watch the tab UI state are included. These tests
   are high-level integration tests, because tests which merely
   examined the recently-audible state would not have caught some
   issues that arose from notification of that state change not being
   propagated to the chrome.

Fixed: 1085862
Change-Id: I9c6c7be64883914fdbfff5bf565718b108113b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213118Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773374}

This reverts commit 92842b6a.

Reason for revert: This breaks fuchsia/engine/browser/media_browsertest.cc
https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20ARM64/103950

Original change's description:
> [Fuchsia] Add WebEngineIntegrationTests.PlayVideo test
> 
> Previously there were tests that play audio and tests that play video,
> but no tests were playing a file with both audio and video. Also video
> was not played to the end. Added PlayVideo test that plays
> bear-vp9-opus.webm to the end. Also updated SetBlockMediaLoading tests
> to share play_video.html and reduce amount of duplicated code.
> 
> Bug: b/153914562
> Change-Id: Iba492ec252f692f7aa3f93c319d858a91bb38278
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219404
> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#773338}

TBR=kmarshall@chromium.org,sergeyu@chromium.org

Change-Id: Ief517228f418509838bb07a1318b4e7a80b1aedd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/153914562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222697Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773373}

paymentOptions used to get populated as an string arraylist in intent
extras. This cl changes the paymentOptions to a bundle so that native
app developers won't need to convert string values to boolean.

Bug: 1026667
Change-Id: I6804d8765b9c90da73b8533ca55c7304823858f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219684Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773372}

Re-organize code so that when retry after initial setWindowBounds,
will trigger setWindowBounds again in hope to trigger window state
change.
This is an attempt to add on the following fix.

[chromedriver] Fix testWindowMinimize flakiness

After setting window bounds, could potentially wait for 1 second
using retries for window state to reflect.

Bug: chromium:1068467
Change-Id: I62ca499879ec1d31e1eabafa8c8dea870e3e03da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222625
Commit-Queue: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773371}

conformance2/textures/image_data/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html
is flaky on Builder Win10 FYI x64 Exp Release (Intel HD 630).
Suppress.

TBR=kylechar@chromium.org

Bug: 1087993
Change-Id: Icdfa404f6ab1b62fbb97b605cb6b0bb34e7d7a18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222881Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Auto-Submit: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773370}

I'll start them out at medium for now, and we'll adjust the rankings
accordingly once we get more testing completed. I updated a few ("Mono
audio" and "Blue light reduction") to kLow since these have been
interfering with "Bluetooth" and "Wi-Fi".

Bug: 1082251
Change-Id: Ic45495e2fcb55939fd7a08e38312c875f364805a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222294
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773369}

This test relies on ChromeDriver's SetWindowBounds, which is flaky -
it waits 100ms for the command to complete rather than observing an
actual event.

Bug: 867511
Change-Id: I7b4b759be6f2498b0ff3b46f705d2e2567d07558
Tbr: johnchen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222720Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773368}

Inset box shadow doesn't scroll, and it's in the scrolling area
above the background below the scrolling contents, so the background
must paint in the main graphics layer.

Bug: 1086457
Change-Id: I6bf5fc3e7754a29cfa60d72acbe5699594152ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222626Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773367}

Change-Id: I3bd33fdfb707408809dfa777ce1a0abfcfd7991b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219159Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773366}

This update is based on the feedback from estade@. Chromium itself
doesn't have a style guide for documentation. For titles and headers,
the existing documentation has different styles. To make our document
consistent, we can follow "Google developer document style guide"
(https://developers.google.com/style/) to use sentence case for titles
and headings.

BUG=none

Change-Id: If9e63e94971b9015e1803c79b9995809ad166783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219302
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773365}

The CL that triggered their flakiness got reverted.

Bug: 1021545
Change-Id: I7d7862f2ee1031fbe402276d0ab62f6fcb13fe6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219349Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773364}

Bug: 929156
Change-Id: Id923970af87c4924a26961a6f70145bffeab3005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460062
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773363}

Add @RetryOnFailure to
IncognitoStorageLeakageTest#testStorageDoesNotLeakFromActivityToActivity

Although there are talk about removing the RetyOnFailure flag (see
crbug.com/797002) for now this should be slightly less expensive than
re-running the entire test suite.

TBR: tedchoch@chromium.org
Bug: 1087796
Change-Id: I2f76509aa7f5aecf9f7554cc3d825149055b428d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222727
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773362}

These histograms are still in use.

Bug: 1072542
Change-Id: I7524ba1fc7f233ca84171ffdb4c11c58c767a8ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222630Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773361}

Same thing that crrev.com/c/2219679 did, but for tests invoked via
host-side cmd (eg: telemetry) rather than device-side cmd (eg: gtests).

Bug: 1087407
Change-Id: I514a01583bbfea6a4a600d738587d8663ae0adec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222901Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773360}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7693b668..772196e5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I13bec7b00a9e05d3e8cba4fb72c105b90d82a9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222207Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773359}

Instead of hardcoding a top and bottom border in the graph, add a border
around each node's bounding area in boundingForce. This will keep nodes
away from the lane markers as well as the graph edges.

R=siggi

Bug: 1086231
Change-Id: I58b52649aec0e921de5a85d8bd191591bf36f13b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222529Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773358}

In-memory representations of the two types of graphs were made
serializable/deserializable to and from JSON. A new module
`serialization` has been created to help with this process.

The end result is one .txt file containing the JSON dump of both the
class and package dependency graphs - more rationale on this format is
included in the docstring of serialization functions.

The performance of the de/serialization is very acceptable (within
a second on my machine). The filesize of the output JSON file is ~7MB,
which I also find acceptable. There are rooms for optimization in the
JSON structure if the filesize becomes an issue in the future.

Bug: 1081889
Change-Id: I03061372e0ed94aed62de58f41fb3f363f543b3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219817
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773357}

This CL changes SetWakeUpRate(double wake_ups_per_second) to
SetWakeInterval(base::TimeDelta interval) to avoid conversions
between rate and interval.

This CL is a no-op.

Bug: 1075553
Change-Id: I1b72f6b56f364c24c73a14eb8f1c3aea8ca31bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219524Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773356}

https://chromium.googlesource.com/openscreen.git/+log/b4e53be8a002..cfe3be0ee4c5

2020-05-29 rwkeane@google.com Code Coverage: Add new buildbot mixin

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I40c444d57a8ab9729262d99c327c7a66f52c077a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222712Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773355}

This CL is suspending the execution of delayed task while the
system is suspended. The ThreadControllerPowerMonitor is
used to notify the ThreadController when the power is back to
normal.

The delayed tasks can no longer be executed between suspend and
resume notifications. They are postponed after the resume notification.

On Windows, while going to suspend mode or waking up, the computer has
bottleneck on clock API (system-wide lock) and has a lot of disk IO
contention. It is not the right moment to wake up all the pending
delayed tasks at once. It is better waiting for the resume notification
while the computer is in a running state.

Bug: 1074332
Change-Id: Icda16b76fc87a20fee22997baf7eeb5e5d02eb09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186200
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773354}

To allow construction with multiple unwinder. This is necessary on android
to provide native and chrome unwinders and will be used in a follow in
stack_sampling_profiler_unittest.cc
https://chromium-review.googlesource.com/c/chromium/src/+/2201658

Bug: 989102
Change-Id: I05ef97403668d82dc7e6e4e9505be95e941174dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211862
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773353}

WebLayer doesn't use ApplicationStatus. In order for WebLayer to use
AccessibilityUtil this splits AccessibilityUtil into two parts. The
core part dealing with determining if accessibility is enabled remains
in AccessibilityUtil. The application state remains in a subclass called
ChromeAccessibilityUtil.

This code is easier to split when the there is an actual instance
created. So, rather than a bunch of static methods, you have to
create an instance of AccessibilityUtil. ChromeAccessibilityUtil takes
care of this. Doing this means all chrome code now has to call a static
function to get the instance. This necessitated a bunch of changes.

There is one other interesting change here. Previously
ApplicationStatus.ActivityStateListener, when RESUME was called, would
reset state so that the next call to isAccessibilityEnabled() would
trigger recalculating the value. If the value changed, this would *not*
notify observers. This seemed like a bug, so I made the RESUME case
immediately calculate the value and notify observers if necessary. Please
let me know if you think the old code was correct.

BUG=1085210
TEST=none

Change-Id: Id4e58da4f96fb9d218e59d3e62a94f0085827bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210358
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773352}

R=thestig
CC=​thakis,maskray@google.com

Bug: 1086636, 1084359
Change-Id: Ibc5f5da51278d90d7f45c4fdadff07f62f6dfd51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219606
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773351}

When there's an Expect-CT failure, a new URLRequest will be created to
report the failure, and that request needs to have a NetworkIsolationKey
to prevent cross-site information leakage.

Bug: 969893, 1082280
Change-Id: I5daa400fed87ce23f7a9b34121888f91b9249895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219091
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773350}

Change-Id: I20c0ea03bf3fd21a260dd9f1fc67e66b6d8c7c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216546Reviewed-by: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773349}

Change-Id: I2f05f6eaa5ea7bcbaa27e0a8f4472affb42afa5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168768
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773348}

If a history navigation targets a subframe, but the subframe has been
removed by its parent, we currently fall back to reload the whole
page.  This CL tries to modify this behavior to instead do a no-op
same-document navigation (to the same item sequence number) to the
main frame.  This approach will update the current history entry to
the target one, but it avoids a reload and allows the main frame and
other frames to continue to function.  The CL tries to preserve the
main frame reload behavior in the cases where that's still needed,
including various kinds of reloads, session restore, and crash
recovery, by refactoring FindFramesToNavigate() to explicitly queue a
different-document load in those cases.

We've also attempted ignoring the navigation completely, rather than
doing a no-op same-document navigation.  This had the problem of not
notifying observers about the updated history entry, meaning that
things like greying out of back/forward buttons didn't work properly,
and history length/offset information wasn't updated properly in the
renderer processes.  Doing a redundant same-document navigation avoids
these problems, as it goes through a complete navigation flow.

There was one unwanted side effect of this approach, which is that the
main frame would redundantly fire popstate events when the ISNs aren't
changing.  The spec [1] argues that popstate events should be fired
whenever the "entry" changes, but "entry" in that context probably
means the FrameNavigationEntry and not NavigationEntry.  Although the
NavigationEntry changes here, the spec probably expects
FrameNavigationEntry to not change (due to how joint session history
entries are supposed to work), even though it does change in our
current implementation (see https://crbug.com/373041).  Other browsers
also don't trigger a redundant popstate in this case.  So this CL also
modifies DocumentLoader to avoid triggering redundant popstate events
when the ISN doesn't change.

This is a less risky option to solve this problem.  It has some
drawbacks -- if there are multiple history entries targeting a removed
subframe, the user might have to keep clicking back/forward until
finding an entry that still works.  In the future, we could consider
improving this to automatically walk past all history entries
corresponding to the affected subframe.

[1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#history-traversal

Bug: 705550
Change-Id: I11fca7a8f1062af347442922f49b2dfe50970d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181973Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773347}

This CL creates a whole new flag for the On-Content variant of
Contextual Web ZeroSuggest.

Bug: 1087700
Change-Id: I4ccb748421470e2ccd3508d69fc317e12c27ff9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219597Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773346}

It then passes the NetworkIsolationKey on to the ExpectCTReporter. Also
plumb NIK through the other TransportSecurityState methods that call
it.  Only one caller of TransportSecurityState is updated to pass in
a non-empty NIK.  The other 3 callers will be addressed in followup CLs.

Bug: 969893, 1082280
Change-Id: I2982c06288e6ff9ec2dd863b0ecbcf01f46b2791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217871Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773345}

This avoid having to type 1 << (numbits_ - 1) in several places which
can make code harder to read and can be typo prone. This function can
also be used within another template.

Change-Id: I46af3ab832bb58a6565702a391db028b2a69807f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222526
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773344}

This ensures the most visited tiles as up-to-date. It's also what the
local NTP does.

Bug: 1087564
Change-Id: I724b99763952894617400d2733ce55992e3933dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222635
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773343}

SuperSize-archive calls _AddUnattributedSectionSymbols() to create
symbols (in .other section) to account for sections that are not covered
by symbols. However, previously this was done only ELF files inside APK
and not for stand-alone ELF files. Also, the accounting was off,
resulting in Supersize-console
  Print(size_info)
producing file sizes that are off. This CL fixes the above problems.
Details:
* Add models.ClassifySections() to classify sections into one of three
  groups:
  (1) Unsummed sections: These don't add to binary size. E.g., .bss.
  (2) Explicitly summed sections: These add to binary size, and have
      symbols that are extracted by the "usual method" via .map file
      parsing, nm, etc. E.g., .text.
  (3) Implicitly summed sections: These add to binary size, but needs
      to be extracted via _AddUnattributedSectionSymbols(), and counted
      as part of the .other section. E.g., .dynsym.
  * The function is used by archive.py and describe.py, to eliminate
    previous size mismatches.
  * Add BaseSizeInfo.ClassifySection() to wrap this.
* archive.py: Change main flow so that _AddUnattributedSectionSymbols()
  get called when an ELF file is the main input (even without APK).
* describe.py: When describing section sizes, add note to make it clear
  that a section is counted in the .other section.

This CL leads to extensive .golden file changes.

Bug: 1084580
Change-Id: If663eb9acce89b32f857a0056b6f5ec39db35d8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217861Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773342}

https://skia.googlesource.com/skia.git/+log/df546db4d8f7..cc7ec24ca824

2020-05-29 egdaniel@google.com Move backend surface vk getters and setters back out from behind compile flag.
2020-05-29 bungeman@google.com Revert "Hide ICU C++ API from Skia users."
2020-05-29 bungeman@google.com Create CTTypesetter without Options.
2020-05-29 herb@google.com tease apart GrTextBlob and SubRun
2020-05-29 bungeman@google.com Hide ICU C++ API from Skia users.
2020-05-29 herb@google.com Rename fUniqueID -> fMessageBoxID
2020-05-29 csmartdalton@google.com Wire up mouse and keyboard events in CanvasKit viewer
2020-05-29 egdaniel@google.com Add GrBackendMutableState object to handle shared texture state.
2020-05-29 michaelludwig@google.com Rename fIH variable to fInvH
2020-05-29 csmartdalton@google.com Merge PathText samples into one, with different modes
2020-05-29 nigeltao@google.com Fix markdown typo in the style guide
2020-05-29 senorblanco@chromium.org Modify SurfaceTest to only test readbacks from supported surfaces.
2020-05-29 brianosman@google.com Minor cleanup in the sample_matrix GMs
2020-05-29 robertphillips@google.com Update DDL test harness to better match OOP-R
2020-05-29 nifong@google.com Record code coverage in canvaskit tests, increase coverage
2020-05-29 herb@google.com Move hasW to SubRun

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: I5ced804b0b88c5c04788f5e10a879779ef17990f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222710Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773341}

CL:2035212 was reverted because we encountered some issue with the
guest user, and VP8 on Intel device. Now those issues are solved.
It's time to enable ChromeosVideoDecoder by default again.

Bug: 984482
Test: ninja media/base
Change-Id: I7ad037186fa4f62a0f7d14025e5f4590c7caad53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214764
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773340}