- 14 Dec, 2020 40 commits
-
-
Ossama Mahmoud authored
Bug: 1153306 Change-Id: I425eba7b9d8b15c6538f4dc49ddd4db893779128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566993Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Cr-Commit-Position: refs/heads/master@{#836580}
-
Antonio Sartori authored
In the Blink Content Security Policy code, we switch from using the internal blink ContentSecurityPolicy::DirectiveType enum to the mojo enum network::mojom::blink::CSPDirectiveName for enumerating CSP directives. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I91681d4a7bfebc06cb40e88f6f9ff9392dfaa0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562253 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#836579}
-
Michael Lippautz authored
Use kNoHeapPointers instead of kEmpty. Bug: 1056170 Change-Id: Ic45d8a216cda3a5ff30d3fe4bfdf32b08e806c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587732 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#836578}
-
Ziran Sun authored
Specifically, the following logical properties are included: - border-start-start-radius - border-start-end-radius - border-end-start-radius - border-end-end-radius These properties correspond to the border-top-left-radius, border-bottom-left-radius, border-top-right-radius, and border-bottom-right-radius properties. The flow-relative Corner Rounding properties (border-*-radius) will allow to set top-left, bottom-left, top-right and bottom-right box corners with logical mappings rather than physical. Intent to Prototype and Ship: CSS flow-relative Corner Rounding properties https://groups.google.com/a/chromium.org/g/blink-dev/c/YmWSODSTPS4 Spec: https://drafts.csswg.org/css-logical/#border-radius-properties Test: http://wpt.fyi/css/css-logical/logical-box-border-radius.html Bug: 1155270 Change-Id: Ia4462092b08f2b2821218b1584fdb0985c98c5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570570Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Ziran Sun <zsun@igalia.com> Cr-Commit-Position: refs/heads/master@{#836577}
-
Olivier Robin authored
By quickly retrigger overscroll actions, you can be in a state where no action is selected but offset is big enough to trigger action. In this case, Overscroll action is stuck in this state. Bug: 1003766 Change-Id: I2071a120e475bfc0bb95f2bddd216bbcb960f916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578984 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836576}
-
Kush Sinha authored
This reverts commit 56a15a3f. Reason for revert: Fails unit tests on linux-chromeos-rel. See https://crbug.com/1158303 for details. Original change's description: > GuestOsSharePath mark paths no longer shared on VM shutdown > > Bug: 1144138 > Change-Id: I970293c61c9686ab32f574957c028bd3db754ccd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589049 > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Jason Lin <lxj@google.com> > Reviewed-by: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#836531} TBR=joelhockey@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,lxj@google.com Change-Id: I4ba6d44fa5b448a4d6899a69dd5848a103a5614c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1144138, 1158303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588930Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#836575}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6a85f40d75b78a412d80613cf664036b584a58bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836574}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/282fb4092b6c..d0f99d5405b4 2020-12-14 xiaoxuan.liu@arm.com Vulkan: Fix build issue in vulkan display/headless backend. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Icee5f8f940c955039bf23498cd1ea5a836467649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589228Reviewed-by:
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2581542 Disable tests CL: https://crrev.com/c/2580885 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k update tests Change-Id: I2deaf3b83905665db277600d9170e6ae89e09723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581839Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836572}
-
Yi Gu authored
Bug: 1152263 Change-Id: Iea5a9ae4af34b34267f4c4a04b85ea4c3c715b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585640 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836571}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0991ca17bab3..8b35cefb4523 2020-12-14 jleconte@google.com Fix Uncaught Error: Invalid dimensions for plot, width = 0, height = 0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: If3124054038060f271f5c2337b599918e0dcc16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589229Reviewed-by:
-
Wolfgang Beyer authored
This CL adds a histogram to keep track of which kind of issues are created. Frontend CL: https://crrev.com/c/2567967 Change-Id: Ifc906076fad1c8f2925953366d4791edc7ca2a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574985Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836569}
-
Fredrik Söderqvist authored
This CL switches from using the SVGResources object graph to do cycle- checking, to using SVGResourceClient and SVGResource (sans the 's'). One of the major benefits is we no longer perform the cycle-check during layout tree attachment, but rather lazily during resource accesses after style resolution and layout tree construction. This should make this process a little more "lifecycle conscious", and makes access to some SVG resources less SVG-centric/awkward in some cases since we no longer need to go through the SVGResourcesCache/SVGResources objects. Accesses to resources now go through the associated SVGResource, that hangs off of computed style, and make use of the client object registered during style recalc. (This is to some degree similar to how StyleImages work.) Since this removes the need to track and maintain the SVGResources object for each client we can drop all the code that constructs and builds this database (which is a fairly significant drop in both LoC and code-size). SVGResourcesCache is thus dropped completely and SVGResources is turned into a static-only class with helpers (likely to be cleaned up latter). Bug: 1028063 Change-Id: I851e76384160a159a826979efab156036271aa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577210 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836568}
-
Alice Wang authored
This CL moves AccountPickerFeatureUtils to signin.ui target. Bug: 1157822 Change-Id: I6094021754e9197ad71b63f5299a6d685e92095a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584927 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836567}
-
Mikel Astiz authored
This rewrites histograms.xml to avoid text duplication. Change-Id: I80ae3d3b7e6873c1d193ef4520d63fc3c6163982 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517594 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836566}
-
Moja Hsu authored
This CL adds focusMode(continuous/manual) and focusDistance MediaTrackCapabilities. Bug: b:151048287, 1068176 Test: Tested logitech camera on eve. Test WFC of kukui. Change-Id: I85fa31b8b4f147b8cc054eac3f94974595545c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371843 Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#836565}
-
Antonio Sartori authored
Some Web Platform Test was expecting that dedicated workers served with Content-Security-Policy: script-src 'none' would block importScripts and setTimeout because of that CSP. However, according to the spec, dedicated workers inherit their CSP from the creator document and disregard the CSPs they are served with. We rewrite those tests with two different cases. For dedicated workers, we expect the inherited CSPs to be applied. For shared workers, we expect the CSP delivered with the worker to be applied. Bug: 1021462,1149272 Change-Id: I64469b2c9017b1d41a65abd4305d2440250b64d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578837 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607903843-e9f03e03b6a80ac1b9393fa413e44243742fdb9c.profdata to chrome-win64-master-1607914577-bca0912c8e5b677cc0f4c3a09eafddf2bb79f844.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If2a6e9fe57b497a8f7f23690560cd722ee45b733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589217Reviewed-by:
-
Hiroki Nakagawa authored
Change-Id: I1e7c49eac75295452149f2e41b290736b8f7e298 Bug: 1144577 Tbr: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586177 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#836562}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4705fd76bbf6e27f0a4568941ac483aacaf1dbae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589120Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836561}
-
Nancy Wang authored
This CL adds FullRestoreSavehandler class and the SaveAppLaunchInfo interface to prepare for the restore data writing implementation. There will be separate CL to implement the restore data and the FullRestoreFileHandler class to run the actual writing with a background task runner. BUG=1146900 Change-Id: I2ff73b40d6441e0f581b7f4a5b035cf6156241c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580922 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#836560}
-
dpapad authored
Bug: 1132403 Change-Id: I4f2feb3468649214c4a3c999505d1601d6fd94b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586761Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836559}
-
Antonio Sartori authored
When the renderer initiates a navigation, it currently sends the routing_id of the initiator RenderFrameHost to the browser. Among other things, this is used for inheriting the policy container of the initiator RenderFrameHost. Unfortunately, setting the initiator routing id is done in a best effort way. Indeed, the initiator routing id is set in the RenderFrameImpl by fetching the routing id of the initiator RenderFrame, which however might already be gone. In particular, this happens when a form submission is executed after the form has been deleted, which can happen since form submissions are scheduled asynchronously in Blink. Because of this reason, the information about the initiator for a form submission must be recorded when we schedule it, not when we issue it. Unfortunately, the code scheduling the form submission does not leave the third_party/blink layer, hence has no access to the routing id of the initiator RenderFrame. Because of this reason, we replace the initiator routing id with the initiator frame token in the BeginNavigation and OpenURL mojo messages. The frame token can be retrieved from within third_party/blink, making it possible to always ensure that a form submission has a valid initiator frame token. Notice that even if the initiator RenderFrameHost has been deleted already, we can still use the initiator frame token to retrieve its policy container. This is implemented in a follow up CL. Bug: 1059959,1130587 Change-Id: Ib98cd86a32328ca9a002b08106205c357f25bde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560578 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836558}
-
Frédéric Wang authored
In [1], security levels 0-1 were introduced for registerProtocolHandler. This CL adds a third level: Level 0: Strictly follow the HTML5 specification (*). Level 1: Allow registration from cross-origin. Level 2: Allow registration of ext+ scheme and chrome-extension:// handler. The ext+ scheme covers one of the use case mentioned in [2] : Extensions willing to register protocols for a "reserved" scheme, that is not overridable by pages. The HTML5 specification does not allow handler with chrome-extension:// scheme [3]. However, removing it was not possible without breaking existing extensions [4]. This CL changes that behavior to both match the spec and allow registration of handler with chrome-extension:// scheme in the context of extensions. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2287304 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=64100#c19 [3] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers [4] https://chromium-review.googlesource.com/c/chromium/src/+/1728369 Bug: 64100 Change-Id: I60e6abc19d5a134c67a9ab7a1ff83b7d11ea3622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560305Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL moves two confirm sync dialog tests to the junit target of c.b.signin.ui module. Bug: 1156585, 1156588 Change-Id: I3f54d90707a20ab22671d3f20e8ef1146c784cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584977Reviewed-by:
-
Alice Wang authored
This CL moves ConfirmSyncDataStateMachine to signin.ui target. Bug: 1156609 Change-Id: I8cf36f4597c6566fd2f81a1fc896255d90d0277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584881Reviewed-by:
-
Morten Stenshorne authored
Not sure what fixed it (went through some recent "suspicious" CLs, but it wasn't any of them). TBR=almaher@microsoft.com Change-Id: Id2283b394b667798ebf4d4060bf260c6916f1eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588929Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#836554}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607903843-a675fcd2050380ffbc0661240474ef4aba9bd536.profdata to chrome-linux-master-1607925234-871dfb77196d03b9fcef95521dbd7963c906e6ee.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7c4df23997b3db699908c84798587bef025bb9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589224Reviewed-by:
-
arthursonzogni authored
Users wanting to prevent plugins to be used were providing an empty list of plugin type to the 'plugin-types' directive. As a result, they were getting a console error, despite getting the intended behavior. It was not clear to the user what was wrong. Users should use object-src: 'none' instead. This patch reflects this into the error message. Bug: 1111546 Fixed: 1111546 Change-Id: I64a266582e33fa3417293ebfdb2e6bf87e08578e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584943 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3bcd2b23165..68da2313ca77 2020-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c75473c2cf88 to 282fb4092b6c (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ibf13ab15ae6c89c2864a51cd81dc7f52f74dbb5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589218Reviewed-by:
-
Ikjoon Jang authored
Replace defined(OS_CHROMEOS) or BUILDFLAG(IS_CHROMEOS_ASH) with BUILDFLAG(IS_CHROMEOS_ASH) || BUILDFLAG(IS_CHROMEOS_LACROS) to apply scheduler boosting to both world. BUG=1041117,1052397,b:159370915 TEST=check /proc/*/sched for all urgent threads Signed-off-by:
Ikjoon Jang <ikjn@chromium.org> Change-Id: Ic3c61b36977d1675037983cd159164bd38a50aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563423 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836550}
-
Nancy Wang authored
This CL adds the convert functions to convert the restore data to base::Value. Add FullRestoreFileHandler to convert the restore data to JSON string, and write to the full restore file. BUG=1146900 Change-Id: I1e93579464cf97ab04235599fc5519f86a606e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581709 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607903843-cfbf56cfb9918bf3ea560508846f459222f50389.profdata to chrome-mac-master-1607925234-ef20c18621d9ca5f7c0d39fedb05c76a05c36900.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib28e7d3e4f9ec172054d468e4492f9d770e80b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589221Reviewed-by:
-
Koji Ishii authored
When |NGLineBreaker| finds a forced break, it includes following close-tags but not empty text items. This caused an additional empty line when there are spaces before/after the close-tags, which causes the `widows` property to count the empty lines. This patch changes |NGLineBreaker| to include them as well. Bug: 1156773 Change-Id: Id01966dd57dce3185d384544e9af662fd43917c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584431Reviewed-by:
-
Anthony Polito authored
this was generated by an automated workflow Bug: 1113033 Change-Id: I9ac4108a97bc50fa795d1b425925b7a82177e20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586280 Auto-Submit: Anthony Polito <apolito@google.com> Reviewed-by:
-
Christian Dullweber authored
We still need the flag. Bug: 1077766 Change-Id: Iba4c5834636845716872209019bd3eb4ccbba5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584925 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#836545}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/da8c22614051..282fb4092b6c 2020-12-14 syoussefi@chromium.org Fix link validation of I/O block members If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I4bb98d59684a5a2412d07ed369d9d67fc72ad9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589002Reviewed-by:
-
Taoyu Li authored
BUG=b:175079058 TEST=manual: verify routes6 view is included in feedback log. Change-Id: I192efc11547d7169d22d8f252ef10fa5177d9d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578338Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Auto-Submit: Taoyu Li <taoyl@chromium.org> Commit-Queue: Taoyu Li <taoyl@chromium.org> Cr-Commit-Position: refs/heads/master@{#836543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/35ebfe2c3bf8..d3bcd2b23165 2020-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0a64a9747555 to c16dc7107fd3 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I26d47b1b6328113c1324f5a8cd89cb13c564990d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588820Reviewed-by:
-
Kenichi Ishibashi authored
To de-flake payment related browser_tests. These tests call GetUserDataForAllRegistrationsByKeyPrefix() more than 500 times. Storage operations are serialized as of crrev.com/c/2494208 but the serialization mechanism doesn't seem to be working correctly for these tests. There seems a situation where we don't call the callback of the method and hit DCHECK() in mojo generated bindings. This CL stops serializing storage operations. Follow-up CLs will address the root cause and re-implement the serialization. I ran LoadAndRemoveIframeWithManyPaymentRequestsTest 50 times on my local environment and didn't observe flakiness. Without this CL the test crashed once every 5 times. Bug: 1129578,1133143 Change-Id: I3054f02eadfb21c570124aca5a377d8112ef8cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584432 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836541}
-
