- 24 Jun, 2020 40 commits
-
-
Vladimir Levin authored
This patch ensures that when we have a find-in-page target, we keep it unlocked for two frames, so that the visibility detection can take place and if needed keep the context unlocked. The root problem here is that sometimes our contain-intrinsic-size is too small, so that when we find a match and scroll it into view, we actually scroll past the locked size by enough distance that the container remains locked, so we never see the match. With this patch, the container is unlocked for two frames which is the least amount needed for visibility to kick in and start being unlocked. This patch also cleans up the previous focus-clearing bug to use the same mechanism of unlocking-until-lifecycle. R=chrishtr@chromium.org Change-Id: I75a2d8b2f41335d5d6fb7a4ec0f42d93438807e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264756Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782115}
-
rbpotter authored
Fix a race condition where if the download button is clicked while a form field is still focused, the plugin may not have yet notified the UI that the document has edits. This results in the "Edited"/"Original" menu not appearing, and the original document being directly downloaded instead. Check before saving the original document if a form field is focused, and if so, wait for the form field focus to change, which gives the plugin time to send the edit status update. Bug: 1098082 Change-Id: Ib11aa2ca9c06d06b9d05041272b070a674b316f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261188Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#782114}
-
Andrew Grieve authored
Android does not use it, so we shouldn't build it. When looking at a ninja trace on the android-binary-size trybot, this target showed up on the critical path and taking ~2 minutes to build. TBR=agrieve # Mechanical BUILD target renames. Bug: 1078460. Change-Id: I645277778762cd5e30cd81ce84a5776d38c3fdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258469 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#782113}
-
Christian Biesinger authored
The in-flow version of abspos-007 Bug: 1045668 Change-Id: I9c33eea25b5378e39e8a9b4f57016cf17828588c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261169Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#782112}
-
Patrick Noland authored
TBR: szager@chromium.org Bug: 1096612 Change-Id: I598cbcf55ff97a453b714759e458915030355a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264768Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782111}
-
Lei Zhang authored
For extensions, instead of having a per-extension last-saved location, use the browser downloads location. Adjust some file_manager tests to pass with this change. In production, file_manager is not affected by this because it is an app and not an extension. However, some of its tests use a test extension, so the tests are affected. Bug: 1011587 Change-Id: I62d08a9b1855ee8e5454098d37ca5a8a685f9d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245686Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782110}
-
Tommy C. Li authored
UX folks suggested 8dp instead for aesthetic reasons. Bug: 1078415 Change-Id: I56ab151c4147b10b8853ebf1b9ae22cf1f4af90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265180 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782109}
-
Albert J. Wong authored
This allows APIs, such as DOM gettings, to take a StringView instead of an AtomicString. On platforms where externalization isn't supported for short strings, this will yield a speed benefit as there will be no AtomicString created. This can especially affect (questionably useful) microbenchmarks like blink_perf.binding get-attribute.html which can hammer the non-externalized path on some platforms. Usages of this API will come in a follow-up CL. This is partially broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: I44d36dadcb341042e7eaf84395be7cc4a069b392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261270 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#782108}
-
Robert Ogden authored
Leaves the command line flag for use in browsertesting and in the about:flag. Note: The browser tests can't set features with params because of this: http://shortn/_ZytN1SHiqN Bug: 1082505 Change-Id: I474fe012c6a00b15f38d70334d677a29815b24b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265178Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782107}
-
Clark DuVall authored
WebLayer now has support for opening in a new tab since http://crrev.com/c/2228365. We can now fix the TODO about captive portals opening in a new tab. Bug: 1047130 Change-Id: I1d2bf894caef6d0cc8f536db6d687fce0397ce0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264879Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782106}
-
David Van Cleve authored
This is a reland of 7d4baea7 Fixed the underlying issue necessitating the revert: crbug.com/1098019. Ran some of the failing tests locally with setup mimicking the failing FYI bot's environment and they seem to pass. Unfortunately, I wasn't able to run the entire failing test suite on a bot with the exact same setup as the failing FYI bot that prompted the revert. Original change's description: > variations: Add a field trial testing config entry for Trust Tokens > > We're rolling Trust Tokens (https://bit.ly/trust-token-dd) out so we can > start its origin trial. (The feature is gated behind both an origin > trial and a base::Feature; see [1] for a longer description of the > rollout strategy.) > > This CL updates the field trial testing config to enable the > `TrustTokens` feature with the configuration we're using during the > rollout. > > [1] > https://groups.google.com/a/chromium.org/g/blink-api-owners-discuss/c/WY17UlZFG3g > > R=chromium-metrics-reviews@google.com > > Bug: 1036483 > Change-Id: If9cb0611d0f2f236f99918326ce5ee33c991df25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255649 > Reviewed-by: Brian White <bcwhite@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Auto-Submit: David Van Cleve <davidvc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780881} Bug: 1036483 Change-Id: I549c6eaff38e019f5d9ca878e2160c0e87b6aee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261403Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782105}
-
Sam Sebree authored
This CL add correct styling for the dark mode focus ring on mac Bug: 1096269 Change-Id: Ib0fe9c18470a2333f48eeee921c9a8c02ac92162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256153Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782104}
-
Matt Falkenhagen authored
Some additional changes this CL makes: - Now the existing unit_tests that exercise prefetching go through throttles. These would crash in ProtocolHandlerThrottle, because a ProtocolHandlerRegistryFactory isn't created in unit tests. A nullptr check is added to not crash. - Revises the comment for ContentBrowserClient::CreateURLLoaderThrottles to be more general, since now any embedder can call it for any browser-initiated request. The comment was already missing the case of requests from PrefetchURLLoaderService before this CL. - Splits out network::EmptyURLLoaderClient from the static helper function DrainURLRequest(). This is needed because ThrottlingURLLoader doesn't use the Mojo pointers to the loader/client, which DrainURLRequest() needs. Bug: 1095842, 1092329 Change-Id: Id036135e9b9d15f6357b3cc1bd36be98d5cb155b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259734Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782103}
-
Maggie Chen authored
Bug: 850881,863086 Change-Id: I37ca7c191bb70d9571b3bea620df382496ae2498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265172Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782102}
-
Thomas Lukaszewicz authored
Currently bubbles rely on having the NonClientFrameView apply a clip mask to the ClientView so that the ClientView's contents are correctly constrained to the bounds of the frame. However, if the ClientView's content view hierarchy employs layer backed views, the ClientView's clip mask is ignored if the ClientView does not itself paint to a layer. This results in clipping issues where views can clip outside the bounds of the bubble when corner radius is increased. This patch addresses this issue by having the BubbleDialogDelegate supply a ClientView that paints to a textured layer. To address the existing cases where bubbles rely on the frame's background color (i.e. they assume that the ClientView is transparent), the BubbleFrameView will update the background color to ensure existing bubble behavior is preserved. Currently these features are gated behind the kEnableMDRoundedCornersOnDialogs feature flag. Bug: 932970, 822075 Change-Id: I68542ffe84b533fd8b751acc01e5852a8b9bf6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257452Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#782101}
-
David Schinazi authored
We've seen an increase in errors without the GQUIC error recently, so we're adding this new histogram to help figure out where those specific errors are coming from. This CL also adds some error codes that were missing from enums.xml. R=renjietang@chromium.org Change-Id: I58507c206ccbf3063ac7e1dc5b776306fe71e1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265233 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782100}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593014209-7e980a1dfa67a2e51666ab74889d15022f0ab030.profdata to chrome-win64-master-1593018578-236971dc116ecc25bb19bba334b12df71f24465e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If5f129ee763c377e3211b31c2e7aa52342a69cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782099}
-
Joel Hockey authored
This reverts commit 159ca7c4. Reason for revert: fixed build script error Original change's description: > Revert "Add CrostiniController class to manage foreground tasks" > > This reverts commit b2e67312. > > Reason for revert: Caused compile failure on Linux ChromiumOS MSan Builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/19874 > > Original change's description: > > Add CrostiniController class to manage foreground tasks > > > > This is a refactor to move code out of file_manager.js and > > into crostini_controller.js in preparation to add more features > > for showing messages. > > > > Updated UI tests to use FILES_NG_ENABLED and work with all files > > that import from chrome://resources such as files_message.html. > > > > Bug: 1095889 > > Change-Id: I9c9f34304e26dca8df4c0aa64a51c124650385b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259873 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781773} > > TBR=joelhockey@chromium.org,lucmult@chromium.org > > Change-Id: I91a7bd3837cf2ab2108ba672c36b3e5a5d5c743c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1095889 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263833 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781810} TBR=bsep@chromium.org,joelhockey@chromium.org,lucmult@chromium.org Bug: 1095889 Change-Id: I83b5dd3369e186ccffa29a63f25de370b73d7e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264086Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#782098}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a13d6a8f2b4d..44e38c4643ce 2020-06-24 chiur@google.com Merge "Clarify gpu_render_stage comments for use with OpenGL" 2020-06-24 lalitm@google.com Merge "tp: cache counter dur column after first creation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06223f331ea93461491e169eed4a84314e1d98d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782097}
-
Jesse McKenna authored
This change makes gfx::CheckWindowCreated() check whether the system is out of Graphics Device Interface (GDI) resources if window creation fails. Exhaustion of GDI resources indicates a GDI leak, either by Chrome or by another program, caused by the acquisition of handles to many GDI objects without the release of those handles. Explicitly checking for this case will make it easier to diagnose crashes in gfx::CheckWindowCreated(), e.g., crbug.com/1091696, which is suspected to be GDI-leak-related but impossible to diagnose with certainty without understanding the GDI-object counts at the time of the crash. Bug: 1091696 Change-Id: Ifaeceae8f7c511a9c7d0f80f37709fbc1c5bb9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244124 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#782096}
-
Matt Reynolds authored
This CL sets up the origin trial feature name "WebHID" and modifies WebHID permissions UI in preparation for an origin trial. * WebHID settings is visible by default in Site Settings * Site settings includes granted HID devices Intent to Experiment thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/LoyzK8xTRME BUG=1038966 Change-Id: I16f52e3c8d112f1f173c62a5a9fe073106e1560e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985174Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#782095}
-
Tom Anderson authored
BUG=1066670 R=msisov CC=sky,nickdiego Change-Id: Iaec104e97e18dca682229a6c52edd1e770c63e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261490 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782094}
-
Tommy C. Li authored
Before this CL, we always set the Headers text color to GoogleGray700. This is not correct, and this CL fixes it so that it's dynamically calculated by the theme just like the dimmed results text. In practice, the result of this calculation is still GoogleGray700 in the standard light-mode configurations, but is enhanced to be a better contrast ratio in dark mode. Bug: 1095205 Change-Id: Ieee2bd1db87b8806cb8cac8dcf0e30cc9859d6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264765 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782093}
-
Dirk Pranke authored
R=martiniss@chromium.org BUG=942720 Change-Id: I42c7a5cdc6b77d22de4a1ed8ab872acd962bed36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249158Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#782092}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/6bb377091bbe..7a06f9b64641 $ git log 6bb377091..7a06f9b64 --date=short --no-merges --format='%ad %ae %s' 2020-06-24 fayang In quic, update packet_size_ when first frame gets queued. protected by gfe2_reloadable_flag_quic_update_packet_size. 2020-06-24 fayang Deprecate gfe2_reloadable_flag_quic_extend_idle_time_on_decryptable_packets. 2020-06-24 fayang Deprecate gfe2_reloadable_flag_quic_advance_ack_timeout_update. 2020-06-23 renjietang Add an option to disable 0-RTT in QUIC crypto. 2020-06-23 haoyuewang Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: I0be5570c0ca8f04db63cb99a66bfe289772baf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265134 Auto-Submit: Fan Yang <fayang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782091}
-
Dana Fried authored
Behind a flag (nothing happens if flag is not set). This is part 1. It introduces the flag which enables the badging, as well as the ability for menu items to be badged. However, the pipeline to hook up badging is not included. Follow-up CLs will include: 1. hook-up from SimpleMenuModel 2. specific items to be badged for release See: https: //docs.google.com/document/d/1vczPpUCnYOKvSQtSWMYX8K1mK-vhrjwsAyRKFv22eYk Change-Id: If8900433015e71802b5deb0e32bebb9477ea8d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208794Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#782090}
-
Shengfa Lin authored
Implemented according to https://w3c.github.io/webdriver/#print. 1. Add endpoint support for print in ChromeDriver 2. Parse parameters according to WebDriver spec 3. Convert the parameters to print parameters for DevTools Protocol printToPDF 4. Python tests for verifying headless print generate pdf files 5. Unit tests for verifying parameters are parsed correctly 6. Update ChromeDriver status document Bug: chromedriver:3481 Change-Id: I4745edca84af02faaa95cc271a32cf7274f7daac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209670 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782089}
-
Oystein Eftevaag authored
R=nyquist@chromium.org,ssid@chromium.org Bug: 1098119 Change-Id: I12279236117ee69bc43110f1b63262afec629a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264460Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#782088}
-
Scott Violet authored
I'm only adding the thing I need, which is whether there is at least one browser in a resumed state, but we can add other calls to this as it makes sense. BUG=1025626 Change-Id: I7fd53fb97bc299d85d0171494888b4a6590b96ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261104Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#782087}
-
Amruth Raj authored
During pointer lock, a kRelativeMotionEvent is sent to indicate a recenter when the mouse is nearing the screen boundary. This test verifies that these events are not coalesced with other user generated events. Bug=1090617 Change-Id: Ib62ccf2531f0c3f45e92f5baef7fdc420af4a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260292Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#782086}
-
Xinghui Lu authored
This CL is for refactoring. There is no functional change. Move part of SendRequest and OnURLLoaderComplete into the base class. This can maximize the code that can be reused by the enterprise URL lookup service. Add two virtual functions GetTrafficAnnotationTag and GetRealTimeLookupUrlPrefix that are configurable by the child classes. Bug: 1085261 Change-Id: Ie895ffceacc15b34653644091763744ca970150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247402 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#782085}
-
Joey Arhar authored
When a form submission is scheduled, this patch will make it so any attempt to navigate the target frame which was already sent to the browser process will be canceled in order to make the form submission take precedence over it. This is the same behavior that would occur if we had synchronous form submissions - a synchronous form submission would cancel any navigations already sent to the browser process. Bug: 1091583 Change-Id: I6c8421922960e3209fcc21a7e4582e0fbf7d4bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254443Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#782084}
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: Id02d0a737b92533ba8abb462a48a20e2c685e58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264023Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782083}
-
Yoichi Osato authored
This feature counts protocol distribution to upload stream. This is recorded per fetch upload attempt regardless of its result. Bug: 688906 Change-Id: I3bba246fe0c41ee987a6d2ae52974fd1ac08b659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255925Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#782082}
-
Christopher Cameron authored
On macOS, most frames should be submitted by CommitOverlayPlanes. Also remove the concept of damage, because on macOS it is not meaningful. Bug: 894929 Change-Id: Idf0d393fd94fbc43f80a1d729bccf8f587431a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264935Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#782081}
-
Li Lin authored
There is a issue with text classifier that some capitalized words are not annotated properly. Convert the text to lower case for now. Bug: b/159756246 Test: manual test Change-Id: I66d355f503890a2b1d3c183853210fb1fd4aa8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261818Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782080}
-
Patrick Noland authored
Bug: 1098986 Change-Id: I00ae9f0a173b17e2b7bde98982ab4eb1925fcbe5 Tbr: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264603Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782079}
-
Chrome Cunningham authored
This reverts commit 30e7e503. Reason for revert: Broke https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/3694 Original change's description: > [Kaleidoscope] Add native parts to OSS repo > > Add the Kaleidoscope native parts to the OSS repo. > > BUG=1044741 > > Change-Id: I8562c8e35db2d1fa0ef8ce140ddbbc57ca7a9991 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255563 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782073} TBR=ellyjones@chromium.org,dcheng@chromium.org,huangs@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I534b8281aabb88bcf9af7f56881e297eaa1efb98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044741, 1099007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264589Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#782078}
-
Elly Fong-Jones authored
This test uses an uninitialized variable to keep track of method calls. Bug: None Change-Id: Icf08c41265986052966420dd4b274e47c83057c1 Tbr: khorimoto@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264463Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#782077}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43a6e176a60f..2639a144ff41 2020-06-23 kjlubick@google.com [demos] Add directory from which to serve demos.skia.org 2020-06-23 adlai@google.com Ignore calls to freeGpuResources on abandoned contexts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com,egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com,egdaniel@google.com Change-Id: I3618fe822937a3acc912f7b947e4d7b04f8b5fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782076}
-