GitLab

Review URL: https://codereview.chromium.org/906913002

Cr-Commit-Position: refs/heads/master@{#315263}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b486083..e6b1a60

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/911493003

Cr-Commit-Position: refs/heads/master@{#315262}

Revert of [Chromoting] Remove wildcard ('*') from remoting_all target. (patchset #8 id:140001 of https://codereview.chromium.org/896743004/)

Reason for revert:
It cause ChromiumOS.Chromium and PFQ bots to fail. The reason might because chroot didn't have "dpkg-architecture" command. The correct solution might be add "dpkg-architecture" command to chroot. But this CL currently break PFQ and a bunch of bots. So revert it for immediate fix.
See crbug.com/456491

Original issue's description:
> [Chromoting] Remove wildcard ('*') from remoting_all target.
>
> Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP.
>
> This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files.
>
> Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary.  The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets).
>
> BUG=
>
> Committed: https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928
> Cr-Commit-Position: refs/heads/master@{#315150}

TBR=kelvinp@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/905223002

Cr-Commit-Position: refs/heads/master@{#315261}

This CL animates the app list search box shadow as it transitions from
any page to the search result page.

BUG=453653

Review URL: https://codereview.chromium.org/889593003

Cr-Commit-Position: refs/heads/master@{#315260}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/360c0d1..5bb4863

TBR=

Review URL: https://codereview.chromium.org/897493003

Cr-Commit-Position: refs/heads/master@{#315259}

Since onDirectoryChanged event is created for each extension, we should not broadcast it.

BUG=456046
TEST=none

Review URL: https://codereview.chromium.org/883163005

Cr-Commit-Position: refs/heads/master@{#315258}

Currently a proxy refusal to allow a WebSocket to establish a tunnel
results in an error message like:

WebSocket connection to 'ws://foo:5036/' failed: Error in connection
establishment: net::ERR_TUNNEL_CONNECTION_FAILED

It is not obvious from this message that a proxy is the cause of the
problem. Change the message to:

WebSocket connection to 'ws://foo:5036/' failed: Establishing a tunnel
via proxy server failed.

BUG=454311
TEST=net_unittests, browser_tests, layout tests

Review URL: https://codereview.chromium.org/902553002

Cr-Commit-Position: refs/heads/master@{#315257}

This simplifies how the background color is set and makes it work for
print preview.

BUG= 456621

Review URL: https://codereview.chromium.org/874663006

Cr-Commit-Position: refs/heads/master@{#315256}

BUG=444485
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/906153002

Cr-Commit-Position: refs/heads/master@{#315255}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b8d4635..b486083

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/909733002

Cr-Commit-Position: refs/heads/master@{#315254}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c77726..360c0d1

TBR=

Review URL: https://codereview.chromium.org/907753002

Cr-Commit-Position: refs/heads/master@{#315253}

Fails on content_browsertests about once every 4 cycles. See bug.

BUG=224659
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/905203002

Cr-Commit-Position: refs/heads/master@{#315252}

It seems to be unnecessary now (tested against bugs: 256127, 256124) and
messes with focus order (i.e. click on a <button>, press tab -> should
go to next focusable item on the page but instead starts at top).

In general I'd also just like to match the rest of the web if possible.

R=tkent@chromium.org
BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/905433003

Cr-Commit-Position: refs/heads/master@{#315251}

This CL makes ShadowBorder depend on ShadowValue more rather than doing
independent calculations. It also adds a constructor that takes a
ShadowValue.

BUG=None

Review URL: https://codereview.chromium.org/900163002

Cr-Commit-Position: refs/heads/master@{#315250}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c2bfb1c..0c77726

TBR=

Review URL: https://codereview.chromium.org/910593002

Cr-Commit-Position: refs/heads/master@{#315249}

failures on Win x64:
TopControlsManagerTest.PinchBeginStartsAnimationIfNecessary
TopControlsManagerTest.PartialShownHideAnimation
TopControlsManagerTest.PartialShownWithAmbiguousThresholdHides

Errors like
TopControlsManagerTest.PartialShownHideAnimation (run #1):
[ RUN      ] TopControlsManagerTest.PartialShownHideAnimation
top_controls_manager_unittest.cc(160): error: Expected: (manager->ControlsTopOffset()) \u003C (previous_offset), actual: -100 vs -100
[  FAILED  ] TopControlsManagerTest.PartialShownHideAnimation (0 ms)

Likely became flaky in r315216.

BUG=456617
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/906103002

Cr-Commit-Position: refs/heads/master@{#315248}

The OSX interface guidelines suggest that this case should have a
continuation, and a continuation is used for this option in
chrome://apps.

BUG=444813

Review URL: https://codereview.chromium.org/896693002

Cr-Commit-Position: refs/heads/master@{#315247}

TBR=agl@chromium.org

BUG=436459

Review URL: https://codereview.chromium.org/879993005

Cr-Commit-Position: refs/heads/master@{#315246}

Cr-Commit-Position: refs/heads/master@{#315245}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/738bfa1..c2bfb1c

TBR=

Review URL: https://codereview.chromium.org/911463002

Cr-Commit-Position: refs/heads/master@{#315244}

it is deleted.

Did a one line fix to reset callback and commented out code that collected
UMA histogram data. Will implement correct fix asap.

TBR=rch@chromium.org
BUG=456524

Review URL: https://codereview.chromium.org/892083006

Cr-Commit-Position: refs/heads/master@{#315243}

because of the use of an uninitialized value in a function call.
Fortunately, it turns out that call is completely unnecessary anyway, so
this simply removes it.

TBR=danakj@chromium.org,jhawkins@chromium.org

Review URL: https://codereview.chromium.org/911453002

Cr-Commit-Position: refs/heads/master@{#315242}

Rebaselines landed (a couple in progress).

BUG=452219
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/906073002

Cr-Commit-Position: refs/heads/master@{#315241}

The Web UI incorrectly states that the issued and expires dates for
certificates is in UTC, when in fact it's in local time. Additionally,
it appends UTC in a non-internationalized way. This patch fixes both
issues by adding a new time_formatting.h utility function to produce a
formatted time string with the local time zone appended.

BUG=426909

Review URL: https://codereview.chromium.org/827123004

Cr-Commit-Position: refs/heads/master@{#315240}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce6d54c..738bfa1

TBR=

Review URL: https://codereview.chromium.org/909703002

Cr-Commit-Position: refs/heads/master@{#315239}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/067f8ab..b8d4635

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/906053002

Cr-Commit-Position: refs/heads/master@{#315238}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e426ccc..ce6d54c

TBR=

Review URL: https://codereview.chromium.org/906863002

Cr-Commit-Position: refs/heads/master@{#315237}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/772b5df..e426ccc

TBR=

Review URL: https://codereview.chromium.org/893053003

Cr-Commit-Position: refs/heads/master@{#315236}

BUG=436459

Review URL: https://codereview.chromium.org/905763002

Cr-Commit-Position: refs/heads/master@{#315235}

Add KeyedServiceShutdownNotifier for classes that depend on keyed services but can't be keyed services themselves.

BUG=395391

Review URL: https://codereview.chromium.org/905703002

Cr-Commit-Position: refs/heads/master@{#315234}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8698150..772b5df

TBR=

Review URL: https://codereview.chromium.org/903413002

Cr-Commit-Position: refs/heads/master@{#315233}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6262aac..8698150

TBR=

Review URL: https://codereview.chromium.org/902403002

Cr-Commit-Position: refs/heads/master@{#315232}

When the user navigates to a new page, stop sending accessibility
events on the old page.

BUG=421116,450409

Committed: https://crrev.com/6ce40a1e561892849c1f6ac070dda140f6cc0115
Cr-Commit-Position: refs/heads/master@{#314812}

Review URL: https://codereview.chromium.org/830053004

Cr-Commit-Position: refs/heads/master@{#315231}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/01d3319..067f8ab

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/866403010

Cr-Commit-Position: refs/heads/master@{#315230}

Logging revealed the flakiness was in ::AccessibleObjectFromWindow.
Replace that with an alternative method, and remove the logging.

BUG=440579
TBR=dtseng,ananta

Review URL: https://codereview.chromium.org/901183003

Cr-Commit-Position: refs/heads/master@{#315229}

Cr-Commit-Position: refs/heads/master@{#315228}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/873033003

Cr-Commit-Position: refs/heads/master@{#315227}

All arm platforms support V4L2 SVDA by default and use_v4l2_codec also
governs V4L2 VDA/VEA now.
Generates libv4l2 stub in GN file.
This CL is re-landed because CL 828063009 is reverted by 902773003.

BUG=449883,455545
TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks,
and panther_freon
TBR=piman@chromium.org,posciak@chromium.org

Review URL: https://codereview.chromium.org/902143002

Cr-Commit-Position: refs/heads/master@{#315226}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/884fc25..6262aac

TBR=

Review URL: https://codereview.chromium.org/906813002

Cr-Commit-Position: refs/heads/master@{#315225}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/57bdc6e..884fc25

TBR=

Review URL: https://codereview.chromium.org/902373002

Cr-Commit-Position: refs/heads/master@{#315224}