- 15 Nov, 2019 30 commits
-
-
Thomas Lukaszewicz authored
Added operators and type conversions to ColorRecipe and ColorTransform that allow for a cleaner and more intuitive use of these classes. Bug: 1887666 Change-Id: I2f0d3455da349c5c39025c6cdf5b1da9ed5e07c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912782 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#715533}
-
James Cook authored
Also clean up enums.xml slightly. A comment was misplaced and "CustomLoginFlags" is used on all platforms for flags metrics, not just Chrome OS. Bug: 1013466 Change-Id: I38531bdcd6bfa17e8e259dc9bb23b2ec1bbbab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918143 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715532}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of ac0e2c90 Original change's description: > Add RenderTests in StartSurfaceLayoutTest for native tab > > Add one more RenderTest for native tab. Choose NTP in incognito mode > for its consistency. > > Also fix the issue about thumbnails being not freed in > http://crrev.com/c/1903402. > > Bug: 983170 > Change-Id: I68d3f08184cb4b9504935a53f893bb7ea9473ba6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903620 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713961} Bug: 983170, 1023299 Change-Id: I7af29c83bc2a9fb6fc13a460522e2d624eddbd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916299 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715531}
-
Bailey Berro authored
Previously, there were navigation stops on each of 1) a user's picture 2) a user's name and 3) a user's email address. With this change, the picture is skipped, and the email address is read as a description of the name, removing unneccssary tab stops Bug: 1023643 Change-Id: Ic54430b7b6c96454eae8d1ccbe297122ae92f3f9 Fixed: 1023643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913055 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715530}
-
Kyle Horimoto authored
Before this CL, the notification was not shown because the stage was set to UPGRADE_ANNOYANCE_NONE. This CL changes this logic such that if there is no RelaunchNotification policy, this is set to UPGRADE_ANNOYANCE_LOW. Fixed: 1019854 Change-Id: I63c58e9fbcea5f7b71983ed2e41d730e1f23cb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900298 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#715529}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/336e51f68564..90c88f097366 git log 336e51f68564..90c88f097366 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 gbeaty@chromium.org Reland "Fetch the input commit ref when both ref and id are specified." Created with: gclient setdep -r src/third_party/depot_tools@90c88f097366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:922150 Change-Id: I819e27bbc379be7d064a8fed77c1d27a71a5f080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715528}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c95e54b558d9..c1c4634dcb07 git log c95e54b558d9..c1c4634dcb07 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 reed@google.com add some api helpers (extracted from different CL) 2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-14 benjaminwagner@google.com Use Clang for CMake build 2019-11-14 herb@google.com Hoist regenGlyphs out of per glyph loop Created with: gclient setdep -r src/third_party/skia@c1c4634dcb07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I50167ba9d0b257d7bae38e4165085eb77c33d74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918480Reviewed-by:
-
Toni Barzic authored
HomeScreenController should minimize non-foreground windows without animation when handling requests to go to home screen. Instead of just using WindowState::Minimize() on each window, use window_util::HideAndMaybeMinimizeWithoutAnimation(). The later should ensure that windows are properly minimized without using animation. BUG=1024659 TEST=Open an android app, then another app above it. Tap Home button. The app in the foreground animates to the home screen; the android app gets minimized without animating. Change-Id: Idb9caa86891b2f21e2127333acfca8dbaea9ed52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918092Reviewed-by:Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715526}
-
Nicholas Verne authored
Bug: None Change-Id: I3b7a78025ea186768f4f9f81bb40df8c341f70fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916530 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#715525}
-
Michael Spang authored
Now that Chromecast Linux enables this, all builds that link //ui/views are enabling this in GN. Add an assert so that accidental dependencies are diagnosed by "gn gen". Bug: 1021770 Change-Id: I681645e97f69c22ee0410c1dba95319fddef7038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898622 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715524}
-
Wez authored
Modify HistoryService and CancelableTaskTracker to track and check their home sequence/thread in Release builds, to get visibility into potential threading issues. Bug: 1009795 Change-Id: Id85a818111e8d2540a4bc4e333c88d7461a93a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918222 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715523}
-
Yue Li authored
Remove the web container feature flag. Since we want the feature only with the launcher UI, we can use the launcher UI flag instead. Bug: b/144383302 Test: Manual Test Change-Id: I5ecc9bce9d59624e430eb690a6dc8e5df1cbae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918181Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715522}
-
Tommy Li authored
It seems that in the past, we've hardcoded the ChromeOS launcher page context to have no default match. But that seems unnecessary, since nothing in chrome/browser/ui/app_list even looks at the default_match() member. I'm removing this because we want to keep the Autocomplete controller as generic as possible without any special cases. ChromeOS launcher can simply ignore the default match if it wants to, and indeed it seems to. The goal of this CL is to unblock removing the default_match_ member variable entirely, since it's always equal to results_.begin() if that first match has |allowed_to_be_default_match| set to true. Bug: 1016845, 363656 Change-Id: Ifd9f72c71c20b3e49bc4fa006353d980f7ba55a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913559Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715521}
-
meacer authored
This CL adds a new interstitial with custom strings and makes it viewable from chrome://interstitials page. It does not yet hook into the SSL error handler path to trigger the interstitial based on the new net error. Bug: 1014711 Change-Id: Ia66567cbb825c35910745aad181006041ae5b537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913882 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#715520}
-
Kyle Horimoto authored
The feature is not yet complete, so the flag cannot expire in M-80. Change-Id: I22dfbbbdb209d8a68e0dd4912a9f50f29204344b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918361 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#715519}
-
Wez authored
ImageFetcherImpl invokes ImageDataFetcherCallbacks asynchronously using PostTask(). This could result in the callback being run after the caller has deleted the ImageFetcherImpl, which is likely unexpected behaviour, and may result in a use-after-free of the calling object. Bug: 1009795 Change-Id: I2468b9e54dabea8d067b87395661ca11380e560f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918360 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#715518}
-
Ken MacKay authored
Fix some issues in MixerInputConnection which caused incorrect rendering delay or failure to start the stream. Bug: internal b/143135800 Test: cast_media_unittests Change-Id: I2c1a39da00aa36d36f72741cb374a1b87e5b46bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918180Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#715517}
-
gogerald authored
Bug: 1017396 Change-Id: I53528b77e5c44f6244c74b45c7a6e8c6c7beead1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917340 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#715516}
-
Sammie Quon authored
This will improve precision, which will remove some janking scrolls. Test: manual Bug: 1024679 Change-Id: Ieb639acb81857407fff296cb52f51f8333289c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912988Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715515}
-
Mei Liang authored
This CL adds a concrete TabSuggestionMessageService to the MessageService component. This concrete class is responsible for serving TabSuggestion message to its MessageObserver. Change-Id: I8dfb6c4fbe146448d534399e5f661101dd0899b0 Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913507Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
SDK 29 is now the default version and we no longer need to be able to build the temporary version of Trichrome for SDK 28. Set the minimum SDK version for all Trichrome targets to 29 so that it will remain constant going forward. Bug: 1003532 Change-Id: Id3974b31f474dba6f72034d9c38645cc56d6a964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918099 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715513}
-
Demetrios Papadopoulos authored
Ther accidentally converts |controlElementsWithAutocomplete| to a string before passing it to __gCrWeb.fill.formOrFieldsetsToFormData(). Bug: None Change-Id: I7d97914d55d96639296bed2af0c8090fee1fb99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914798Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715512}
-
Michael Spang authored
This reverts commit 5989e357. Reason for revert: Wrong culprit as Determinic Linux (dbg) is still red after reverting. The failure is in pak files which this shouldn't affect. Original change's description: > Revert "views: Enable toolkit_views on Chromecast builds that use views" > > This reverts commit 57ee9cf0. > > Reason for revert: Speculative revert for the failures on deterministic builds, e.g. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/12654 > > Original change's description: > > views: Enable toolkit_views on Chromecast builds that use views > > > > Chromecast uses views, but does not set toolkit_views=true. Set this to > > true & remove desktop-oriented code that breaks in this case. > > > > This replaces !defined(OS_CHROMEOS) with a new > > BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views. This > > is needed because Chromecast doesn't use desktop_aura and uses aura > > similarly to Chrome OS by creating one WindowTreeHost for the display > > [alternative suggestions on how to handle this distinction welcome]. > > > > This does not enable views in content(_shell) yet. That's left to the > > next patch as it changes the UI. > > > > As of this change, views_unittests passes in Chromecast Linux builds. > > > > Bug: 1021770 > > Test: views_unittests, content_browsertests on is_chromecast=true build > > > > Change-Id: I54e79402a761572feb76f122ed846558e84210b6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Michael Spang <spang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#715183} > > TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org > > Change-Id: I17c9efdff45b51d3a215bccd3be9eb9418478de0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1021770 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917294 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715327} TBR=sky@chromium.org,spang@chromium.org,jam@chromium.org,dpranke@chromium.org,steimel@chromium.org Change-Id: Ic7385336d896988c7bac9fd06f24f3cc048ba3af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918287Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715511}
-
Michael Spang authored
This function creates a gfx::Transform which is a floating point matrix. Change the gfx::Size argument to gfx::SizeF. This is needed to de-duplicate with ash::CreateRotationTransform, which sometimes transforms non-integer sizes. Bug: 1019015 Change-Id: I49294b123c546a7e54fe9f1ef2a63c62307dec38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914960 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#715510}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c98dded5. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." f55f08c7 "[Background Sync] Update idlharness test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mcasas@chromium.org: external/wpt/geolocation-API NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8197dff6f639da9d067dc4159004113622e0c889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917087Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715509}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7434231471c18588061be575cfe765020bb2ff80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918182Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#715508}
-
Lambros Lambrou authored
The IT2Me host bundle did not have any bundle icon. This bundle appears in Security & Privacy permissions lists with a stock Apple icon, so this CL adds a proper .icns file to the bundle. Change-Id: I115f35e2cfeaccd402064d1403a9ce26f08a63bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918026 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#715507}
-
Yuchen Liu authored
This fixed the build failure when ENABLE_CAST_RENDERER but not USE_CHROMECAST_CDMS. Without the internal part, CastMojoMediaClient always creates CastCdmFactory which is a dummy impl. Also remove USE_CHROMECAST_CDMS on the use of MediaDrmStorageImpl mojo connection. In addition, add missing header file to cast_content_browser_client_receiver_bindings.cc. Bug: None Test: Build, CQ Change-Id: I7376441b342e5320cdb3c7322a5ad5d7a7ed5e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913474Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715506}
-
Karan Bhatia authored
addDynamicRules method was recently removed in r714353 and replaced with updateDynamicRule. Remove the last mention of addDynamicRules from the docs. BUG=1023501 Change-Id: Ia00669bc84fbb0136a9f2cfe73d37b474e3579bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918519Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715505}
-
Connie Wan authored
- Removed IsTabPinned() check: This was only necessary before crrev.com/c/1898620, where groups were potentially created pre-navigation. There are already post-nagivation checks to make sure that a pinned tab is never grouped, so that it will never spawn a grouped tab: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=1981&rcl=16740b37447c5c07bebcfe2162e868b63b50ec1d - Checked for valid index: This isn't strictly necessary because GetTabGroupForTab() handles this gracefully (https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=873&rcl=16740b37447c5c07bebcfe2162e868b63b50ec1d), but it's still the desired behavior to return early in this case, and it's better to be explicit with this check. This was the root cause of the crash in the attached bug, when combined with IsTabPinned(). Bug: 1024485 Change-Id: I8650da21eb6d72539753ecf740644018a624aa02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917319 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#715504}
-
- 14 Nov, 2019 10 commits
-
-
kylechar authored
The GPU.CompositingMode histogram will periodically record what compositing mode is being used. Since we can switch from GL to software compositing at any time for a variety of different reasons this will provide a more comparable measure. Include Vulkan and Metal in the compositing modes enum as they are necessary soon. Bug: 1021645 Change-Id: Id78a34a171c771c000822ab474865c2931434a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899559Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715503}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/168bb0dc14f2..102fd19c65f4 git log 168bb0dc14f2..102fd19c65f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 amaiorano@google.com PixelRoutine: const-qualify reference parameters Created with: gclient setdep -r src/third_party/swiftshader@102fd19c65f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/143351714 Change-Id: I60fe61c5a5776e949ddb7fcbc3f6e1a331c21eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917989Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc70a4f8a96a..026ada55a386 Created with: gclient setdep -r src-internal@026ada55a386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3f3c0ee44ea89087a505cfc6d9d3dba7e07d8860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918044Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715501}
-
Yue Zhang authored
Instead of getting location of the animation source card relative to recyclerView, this CL gets its global position to make the animation more robust to different layouts. Bug: 995423 Change-Id: I349e219356cabc1e5704ba1a1cc62b92791a7ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896297Reviewed-by:
-
Edward Jung authored
This updates Enabled B setting to a slower 300-800ms range. Reduces the tab strip mouse out and return buffer to 300ms. Change-Id: I6f19d45aae8cb5b5d6dbc30cdd6521c4093f9918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914361Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#715499}
-
Ce Chen authored
suggestions. Bug: 925072 Change-Id: Ia22128991b70a5ce69f48ab2eb89c20e6af10b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918119 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715498}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/58dbfcae38f4..9b67273de9e5 git log 58dbfcae38f4..9b67273de9e5 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 ellyjones@google.com build: assert use_dawn Created with: gclient setdep -r src/third_party/dawn@9b67273de9e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:None Change-Id: I55404f6de3f1cbf5838ad7a02e68d9e6edecdbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917990Reviewed-by:
-
Toby Huang authored
Currently, ParentAccessServiceTest uses LoginPolicyTestBase to log in as child user for tests. We should deprecate LoginPolicyTestBase in favor of LoggedInUserMixin instead. This CL converts ParentAccessServiceTest to replace LoginPolicyTestBase with LoggedInUserMixin for logging in as child user for tests. Bug: 1014663 Change-Id: Ied5b53ee8ec2f44d5dc2193f011b741217080eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909273Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#714592} Signed-off-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914348 Cr-Commit-Position: refs/heads/master@{#715496}
-
Toni Barzic authored
AppListControllerImpl: if overview mode starting animation was canceled, the overview is about to start exiting, so update app list visibility accordingly - app list will not be occluded by overview, so its visibility should be determined by whether any windows are visible (this avoids changing the app list visibility to false for a moment before overview exit starts). In ShelfLayoutManager do not reset workspace update blockers as another overview animation is about to start. BUG=1024510 Change-Id: Ia5ac80f394a1d977c25b3dcac9cdae89c93dae16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914532Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5c144f39feb1..dad08eab03cc git log 5c144f39feb1..dad08eab03cc --date=short --no-merges --format='%ad %ae %s' 2019-11-14 ilkos@google.com Merge "Write process tree when polling /proc irrespective of on-demand quirk" Created with: gclient setdep -r src/third_party/perfetto@dad08eab03cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3b99d8abd299b16126b7c74c5b1dad320d3ae65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917992Reviewed-by:
-
