- 11 Dec, 2018 40 commits
-
-
Alex Leung authored
Bug: internal b/120633112 Test: Ran unit tests Change-Id: Idbda6d8ff9b26db40b924dc1bf9d56ab331d4e8e Reviewed-on: https://chromium-review.googlesource.com/c/1366389Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#615608}
-
Xianzhu Wang authored
This shortens call sites, and removes the requirement of DisplayItemClient at call sites. Change-Id: I445a48a13fb52b07a1a9fccb912c16f829e1c404 Reviewed-on: https://chromium-review.googlesource.com/c/1371195 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615607}
-
Nico Weber authored
Listing a generated directory in the isolate means that incremental builders (and devs doing incremental builds) can have stale files in their generated isolated files. Since we already have data_deps on all these copy steps, the isolate already contains an explicit list of all files in that directory, and having a data line for the directory is not necessary. Just remove it. Bug: 912946 Change-Id: Id7232369905fb651227d5e913247271dd39a4211 Reviewed-on: https://chromium-review.googlesource.com/c/1368584Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615606}
-
ccameron authored
This reverts commit 2e1e507d. Reason for revert: Flakey test has been disabled. The behavior that the test is testing is being deprecated in Chrome 73. Original change's description: > Revert "RemoteMacViews: Fix hang at command-Q" > > This reverts commit 464fae69. > > Reason for revert: Causes heavy flakiness (14/17 on Mac 10.11) and attempted fix showed no effect: https://crrev.com/c/1369136 > > TBR=ccameron@chromium.org > Bug: 902583 > > Original change's description: > > RemoteMacViews: Fix hang at command-Q > > > > When we call -[NSApp terminate] in the app shim process, this does > > not immediately terminate. Rather, it > > 0. Sends the message appShimController_->host()->QuitApp() and waits > > for a reply before actually terminating. > > 1. In the browser, this call hits ExtensionAppShimHandler:: > > CloseBrowsersForApp > > 2. Which will end up calling NativeWidgetMac::Close > > 3. Which will then politely request that the app shim process close > > the corresponding window via > > views_bridge_mac::mojom::BridgedNativeWidget::CloseWindow > > 4. Which will send an ack back to the browser via > > views_bridge_mac::mojom::BridgedNativeWidgetHost::OnWindowHasClosed > > 5. Whereupon the browser window will be registered as closed, and a > > close message will be sent to the app shim, and the wait for > > termination will break > > > > This ends up not working at step 3. Our suspended terminate ends up > > running a nested message loop inside a mojo message handler, and so > > it will never execute the CloseWindow message, and therefore never > > close. > > > > Change the logic at [0] to send the QuitApp message, and then > > immediately terminate the application. > > > > Bug: 902583 > > Change-Id: I60fd7b5fdf9f145369d06219e8ebef36cdcd0f44 > > Reviewed-on: https://chromium-review.googlesource.com/c/1364220 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Commit-Queue: ccameron <ccameron@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614922} > > TBR=ccameron@chromium.org,rsesek@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 902583 > Change-Id: I34a3300dc188cdd0de58692042ce131a8639117f > Reviewed-on: https://chromium-review.googlesource.com/c/1371475 > Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> > Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615485} TBR=ccameron@chromium.org,rsesek@chromium.org,fhorschig@chromium.org Change-Id: Iceda65f61ac8a63bfd53803f713f0472f90e0d47 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902583 Reviewed-on: https://chromium-review.googlesource.com/c/1371939Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615605}
-
Dan Harrington authored
TimeTicks is preferred for measuring time, when time isn't being measured across restarts. These were the only two cases I found under components/offline_pages that could be converted to TimeTicks. Change-Id: I627698de121cdda5d7853e0d92f7032ade524a40 Reviewed-on: https://chromium-review.googlesource.com/c/1364080 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615604}
-
Owen Min authored
Removing the deprecated enum option breaks metrics count. Add it back with a deprecation message. Bug: 913103 Change-Id: Ia06712e466747989e38cf999dd199918e995a8c1 Reviewed-on: https://chromium-review.googlesource.com/c/1368632 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#615603}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5c88e7e1c1a..be607ad63609 git log f5c88e7e1c1a..be607ad63609 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 geofflang@chromium.org GL: Implement GL_OES_EGL_image_external and GL_OES_EGL_image_external_essl3 Created with: gclient setdep -r src/third_party/angle@be607ad63609 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ibf3dd3250b8f7002587586d74ce15f6e47c296e9 Reviewed-on: https://chromium-review.googlesource.com/c/1372091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615602}
-
chrome://password-manager-internalsDominic Battre authored
This CL introduces two minor improvements to the data produced in chrome://password-manager-internals: 1. The renderer ids are printed for new password elements. 2. For forms that are given to the new form parser, the form signature is printed. This makes it a bit easier to search for data that belongs together. Bug: 913516 Change-Id: Ia1392e0b1f70bab6aa5e6348a10946d1c53046e5 Reviewed-on: https://chromium-review.googlesource.com/c/1371812 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#615601}
-
Chase Phillips authored
Bug: 717812 Change-Id: I90c36249357705d3a1bc215b8c02278f59993622 Reviewed-on: https://chromium-review.googlesource.com/c/1359862Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615600}
-
Reilly Grant authored
This change: * Switches all remaining SingleThreadTaskRunners to SequencedTaskRunners. * Switches all remaining ThreadCheckers to SequenceCheckers. * Removes shared TaskRunners wherever possible, preferring to use the task scheduler's PostTask() method or creating a dedicated TaskRunner when one is needed. * Renames FileThreadHelpers to BlockingTaskHelpers. * Adds base::ScopedBlockingCall annotations when calling into libusb functions that can potentially block. Change-Id: I538704faf7e668015c509bf2c8a03db6d0522fb3 Reviewed-on: https://chromium-review.googlesource.com/c/1368776Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615599}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I0aa1ad64b28d9f2c919cf0441060f13c4c0d7388 Reviewed-on: https://chromium-review.googlesource.com/c/1371253Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#615598}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f738832a976..3bdc3f5f9c0b git log 4f738832a976..3bdc3f5f9c0b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 bsalomon@google.com Move some Gr headers from include/gpu to include/private and src/gpu. 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2661e8408331..7cfb50cd5f50 (1 commits) 2018-12-11 scroggo@google.com Treat kWEBP encode with quality=100 as lossless 2018-12-11 reed@google.com change convex scan converter to be defensive Created with: gclient setdep -r src/third_party/skia@3bdc3f5f9c0b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899689 TBR=ethannicholas@chromium.org Change-Id: I8654098ad7ea12d70046b041654d0cfddc1d07ee Reviewed-on: https://chromium-review.googlesource.com/c/1372088Reviewed-by:
-
Ryan Hansberry authored
Change-Id: I0c9c61c9671e6cbfebf419f1f148f268d79eb5e4 Reviewed-on: https://chromium-review.googlesource.com/c/1370855Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#615596}
-
Robbie Gibson authored
Bug: 913958 Change-Id: Ib942171d8f94e7b37cb91cdebe52c5e02141917e Reviewed-on: https://chromium-review.googlesource.com/c/1371893 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615595}
-
Yannis Guyon authored
WEBP_REDUCE_SIZE is defined in chromium, disabling WebPPictureCrop() and WebPPictureRescale(), crashing ExtractAndCropOrScale() in fuzz.h. Disable ExtractAndCropOrScale() without returning an error when WEBP_REDUCE_SIZE is defined. BUG=chromium:912455 Change-Id: I10f66de59498f664d7e0603cfd10698fa3f5f114 Reviewed-on: https://chromium-review.googlesource.com/c/1368108 Commit-Queue: Yannis Guyon <yguyon@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#615594}
-
Alexander Hendrich authored
These changes show up as presubmit errors when working on internet_detail_page.js. Bug: none Change-Id: Ie1d3d8fb061f607d47f71fc3345a37c9e4851041 Reviewed-on: https://chromium-review.googlesource.com/c/1371867Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#615593}
-
Arthur Hemery authored
This patch removes deprecated method RenderFrameHostTester::NavigateAndCommitRendererInitiated and its remaining uses in unit tests. Bug: 728571 Change-Id: I6bd3c51a11b0892b9e3e0ebc0f9ea263f27a223d Reviewed-on: https://chromium-review.googlesource.com/c/1369936 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615592}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c8b5fd3f2752..1ec085624fc7 git log c8b5fd3f2752..1ec085624fc7 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 eseckler@google.com Merge "trace writer: Send patches after completing fragmented packet" Created with: gclient setdep -r src/third_party/perfetto@1ec085624fc7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic6abac689f30af8a98120e210957b599be44d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/1372087Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bdff670a66b9..e98d9aa1ef9b git log bdff670a66b9..e98d9aa1ef9b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 yueherngl@google.com flapjack: add board and paladin Created with: gclient setdep -r src/third_party/chromite@e98d9aa1ef9b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I17c3fec3522100def0ec2d29b5d7fd364026d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/1372090Reviewed-by:
-
Jeremy Roman authored
Bug: 736037 Change-Id: Ic43002666a0d33296b86b16400590f43ec628ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1372233Reviewed-by:
-
David 'Digit' Turner authored
This allows --mode=system and --mode=universal (which replaces the obsolete --universal option). BUG=912934 R=jbudorick@chromium.org,benmason@chromium.org,tiborg@chromium.org,agrieve@chromium.org Change-Id: Ibd69369ff5aac5410409534319683f1f5db0f2d1 Reviewed-on: https://chromium-review.googlesource.com/c/1371844 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615588}
-
Theresa authored
BUG=452615 Change-Id: Ibc5b6782c2116ca21435e1afa52f41f5f9dc9ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1371900Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615587}
-
Jérôme Lebel authored
Removing ResponseCookies parameter from GaiaAuthFetcher::DispatchFetchedRequest() Change-Id: Ib63c24d88ea996cbd99f50789492cf0bc9f9d7fd Reviewed-on: https://chromium-review.googlesource.com/c/1371891Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615586}
-
Matt Menke authored
Pooling sockets from independent socket pools together breaks layering assumptions. A later point in time, these pools will also need to wrap lower layer objects than ClientSocketHandles. Bug: 895562 Change-Id: I8235f244048475bcb64bf48b3e15309e8607e85e Reviewed-on: https://chromium-review.googlesource.com/c/1362192 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615585}
-
Rayan Kanso authored
Update BackgroundFetchRegistration idl file to include the new changes in the spec. Bug: 913867 Change-Id: Ie94bc1a064734021e5bd98541d9ab47a4006aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/1371387Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#615584}
-
Alex Clarke authored
Based on the reverted https://crrev.com/c/1361103 but without any policy changes. I feel most of the changes are a net improvement in readability so I'd like to land them anyway. Change-Id: I3a60bfb3e5c6171c915f00afbbeb58ee2da01690 Reviewed-on: https://chromium-review.googlesource.com/c/1371428 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615583}
-
Dominik Röttsches authored
DirectWrite will only ever give us one file - we do not need an implementation for retrieving multiple files per IDWriteFont. In upcoming changes for unique local font matching for src: local(...) @font-face declarations, we need a way to retrieve the ttc index of a matched font. Taking those two aspects into account, refactor AddFontFiles to rely on a new method FontFilePathAndTtcIndex which retrieves path and ttc index for a IDWriteFont. Also move helper methods to anonymous namespace. No functional changes to the DWriteFontProxy mojo interface, which this DWriteFontProxyImpl implements. Implementation mostly moved and restructured, but mostly unchanged and taken from previous code. Bug: 889864 Change-Id: Ida13667533eb338bb62083026ddbb386b8dcf0b2 Reviewed-on: https://chromium-review.googlesource.com/c/1371884 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#615582}
-
Peter Boström authored
This reverts commit 742b8857. Reason for revert: Flaky tests should be fixed in r615470. Bug: chromium:912543, chromium:913135, chromium:913784 Original change's description: > Revert "Disable the new tab-loading animation" > > This reverts commit 355b8185. > > Reason for revert: Made several tests flaky: https://crbug.com/912543 > > Original change's description: > > Disable the new tab-loading animation > > > > Makes sure that a lot of animation-related code is bypassed when the > > new-tab-animation flag is off. This should hopefully fix a couple of > > performance regressions that have not yet been root caused so that they > > don't go out with M72. > > > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > > Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1364212 > > Reviewed-by: Sidney San Martín <sdy@chromium.org> > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614199} > > TBR=pbos@chromium.org,sdy@chromium.org > > Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > Reviewed-on: https://chromium-review.googlesource.com/c/1366359 > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> > Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614440} TBR=jyasskin@chromium.org,pbos@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 Change-Id: I3981455a00f743fae535de4626179dcceab9b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1372236Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615581}
-
Aiden Benner authored
Adds script for refactoring non-static native methods to static native methods using @JCaller and for refactoring static native methods that to use mockable natives. Bug: 898261 Change-Id: I5188a99c55bba028c375a9bf43d029a2c6752b08 Reviewed-on: https://chromium-review.googlesource.com/c/1361782 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
-
David Bokan authored
When a wheel event listener is added or removed on a page, we set each layer as having a WheelEventHandlerRegion equal to the entire bounds of the layer. This happens in Layer::PushPropertiesTo. This means that when an event listener is changed, we need to cause all layers to need a push properties and commit. Prior to this CL, this happens in LayerTreeHost::SetEventListenerProperties by setting SetNeedsFullTreeSync and SetSubtreePropertyChanged. However, as noted by surrounding comments, this looks wrong; SetNeedsFullTreeSync only causes the tree structure to be synced, properties aren't pushed. SetSubtreePropertyChanged causes a property sync only on the root layer. This works prior to BGPT because SetNeedsFullTreeSync causes a property tree rebuild during which all layers are marked as needing a property push. See PropertyTreeBuilderContext::BuildPropertyTreesInternal which calls SetLayerPropertyTreeChangedForChild for all child layers as the tree is built. When BGPT is turned on, property trees are built in Blink independent of the layer tree so this doesn't cause us to SetNeedsPushProperties. This CL fixes SetEventListenerProperties to set the correct flags to propagate the listener state to the active tree. This CL fixes: PointerLockBrowserTest.PointerLockWheelEventRouting TouchpadPinchBrowserTest.WheelListenerAllowingPinch/0 TouchpadPinchBrowserTest.WheelListenerAllowingPinch/1 With BGPT turned on. Bug: 912334,881011 Change-Id: I4446ccfd32de12e618219e5fa15c48f5093bcc98 Reviewed-on: https://chromium-review.googlesource.com/c/1369059Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e011cb742d99..7025535b4bb4 git log e011cb742d99..7025535b4bb4 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d5698f68..573be063 (615355:615506) 2018-12-11 andersc@webrtc.org Fix header import in broadcast extension. 2018-12-11 terelius@webrtc.org Print media types for streams using the new event log format. 2018-12-11 saza@webrtc.org Change the type of indW32 back to int32_t Created with: gclient setdep -r src/third_party/webrtc@7025535b4bb4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:906379 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0780646df3dae1ae436f82e3cfe3f897ec48ca41 Reviewed-on: https://chromium-review.googlesource.com/c/1372086Reviewed-by:
-
Ben Pastene authored
Will watch for cycle time increases on the CQ bot: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/mac_chromium_compile_dbg_ng R=dpranke, erikchen, jbudorick Bug: 910227 Change-Id: I73f6e5cc18e707aebe6689034a734ee96fbaa97b Reviewed-on: https://chromium-review.googlesource.com/c/1370949Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#615577}
-
Dominik Röttsches authored
These switches were used in an trial to figure out whether they help with the Windows empty font handle issues. These trials have now been expired without the intended results and are no longer used. Bug: 889864 Change-Id: I9ed1376d989b59a71e325cd54604faeaae71a5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1371807Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#615576}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf020164. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I640242d27bf5607e8fe5aa25bbddfcbfe5c2eb43 Reviewed-on: https://chromium-review.googlesource.com/c/1372228Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615575}
-
Gabriel Marin authored
Add MetricCollector, a baseline class for collectors. It implements the common functionality for a collector and the interaction between the various defined triggers. The majority of the implementation is copied from the PerfProvider class. The unit tests are mostly new. Added rules to compile the class and the associated unit tests, but the code will not be used in prod until a later CL that adds a perf events collector to replace PerfProvider. BUG=b:116527691 TEST=Unit tests pass Change-Id: Ia4053f0a70a2db2c4c5bf12ca9a9817a310ffad9 Reviewed-on: https://chromium-review.googlesource.com/c/1357598Reviewed-by:
-
Florin Malita authored
AddArc and AddEllipse take an "anticlockwise" parameter, which is no longer used. Remove the args and hoist related DCHECKs into CanvasPath's AdjustEndAngle (where the actual adjustment is applied). Change-Id: I445379021635b1a6d3fa35c36e9bae6a2563a66b Reviewed-on: https://chromium-review.googlesource.com/c/1366441 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#615573}
-
Linwan Song authored
This change links tile raster tasks to the tile manager that initiated them. Tile managers are in turn linked to a frame, which is processed by telemetry later on to determine the time difference between when raster tasks start to when the compositor frame is submitted. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I876a029f6db1e664aafe945fcdd629da3bdc681e Bug: 912730 Reviewed-on: https://chromium-review.googlesource.com/c/1286889 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#615572}
-
Miguel Casas-Sanchez authored
This CL reduces the amount of PictureBuffers requested to be allocated by the |client_| when we are not |decode_using_client_picture_buffers_|. Instead, it "splits" the requested allocations into - the actual needed PictureBuffers (A) - the codec's requested reference frames (B) (a new method GetNumReferenceFrames() is added to AcceleratedVideoDecoder for this). This splitting saves a lot of memory, since we allocate A+B buffers instead of 2*(A+B). (B is 5 and A is 4-VP8, 4-12 H264/VP9) Test: crosvideo changing resolutions for each codec, v_d_a_unittest on nocturne (KBL) and caroline (SKL). Bug: 909926 Change-Id: I1fce92863beddce0e8b221861cf156b9c3ad0c0f Reviewed-on: https://chromium-review.googlesource.com/c/1363807Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615571}
-
ccameron authored
This reverts commit 00c1b7ab. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness." > > This reverts commit 0c873bf2. > > Reason for revert: Fix for flake in crrev.com/615269 > > Original change's description: > > [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness. > > > > Tbr: ccameron@chromium.org > > Bug: 913490 > > Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f > > Reviewed-on: https://chromium-review.googlesource.com/c/1369721 > > Commit-Queue: Samuel Huang <huangs@chromium.org> > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#615159} > > TBR=huangs@chromium.org,ccameron@chromium.org > > Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 913490 > Reviewed-on: https://chromium-review.googlesource.com/c/1370571 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615274} TBR=huangs@chromium.org,ccameron@chromium.org Change-Id: I72829b7b404a571095123f2ffd028ff189563ee8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913490 Reviewed-on: https://chromium-review.googlesource.com/c/1371931Reviewed-by:
-
Marc Treib authored
This test covers initial sync, i.e. when there are pre-existing autofill profiles at the time Sync is turned on. Bug: 904390 Change-Id: I7c7f32f9ceb754c5d517a8e182eca6415a2abc61 Reviewed-on: https://chromium-review.googlesource.com/c/1371845 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615569}
-
