GitLab

TBR=benmason@chromium.org

Change-Id: Iea73037b57d034780b936de8aa51439fbcae834d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519539Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824089}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62e571e6bb4c..46498235efc5

2020-11-04 tvanderlippe@chromium.org Typecheck timeline/TimelineEventOverview.js with TypeScript
2020-11-04 tvanderlippe@chromium.org Typecheck timeline/TimelinePanel.js with TypeScript
2020-11-04 tvanderlippe@chromium.org Revert "Add setting for record network log action"
2020-11-04 alcastano@google.com Fix double escaping in Markdown renderer
2020-11-04 sigurds@chromium.org Update browser_protocol.pdl
2020-11-04 andoli@chromium.org Fixes dragging of the first column of a data grid by resizing
2020-11-04 sigurds@chromium.org Don't show all columns in network panel
2020-11-04 szuend@chromium.org Update TypeScript to 4.1.1-rc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1122580,chromium:1138302,chromium:1139899,chromium:1144720,chromium:1145150,chromium:1145510
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8929d2de0dbc0433b0693d6ba735303a623de5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824088}

Part 1 of enabling closure compiler for scanning browser tests. Focusing on enabling and making sure it compiles, without optimization to tests themselves.

Intentionally omits registration to the main target webui:closure_compile (to be enabled later).

Bug: 1059779
Test: browser_tests --gtest_filter=Scanning* && autoninja -C ${out} chrome/test/data/webui:closure_compile
Change-Id: I2919208ffe58ff422dcc675a40dfd9a8fe573246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511758
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824087}

This change guarantees that each browser has appropriate profile with
the same index in SyncTest.

Bug: None.
Change-Id: I5acbacf2b0c4e6b609ce6861f634e31709bcc076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519451Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#824086}

This reverts commit bf110115.

Reason for revert: Looks like a9eaeb80 in the GN roll broke incremental rebuilds. crbug.com/gn/215.

Original change's description:
> Reland "Roll GN from e002e68a..f5f465b5"
>
> This reverts commit f89a9f12.
>
> Reason for revert: Whoops. I was wrong, and I think the src-internal roll *has* landed.
>
> Original change's description:
> > Revert "Roll GN from e002e68a..f5f465b5"
> >
> > This reverts commit 7ba203c1.
> >
> > Reason for revert: reverting since the src-internal roll hasn't landed yet.
> >
> > Original change's description:
> > > Roll GN from e002e68a..f5f465b5
> > >
> > > Generated by //tools/gn/roll_gn.py
> > >
> > > https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5
> > >
> > >     f5f465b5 Fix runtime_deps for elided targets
> > >     3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr.
> > >     ad0a7ada Remove support for set_sources_assignment_filter function
> > >     e1ac69b1 Add a command line to define/overwrite "root" in ".gn"
> > >     7b2a04d5 VS: Use most recently installed Windows 10 SDK.
> > >     132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up."
> > >     3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules
> > >     4323e701 gn recipe: Link GN with rpmalloc to speed it up.
> > >     c808630c Move runtime_deps file for phony targets to /obj
> > >     8855c522 Update Clang and Xcode SDK to 12B5025f
> > >     76f9b6ad Use fetch instead of cherry-pick for Gerrit changes
> > >     a3d69e87 Don't return if package is up-to-date
> > >     36ff17cb Switch back to the older Clang version
> > >     7bcc0eb3 Revert "Update Xcode SDK to 12B5025f"
> > >     e5f1f587 Update Xcode SDK to 12B5025f
> > >     6453c5de Support cross-compiling GN for other targets
> > >     42d6de6e Don't classify Rust static libraries as final
> > >     a9eaeb80 Switch remaining stamp targets to phony targets
> > >     ff45cf2a Show config.visibility in `gn desc`
> > >     de5a8348 [rust project] removing obsolete std libraries
> > >     4c684398 Fix "gn outputs" for bundle data.
> > >     99f72f88 Switch source_set stamp targets to phony targets
> > >     5233fa13 Remove extra * in gn output docs
> > >
> > > As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate
> > > steps in the build graph have been replaced with phony aliases. As a
> > > result, this CL also updates the MB tool to look for ".runtime_deps"
> > > files instead of ".stamp.runtime_deps".
> > >
> > > This is a reland of 7f3e4855
> > >
> > > Change-Id: I5bf18f1529b0969b8c79d768e9b3f377b8dee8cb
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514460
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#823725}
> >
> > TBR=dpranke@google.com,rjascani@google.com
> >
> > Change-Id: Iebf4e78bd9e7550de3b025a997d4f792c3f80b1b
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518755
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#823727}
>
> TBR=dpranke@google.com,rjascani@google.com
>
> # Not skipping CQ checks because this is a reland.
>
> Change-Id: I86d184461002eacaf42a96f1ea8901269ff7e856
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518093
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#823791}

TBR=dpranke@google.com,rjascani@google.com

Change-Id: Ib179abfd84e9cc7647f1e1fb8737038215af1652
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519838Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#824085}

This suite was useful when we were first spinning up tests on CrOS, as
it provides a smoke check of the browser.

Since then, we've also integrated Tast tests. And as more Tast tests
have been written, they've grown to provide coverage of everything that
the sanity test provided. (eg: tests like ui.ChromeLogin check the
browser's log in flow, arc.* tests cover ARC functionality.)

These days, you'll never see the sanity test fail without also seeing
at least one Tast test failing.

Bug: None
Change-Id: I2a7db54bec15eac7bf909970cdf21946a306817b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518661
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#824084}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011040600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/_hGheFl2oO5agp6bFXl5GHcbq1dU78G_xuIV8hCSitQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/170172788,b/172180702
Tbr: media-app@grotations.appspotmail.com
Change-Id: I9fe8b4b7c1a1d6fe9b19f774cf07bb9cb07e5e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519654Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824083}

This CL removes the flag gating layer masking for ClientViews of
dialogs and bubbles.

With this change dialogs and bubbles can use layer masking to
apply the appropriate clip to their ClientViews. Bubbles can opt into
layer masking by calling SetPaintClientToLayer(true).

The kEnableMDRoundedCornersOnDialogs flag continues to gate the
increased corner radius of bubbles and dialogs used in Chrome.

Bug: None
Change-Id: I4559ced170fa56b6b8974f4d9b2bd689668cbac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490666
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824082}

This patch adds one metrics to record the number of times
the task run for completing a capture.

It also replaces CaptureContentTime to CaptureContentTime2.

Bug: 1137463
Change-Id: I34199438353f14beffa20976ebafb3240fd6566f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515143
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824081}

This CL cleans and removes EnablePersistentDownloads &
OpenDownloadsInFilesApp flag.

Bug: 1136795
Change-Id: Id07e40ae59f9caa2a60fcb2ce7835b7504eb85b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460897
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824080}

This CL makes sure that the message sent at the end of the restoration
is only added if a session restoration is in progress. It is also making
sure to remove the script once the restoration is complete.

Fixed: 1127521
Change-Id: Ie70be6a9233c540e6a4c6a05531eb1f5b1b1e206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463824Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824079}

As part of the Flash/Plugins deprecation, the resource identifier
becomes obsolete. This CL removes resource_identifier from the
HostContentSettingsMap private methods only.

The rest methods API will be cleaned separately.

Bug: 1134547
Change-Id: Id74420f86abcd91b034af1eb040f09d1d95d456f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517587Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Illia Klimov <elklm@google.com>
Auto-Submit: Illia Klimov <elklm@google.com>
Cr-Commit-Position: refs/heads/master@{#824078}

This CL refactors chrome_web_contents_view_handle_drop_unittest.cc to
use Connector policies directly instead of using the indirect helpers
that map to legacies policies.

Bug: 1109242
Change-Id: I343f5e2270ebc7c77606fcb23b168cf76c1173d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518035Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824077}

As above. This passes a WritingDirectionMode into the constraint space
builder, instead of the WritingMode, and Direction independently.

This removes the SetTextDirection api now.

There might be some slight (positive) behaviour change as a few call
sites were missing SetTextDirection previously.

Bug: 1091797
Change-Id: I57f0b664fa327866b8b76fbbe5d0b5e08c29aaa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519715Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824076}

HID peripherals may provide a product name string. When a device
has no product name string or the string is empty, generate a
placeholder string based on the vendor and product IDs. This
allows the device to be identified in permissions contexts.

BUG=1126182

Change-Id: I756f2a5d3bd8519fd4aa7855afb5b2ac8b3f6114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487724
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824075}

Bug: 897796
Change-Id: Iec9b4bf8fbf4626c3bb54be144904b300d438a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517639Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824074}

Fixed: 1066090
Change-Id: If351197bddae9eae2a0cef42cf01d6ad8a01412b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517705
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824073}

We are seeing some pretty bad pop-in sometimes. Try to more eagerly request bitmaps.

Change-Id: I4fb249a4b72b4f9034df15c5d4ef4ba0ef0a01aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519577
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824072}

Adds a simple test to ensure that Sync settings is on when Sync is
enabled in the sign-in flow.

Bug: 1145188
Change-Id: I3f705030a5b2af9b0a31734a372bed7f2de20f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517463
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824071}

https://swiftshader.googlesource.com/SwiftShader.git/+log/19f01495a8a1..419b7d7bd164

2020-11-04 capn@google.com Fix unaligned access on depth values

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I055f310e6f8b256e3181b72a7d60d50742448dbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519576Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824070}

We found that erasing from the weak container worklist caused timeouts
in some blink_perf benchmarks. The erase operation was meant to avoid
retracing the same backing store multiple times (an iterator to a hash
table would result in at least 2 on-stack references to the backing
store). Instead of erasing, this CL pushes retraced backing stores to
a vector. Backing stores are retraced only if they are not yet in the
vector. Thus iterators should trigger only a single retracing of the
backing store.
The vector is limited in size to avoid making it uncontrollably large.
That means it is possible to retrace the same backing store multiple
times if it was already ejected from the backing store. However this is
very unlikely in practice.

Drive-by: re-enable skipped tests.

Bug: 1142315
Change-Id: I49bd30263db46e66293d046b85699826298aa033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516363Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824069}

Adds a static method to XRRuntimeManager to return the web contents
displayed in an active WebXR session, if any. This is used to not hide
WebContents when occluded, if a session is active on the WebContents.

Bug: 1139083
Change-Id: I5ffecbdad2003c2957f9f566fc8fbd8b6ac624a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510349Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824068}

This CL moved respondCanMakePaymentQuery() and
respondHasEnrolledInstrumentQuery() into PaymentRequestService.

Bug: 1144527

Change-Id: Idd33310232c6ca46865bd4ff6e0c4100b29f4fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515133Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824067}

This moves a bunch of methods from WebViewImpl into WebViewFrameWidget.
This now makes the WebFrameWidgetBase is now a PageWidgetEventHandler
so that we can share common code in the base class. In follow up CLs
duplicate code in WebFrameWidgetImpl will be removed.

BUG=1097816

Change-Id: I3bf9610f6eb8ce6b5bd36c5db9b374ff5d100be3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518127
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824066}

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517500
has been submitted.

R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I247d3dcba9e1bab20c031237ae2b7950bea230e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519453
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824065}

When ClipboardHistory tries to check whether clipboard
data read is allowed, no notification should be shown
because this action isn't triggered by the user.

Bug: 
Change-Id: If9d82fb92660a322c35a276454ff0d6be1a7fcda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514212Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824064}

Migrate uses of the relevant set_* functions on the sql::Database object
to use the new DatabaseOptions constructor instead.

This change should have no intended behavioral effect.

Bug: 1126968
Change-Id: I3b3983f2fdd9eb9f7d66283aa5fbe0363aa8fe7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505674Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#824063}

R=pkasting@chromium.org

Bug: 1145347
Change-Id: Iac5603761900d5e006db6d78064c281b65fa779f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519805
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Stephen Lin <stephenlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824062}

Bug: 1145384
Change-Id: I5eb7f1a9599eefe4e7cd0e6992f1322c4b6a5db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518248Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824061}

Chrome crashes when the tab drag session is cancelled (ie: pressing esc)
in attached mode. The crash happens because a use-after-free in
ExtendedDragSource's destructor, when attempting to notify registered
observers about its destruction.

More specifically, the issue happens because DragDropOperation instance
doesn't remove itself from the extended drag source's observers list
when it's destroyed in response to a session cancellation. This patch
fixes it and, additionally, cleans up how DragDropOperation access to
the extended drag source instance is done, by associating it with its
seat instead of the data source, simplifying code handling (ext-)source
destruction, etc.

R=oshima@chromium.org

Bug: 1099418
Change-Id: I265379fb0aed0742674d3dcd97815b1cffdc709f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514360
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824060}

Refactors disconnectIfNoPaymentMethodsSupported() so that:
* it becomes ready to be moved into PRService,
* hasAvailableApps() becomes ready to be delegated through BrowserPR
* disconnectForStrictShow() becomes ready to be delegated through
  BrowserPR

Bug: 1144527

Change-Id: I4dab80acf293fc332729970e546a5c059b8c9e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515522Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824059}

This CL add unit tests that tests all different scenarios that the
PSM can encounter. That doesn't include tests for PSM + hash dance.

See go/cros-psm-client-unittests-coverage for an overview of the
test cases for the different cases.

BUG=chromium:1136866

Change-Id: I69d16af68fecde5212f362f84ed5bbcb05a971e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461343
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Roland Bock <rbock@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824058}

Roll Chrome Win64 PGO profile from chrome-win64-master-1604447854-94cc190ab0ce9114e706f7027e39b9e22ef628e2.profdata to chrome-win64-master-1604480374-c14bff331808fa9a4e787bbbdb6a7c4b82678afd.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ida011a017387f5d96c1d7163687503a4d8814a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824057}

This CL removes the WebComponentsV0 feature added in [1] for
WebView. This was a temporary feature, to enable developers to
control these features starting in M86, because a Finch config
began disabling M86 Web Components for all users. Now that M86
(and M87) are out of Dev, this CL removes this feature flag
completely.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2268544

Bug: 1021631, 1021631
Change-Id: Ie6d14040105f2a239b8f95caae88a95d1da1f7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514590Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824056}

Implement italic correction [1] when laying out scripts. In order to
signal that an operator has an italic correction we add
SetMathItalicCorrection on the fragment builder and set it if
needed when laying out the operator. The script layout algorithm
uses this value when laying out the script, where appropriate.

[1] https://mathml-refresh.github.io/mathml-core/#dfn-italic-correction
Bug: 1125136, 6606

Change-Id: I2995b0fad1e1c8e96cc08818d50927d28cb54f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414240Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#824055}

Updates imports in chrome/browser/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: I13e7a3352607cf4ec907a8a5ec1b99a827ce85af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518133
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824054}

Ran `./tools/clang/scripts/upload_revision.py c9f69ee7`.

Disable ArcDataSnapshotdManagerBasicTest.RestoredAfterCrash under msan
since it has uninitialized memory accesses that the new compiler
identifies (https://crbug.com/1144452)

Bug: 1126953,1144452
Change-Id: I8e526de19b723ac7a4b5ca36c511d70378b7f68f
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:win64-chrome,mac-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518420
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824053}

Updates imports in chrome/android/features/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: Iff732b193bc6da12aa7b9c4e39aba032989f1fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518215
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824052}

This CL adds support for VideoFrame.createImageBitmap() for frames that
are PIXEL_FORMAT_XRGB. This includes all frames produces by VDAs that
are configured to request PIXEL_FORMAT_UNKNOWN, such as DXVA VDA in its
FP16 mode.

Bug: 1145292
Change-Id: I853c6b92d84ffdc3f678f62e9407f8ee53efe683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518112Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824051}

Bug: 1139194
Change-Id: If4fb560c5be11a613830ab76b2b9908904c882eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490022Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com>
Cr-Commit-Position: refs/heads/master@{#824050}