GitLab

Before this patch, the browser identification contained the version number as well (which happens to be the last directory of the path). This patch strips that directory so that the identification stays stable after upgrades.

Change-Id: I11b3b37c37f01eb07d8003174ecf5c80da1ba718
Reviewed-on: https://chromium-review.googlesource.com/1028663Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553807}

Invoke GetDeviceList permission check rather than treat as it is always
granted to apps.

Bug: b/78231419
Test: Manual
Change-Id: I838c00fd2d87719c8e9e8d5c9194144a279c0eca
Reviewed-on: https://chromium-review.googlesource.com/1014602Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#553806}

Start the scroll from the middle of the screen incase the default bottom of the
screen is obscured by the bottom toolbar and stop using kGREYContentEdgeBottom.

BUG: 825431
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I704954672bf46e9cb138ea0be6a325ba4aeb3d69
Reviewed-on: https://chromium-review.googlesource.com/1028462Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553805}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=hubbe@chromium.org

Bug: 825327
Change-Id: Ifccb0682900e0015ef59bed96592d03275217e24
Reviewed-on: https://chromium-review.googlesource.com/1024663Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553804}

Bug: 824970
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5adf0dc043bb6e3683f013036f1c42eb7364f016
Reviewed-on: https://chromium-review.googlesource.com/1017322
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553803}

This test is flaky on android when viz hit testing is enabled.

Bug: 835058
Change-Id: Ia746468e3595806ca01df494c95fc97ab2927602
Reviewed-on: https://chromium-review.googlesource.com/1028975Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553802}

We are moving find-in-page related functions out of
web_local_frame_impl_find_in_page.cc to its own class
(FindInPage) for easier mojoification and so that we can add
new find-in-page related functions more easily.

In this CL, we are moving functions out of
web_local_frame_impl_find_in_page.cc. In the next CL we are going to
entirely remove the functions from the WebLocalFrame interface.

Previous CLs:
crrev.com/c/956648
crrev.com/c/1025242

Next CLs:
Remove find-in-page functions from WebLocalFrame
Introduce FindInPage mojo interface

Bug: 819919
Change-Id: Ia82b5e8f1e08701b014236039d2c6e5e45410222
Reviewed-on: https://chromium-review.googlesource.com/1027013
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553801}

This is a reland of 4f376c3e

Original change's description:
> Convert xml_parser.mojom to use mojo/public/mojom/base/values.mojom
> 
> This change also converts the minimum necessary amount of C++ code to pass
> objects of base::Value by value instead of std::unique_ptr.
> 
> Bug: 646113,799482
> Change-Id: I86dcd6b4cfbb061942cb73f6ffddcf9e712f355f
> Reviewed-on: https://chromium-review.googlesource.com/1012931
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551470}

Bug: 646113, 799482
Change-Id: I54fdbc1cfd23f7065673a78c2e8e1376717baf62
Reviewed-on: https://chromium-review.googlesource.com/1026471Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553800}

https://chromium.googlesource.com/angle/angle.git/+log/10434f67672d..23dc90b81efb

$ git log 10434f676..23dc90b81 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 lfy GLES1: Enable/disable for texture targets
2018-04-25 oetuaho Handle negative float to uint conversion robustly
2018-04-24 lucferron Vulkan: Enable UnpackAlignmentTest and remove useless warning.
2018-04-24 lucferron Vulkan: Fix issue with texsubimage2d barriers
2018-04-25 jmadill Clean up DEPS style.

Created with:
  roll-dep src/third_party/angle
BUG=chromium:835868,chromium:782846


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I7ff0b0ad560ed9fadcce00db4c136232330826c9
Reviewed-on: https://chromium-review.googlesource.com/1028521
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553799}

It is still flaky:

https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.chromiumos%2Flinux-chromeos-rel%2F109818%2F%2B%2Frecipes%2Fsteps%2Fmash_browser_tests__with_patch_%2F0%2Fstdout

Bug: 832981
Change-Id: Idd9646c0bfe7ebec3c1ff9068c39d11ba02faf67
Reviewed-on: https://chromium-review.googlesource.com/1028730
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553798}

Currently, IsCreditCardVerificationPasswordField creates a static
string16 object. That involves a static destructor, which is forbidden
by the style guide:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

This CL fixes that by using base::NoDestructor. It also restructures the
function slightly.

There should be no visible change caused by this CL.

Bug: 833838
Change-Id: Id879c5595113aae295e858bebf6cacc7f211b373
Reviewed-on: https://chromium-review.googlesource.com/1028272
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553797}

Rename ResourceDispatcherHostBrowserTest to LoaderBrowserTest since these tests aren't specific to RDH.

This is a follow-up to r553717.

Bug: 787614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id0fc9c7e8314cfb97ca499b9161471f9850d3f9a
Reviewed-on: https://chromium-review.googlesource.com/1028520
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553796}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=jochen@chromium.org

Bug: 825327
Change-Id: I2900d3ff9c29bb0044ec7d7d8351f5369522a0df
Reviewed-on: https://chromium-review.googlesource.com/1024653Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553795}

If a line break is introduced implicitly, i.e. because there is one block layout node next to the other, there would be two leaf positions:
One is at the end of the first layout node at the end of the line and the other at the beginning of the second block node at the start of the next line.
Both positions will have a downstream affinity, because there is no ambiguity as to which position is at the end vs. the start of the line.
However, when computing the parent equivalent position, and since there is no line break in the text of the parent, affinity will need to be computed on the browser side.
Also, I made some fixes which maintain predictability as to which affinity will be assigned to computed positions, regardless of the input position.

R=dmazzoni@chromium.org

Bug: 831179
Change-Id: I425223bee1f53654ddaaa045a375c6da0367b7a8
Tested: Unit tests
Reviewed-on: https://chromium-review.googlesource.com/1028181Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553794}

Now that last committed URLs are tracked on RFH instead of
FrameTreeNode, there's no harm in keeping this URL around after a RFH
becomes pending deletion.  Keeping it might be useful for security
checks on such RFHs, and not keeping it might actually lead to
correctness issues when last committed URLs are checked for pending
delete RFHs.

Bug: 836211
Change-Id: I2090732bd1f1583430e2eafcf732965f43e00c44
Reviewed-on: https://chromium-review.googlesource.com/1026971
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553793}

Creates the browser-side implementation of the SessionStorageNamespace
mojo interface. The namespace holds the per-origin storage area and
provides ways to both connect to the data and shallow-clone the data.

TBR: jam@chromium.org for content/browser/BUILD.gn
Bug: 716490
Change-Id: I9df5812afdacf4330728c590d47ecfdf93e320bd
Reviewed-on: https://chromium-review.googlesource.com/1015894
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553792}

unprefixed versions of the "grab" and "grabbing" CSS cursors
were not supported at blink.

Bug: 708197
Change-Id: I4d4b7e61884bc565526fb92374e40c9dc7ec36a6
Reviewed-on: https://chromium-review.googlesource.com/1012047
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553791}

This is an issue that happens in Flexbox and Grid Layout
and any other layout method that uses OverrideLogicalHeight.
In LayoutBox::PerpendicularContainingBlockLogicalHeight()
we were returning the OverrideContentLogicalHeight() plus
the scrollbar height.
That caused issue with orthogonal flows between flex/grid items
and their children.

The issue is fixed just following the suggestion in the TODO
and using OverrideContentLogicalHeight()
(which doesn't include the scrollbar height).

BUG=836827
TEST=external/wpt/css/css-flexbox/percentage-size-subitems-001.html
TEST=external/wpt/css/css-grid/grid-items/percentage-size-subitems-001.html

Change-Id: I0c7586449067aab78430defc831b2774136e2f0b
Reviewed-on: https://chromium-review.googlesource.com/1028012
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#553790}

|PopupTouchHandleDrawable| is reacting to both native and Java for its
visibility. When WebView is moved under other window/view, Java side
will hide the handles and set their visiblity to |INVISIBLE|.

Previously, Java setOrigin() only do invalidation when the view is
visible, but if we do a selection and move the selection to under other
window, and then do another selection, the visiblity will be preserved,
so handles are not showing again. Native treated the second selection as
selection handles moved event, there is no need to update the visibility
from native's perspective.

We should scheduleInvalidate() when native thinks the handle should be
visible, scheduleInvalidate() will calculate the real visiblitiy against
the current view hierarchy and do invalidation if necessary.

Bug: 808701
Change-Id: I50dfa80d0299fd4692abba2c33b8a335bd455372
Reviewed-on: https://chromium-review.googlesource.com/1026834Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553789}

Marks common callbacks that produce no JS-observable side-effect,
including
- window.window
- window.location
- location.href
- navigator.userAgent

Bug: 829571
Change-Id: I9404104dc2cd30ffeafbfae83c53c0176a28e1b1
Reviewed-on: https://chromium-review.googlesource.com/1026991
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553788}

Bug: 754892
Change-Id: I423630306e0a83cc02a78e4b0e1f99f908bfc24e
Reviewed-on: https://chromium-review.googlesource.com/1022812Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553787}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/26ad1acbcb4c..2157d8fa6f7e

$ git log 26ad1acbc..2157d8fa6 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 bungeman [base] Avoid undefined behaviour in lcd filtering code (#53727).
2018-04-22 wl * src/base/ftoutln.c (FT_Outline_Decompose): Improve error tracing.
2018-04-22 apodtele [base] Fix bitmap emboldening.
2018-04-22 wl Revert "[base] Fix bitmap copying where the new pitch is smaller."
2018-04-22 wl [base] Fix bitmap copying where the new pitch is smaller.
2018-04-22 wl Another fix for handling invalid format 2 cmaps.
2018-04-19 apodtele Documentation tweaks.
2018-04-19 wl [autofit] Add support for Georgian Mtavruli characters.
2018-04-19 wl Fix handling of invalid format 2 cmaps.
2018-04-17 wl [truetype] Integer overflow issues.
2018-04-16 wl CHANGES: Mention CVE-2018-6942.
2018-04-16 wl [truetype] Integer overflow issues.
2018-04-15 ankit97dhankhar [docmaker] Make it work with python3.
2018-04-15 apodtele [build] Use `info' function of make 3.81.
2018-04-15 wl [truetype]: Limit `SLOOP' bytecode argument to 16 bits.
2018-04-14 wl [truetype] Integer overflow issues.
2018-04-14 wl [autofit] Update to Unicode 11.0.0.
2018-04-07 madigens Modernize CMake build.
2018-04-09 wl [truetype] Integer overflow issues.
2018-04-06 apodtele [windows, wince] Clean up legacy project files.
2018-04-04 wl [cff, type1] Sanitize `BlueFuzz' and `BlueShift'.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org
BUG=chromium:834853
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1070
ChromiumOS-Issue: chromium:836302
Change-Id: Ibd486fc3983625a7a621ffd0680118c9794585ac
Reviewed-on: https://chromium-review.googlesource.com/1025069Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553786}

As hashing function is used frequently in converting parsing device
response, add CreateSHA256Hash() to fido_parsing_utils scope.

Bug: 798573
Change-Id: Ifc6ed40db6aca682548a75068701f6c0af7cfdce
Reviewed-on: https://chromium-review.googlesource.com/1024924
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553785}

https://chromium.googlesource.com/catapult.git/+log/55650fadabf7..d43ffede2b5c

$ git log 55650fada..d43ffede2 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 simonhatch Dashboard - Clean up some histogram tests to use _CreateHistogram
2018-04-23 simonhatch Dashboard - Move Row._pre_put_hook contents to UpdateParentAsync()

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I0d2db24d9ce4f3261c7e1a318857bed95c47cbd1
Reviewed-on: https://chromium-review.googlesource.com/1028557Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553784}

MRUIService is instantiated at startup to show the Cast toolbar icon.
This CL prevents that if the Media Router feature is disabled.

Bug: 834719
Change-Id: I02fdecb1ca50940c2311d6491698764bc6275ec1
Reviewed-on: https://chromium-review.googlesource.com/1026975Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553783}

Since the surfaceless renderers inherit the surface renderers, we
actually initially post two tasks to render frame. This results in
tearing.

Remove the duplicate post. As a followup, this inheritance should
be removed since it is too error prone.

Bug: 836971
Test: ozone_demo on eve
Change-Id: If79edf65f6aba2cc239f0e349860d6b56ba82450
Reviewed-on: https://chromium-review.googlesource.com/1028844Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553782}

To make it possible to write a test client without having to write too
many empty implementations.

Change-Id: I45139957848a4d48e02740cc349605ab4b75e3a0
Reviewed-on: https://chromium-review.googlesource.com/1013997
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553781}

This if-stmt is now invalid as inside the NGExclusionSpace there is
always at least one opportunity which has a block-end offset of
LayoutUnit::Max().

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4ca866e38b4aa764b3181c59e642e2a5be422a55
Reviewed-on: https://chromium-review.googlesource.com/1028351Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553780}

This CL allows this test to toggle SetShouldNotRequireCTForTesting.

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I31108cbbec240660c87209f65be067a0b30c9339
Reviewed-on: https://chromium-review.googlesource.com/999099Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553779}

RenderWidgetHostInputEventRouter sends all pinch gesture event to root
frame, but this might be a problem when the subframe has touch action
restrictions.

To avoid allowing pinch zoom when the target element in the subframe has
touch-action:none property, this CL makes RWHIER checks the target frame
and drop the event if touch action filter rejects the pinch.

Bug: 827182
Change-Id: Ifa566446e8c695d934aad4bcaaef49af0cde76e2
Reviewed-on: https://chromium-review.googlesource.com/1007892Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553778}

  unitlessZeroFeature -> unitless_zero_feature
  negativeSize -> negative_size
  threeValuePosition -> three_value_position

Change-Id: Id42906e518e6780bfa601031d8ad00430b2f48b4
Reviewed-on: https://chromium-review.googlesource.com/1027878
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553777}

This is a reland of be8138a4
The issues with the previous attempt were addressed in the latest
Clang roll (#553415).

Original change's description:
> win: Link with lld instead of MSVC's link.exe by default
>
> lld is LLVM's linker. It produces PE/COFF and PDB files just like
> link.exe, but it's significantly faster and it can also handle LLVM's
> internal representation, which will enable us to do link-time
> optimization and control-flow integraty checks with Clang.
>
> While lld is much faster at linking, it doesn't support incremental
> links, meaning builds that only touch a few files and re-link a large
> executable may become slower.
>
> This is the first attempt at switching everything over, with the
> purpose of gathering data and finding unknown unknowns. It's likely
> temporary until something breaks.
>
> is_win_fastlink is implicitly ignored when using lld, as lld without
> fastlink is faster than link.exe with it.
>
> Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> link.exe to make sure that configuration keeps working.
>
> Bug: 792131
> Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d
> Reviewed-on: https://chromium-review.googlesource.com/983632
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551367}

Bug: 792131
Change-Id: I3b76cd015ef18bb3e2ac7a3efa4352c4f04e560b
Reviewed-on: https://chromium-review.googlesource.com/1028374Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553776}

Some apps roll their own intent dispatching code, and their intent
dispatching code is incorrect, so they end up erroneously firing 2D
intents explicitly to the VR launcher.

If either the intent doesn't have the Daydream category, or the system
isn't in a VR session (meaning launchInVr definitely wasn't used),
retarget the intent back to the 2D launcher.

Tested on a local Chrome dev build, verified it fixes b/78239314 too.

Bug: 836209
Change-Id: I779c7bf3820ddd50650eb6752d720246a86d24b1
Reviewed-on: https://chromium-review.googlesource.com/1028572
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553775}

Bug: 817377
Change-Id: I5eb7768bdd8e20b5841de3cf56f6f8ed47ec6922
Reviewed-on: https://chromium-review.googlesource.com/1020062Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553774}

This CL adds two metrics in drm_util.cc:

- DrmUtil.CreateDisplaySnapshot.HasEdidBlob (boolean): to detect whether an EDID
blob is detected in the CreateDisplaySnapshot function. There are no
existing unit tests for this function, so no tests are added for this metric.

- DrmUtil.GetColorSpaceFromEdid.ChecksOutcome (histogram): to detect
whether the sanity checks pass in the GetColorSpaceFromEdid function (or
which one fails). Existing unit tests are modified to test this metric.

Also, some unused includes are removed from drm_util_unittest.cc.

Bug: 829506
Change-Id: Ib1cfc14577630e6649640da9b0a0b663a36296d5
Reviewed-on: https://chromium-review.googlesource.com/1014522
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553773}

This change also converts the minimum necessary amount of C++ code to pass
objects of base::Value by value instead of std::unique_ptr.

Bug: 646113,799482
Change-Id: Iebebef972fc8e503c030639c8aefa0909bfcdbf9
Reviewed-on: https://chromium-review.googlesource.com/1024286
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553772}

Include in-product help to let users know that there is the option to
change download storage location through the download settings option in
downloads home.

Screenshot:
https://drive.google.com/file/d/1EcJkOUnKa0W3DldtmMPgugG6rGIdNqd8/view

Bug: 792775
Change-Id: I90932e6c647e2d46a24a13e80d71fc30df8a4da1
Reviewed-on: https://chromium-review.googlesource.com/1020458
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553771}

The state is 'Enabled' if the user has enabled the feature, 'Disabled'
if the user has disabled the feature, and 'Unset' if the user has never
enabled the feature.

R=asvitkine@chromium.org, hansberry@chromium.org

Bug: 831371
Test: none
Change-Id: Id7f6207d2763d259cbb117457bc0e968fa6fcd3b
Reviewed-on: https://chromium-review.googlesource.com/1026936Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553770}

WebContentsImpl now tracks the last time it received an input event that
could be considered user interaction. When the browser process receives
a WebUI message that requires a user gesture, it checks the WebContents
hosting the WebUI to make sure that the user recently interacted with
it.

This also cleans up a few incidental bits of code:
- RenderWidgetHost no longer prefilters events before notifying the
  delegate. This exposed some broken event filtering, tracked at
  https://crbug.com/827659.
- Since the delegate method no longer prefilters input events,
  RenderWidgetHostDelegate::OnUserInteraction() is now named
  RenderWidgetHostDelegate::DidReceiveInputEvent().

TBR=isherman@chromium.org

Bug: 823864
Change-Id: I9237052dbd325d8e578bfa904a8779533b63b2f9
Reviewed-on: https://chromium-review.googlesource.com/1028484Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553769}

This CL handles key events (onKeyUp, dispatchKeyEvent) by forwarding
them to native first like the others. They are consumed by content
components such as ImeAdapter, TapDisambiguator, etc.

Introduced a couple of new classes for this flow to work:

KeyEventAndroid: New object for Android key event, used to let it through
    the ViewAndroid tree and hit testing logic like other types of events.
    Hit testing is not necessary for key events since they don't have
    location information, but devised to process them in the same pattern.
    First EventHandlerAndroid (which is WCVA) is regarded to have
    the focus, and always expected to consume it.

ContentUiAndroid: Bridges native and Java for the new events.
    Used to pass them back up to Java layer from EventHandlerAndroid(WCVA).

Bug: 622847
Change-Id: I991274f9ecb49b739ab0f798390d7918a7e4bb37
Reviewed-on: https://chromium-review.googlesource.com/1018682Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553768}