- 10 Sep, 2019 40 commits
-
-
Wez authored
* Implement the fuchsia.web.Frame/SetUrlRequestRewriteRules API. * Add a mojo interface to provide the renderers with new rules. * This interface is implemented in the browser in UrlRequestRewriteRulesManager, which also takes care of validating and converting the rules from FIDL to Mojo, and providing them to the WebEngineURLLoaderThrottles in the browser. * In the renderer, there is one rules receiver per RenderFrame, implemented in UrlRequestRulesReceiver. They cache the rules and provide them to the WebEngineURLLoaderThrottles in the renderer. * Add unit tests and browser tests for the new API. Bug: 976975 Change-Id: I446ea4838d50e65c568e7e2cbcd32c23d64af426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659677 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695298}
-
Yue Li authored
Generalize the board type check rule to match different sub-types of the board. Bug: b/140766051 Test: Manual Test Change-Id: Iecd194dbccb2f8b6ceb299632d301e6b58f1797e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794202Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#695297}
-
Brian Ho authored
This CL registers a few functions in the Vulkan binding generator script to be used for importing dma-bufs as VkImages [1] with the end goal of supporting WebGPU on Chrome OS. In particular, we add: - vkGetPhysicalDeviceImageFormatProperties2: allows us to query if the physical device supports importing dma-bufs into Vulkan via the VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT flag [2]. - vkGetMemoryFdPropertiesKHR: allows us to list the types of memory that our buffer backed by a dma-buf can be imported as. - vkGetImageMemoryRequirements2: allows us to list the types of memory supported by a given VkImage which can be compared to the output of vkGetMemoryFdPropertiesKHR to determine a suitable memory type for import. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1796049 [2] https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkExternalMemoryHandleTypeFlagBits.html BUG=996470 TEST=ran the script and used the newly bound functions Change-Id: I0f61e531009596d7237153f203084639e649afd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794142Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#695296}
-
Nate Fischer authored
No change to logic. This cleans up C++ includes, guided by the `cppclean` tool: * Changes some #includes to forward declarations * Moves some #includes from the .h to the .cc file * Deletes #includes which are no longer necessary * Add some #includes for <string> (not detected by cppclean) Also deletes a redundant definition for a constructor. Test: autoninja -C out/Default system_webview_apk Change-Id: I53bd5329c1e7116ecc4c50997501556ca6b08869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794275 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#695295}
-
Mohit Bansal authored
This CL adds additional test for validating alt text retrieval for various scenarios. This CL makes use of a new test file which has a mix of text, images and links. Bug: 981448 Change-Id: Iae48b5111227c1729486fdf3fe67dba8aa364835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792414 Commit-Queue: Mohit Bansal <mohitb@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695294}
-
Xiyuan Xia authored
Fix ash_ui_perftests compile after https://crrev.com/c/1775390 Bug: 973483 Change-Id: Iaebaa8ffe341080f01f28a5e399cd0a4ebf7e673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795488Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695293}
-
Alexandre Frechette authored
Change-Id: I2af8368c4c85990b0a72407ef8be7233f26ddfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754105 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695292}
-
Dale Curtis authored
Log in it's current position was logging status after we'd replaced the sink with a fake device. We need to log the status before we do that. BUG=986021 R=sandersd Change-Id: I27c588e5b5c0445b29d5f5034df0053e98c27a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796625 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695291}
-
Chris Blume authored
Previously, the SkiaRenderer GL bot was added with the restriction that it must find matching devices in the GPU pool. But the GPU pool did not include any Nexus 5Xs which could satisfy the SkiaRenderer GL bot's other requirements. This CL removes the GPU pool requirement for the SkiaRenderer GL bot. Bug: 969855 Change-Id: I69787e0415890c6e5755df6cfb3be99b4de92c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796642Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#695290}
-
David Tseng authored
Bug: 1001562 Change-Id: I0e0eb5ab1b04f20605946c525ea4abdea831c11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791439Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695289}
-
Dirk Pranke authored
This helps people figure out how to file bugs for stuff in that directory. Change-Id: I88cde6f209fcbd710a011b57df390a558bfdfca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795495Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695288}
-
Toni Barzic authored
Removes code that was used to scaled the app list main view on small screens (when apps grid did not fit into the available space). CL:1759856 changed approach to update the item sizes inside the apps grid instead. The following is thus no longer necessary: * AppsContainerView::GetMinimumSize() override - was used to calculate whether and what scale to use (the usage has been removed; not used during container layout * ContentsView::GetAppListMainViewScale() - the scale transform on the main view does not get set any longer, so the scale should always be 1 Change-Id: I2bcafd63b7e34c2c40167d365cfbe83b192f71e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789467Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695287}
-
Danan S authored
Previously we were using a private API to force the user to do a full Google signin after gellerization. Instead, we now use UserManager::SaveForceOnlineSignin, which is the public API for this purpose. Also reverts changes to signin_metrics enum from http://crrev.com/c/1786857 Bug: 1000948 Change-Id: I287bc86b1d719f11d0da0c6bb6ef09fcfd355987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789827Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695286}
-
Brian White authored
Adds expires_after attribute for 146 histograms that do not show any access in the past 120 days. Change-Id: I1c7e0fbe985dfd2c813f93d677e2d4fe2f58f038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796263 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#695285}
-
François Beaufort authored
This CL adds debug markers methods (pushDebugGroup, popDebugGroup, and insertDebugMarker) to GPUCommandEncoder. Bug: 877147 Change-Id: I19d13e2f2c61ab58bb0cb9b266e9ef69b285bbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732078Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#695284}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d249d6d6. With Chromium commits locally applied on WPT: 999a3129 "[LayoutNG] Fix line breaking behavior after out-of-flow objects" b48cdedb "Add feature-detectable API for Scroll To Text" cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie045406195eebd26cb6e97002cf47493095beb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795666Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695283}
-
Sami Kyostila authored
Change-Id: I5ba202a48eea74c9cde518e062d1669b71638238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796542 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#695282}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9800e5adb7a..66d325b6e26e Created with: gclient setdep -r src-internal@66d325b6e26e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibc25eb9e52def586c531172b9a4229e7d90d8a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796628Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695281}
-
Tomas Popela authored
Use the PRETTY_NAME variable from /etc/os-release (or /usr/lib/os-release) to get the "pretty operating system name in a format suitable for presentation to the user" as the standard says. This could allow us to drop a requirement on lsb_release binary on Linux. The os-release is presented on most new distribution like Fedora, RHEL 7, CentOS 7, Ubuntu 12.04+, Debian Wheezy+. More information could be found on https://www.freedesktop.org/software/systemd/man/os-release.html. Bug: 420439 Change-Id: If4fc3cd3d22507e47b32d6184ac6ef4ae4b4ff3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1156504 Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#695280}
-
Alex Newcomer authored
All active apps have been moved into the hotseat. The hotseat is dismissable in tablet mode, this means users should have more space. The usefulness of this feature will be more apparent after in-app shelf is landed. Hotseat Properties: - In tablet mode can be either Shown (old behavior), Hidden(off screen), or Extended (floating above the shelf). - In clamshell mode, the hotseat is always Shown. - The hotseat hides when the background is interacted with. - The hotseat is draggable. Other changes to facilitate the hotseat, included in this patch: - Instead of maintaining target home launcher position, maintain the animation state. This simplifies some of our old logic. Future changes: - Hotseat should have a background. - Hotseat should gracefully handle keyboard nav/screen reader. Bug: 973482 Change-Id: I018cecda768e13a453475a6aef0adc5d9da0ac44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787399 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#695279}
-
Elly Fong-Jones authored
Thanks thakis@ :) CC=thakis@chromium.org R=agable@chromium.org Bug: None Change-Id: Ida6a7bcf5f59178d39546eb9f1c0d2c6810366cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796202Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#695278}
-
Stephen McGruer authored
The initial/unset value for background-position is 0% 0%, so any interpolation from/to that involves a calc with a percentage in it. By the calc spec, calcs with percentages in them are not resolved when getting the computed value - even if the percentage is 0%. The test shouldn't pass in Chrome after this CL, but does anyway as it resolves the expected values to not include percentages either! See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we discovered the test was wrong. Bug: 1002430 Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795842Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#695277}
-
Xinghui Lu authored
It is unlikely that a url needs to match multiple allowlists. Change the startAllowlistLookup signature to only support a single threat type. Bug: 999344 Change-Id: I717a94ee11e50a66bb87fd7af71754b82cf2dc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793811Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695276}
-
Matt Menke authored
Previous CLs have added NetworkIsolationKey support to broken- alternative-services-related HttpServerProperties methods, but they were still being passed empty NetworkIsolationKeys by consumers. This CL makes consumers pass in the correct NIK, and adds tests for all callsites. Bug: 969890 Change-Id: I5b3d7947bfe91f7fcc6a19bcf30c399dd8f49d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782666Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695275}
-
Rune Lillesveen authored
This is by no means extensive and more patches will follow to do dark styling of forms when used color-scheme is dark. Since color-scheme is behind a flag, this should not cause any behavioral changes. Bug: 939811 Change-Id: I75d825c8641c6ed8d20b43b5261d3aee90daad68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795582Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#695274}
-
Eric Roman authored
Change-Id: If1188ff1379ad743f85f8cdbb0e30b3943cbe38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796742 Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695273}
-
Stephen Nusko authored
This is required to promote our finch study to Beta and Stable (once stable finishes releasing that is). We don't expect any noticeable performance impact. Bug: 980536 Change-Id: I7913529a00b12c2213c42d2785f5feaf3107372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793092 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ab2ac03d8ee..f57b7cb8f0bc git log 2ab2ac03d8ee..f57b7cb8f0bc --date=short --no-merges --format='%ad %ae %s' 2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f57b7cb8f0bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I63d7a0786a5d4972a470f42c4655135b097fb25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695271}
-
Eric Stevenson authored
This change was generated by //base/android/jni_generator/jni_refactorer.py. TBR: tedchoc@chromium.org Bug: 929661 Change-Id: I5a093f1f51876de014a2337e5ce711907109a502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782676 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#695270}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29ab487ea7c1..de5f63910e24 git log 29ab487ea7c1..de5f63910e24 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 srte@webrtc.org Removes decoder thread fallback from VideoReceiveStream. Created with: gclient setdep -r src/third_party/webrtc@de5f63910e24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I0a6e401141ca2df371713a06229438d7c7454776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695269}
-
Sanket Joshi authored
Per the updated comps, the color picker should use a sans-serif font. Making that change in color_picker.css, and also updating baselines for pixel tests. Bug: 1001576 Change-Id: Iaa2a65ba574ad6f3e46aea82a009301273582723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792790Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695268}
-
Mansi Awasthi authored
This CL adds the logic to enumerate over FPDF_LINKs and populate link annotations' data with its underlying text range in |links_| vector in PDFiumPage. A test is added to validate that the link annotations are correctly populated for a page. Bug: 981448 Change-Id: I6569e939c4a2309cc598f5062dec0e396ca818b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736886Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695267}
-
Miguel Casas-Sanchez authored
This CL follows up on a comment [1], where instead of forcing clients to make the context current and then call either CreateSharedImage or UpdateSharedImage, it is suggested to have public methods bundling those operations in SharedImageStub. This CL does just that, making the current OnCreateGMBSharedImage and OnUpdateSharedImage use the newly introduced ones. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1772642/30/media/gpu/linux/mailbox_video_frame_converter.cc#361 Bug: 998279 Change-Id: If39d94b04d2851e6ed8e248e9af96908dfa27e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794274Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695266}
-
Alex Clarke authored
We are trying to prioritize loading and composting tasks until FCP and when enabled this test fails. Upon investigation it turned out the test script was starting before the link tag resources had loaded. Starting the test in a window.onload handler fixes the issue. Bug: 971191 Change-Id: I9d4f99a5cac86970606dd6c9b4ab2416ccaac2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782814Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695265}
-
Mitsuru Oshima authored
* Added OnMouseEnter to PlatformWindow{Delegate} * Updated DRM/X11 impl to call it when the mouse location enters it. and chrome for chromeos on linux desktop. Bug: 990589 Test: X11WindowOzoneTest.MouseEnterAndDelete, manually tested on device Change-Id: I452c34ef0019f10d20d1096ef608cf84dd3a73db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761772 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695264}
-
Yi Gu authored
This function is unused. Bug: None Change-Id: Ic0c39655a6ea8087dbfbf2150e4d1478163b06e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795756Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695263}
-
Yue Li authored
Move the status sync to prevent timing issues. Bug: None Test: Manual Test Change-Id: I2e2847c07a4125d830a423ab9e5c4e454f891de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788176 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695262}
-
Dana Fried authored
Details are in the new, improved documentation. But MoveWebContentsAt() will now never leave a group in a non-contiguous state. Also, did some fixup in the unit tests to support testing of the new functionality. Bug: 915956 Change-Id: Ibd83249ebbaeb74e50f6805dc626c26c0291f86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793544Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#695261}
-
Eric Karl authored
This reverts commit 797ebfdc. Reason for revert: Fixed minor build issue causing initial revert. Original change's description: > Revert "Cleanup Android video targets" > > This reverts commit 9c44fedd. > > Reason for revert: broke https://ci.chromium.org/p/chromium/builders/ci/android-jumbo-rel/13515 > > Original change's description: > > Cleanup Android video targets > > > > Fixes WebView component build issues. > > > > Previous CLs introduced a number of new targets including > > texture_owner_android and shared_image_video. These were causing build > > problems due to duplicate file compilation which led to DCHECKs. > > > > Moved most of these files into gpu/command_buffer/service:gles2, as > > they all depended on this target (so no new transitive deps), and it's > > probably a good place for them for now and simplifies dependency > > management. > > > > Bug: 996285 > > Change-Id: Ic5a9cced7e67500cfd5fff8809d4ee5e17bbab8b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787165 > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: vikas soni <vikassoni@chromium.org> > > Auto-Submit: Eric Karl <ericrk@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#695006} > > TBR=kinuko@chromium.org,nasko@chromium.org,liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org > > Change-Id: Ib51ec09046ecfa51543836755b6b830d76fbce94 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 996285 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793931 > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Commit-Queue: Tao Bai <michaelbai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695062} TBR=michaelbai@chromium.org,kinuko@chromium.org,nasko@chromium.org,liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org Change-Id: I35661eb7691dbbacb063e308513daca68efcff75 Bug: 996285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796110Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695260}
-
Andrew Xu authored
In ShelfLayoutManagerTest::ShelfUpdatedWhenStatusAreaChangesSize, it assumes that the shelf view fills the display space. It will be incorrect under new specs. In ShelfLayoutManagerTest::RtlPlacement, the test fails to reset the RTL setting. This CL fixes these two tests. Bug: 1002576 Change-Id: I9dc2a82f5dab18c33e6947e21112af5aa4913f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796118 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695259}
-